Re: [PATCH v5] media: dvb_dummy_tuner: implement driver skeleton

[kbuild test robot]

CC: kbuil...@lists.01.org
In-Reply-To: <20200210154102.11...@gmail.com>
References: <20200210154102.11...@gmail.com>
TO: "Daniel W. S. Almeida" <dwlsa...@gmail.com>
CC: mch...@kernel.org, se...@mess.org, tg...@linutronix.de, gre...@linuxfoundation.org, "Daniel W. S. Almeida" <dwlsa...@gmail.com>, linux...@vger.kernel.org, linux-...@vger.kernel.org, sk...@linuxfoundation.org, linux-kern...@lists.linuxfoundation.org, "Daniel W. S. Almeida" <dwlsa...@gmail.com>, linux...@vger.kernel.org, linux-...@vger.kernel.org, sk...@linuxfoundation.org, linux-kern...@lists.linuxfoundation.org
CC: "Daniel W. S. Almeida" <dwlsa...@gmail.com>, linux...@vger.kernel.org, linux-...@vger.kernel.org, sk...@linuxfoundation.org, linux-kern...@lists.linuxfoundation.org

Hi "Daniel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v5.6-rc1 next-20200212]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Daniel-W-S-Almeida/media-dvb_dummy_tuner-implement-driver-skeleton/20200213-034625
base: git://linuxtv.org/media_tree.git master
config: arm64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (git://gitmirror/llvm_project a58017e5cae5be948fd1913b68d46553e87aa622)
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm64

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <l...@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/media/tuners/dvb_dummy_tuner.c:64:21: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 13.5 to 13 [-Wliteral-conversion]
{ QPSK, FEC_9_10, 13.5, 16.5},
~ ^~~~
drivers/media/tuners/dvb_dummy_tuner.c:64:27: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 16.5 to 16 [-Wliteral-conversion]
{ QPSK, FEC_9_10, 13.5, 16.5},
~ ^~~~
drivers/media/tuners/dvb_dummy_tuner.c:65:21: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 14.5 to 14 [-Wliteral-conversion]
{ PSK_8, FEC_2_3, 14.5, 17.5},
~ ^~~~
drivers/media/tuners/dvb_dummy_tuner.c:65:27: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 17.5 to 17 [-Wliteral-conversion]
{ PSK_8, FEC_2_3, 14.5, 17.5},
~ ^~~~
drivers/media/tuners/dvb_dummy_tuner.c:67:21: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 17.5 to 17 [-Wliteral-conversion]
{ PSK_8, FEC_5_6, 17.5, 20.5},
~ ^~~~
drivers/media/tuners/dvb_dummy_tuner.c:67:27: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 20.5 to 20 [-Wliteral-conversion]
{ PSK_8, FEC_5_6, 17.5, 20.5},
~ ^~~~
drivers/media/tuners/dvb_dummy_tuner.c:73:22: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 4.1 to 4 [-Wliteral-conversion]
{ QPSK, FEC_1_2, 4.1, 5.9},
~ ^~~
drivers/media/tuners/dvb_dummy_tuner.c:73:28: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 5.9 to 5 [-Wliteral-conversion]
{ QPSK, FEC_1_2, 4.1, 5.9},
~ ^~~
drivers/media/tuners/dvb_dummy_tuner.c:74:22: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 6.1 to 6 [-Wliteral-conversion]
{ QPSK, FEC_2_3, 6.1, 9.6},
~ ^~~
drivers/media/tuners/dvb_dummy_tuner.c:74:28: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 9.599999999999999 to 9 [-Wliteral-conversion]
{ QPSK, FEC_2_3, 6.1, 9.6},
~ ^~~
drivers/media/tuners/dvb_dummy_tuner.c:75:22: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 7.2 to 7 [-Wliteral-conversion]
{ QPSK, FEC_3_4, 7.2, 12.4},
~ ^~~
drivers/media/tuners/dvb_dummy_tuner.c:75:27: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 12.4 to 12 [-Wliteral-conversion]
{ QPSK, FEC_3_4, 7.2, 12.4},
~ ^~~~
drivers/media/tuners/dvb_dummy_tuner.c:76:22: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 8.5 to 8 [-Wliteral-conversion]
{ QPSK, FEC_5_6, 8.5, 15.6},
~ ^~~
drivers/media/tuners/dvb_dummy_tuner.c:76:27: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 15.6 to 15 [-Wliteral-conversion]
{ QPSK, FEC_5_6, 8.5, 15.6},
~ ^~~~
drivers/media/tuners/dvb_dummy_tuner.c:77:22: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 9.199999999999999 to 9 [-Wliteral-conversion]
{ QPSK, FEC_7_8, 9.2, 17.5},
~ ^~~
drivers/media/tuners/dvb_dummy_tuner.c:77:27: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 17.5 to 17 [-Wliteral-conversion]
{ QPSK, FEC_7_8, 9.2, 17.5},
~ ^~~~
drivers/media/tuners/dvb_dummy_tuner.c:79:22: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 9.800000000000001 to 9 [-Wliteral-conversion]
{ QAM_16, FEC_1_2, 9.8, 11.8},
~ ^~~
drivers/media/tuners/dvb_dummy_tuner.c:79:27: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 11.8 to 11 [-Wliteral-conversion]
{ QAM_16, FEC_1_2, 9.8, 11.8},
~ ^~~~
drivers/media/tuners/dvb_dummy_tuner.c:80:21: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 12.1 to 12 [-Wliteral-conversion]
{ QAM_16, FEC_2_3, 12.1, 15.3},
~ ^~~~
drivers/media/tuners/dvb_dummy_tuner.c:80:27: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 15.3 to 15 [-Wliteral-conversion]
{ QAM_16, FEC_2_3, 12.1, 15.3},
~ ^~~~
drivers/media/tuners/dvb_dummy_tuner.c:81:21: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 13.4 to 13 [-Wliteral-conversion]
{ QAM_16, FEC_3_4, 13.4, 18.1},
~ ^~~~
drivers/media/tuners/dvb_dummy_tuner.c:81:27: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 18.1 to 18 [-Wliteral-conversion]
{ QAM_16, FEC_3_4, 13.4, 18.1},
~ ^~~~
drivers/media/tuners/dvb_dummy_tuner.c:82:21: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 14.8 to 14 [-Wliteral-conversion]
{ QAM_16, FEC_5_6, 14.8, 21.3},
~ ^~~~
drivers/media/tuners/dvb_dummy_tuner.c:82:27: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 21.3 to 21 [-Wliteral-conversion]
{ QAM_16, FEC_5_6, 14.8, 21.3},
~ ^~~~
drivers/media/tuners/dvb_dummy_tuner.c:83:21: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 15.7 to 15 [-Wliteral-conversion]
{ QAM_16, FEC_7_8, 15.7, 23.6},
~ ^~~~
drivers/media/tuners/dvb_dummy_tuner.c:83:27: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 23.6 to 23 [-Wliteral-conversion]
{ QAM_16, FEC_7_8, 15.7, 23.6},
~ ^~~~
drivers/media/tuners/dvb_dummy_tuner.c:86:21: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 19.9 to 19 [-Wliteral-conversion]
{ QAM_64, FEC_2_3, 19.9, 25.4},
~ ^~~~
drivers/media/tuners/dvb_dummy_tuner.c:86:27: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 25.4 to 25 [-Wliteral-conversion]
{ QAM_64, FEC_2_3, 19.9, 25.4},
~ ^~~~
drivers/media/tuners/dvb_dummy_tuner.c:87:21: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 24.9 to 24 [-Wliteral-conversion]
{ QAM_64, FEC_3_4, 24.9, 27.9},
~ ^~~~
drivers/media/tuners/dvb_dummy_tuner.c:87:27: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 27.9 to 27 [-Wliteral-conversion]
{ QAM_64, FEC_3_4, 24.9, 27.9},
~ ^~~~
drivers/media/tuners/dvb_dummy_tuner.c:88:21: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 21.3 to 21 [-Wliteral-conversion]
{ QAM_64, FEC_5_6, 21.3, 23.3},
~ ^~~~
drivers/media/tuners/dvb_dummy_tuner.c:88:27: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 23.3 to 23 [-Wliteral-conversion]
{ QAM_64, FEC_5_6, 21.3, 23.3},
~ ^~~~
32 warnings generated.

vim +64 drivers/media/tuners/dvb_dummy_tuner.c

56
57 struct dvb_dummy_tuner_cnr_to_qual_s dvb_s2_cnr_2_qual[] = {
58 /* from libdvbv5 source code */
59 { QPSK, FEC_1_2, 9., 12.},
60 { QPSK, FEC_2_3, 11., 14.},
61 { QPSK, FEC_3_4, 12., 15.},
62 { QPSK, FEC_5_6, 12., 15.},
63 { QPSK, FEC_8_9, 13., 16.},
> 64 { QPSK, FEC_9_10, 13.5, 16.5},
65 { PSK_8, FEC_2_3, 14.5, 17.5},
66 { PSK_8, FEC_3_4, 16., 19.},
67 { PSK_8, FEC_5_6, 17.5, 20.5},
68 { PSK_8, FEC_8_9, 19., 22.},
69 };
70

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuil...@lists.01.org

[Nathan Chancellor]

Reported to LKML:

https://lore.kernel.org/lkml/20200214050813.GA37036@ubuntu-m2-xlarge-x86/

Cheers,
Nathan