--
You received this message because you are subscribed to the Google Groups "CDS Hooks" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cds-hooks+...@googlegroups.com.
To post to this group, send email to cds-...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/cds-hooks/65d6ebdc-4f98-4e1f-9231-d07df0a654d8%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
That is just so wrong.
Sent from my iPhone
To unsubscribe from this group and stop receiving emails from it, send an email to cds-hooks+unsubscribe@googlegroups.com<mailto:cds-hooks+unsubscribe@googlegroups.com>.
To post to this group, send email to cds-...@googlegroups.com<mailto:cds-hooks@googlegroups.com>.
To unsubscribe from this group and stop receiving emails from it, send an email to cds-hooks+...@googlegroups.com.
To post to this group, send email to cds-...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/cds-hooks/E027A8A9-5FF2-4849-95BE-48AD8DFCE87B%40ge.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "CDS Hooks" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cds-hooks+...@googlegroups.com.
To post to this group, send email to cds-...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/cds-hooks/65d6ebdc-4f98-4e1f-9231-d07df0a654d8%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
To view this discussion on the web visit https://groups.google.com/d/msgid/cds-hooks/CAMTEi2m7DsjJBj9Zkoa1EaZJpJtZGEfRAff3ey8ZnfoCG0pGNg%40mail.gmail.com.
On Sat, Jan 16, 2016 at 1:57 AM, Grahame Grieve <grahame@healthintersections.com.au> wrote:
hi KeithI think you're being unreasonable. Kevin has proposed something for discussion, and we should be able have discussion about what's the best solution about what the best approach is without worrying about what 'is fhir' or not.I think it's very useful to me and other implementers that the cds-hook service works well when implemented on a FHIR Server, and that discovery works if you start at the FHIR conformance statement. But I don't think that this should be the only way to discover the service, nor that implementing the service correctly should require a full FHIR Server. There's some aspects of Kevin's proposal that don't play well for those of use who want to implement in the context of a FHIR Server, but there may be - should be - a middle path that will work for both. I will propose one later today, hopefullyGrahame
On Sat, Jan 16, 2016 at 1:29 AM, Boone, Keith W (GE Healthcare) <keith...@ge.com> wrote:
Where SMART differs from FHIR is that it provides features not found therein. The current discussion proposes alternate features already found in FHIR for discovery.
Sent from my iPhone
On Jan 15, 2016, at 9:20 AM, Kevin Shekleton <kevin.s...@gmail.com<mailto:kevin.shekleton@gmail.com>> wrote:
Keith replied to me personally, though I'm sure he intended for his response to be in this Google group thread.
Keith wrote:
>You are using FHIR, but rather than using the FHIR framework, you are going to do something else because either, that part of the framework is too hard to use, or you cannot be bothered to figure out how to use it.
>
>Make the standard better. Don't ignore it.
Certainly my line of thinking that initially led to the thoughts that resulted in this discussion were born from my implementation work at the Connectathon. That's not to say that I found the framework hard to use or that I didn't take the time to learn it. To the contrary, I've implemented a FHIR server<https://urldefense.proofpoint.com/v2/url?u=http-3A__fhir.cerner.com_&d=CwMFaQ&c=IV_clAzoPDE253xZdHuilRgztyh_RiV3wUrLrDQYWSI&r=_V5W6w_wI5HOMI7JpAQvQdQOzM3ZKwQx-Qa2F-ui1oY&m=tLC0F9JN_rbLykC2NBtnI0J2vVcbTNgWCLXmWl7kUJA&s=ugeiaEMc52WOWd8hE7NP-Lg8rNT_pBoIDNoo0n2XWLQ&e=> (now in use in production) on top of a mature EHR with complex business rules and services. So, it's certainly not my lack of understanding with FHIR that brought me to this thinking.
It's also not that that I'm ignoring the standard or not interested in making the standard better. It's that I don't see CDS Hooks as part of FHIR; rather, I see it using FHIR (data). Consider SMART on FHIR: SMART leverages FHIR where it best fits -- sharing data from the EHR. Likewise, I'm proposing that CDS Hooks leverage FHIR in the same way.
Regards,
Kevin
On Friday, January 15, 2016 at 7:47:15 AM UTC-5, Kevin Shekleton wrote:
Hi Keith. Can you elaborate on what you find wrong?
Regards,
Kevin
On Friday, January 15, 2016 at 7:30:54 AM UTC-5, keith.boone wrote:
That is just so wrong.
Sent from my iPhone
To unsubscribe from this group and stop receiving emails from it, send an email to cds-hooks+unsubscribe@googlegroups.com<mailto:cds-hooks%2Bunsubscribe@googlegroups.com><mailto:cds-hooks+unsubscribe@googlegroups.com<mailto:cds-hooks%2Bunsubscribe@googlegroups.com>>.
To post to this group, send email to cds-...@googlegroups.com<mailto:cds-hooks@googlegroups.com><mailto:cds-hooks@googlegroups.com<mailto:cds-ho...@googlegroups.com>>.
To view this discussion on the web visit https://groups.google.com/d/msgid/cds-hooks/66321a9a-3291-4f16-8790-c855d607290a%40googlegroups.com<https://urldefense.proofpoint.com/v2/url?u=https-3A__groups.google.com_d_msgid_cds-2Dhooks_66321a9a-2D3291-2D4f16-2D8790-2Dc855d607290a-2540googlegroups.com&d=CwMFaQ&c=IV_clAzoPDE253xZdHuilRgztyh_RiV3wUrLrDQYWSI&r=_V5W6w_wI5HOMI7JpAQvQdQOzM3ZKwQx-Qa2F-ui1oY&m=tLC0F9JN_rbLykC2NBtnI0J2vVcbTNgWCLXmWl7kUJA&s=55PXwiNtdeav2R_b0BIgDETjiVXNoXBhbjAX15rEsuk&e=><https://urldefense.proofpoint.com/v2/url?u=https-3A__groups.google.com_d_msgid_cds-2Dhooks_66321a9a-2D3291-2D4f16-2D8790-2Dc855d607290a-2540googlegroups.com-3Futm-5Fmedium-3Demail-26utm-5Fsource-3Dfooter&d=CwMFaQ&c=IV_clAzoPDE253xZdHuilRgztyh_RiV3wUrLrDQYWSI&r=_V5W6w_wI5HOMI7JpAQvQdQOzM3ZKwQx-Qa2F-ui1oY&m=VlIWsAGt5a-1zsbVF91T-c9GEfEjVVrYIQkJsZwRhek&s=Z6dQJJyYmzbVZuU_xPSINROX8YZMzZa0DDpm_EdWKqA&e=>.
For more options, visit https://groups.google.com/d/optout<https://urldefense.proofpoint.com/v2/url?u=https-3A__groups.google.com_d_optout&d=CwMFaQ&c=IV_clAzoPDE253xZdHuilRgztyh_RiV3wUrLrDQYWSI&r=_V5W6w_wI5HOMI7JpAQvQdQOzM3ZKwQx-Qa2F-ui1oY&m=tLC0F9JN_rbLykC2NBtnI0J2vVcbTNgWCLXmWl7kUJA&s=b0mFiiewl7vLiyCtCbtxVoMUcW5RL4xBWqD_AV-tL6I&e=><https://urldefense.proofpoint.com/v2/url?u=https-3A__groups.google.com_d_optout&d=CwMFaQ&c=IV_clAzoPDE253xZdHuilRgztyh_RiV3wUrLrDQYWSI&r=_V5W6w_wI5HOMI7JpAQvQdQOzM3ZKwQx-Qa2F-ui1oY&m=VlIWsAGt5a-1zsbVF91T-c9GEfEjVVrYIQkJsZwRhek&s=wTcqOKOgSaWxRy_pCiurD2pHfLMTWIhwpVnycNFEgwI&e=>.
--
You received this message because you are subscribed to the Google Groups "CDS Hooks" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cds-hooks+unsubscribe@googlegroups.com<mailto:cds-hooks+unsubscribe@googlegroups.com>.
To post to this group, send email to cds-...@googlegroups.com<mailto:cds-hooks@googlegroups.com>.
To view this discussion on the web visit https://groups.google.com/d/msgid/cds-hooks/594bade1-9719-40e6-bb4e-ddb5c1987e1d%40googlegroups.com<https://urldefense.proofpoint.com/v2/url?u=https-3A__groups.google.com_d_msgid_cds-2Dhooks_594bade1-2D9719-2D40e6-2Dbb4e-2Dddb5c1987e1d-2540googlegroups.com-3Futm-5Fmedium-3Demail-26utm-5Fsource-3Dfooter&d=CwMFaQ&c=IV_clAzoPDE253xZdHuilRgztyh_RiV3wUrLrDQYWSI&r=_V5W6w_wI5HOMI7JpAQvQdQOzM3ZKwQx-Qa2F-ui1oY&m=tLC0F9JN_rbLykC2NBtnI0J2vVcbTNgWCLXmWl7kUJA&s=woXlUEC9ceeHOOZ43NzENWK5-ZM3mPLd4HO9RdafZ3g&e=>.
For more options, visit https://groups.google.com/d/optout<https://urldefense.proofpoint.com/v2/url?u=https-3A__groups.google.com_d_optout&d=CwMFaQ&c=IV_clAzoPDE253xZdHuilRgztyh_RiV3wUrLrDQYWSI&r=_V5W6w_wI5HOMI7JpAQvQdQOzM3ZKwQx-Qa2F-ui1oY&m=tLC0F9JN_rbLykC2NBtnI0J2vVcbTNgWCLXmWl7kUJA&s=b0mFiiewl7vLiyCtCbtxVoMUcW5RL4xBWqD_AV-tL6I&e=>.
--
You received this message because you are subscribed to the Google Groups "CDS Hooks" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cds-hooks+unsubscribe@googlegroups.com.
To post to this group, send email to cds-...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/cds-hooks/E027A8A9-5FF2-4849-95BE-48AD8DFCE87B%40ge.com.
For more options, visit https://groups.google.com/d/optout.
The wire protocol you outlined is much cleaner than the current version we're working with today and very close to what I proposed. The only difference looks like you have resourceType as a top level attribute in the response which, given the choice between what we have today and your version, I'd take yours everyday. I'm curious how this new response would be handled within FHIR. I imagine it would be treated as a custom model by parsers? I have no problem with this but I'm asking as I was under the impression that one of the proposed benefits of leveraging FHIR's operations framework was that consumers would get parsing for 'free'.
Regarding my proposal for the invocation URI, my suggestion for including the activity instance (what I called :id) as part of the URI is that I felt /cds-hooks/:hook/:id best represents a RESTful approach for modeling a CDS Hooks resource for a given activity and id (activity instance). This proposal though was suggested in the context of CDS Hooks not being part of FHIR but rather just leveraging FHIR in some aspects (again, like SMART). Of course, if we decide to keep CDS Hooks as part of FHIR, we'd eschew this invocation URI proposal in favor of FHIR's URI conventions.
hi Kevin.Comments inlineThe wire protocol you outlined is much cleaner than the current version we're working with today and very close to what I proposed. The only difference looks like you have resourceType as a top level attribute in the response which, given the choice between what we have today and your version, I'd take yours everyday. I'm curious how this new response would be handled within FHIR. I imagine it would be treated as a custom model by parsers? I have no problem with this but I'm asking as I was under the impression that one of the proposed benefits of leveraging FHIR's operations framework was that consumers would get parsing for 'free'.well, this is a half-way house. I'm thinking that anyone using operations (the parameters type) in json is pretty much going to be thinking the same thing, so I'd propose it as a special case for parsers to support - though the interesting thing is that it only works if you know the type of the element in advance; it doesn't work well for extensibility.
Regarding my proposal for the invocation URI, my suggestion for including the activity instance (what I called :id) as part of the URI is that I felt /cds-hooks/:hook/:id best represents a RESTful approach for modeling a CDS Hooks resource for a given activity and id (activity instance). This proposal though was suggested in the context of CDS Hooks not being part of FHIR but rather just leveraging FHIR in some aspects (again, like SMART). Of course, if we decide to keep CDS Hooks as part of FHIR, we'd eschew this invocation URI proposal in favor of FHIR's URI conventions.well, again, we can grow the conventions in FHIR if it's a good idea. Is there always an activity instance? as for 'restful', the cds-hook thing is inherently rpc, isn't it? there's no transfer of state, only the requesting of a comment to be made?...
Grahame
well, this is a half-way house. I'm thinking that anyone using operations (the parameters type) in json is pretty much going to be thinking the same thing, so I'd propose it as a special case for parsers to support - though the interesting thing is that it only works if you know the type of the element in advance; it doesn't work well for extensibility.Gotcha. This is was I was expecting but good to hear you confirm. If you're fine with a custom parser, I'm not sure why it's necessary to use any of the operations framework since it would be so different than what exists in FHIR today.
Additionally, by leveraging FHIR operations, does this imply that CDS Hooks should support/define XML APIs as well? I know that a FHIR server isn't under any obligation to support a particular format, but I know that FHIR makes deliberate and conscience design decisions to ensure both JSON and XML formats are handled with any feature. If CDS Hooks were part of FHIR, I would imagine it should follow the same path.
Regarding my proposal for the invocation URI, my suggestion for including the activity instance (what I called :id) as part of the URI is that I felt /cds-hooks/:hook/:id best represents a RESTful approach for modeling a CDS Hooks resource for a given activity and id (activity instance). This proposal though was suggested in the context of CDS Hooks not being part of FHIR but rather just leveraging FHIR in some aspects (again, like SMART). Of course, if we decide to keep CDS Hooks as part of FHIR, we'd eschew this invocation URI proposal in favor of FHIR's URI conventions.well, again, we can grow the conventions in FHIR if it's a good idea. Is there always an activity instance? as for 'restful', the cds-hook thing is inherently rpc, isn't it? there's no transfer of state, only the requesting of a comment to be made?...The activity instance as defined today marks an instance of a CDS Hook call. I don't think CDS Hooks is inherently RPC. The client (EHR) certainly transfers state based upon the the cards (and links therein). If you're looking for a full HATEOS design, I agree that's not here (or nearly anywhere for that matter). However, a CDS Service should share all of the other properties of a RESTful design (stateless, layered, uniform interface, etc).
Grahame
--
You received this message because you are subscribed to the Google Groups "CDS Hooks" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cds-hooks+...@googlegroups.com.
To post to this group, send email to cds-...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/cds-hooks/e196a98a-245c-4446-ba74-2c39ecadb032%40googlegroups.com.