Extend camunda-commons-ui

[robert.k...@gmail.com]

Hi there,

is it possible (maybe via Maven Overlay camunda-webapp) to extend/override html pages from camunda-commons-ui?
I've added oAuth functionality agains our internal CAS Server and want to add some "SSO" Button to the Login page. Ive already read https://github.com/camunda/camunda-bpm-webapp/tree/master/webapp#overriding-a-plugins-resources-server-side but this seems only to work after loggin in into Cockpit.
I've already checked out https://github.com/camunda/camunda-commons-ui and edited lib/auth/page/login.html npm/grunt ran fine. But it feels wrong to change something there. I even dont know yet, how to reference my custom commons-ui in my webapp overlay.
Hopefully someone understands my problem. German is my mother language. Greets from Potsdam to Berlin ;)

[Sebastian Stamm]

Hi,

commons-ui and some other dependencies are compiled to a single javascript file in order to speed up the loading process. So if you want to include a custom commons-ui build, you would have to rebuild the webapp itself [1]. Make sure that your checked out version of the webapp is linked to your modified version of the commons-ui library (e.g. by using npm link).

I agree with you that changing the login.html page itself is maybe not the best idea (will be a pain to merge with new versions). A slightly better option would be to implement a new / alternative login page and use that instead.

In my mind, the best solution would be to implement a plugin point for the login page so that the login logic is exchangeable.

Cheers

Sebastian

[1]: https://github.com/camunda/camunda-bpm-webapp/tree/master/webapp#grunt

[robert.k...@gmail.com]

Am Montag, 30. November 2015 09:06:14 UTC+1 schrieb Sebastian Stamm:
> In my mind, the best solution would be to implement a plugin point for the login page so that the login logic is exchangeable.

I guess, this plugin point does not yet exist and you will sometimes implement this in commons-ui? It will be great to have the same features, like for cockpit plugins (overriding resources, ...)

Thanks anyways for your fast reply!

[Sebastian Stamm]

You are right - this plugin point does not exist yet. Feel free to create a feature request for it :-)

[robert.k...@gmail.com]

Am Montag, 30. November 2015 09:22:24 UTC+1 schrieb Sebastian Stamm:
> You are right - this plugin point does not exist yet. Feel free to create a feature request for it :-)

Ok, here is my feature request: Would you be so kind and add a plugin point for an interchangeable login provider. HelloJS [1] will be great feature to use this plugin point :).

[1] http://adodson.com/hello.js/

[Valentin Vago]

Hi Robert,

I guess that what Sebastian ment was: "feel free to create a feature request in our JIRA" ;)
Which can be done here: https://app.camunda.com/jira/secure/CreateIssue!default.jspa

I created the following issue: https://app.camunda.com/jira/browse/CAM-5088

Cheers

[robert.k...@gmail.com]

Oh, ok. Thank you, Valentin!