Help test our February release

[Rachel Fenichel]

Hi everyone,

We're got a release to master lined up.  The pull request is here.  You can get the code by pulling from the rc/feb_2018 branch.  I'm also currently hosting the playground and demos on my personal site for testing purposes.

We're currently testing this build and looking for bugs.  Please help us out, and file any bugs you find on github.

Known bugs that we will fix before release:

• https://github.com/Microsoft/pxt-blockly/pull/96 (Don't register mouse events if pointer events are supported.)

• https://github.com/google/blockly/issues/1544 (Too many variables get created when editing the name of a procedure argument.)
  

Thanks,

Rachel

[G Alexander]

Hi

maybe a dumb questions is the demo not functional? i.e., it just dump out code?  where's the eval command?

thanks

[Andrew n marshall]

Correct, the Blockly Playground does not have any evaluation. It is just to make sure the blocks and generators work.

This is true of most of our demos.

--
Andrew

--
You received this message because you are subscribed to the Google Groups "Blockly" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blockly+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[G Alexander]

On Wednesday, February 14, 2018 at 3:54:46 PM UTC-8, Andrew n marshall wrote:

Correct, the Blockly Playground does not have any evaluation. It is just to make sure the blocks and generators work.

This is true of most of our demos.

--
Andrew

Thanks.

Ok thanks for that.

Is there a library or class codeblock? so is it possible to import the block and pull down the function you want?

[Andrew n marshall]

Blockly is a library. Specifically, the blockly_compressed.js and blocks_compressed.js files.

The link Rachel sent out is just a demo of the library in use.

If you want to make your own application using Blockly, connecting the generated code to other functions, then I suggest starting with the our Getting Started page, or the Blockly Code Lab.

--
Andrew

--

[Cleo Qc]

finally getting to this, sorry for the delay.

I did a basic drag and drop of the necessary files from the update over our year-old copies, and I'm now taking a look at what gets broken in our code. I fully understand that we may have to do changes on our side, I just don't know what at this very moment.

Anyway, first issue for me, in Blockly's python.js

  var defvars = [];
  var variables = workspace.variableList;
  for (var i = 0; i < variables.length; i++) {
    defvars[i] = Blockly.Python.variableDB_.getName(variables[i],
        Blockly.Variables.NAME_TYPE) + ' = None';
  }

The above code dies on variables.length, telling me that variables is undefined.  That would make sense as workspace.variableList is new with this release.

Where and how should I set it to an empty list (at least for now, I'll need it later on)

Cleo

--
You received this message because you are subscribed to the Google Groups "Blockly" group.

To unsubscribe from this group and stop receiving emails from it, send an email to blockly+u...@googlegroups.com.

[Cleo Qc]

I'm now setting workspace.variableList to [] on startup, and I'm over this bug.

I sorta expected this to be set as the default already though. Maybe my upgrade didn't go as planned?

[Rachel Fenichel]

Did you pull in the new version of python.js? 

We stopped using variableList in this change: https://github.com/google/blockly/commit/d903b5e86ba247dbecd31be16b4513eaa94ee889#diff-a7a92523878b838d6146d6a7d9220feb

[Cleo Qc]

You are correct, I goofed with the branches...

Back to the drawing board (and thanks !)

[Cleo Qc]

Ok, now it clearly states (rc/feb_2018) as the branch...

I copied all the files over but I must have goofed somewhere again.  I'm now getting the following: 

[Cleo Qc]

I've removed blocks_compressed.js so our blocks are used instead.

Onwards!

Now: 

potential_blocks.js:13 Uncaught TypeError: Cannot read property 'push' of undefined

    at potential_blocks.js:13

Blockly.Blocks['controls_flow_statements'].LOOP_TYPES.push('dexter_forever');

dexter_forever is a homemade loop block, and we want to be able to break out of it. 

The comment that says to use the above is still in the code 

https://github.com/google/blockly/blob/rc/feb_2018/blocks/loops.js#L302

but it doesn't seem to be working

One step at a time :)

[Cleo Qc]

The following works:

Blockly.Constants.Loops.CONTROL_FLOW_IN_LOOP_CHECK_MIXIN.LOOP_TYPES.push('dexter_forever');

Would that be the right approach? If so, the comment would need to be updated.

[Rachel Fenichel]

Comment update here, though this change significantly predates this release.

[Rachel Fenichel]

Hi Cleo,

I'm about to ship the release with the last week of bugfixes, but please keep us updated on issues you run into as you update so we know where developer pain points are.

Thanks,

Rachel

[Cleo Qc]

Thanks for all your work, Rachel and team.

Would you have me fill in github issues directly? It's just that I never know if it's me being dumb, or if it's an actual bug. I'm a Python dev, not a javascript one, and there are a whole lot of tools being used in Blockly that I have no knowledge of. So it's often just me being dumb.

Cleo

--

[Rachel Fenichel]

If you think it's just a user error, feel free to post here and look for an answer.  If it feels like a real bug you should make a github issue.  Worst case we'll redirect to the right place.