Class ActionBarSherlockTrojanHorse

BusDeath

unread,

May 29, 2012, 8:01:32 AM5/29/12

to actionba...@googlegroups.com

What makes the class ActionBarSherlockTrojanHorse?

Jake Wharton

unread,

May 29, 2012, 11:30:28 AM5/29/12

to actionba...@googlegroups.com

It provides access to package-scoped things inside the support library which are not public.

---
Jake Wharton
http://about.me/jakewharton

On Tue, May 29, 2012 at 5:01 AM, BusDeath <andre.ze...@googlemail.com> wrote:

What makes the class ActionBarSherlockTrojanHorse?

Mark Murphy

unread,

May 29, 2012, 11:40:22 AM5/29/12

to actionba...@googlegroups.com

On Tue, May 29, 2012 at 11:30 AM, Jake Wharton <jakew...@gmail.com> wrote:
> It provides access to package-scoped things inside the support library which
> are not public.

All else being equal, particularly if you're doing a bunch of other
refactoring, you might consider changing the name of the class. I have
had a couple of people comment on this to me, wondering why we are
adding a Trojan horse to our apps. It's the sort of thing where the
class name raises more questions than it may be worth.

Just my 2 cents.

--
Mark Murphy (a Commons Guy)
http://commonsware.com | http://github.com/commonsguy
http://commonsware.com/blog | http://twitter.com/commonsguy

_The Busy Coder's Guide to Android Development_ Version 3.7 Available!

Shane Perry

unread,

May 29, 2012, 11:44:33 AM5/29/12

to actionba...@googlegroups.com

I would tend to agree with Mark on this one. The name change would be a wise move.

Shane

Christopher Jenkins

unread,

May 29, 2012, 12:36:31 PM5/29/12

to actionba...@googlegroups.com

Ahh I quite like the name, maybe unlike some people I read the comments in the class before I asked questions..

Buuuut, I can see the issue (if) there was an exception and someone checked a stack trace could give your app a bad rep seeing TrojanHorse in the trace (or de-dex'ed for that matter). Rare I know.. but probably not a risk we should take...