Patch to search files without an extension

[Andy Lester]

I really don't want to modify ack's behavior on file searching any more in ack 1.x, but this patch looks like it might be able to handle files without an extension without causing any weird behavior elsewhere.

Thoughts?  Would this be useful to you?

xoa

Begin forwarded message:

From: Sebastian Willert <reply+i-3545608-87047bc9f6ffa10...@reply.github.com>

Subject: [ack] Files without an extension (#213)

Date: March 7, 2012 10:26:21 AM CST

To: Andy Lester <an...@petdance.com>

Allow files without an extension to be recognized as a distinct type. Keep old behavior unless --type-allow-empty is explicitly specified to ensure backwards-compatibility. Added tests and help text for this change.

You can merge this Pull Request by running:

 git pull https://github.com/willert/ack master

Or you can view, comment on it, or merge it online at:

 https://github.com/petdance/ack/pull/213

-- Commit Summary --

* Allow files without an extension to be recognized as a distinct type. Keep old behavior unless --type-allow-empty is explicitly specified. Added tests and help text for this change.

-- File Changes --

M Ack.pm (15)
M ack (15)
M t/ack-text.t (1)
M t/ack-type.t (20)
A t/swamp/no-extension (1)

-- Patch Links --

 https://github.com/petdance/ack/pull/213.patch
 https://github.com/petdance/ack/pull/213.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/petdance/ack/pull/213

--
Andy Lester => an...@petdance.com => www.petdance.com => AIM:petdance

[Tom Burger]

I would use it.  I can't always guarantee what file extensions (or lack thereof) I'm searching for.

-Tom

--
You received this message because you are subscribed to the Google Groups "ack dev/users" group.
To post to this group, send email to ack-...@googlegroups.com.
To unsubscribe from this group, send email to ack-users+...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/ack-users?hl=en.

[Bill Ricker]

Looks plausible, minimal, and useful. And comes with tests.

+1

bill.

--
Bill
@n1vux bill....@gmail.com

[Fisc McTang]

On Wednesday, March 7, 2012 8:43:14 AM UTC-8, Andy Lester wrote:

Thoughts?  Would this be useful to you?

Yes, very useful. 

[suan]

++1. In fact I have a use for it at this very moment.

- Suan

On Wednesday, March 7, 2012 10:43:14 AM UTC-6, Andy Lester wrote:

I really don't want to modify ack's behavior on file searching any more in ack 1.x, but this patch looks like it might be able to handle files without an extension without causing any weird behavior elsewhere.

Thoughts?  Would this be useful to you?

xoa

Begin forwarded message:

On Wednesday, March 7, 2012 10:43:14 AM UTC-6, Andy Lester wrote:

I really don't want to modify ack's behavior on file searching any more in ack 1.x, but this patch looks like it might be able to handle files without an extension without causing any weird behavior elsewhere.

Thoughts?  Would this be useful to you?

xoa

Begin forwarded message:

[Michael Mitchell]

This would be useful to me. I want ack to search my Gemfiles in my rails projects.

-mj