Groups

golang-codereviews

Contact owners and managers

1–30 of 106379

0 selected

Gerrit Bot (Gerrit), … Vann Te (Gerrit)8

5:58 AM

[go] go/token: replace map with array for looking up keywords

Attention needed from Robert Griesemer Vann Te added 1 comment File src/go/token/token.go Line 304,

unread,

[go] go/token: replace map with array for looking up keywords

Attention needed from Robert Griesemer Vann Te added 1 comment File src/go/token/token.go Line 304,

5:58 AM

Junyang Shao (Gerrit), Keith Randall (Gerrit)12

12:23 AM

[go] cmd/compile: add compiler statistics.

Attention needed from David Chase and Keith Randall Junyang Shao voted and added 2 comments Votes

unread,

[go] cmd/compile: add compiler statistics.

Attention needed from David Chase and Keith Randall Junyang Shao voted and added 2 comments Votes

12:23 AM

Junyang Shao (Gerrit), … Keith Randall (Gerrit)15

Nov 29

[go] cmd/compile: add mem2reg pass

Attention needed from David Chase and Junyang Shao Junyang Shao uploaded new patchset Junyang Shao

unread,

[go] cmd/compile: add mem2reg pass

Attention needed from David Chase and Junyang Shao Junyang Shao uploaded new patchset Junyang Shao

Nov 29

Gerrit Bot (Gerrit), … Vann Te (Gerrit)24

Nov 29

[go] time: optimize the performance of the function appendFormatRFC3339

Attention needed from Joseph Tsai and Russ Cox Gerrit Bot uploaded new patchset Gerrit Bot uploaded

unread,

[go] time: optimize the performance of the function appendFormatRFC3339

Attention needed from Joseph Tsai and Russ Cox Gerrit Bot uploaded new patchset Gerrit Bot uploaded

Nov 29

Gerrit Bot (Gerrit), … Keith Randall (Gerrit)17

Nov 29

[go] debug/elf: check if symbol section of 64-bit binary is empty to prevent panic

Attention needed from Florian Lehner Keith Randall voted Code-Review+1 Code-Review +1 Open in Gerrit

unread,

[go] debug/elf: check if symbol section of 64-bit binary is empty to prevent panic

Attention needed from Florian Lehner Keith Randall voted Code-Review+1 Code-Review +1 Open in Gerrit

Nov 29

Gerrit Bot (Gerrit), … Lonny Wong (Gerrit)7

Nov 29

[crypto] ssh: add openssh controlmaster socket support

Attention needed from Cy Borg and Filippo Valsorda Lonny Wong added 2 comments Patchset-level

unread,

[crypto] ssh: add openssh controlmaster socket support

Attention needed from Cy Borg and Filippo Valsorda Lonny Wong added 2 comments Patchset-level

Nov 29

jiahua wang (Gerrit), … Sean Liao (Gerrit)6

Nov 29

[go] strings: use bytealg.IndexRabinKarp on strings.LastIndex

Attention needed from Robert Griesemer, jiahua wang and qiu laidongfeng Sean Liao voted and added 1

unread,

[go] strings: use bytealg.IndexRabinKarp on strings.LastIndex

Attention needed from Robert Griesemer, jiahua wang and qiu laidongfeng Sean Liao voted and added 1

Nov 29

Ian Lance Taylor (Gerrit), Sean Liao (Gerrit)3

Nov 29

[go] debug/elf: correct case of DWARF in comment

Attention needed from Ian Lance Taylor Sean Liao voted Code-Review+2 Code-Review +2 Open in Gerrit

unread,

[go] debug/elf: correct case of DWARF in comment

Attention needed from Ian Lance Taylor Sean Liao voted Code-Review+2 Code-Review +2 Open in Gerrit

Nov 29

Alejandro Saez Morollon (Gerrit), Than McIntosh (Gerrit)8

Nov 29

[go] cmd/link: use .debug_line_str for DWARF 5

Attention needed from Cherry Mui, Michael Hudson-Doyle and Than McIntosh Alejandro Saez Morollon

unread,

[go] cmd/link: use .debug_line_str for DWARF 5

Attention needed from Cherry Mui, Michael Hudson-Doyle and Than McIntosh Alejandro Saez Morollon

Nov 29

Joel Sing (Gerrit), Joel Sing (Gerrit)10

Nov 28

[go] test/codegen: add tests for combined shift and zero extension

Joel Sing voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is empty

unread,

[go] test/codegen: add tests for combined shift and zero extension

Joel Sing voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is empty

Nov 28

Joel Sing (Gerrit), … Joel Sing (Gerrit)8

Nov 28

[go] cmd/compile: avoid zero extension when sufficiently shifted on riscv64

Attention needed from Joel Sing Joel Sing uploaded new patchset Joel Sing uploaded patch set #4 to

unread,

[go] cmd/compile: avoid zero extension when sufficiently shifted on riscv64

Attention needed from Joel Sing Joel Sing uploaded new patchset Joel Sing uploaded patch set #4 to

Nov 28

Sean Liao (Gerrit), … Dmitri Shuralyov (Gerrit)3

Nov 28

[website] _content/blog/generic-interfaces: fix typo in code sample

Dmitri Shuralyov voted Code-Review+1 Code-Review +1 Open in Gerrit Related details Attention set is

unread,

[website] _content/blog/generic-interfaces: fix typo in code sample

Dmitri Shuralyov voted Code-Review+1 Code-Review +1 Open in Gerrit Related details Attention set is

Nov 28

Keith Randall (Gerrit), Jorropo (Gerrit)8

Nov 28

[go] cmd/compile: fix shift codegen tests

Keith Randall abandoned this change Related details Attention set is empty Submit Requirements: Code-

unread,

[go] cmd/compile: fix shift codegen tests

Keith Randall abandoned this change Related details Attention set is empty Submit Requirements: Code-

Nov 28

Joel Sing (Gerrit), … Gopher Robot (Gerrit)18

Nov 28

[go] test/codegen: fix shift tests on riscv64

Gopher Robot submitted the change Change information Commit message: test/codegen: fix shift tests on

unread,

[go] test/codegen: fix shift tests on riscv64

Gopher Robot submitted the change Change information Commit message: test/codegen: fix shift tests on

Nov 28

Cuong Manh Le (Gerrit), … Gopher Robot (Gerrit)11

Nov 28

[go] cmd/compile: avoid unnecessary interface conversion in bloop

Gopher Robot submitted the change Change information Commit message: cmd/compile: avoid unnecessary

unread,

[go] cmd/compile: avoid unnecessary interface conversion in bloop

Gopher Robot submitted the change Change information Commit message: cmd/compile: avoid unnecessary

Nov 28

Gerrit Bot (Gerrit), … Ian Lance Taylor (Gerrit)17

Nov 28

[go] os: allow direntries to have zero inodes on Linux

Attention needed from Brad Fitzpatrick, Dave Vasilevsky and Tobias Klauser Ian Lance Taylor voted

unread,

[go] os: allow direntries to have zero inodes on Linux

Attention needed from Brad Fitzpatrick, Dave Vasilevsky and Tobias Klauser Ian Lance Taylor voted

Nov 28

Gerrit Bot (Gerrit), … Gopher Robot (Gerrit)9

Nov 28

[tools] go/analysis/passes/printf: panic when function literal is assigned to the blank identifier

Gopher Robot submitted the change Change information Commit message: go/analysis/passes/printf: panic

unread,

[tools] go/analysis/passes/printf: panic when function literal is assigned to the blank identifier

Gopher Robot submitted the change Change information Commit message: go/analysis/passes/printf: panic

Nov 28

Dmitri Shuralyov (Gerrit), Ian Lance Taylor (Gerrit)4

Nov 28

[oscar] internal/gaby: fix %q verb use with wrong type

Attention needed from Russ Cox Dmitri Shuralyov added 1 comment Patchset-level comments File-level

unread,

[oscar] internal/gaby: fix %q verb use with wrong type

Attention needed from Russ Cox Dmitri Shuralyov added 1 comment Patchset-level comments File-level

Nov 28

Dmitri Shuralyov (Gerrit), … Gopher Robot (Gerrit)4

Nov 28

[telemetry] counter/countertest: fix %q verb use with wrong type

Gopher Robot submitted the change Change information Commit message: counter/countertest: fix %q verb

unread,

[telemetry] counter/countertest: fix %q verb use with wrong type

Gopher Robot submitted the change Change information Commit message: counter/countertest: fix %q verb

Nov 28

Dmitri Shuralyov (Gerrit), … Gopher Robot (Gerrit)4

Nov 28

[net] http2, webdav, websocket: fix %q verb uses with wrong type

Gopher Robot submitted the change Change information Commit message: http2, webdav, websocket: fix %q

unread,

[net] http2, webdav, websocket: fix %q verb uses with wrong type

Gopher Robot submitted the change Change information Commit message: http2, webdav, websocket: fix %q

Nov 28

Dmitri Shuralyov (Gerrit), … Gopher Robot (Gerrit)4

Nov 28

[text] transform: fix %q verb use with wrong type

Gopher Robot submitted the change Change information Commit message: transform: fix %q verb use with

unread,

[text] transform: fix %q verb use with wrong type

Gopher Robot submitted the change Change information Commit message: transform: fix %q verb use with

Nov 28

Dmitri Shuralyov (Gerrit), … Gopher Robot (Gerrit)5

Nov 28

[pkgsite] internal/postgres: fix %q verb uses with wrong type

Gopher Robot submitted the change Change information Commit message: internal/postgres: fix %q verb

unread,

[pkgsite] internal/postgres: fix %q verb uses with wrong type

Gopher Robot submitted the change Change information Commit message: internal/postgres: fix %q verb

Nov 28

Gerrit Bot (Gerrit), Gopher Robot (Gerrit)4

Nov 28

[tools] tools/gopls Support indexing table-driven subtests in test discovery

Gerrit Bot uploaded new patchset Gerrit Bot uploaded patch set #2 to this change. Open in Gerrit

unread,

[tools] tools/gopls Support indexing table-driven subtests in test discovery

Gerrit Bot uploaded new patchset Gerrit Bot uploaded patch set #2 to this change. Open in Gerrit

Nov 28

Dmitri Shuralyov (Gerrit), Sean Liao (Gerrit)4

Nov 28

[oauth2] endpoints: fix %q verb use with wrong type

Dmitri Shuralyov added 1 comment Patchset-level comments File-level comment, Patchset 1 (Latest):

unread,

[oauth2] endpoints: fix %q verb use with wrong type

Dmitri Shuralyov added 1 comment Patchset-level comments File-level comment, Patchset 1 (Latest):

Nov 28

Oleg Aleksandrov (Gerrit), Keith Randall (Gerrit)30

Nov 28

[go] cmd/compile: replace conditions to CCMP instructions on ARM64

Attention needed from Keith Randall and Martin Möhrmann Oleg Aleksandrov added 2 comments Patchset-

unread,

[go] cmd/compile: replace conditions to CCMP instructions on ARM64

Attention needed from Keith Randall and Martin Möhrmann Oleg Aleksandrov added 2 comments Patchset-

Nov 28

Gerrit Bot (Gerrit), … Klaus Post (Gerrit)60

Nov 28

[go] compress/flate: improve compression speed

Attention needed from Carlos Amedee, Cherry Mui, Ian Lance Taylor, Jorropo, Sean Liao and t hepudds

unread,

[go] compress/flate: improve compression speed

Attention needed from Carlos Amedee, Cherry Mui, Ian Lance Taylor, Jorropo, Sean Liao and t hepudds

Nov 28

Gerrit Bot (Gerrit), … Keith Randall (Gerrit)3

Nov 28

[go] runtime: add explicit lower bounds check to decoderune

Attention needed from Carlos Amedee, Dmitry Vyukov and Ian Lance Taylor Keith Randall added 1 comment

unread,

[go] runtime: add explicit lower bounds check to decoderune

Attention needed from Carlos Amedee, Dmitry Vyukov and Ian Lance Taylor Keith Randall added 1 comment

Nov 28

Daniel Morsing (Gerrit), … Gopher Robot (Gerrit)6

Nov 28

[go] runtime/secret: disable tests under memory validating modes

Gopher Robot submitted the change Change information Commit message: runtime/secret: disable tests

unread,

[go] runtime/secret: disable tests under memory validating modes

Gopher Robot submitted the change Change information Commit message: runtime/secret: disable tests

Nov 28

Dmitri Shuralyov (Gerrit), … Gopher Robot (Gerrit)5

Nov 28

[tools] gopls/internal/cache: fix %q verb use with wrong type

Gopher Robot submitted the change Change information Commit message: gopls/internal/cache: fix %q

unread,

[tools] gopls/internal/cache: fix %q verb use with wrong type

Gopher Robot submitted the change Change information Commit message: gopls/internal/cache: fix %q

Nov 28

Dmitri Shuralyov (Gerrit), … Gopher Robot (Gerrit)6

Nov 28

[build] all: fix %q verb uses with wrong type

Dmitri Shuralyov added 1 comment Patchset-level comments File-level comment, Patchset 2 (Latest):

unread,

[build] all: fix %q verb uses with wrong type

Dmitri Shuralyov added 1 comment Patchset-level comments File-level comment, Patchset 2 (Latest):

Nov 28

Search

Clear search

Close search

Google apps

Main menu