Groups

golang-codereviews

Contact owners and managers

1–30 of 106784

0 selected

Lin Lin (Gerrit), Alan Donovan (Gerrit)3

8:34 PM

[tools] go/analysis/passes/modernize: fix doc URLs in newexpr.go and stringscurt.go

Alan Donovan has uploaded the change for review Commit message [internal-branch.go1.26-vendor] go/

unread,

[tools] go/analysis/passes/modernize: fix doc URLs in newexpr.go and stringscurt.go

Alan Donovan has uploaded the change for review Commit message [internal-branch.go1.26-vendor] go/

8:34 PM

Kirill Kolyshkin (Gerrit), Robert Griesemer (Gerrit)3

8:07 PM

[go] runtime: replace sort.Slice with slices.Sort

Attention needed from Dmitry Vyukov, Ian Lance Taylor, Martin Möhrmann and Robert Griesemer Kirill

unread,

[go] runtime: replace sort.Slice with slices.Sort

Attention needed from Dmitry Vyukov, Ian Lance Taylor, Martin Möhrmann and Robert Griesemer Kirill

8:07 PM

Kirill Kolyshkin (Gerrit), Robert Griesemer (Gerrit)4

8:06 PM

[go] all: replace reflect.TypeOf(x) with TypeFor[T]()

Attention needed from Ian Lance Taylor, Robert Griesemer and Roland Shoemaker Kirill Kolyshkin voted

unread,

[go] all: replace reflect.TypeOf(x) with TypeFor[T]()

Attention needed from Ian Lance Taylor, Robert Griesemer and Roland Shoemaker Kirill Kolyshkin voted

8:06 PM

Kirill Kolyshkin (Gerrit), Robert Griesemer (Gerrit)5

8:06 PM

[go] all: replace explicit loops over maps with calls to maps package

Attention needed from Austin Clements, Ian Lance Taylor and Robert Griesemer Kirill Kolyshkin voted

unread,

[go] all: replace explicit loops over maps with calls to maps package

Attention needed from Austin Clements, Ian Lance Taylor and Robert Griesemer Kirill Kolyshkin voted

8:06 PM

Kirill Kolyshkin (Gerrit), Robert Griesemer (Gerrit)6

8:06 PM

[go] all: replace []byte(fmt.Sprintf) with fmt.Appendf

Attention needed from Brad Fitzpatrick, Jonathan Amsterdam and Robert Griesemer Kirill Kolyshkin

unread,

[go] all: replace []byte(fmt.Sprintf) with fmt.Appendf

Attention needed from Brad Fitzpatrick, Jonathan Amsterdam and Robert Griesemer Kirill Kolyshkin

8:06 PM

Kirill Kolyshkin (Gerrit), Robert Griesemer (Gerrit)6

8:06 PM

[go] all: replace += with strings.Builder

Attention needed from Ian Lance Taylor, Rob Pike and Robert Griesemer Kirill Kolyshkin voted and

unread,

[go] all: replace += with strings.Builder

Attention needed from Ian Lance Taylor, Rob Pike and Robert Griesemer Kirill Kolyshkin voted and

8:06 PM

Kirill Kolyshkin (Gerrit), Robert Griesemer (Gerrit)5

8:05 PM

[go] all: replace ranging over Split/Fields with SplitSeq/FieldsSeq

Attention needed from Filippo Valsorda, Robert Griesemer and Roland Shoemaker Kirill Kolyshkin voted

unread,

[go] all: replace ranging over Split/Fields with SplitSeq/FieldsSeq

Attention needed from Filippo Valsorda, Robert Griesemer and Roland Shoemaker Kirill Kolyshkin voted

8:05 PM

Kirill Kolyshkin (Gerrit)4

8:05 PM

[go] all: replace HasPrefix/TrimPrefix with CutPrefix

Attention needed from Brad Fitzpatrick, Ian Lance Taylor and Roland Shoemaker Kirill Kolyshkin voted

unread,

[go] all: replace HasPrefix/TrimPrefix with CutPrefix

Attention needed from Brad Fitzpatrick, Ian Lance Taylor and Roland Shoemaker Kirill Kolyshkin voted

8:05 PM

Kirill Kolyshkin (Gerrit), … Robert Griesemer (Gerrit)5

8:04 PM

[go] all: replace if/else statements with calls to min or max

Attention needed from Alan Donovan, Austin Clements, Ian Lance Taylor, Michael Pratt, Robert

unread,

[go] all: replace if/else statements with calls to min or max

Attention needed from Alan Donovan, Austin Clements, Ian Lance Taylor, Michael Pratt, Robert

8:04 PM

leow kimfui (melalui Google Drive)

7:59 PM

Item yang dikongsi dengan anda: "ai-responsibility-update-published-february-2025 (1)_salinan.pdf"

leow kimfui berkongsi satu item leow kimfui (cokiw...@gmail.com) telah berkongsi item berikut: ai-

unread,

Item yang dikongsi dengan anda: "ai-responsibility-update-published-february-2025 (1)_salinan.pdf"

leow kimfui berkongsi satu item leow kimfui (cokiw...@gmail.com) telah berkongsi item berikut: ai-

7:59 PM

Keith Randall (Gerrit)

7:45 PM

[sys] sys/cpu: add symbolic constants for remaining cpuid bits

Attention needed from Cherry Mui Keith Randall has uploaded the change for review Keith Randall would

unread,

[sys] sys/cpu: add symbolic constants for remaining cpuid bits

Attention needed from Cherry Mui Keith Randall has uploaded the change for review Keith Randall would

7:45 PM

Keith Randall (Gerrit)

7:45 PM

[sys] sys/cpu: use symbolic names for masks

Attention needed from Cherry Mui Keith Randall has uploaded the change for review Keith Randall would

unread,

[sys] sys/cpu: use symbolic names for masks

Attention needed from Cherry Mui Keith Randall has uploaded the change for review Keith Randall would

7:45 PM

Keith Randall (Gerrit)

7:45 PM

[sys] sys/cpu: modify x86 port to match what internal/cpu does

Attention needed from Cherry Mui Keith Randall has uploaded the change for review Keith Randall would

unread,

[sys] sys/cpu: modify x86 port to match what internal/cpu does

Attention needed from Cherry Mui Keith Randall has uploaded the change for review Keith Randall would

7:45 PM

Marcellus Salvatore

7:19 PM

Looking for an awesome blog post? We’ve got it!

Hi, I am Marcellus, A B2B writer committed to composing impactful, SEO-friendly articles for

unread,

Looking for an awesome blog post? We’ve got it!

Hi, I am Marcellus, A B2B writer committed to composing impactful, SEO-friendly articles for

7:19 PM

Ethan Lee (Gerrit), Dmitri Shuralyov (Gerrit)8

6:28 PM

[tools] gopls/internal/server: disable TestCheckGoModDeps for js

Attention needed from Dmitri Shuralyov and Hongxiang Jiang Ethan Lee voted and added 1 comment Votes

unread,

[tools] gopls/internal/server: disable TestCheckGoModDeps for js

Attention needed from Dmitri Shuralyov and Hongxiang Jiang Ethan Lee voted and added 1 comment Votes

6:28 PM

Keith Randall (Gerrit)5

6:04 PM

[go] cmd/compile: ensure ops have the expected argument widths

Attention needed from Keith Randall and Michael Pratt Keith Randall uploaded new patchset Keith

unread,

[go] cmd/compile: ensure ops have the expected argument widths

Attention needed from Keith Randall and Michael Pratt Keith Randall uploaded new patchset Keith

6:04 PM

David Chase (Gerrit), … Cherry Mui (Gerrit)7

5:32 PM

[go] internal/cpu: repair VNNI feature check

Attention needed from David Chase, Keith Randall, Keith Randall and Martin Möhrmann Cherry Mui added

unread,

[go] internal/cpu: repair VNNI feature check

Attention needed from David Chase, Keith Randall, Keith Randall and Martin Möhrmann Cherry Mui added

5:32 PM

Wanbiao Ye (Gerrit), Robert Griesemer (Gerrit)4

5:01 PM

[go] math/pow10: remove overlapping boundary (n=0)

Attention needed from Robert Griesemer, Russ Cox and Wanbiao Ye Robert Griesemer voted and added 1

unread,

[go] math/pow10: remove overlapping boundary (n=0)

Attention needed from Robert Griesemer, Russ Cox and Wanbiao Ye Robert Griesemer voted and added 1

5:01 PM

Madeline Kalil (Gerrit), Alan Donovan (Gerrit)22

5:01 PM

[tools] gopls/internal/golang: fix incorrect missing method code action

Attention needed from Alan Donovan Madeline Kalil voted and added 3 comments Votes added by Madeline

unread,

[tools] gopls/internal/golang: fix incorrect missing method code action

Attention needed from Alan Donovan Madeline Kalil voted and added 3 comments Votes added by Madeline

5:01 PM

Alan Donovan (Gerrit), Madeline Kalil (Gerrit)4

5:01 PM

[tools/internal-branch.go1.26-vendor] [internal-branch.go1.26-vendor] go/analysis/passes/modernize: disable reflecttypefor modernizer for unnamed struct/interface

Alan Donovan voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

unread,

[tools/internal-branch.go1.26-vendor] [internal-branch.go1.26-vendor] go/analysis/passes/modernize: disable reflecttypefor modernizer for unnamed struct/interface

Alan Donovan voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

5:01 PM

Alan Donovan (Gerrit), … Madeline Kalil (Gerrit)12

5:01 PM

[tools] go/analysis/passes/modernize: rangeint: result vars are implicit uses

Alan Donovan voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

unread,

[tools] go/analysis/passes/modernize: rangeint: result vars are implicit uses

Alan Donovan voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

5:01 PM

Gerrit Bot (Gerrit), … Armin Günther (Gerrit)19

4:51 PM

[go] math/big: add Floor and Ceil methods to Rat

Attention needed from Alan Donovan and Robert Griesemer Gerrit Bot uploaded new patchset Gerrit Bot

unread,

[go] math/big: add Floor and Ceil methods to Rat

Attention needed from Alan Donovan and Robert Griesemer Gerrit Bot uploaded new patchset Gerrit Bot

4:51 PM

Kirill Kolyshkin (Gerrit), … Gopher Robot (Gerrit)5

4:42 PM

[tools] gopls/internal/analysis/modernize: fix URL

Gopher Robot submitted the change Change information Commit message: gopls/internal/analysis/

unread,

[tools] gopls/internal/analysis/modernize: fix URL

Gopher Robot submitted the change Change information Commit message: gopls/internal/analysis/

4:42 PM

Lin Lin (Gerrit), … Michael Knyszek (Gerrit)3

4:41 PM

[go] cmd: fix unused errors reported by ineffassign

Attention needed from Lin Lin and Than McIntosh Michael Knyszek voted Code-Review+1 Code-Review +1

unread,

[go] cmd: fix unused errors reported by ineffassign

Attention needed from Lin Lin and Than McIntosh Michael Knyszek voted Code-Review+1 Code-Review +1

4:41 PM

Kirill Kolyshkin (Gerrit), Alan Donovan (Gerrit)4

4:41 PM

[go] all: replace strings.Index etc. with strings.Cut

Attention needed from Damien Neil, Kirill Kolyshkin and Robert Griesemer Alan Donovan voted and added

unread,

[go] all: replace strings.Index etc. with strings.Cut

Attention needed from Damien Neil, Kirill Kolyshkin and Robert Griesemer Alan Donovan voted and added

4:41 PM

Peter Weinberger (Gerrit), … Alan Donovan (Gerrit)39

4:37 PM

[tools] gopls/mod: find references to required modules

Attention needed from Peter Weinberger Alan Donovan added 7 comments File gopls/doc/features/

unread,

[tools] gopls/mod: find references to required modules

Attention needed from Peter Weinberger Alan Donovan added 7 comments File gopls/doc/features/

4:37 PM

Ethan Lee (Gerrit), … Jonathan Amsterdam (Gerrit)34

4:16 PM

[pkgsite] internal/frontend: add CodeWiki link support to pkgsite

Attention needed from Ethan Lee Jonathan Amsterdam voted Code-Review+2 Code-Review +2 Open in Gerrit

unread,

[pkgsite] internal/frontend: add CodeWiki link support to pkgsite

Attention needed from Ethan Lee Jonathan Amsterdam voted Code-Review+2 Code-Review +2 Open in Gerrit

4:16 PM

Kirill Kolyshkin (Gerrit), … Robert Griesemer (Gerrit)6

4:07 PM

[go] all: replace loops with slices.Contains or slices.ContainsFunc

Attention needed from Daniel McCarney, Filippo Valsorda, Robert Griesemer and Roland Shoemaker Kirill

unread,

[go] all: replace loops with slices.Contains or slices.ContainsFunc

Attention needed from Daniel McCarney, Filippo Valsorda, Robert Griesemer and Roland Shoemaker Kirill

4:07 PM

Nick Ripley (Gerrit), … Cherry Mui (Gerrit)5

3:53 PM

[go] runtime: adjust frame pointer of dead frames interrupted by sigpanic

Attention needed from Cherry Mui and Keith Randall Nick Ripley voted and added 4 comments Votes added

unread,

[go] runtime: adjust frame pointer of dead frames interrupted by sigpanic

Attention needed from Cherry Mui and Keith Randall Nick Ripley voted and added 4 comments Votes added

3:53 PM

Ethan Lee (Gerrit), Jonathan Amsterdam (Gerrit)5

3:20 PM

[pkgsite] tests: update docs for updating screenshot tests

Ethan Lee voted and added 1 comment Votes added by Ethan Lee Auto-Submit +1 Commit-Queue +1 1 comment

unread,

[pkgsite] tests: update docs for updating screenshot tests

Ethan Lee voted and added 1 comment Votes added by Ethan Lee Auto-Submit +1 Commit-Queue +1 1 comment

3:20 PM

Search

Clear search

Close search

Google apps

Main menu