Groups

golang-codereviews

Contact owners and managers

1–30 of 105096

0 selected

Markus Kusano (Gerrit), Ethan Lee (Gerrit)3

1:41 PM

[pkgsite-metrics] Makefile: set project ID for docker runs.

Attention needed from Markus Kusano Ethan Lee voted Code-Review+2 Code-Review +2 Open in Gerrit

unread,

[pkgsite-metrics] Makefile: set project ID for docker runs.

Attention needed from Markus Kusano Ethan Lee voted Code-Review+2 Code-Review +2 Open in Gerrit

1:41 PM

Hongxiang Jiang (Gerrit), Robert Findley (Gerrit)21

1:29 PM

[tools] gopls/internal/filewatcher: backfill events after watching a directory

Attention needed from Alan Donovan and Robert Findley Hongxiang Jiang uploaded new patchset Hongxiang

unread,

[tools] gopls/internal/filewatcher: backfill events after watching a directory

Attention needed from Alan Donovan and Robert Findley Hongxiang Jiang uploaded new patchset Hongxiang

1:29 PM

Mateusz Poliwczak (Gerrit), … Robert Griesemer (Gerrit)7

1:14 PM

[go] go/ast: document CommentGroup types

Attention needed from Alan Donovan and Robert Griesemer Mateusz Poliwczak voted Commit-Queue+1 Commit

unread,

[go] go/ast: document CommentGroup types

Attention needed from Alan Donovan and Robert Griesemer Mateusz Poliwczak voted Commit-Queue+1 Commit

1:14 PM

Junyang Shao (Gerrit)2

1:03 PM

[go] cmd/compile: make dead auto elim ignore variable size

Attention needed from David Chase and Keith Randall Junyang Shao voted Commit-Queue+1 Commit-Queue +1

unread,

[go] cmd/compile: make dead auto elim ignore variable size

Attention needed from David Chase and Keith Randall Junyang Shao voted Commit-Queue+1 Commit-Queue +1

1:03 PM

Markus Kusano (Gerrit)3

12:51 PM

[pkgsite-metrics] internal/worker: addSource information to results

Attention needed from Ethan Lee Markus Kusano voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

unread,

[pkgsite-metrics] internal/worker: addSource information to results

Attention needed from Ethan Lee Markus Kusano voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

12:51 PM

Gerrit Bot (Gerrit), … t hepudds (Gerrit)109

12:51 PM

[go] Proposal #74609: goroutine leak detection by using the garbage collector

Attention needed from Austin Clements, Emmanuel Odeke, Michael Knyszek, Michael Pratt and t hepudds

unread,

[go] Proposal #74609: goroutine leak detection by using the garbage collector

Attention needed from Austin Clements, Emmanuel Odeke, Michael Knyszek, Michael Pratt and t hepudds

12:51 PM

Damien Neil (Gerrit), … Gopher Robot (Gerrit)10

12:50 PM

[net] http2: make the error channel pool per-Server

Gopher Robot submitted the change Change information Commit message: http2: make the error channel

unread,

[net] http2: make the error channel pool per-Server

Gopher Robot submitted the change Change information Commit message: http2: make the error channel

12:50 PM

Michael Pratt (Gerrit), … Carlos Amedee (Gerrit)16

12:40 PM

[go] sync/atomic: correct Uintptr.Or return doc

Carlos Amedee submitted the change Change information Commit message: [release-branch.go1.25] sync/

unread,

[go] sync/atomic: correct Uintptr.Or return doc

Carlos Amedee submitted the change Change information Commit message: [release-branch.go1.25] sync/

12:40 PM

Carlos Amedee (Gerrit), Cherry Mui (Gerrit)4

12:39 PM

[go/release-branch.go1.25] [release-branch.go1.25] runtime: initialise debug settings much earlier in startup process

Carlos Amedee submitted the change Change information Commit message: [release-branch.go1.25] runtime

unread,

[go/release-branch.go1.25] [release-branch.go1.25] runtime: initialise debug settings much earlier in startup process

Carlos Amedee submitted the change Change information Commit message: [release-branch.go1.25] runtime

12:39 PM

Keith Randall (Gerrit), … Carlos Amedee (Gerrit)16

12:39 PM

[go] cmd/compile: don't rely on loop info when there are irreducible loops

Attention needed from Keith Randall Carlos Amedee voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

unread,

[go] cmd/compile: don't rely on loop info when there are irreducible loops

Attention needed from Keith Randall Carlos Amedee voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

12:39 PM

Alan Donovan (Gerrit), … Robert Griesemer (Gerrit)7

12:38 PM

[go] doc/go_spec.html: document new(expr)

Robert Griesemer added 1 comment Patchset-level comments File-level comment, Patchset 5 (Latest):

unread,

[go] doc/go_spec.html: document new(expr)

Robert Griesemer added 1 comment Patchset-level comments File-level comment, Patchset 5 (Latest):

12:38 PM

Ethan Lee (Gerrit), Markus Kusano (Gerrit)2

12:33 PM

[pkgsite-metrics] cmd/ejobs: provide option to use existing binary in GCS

Attention needed from Ethan Lee Markus Kusano voted and added 1 comment Votes added by Markus Kusano

unread,

[pkgsite-metrics] cmd/ejobs: provide option to use existing binary in GCS

Attention needed from Ethan Lee Markus Kusano voted and added 1 comment Votes added by Markus Kusano

12:33 PM

Junyang Shao (Gerrit)2

12:25 PM

[go] cmd/compile: correct OffPtr collapsing rule type

Attention needed from David Chase and Keith Randall Junyang Shao voted Commit-Queue+1 Commit-Queue +1

unread,

[go] cmd/compile: correct OffPtr collapsing rule type

Attention needed from David Chase and Keith Randall Junyang Shao voted Commit-Queue+1 Commit-Queue +1

12:25 PM

Omar Khan (Gerrit), … Robert Griesemer (Gerrit)3

12:17 PM

[go] go/token/position.go: Fix trivial typo in comment.

Attention needed from Omar Khan and Robert Griesemer Robert Griesemer voted Code-Review+2 Code-Review

unread,

[go] go/token/position.go: Fix trivial typo in comment.

Attention needed from Omar Khan and Robert Griesemer Robert Griesemer voted Code-Review+2 Code-Review

12:17 PM

Gerrit Bot (Gerrit), … Gopher Robot (Gerrit)16

12:13 PM

[go] Issue #75685: inverted test failure message in TestContextAfterFunc

Gopher Robot submitted the change Change information Commit message: testing/synctest: fix inverted

unread,

[go] Issue #75685: inverted test failure message in TestContextAfterFunc

Gopher Robot submitted the change Change information Commit message: testing/synctest: fix inverted

12:13 PM

Ethan Lee (Gerrit), … Gopher Robot (Gerrit)3

12:07 PM

[pkgsite-metrics] terraform/environment: increase number of queues to 7

Gopher Robot submitted the change Change information Commit message: terraform/environment: increase

unread,

[pkgsite-metrics] terraform/environment: increase number of queues to 7

Gopher Robot submitted the change Change information Commit message: terraform/environment: increase

12:07 PM

Ethan Lee (Gerrit), … Gopher Robot (Gerrit)3

12:07 PM

[pkgsite-metrics] terraform/environment: increase max auto scaling worker count

Gopher Robot submitted the change Change information Commit message: terraform/environment: increase

unread,

[pkgsite-metrics] terraform/environment: increase max auto scaling worker count

Gopher Robot submitted the change Change information Commit message: terraform/environment: increase

12:07 PM

Roland Shoemaker (Gerrit)2

11:59 AM

[go] crypto/x509: simplify candidate chain filtering

Attention needed from Daniel McCarney and Filippo Valsorda Roland Shoemaker voted Commit-Queue+1

unread,

[go] crypto/x509: simplify candidate chain filtering

Attention needed from Daniel McCarney and Filippo Valsorda Roland Shoemaker voted Commit-Queue+1

11:59 AM

Damien Neil (Gerrit), … Cherry Mui (Gerrit)12

11:32 AM

[go] context: don't return a non-nil from Err before Done is closed

Attention needed from Damien Neil and Sameer Ajmani Cherry Mui voted Code-Review+2 Code-Review +2

unread,

[go] context: don't return a non-nil from Err before Done is closed

Attention needed from Damien Neil and Sameer Ajmani Cherry Mui voted Code-Review+2 Code-Review +2

11:32 AM

Carlos Amedee (Gerrit), Cherry Mui (Gerrit)6

11:31 AM

[go/release-branch.go1.25] [release-branch.go1.25] debug/pe: permit symbols with no name

Attention needed from Carlos Amedee, Ian Lance Taylor, Michael Pratt and Quim Muntal Cherry Mui voted

unread,

[go/release-branch.go1.25] [release-branch.go1.25] debug/pe: permit symbols with no name

Attention needed from Carlos Amedee, Ian Lance Taylor, Michael Pratt and Quim Muntal Cherry Mui voted

11:31 AM

David Chase (Gerrit)2

11:31 AM

[go] cmd/compile: make wasm match other platforms for FP->int32/64 conversions

David Chase voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

unread,

[go] cmd/compile: make wasm match other platforms for FP->int32/64 conversions

David Chase voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

11:31 AM

Damien Neil (Gerrit), … Cherry Mui (Gerrit)18

11:30 AM

[go] net/http: avoid connCount underflow race

Attention needed from Damien Neil Cherry Mui voted Code-Review+2 Code-Review +2 Open in Gerrit

unread,

[go] net/http: avoid connCount underflow race

Attention needed from Damien Neil Cherry Mui voted Code-Review+2 Code-Review +2 Open in Gerrit

11:30 AM

Alan Donovan (Gerrit), Michael Pratt (Gerrit)5

11:12 AM

[telemetry] cmd/stacks: show build info tuple using go command syntax

Attention needed from Michael Pratt Alan Donovan added 2 comments File cmd/stacks/stacks.go Line 856,

unread,

[telemetry] cmd/stacks: show build info tuple using go command syntax

Attention needed from Michael Pratt Alan Donovan added 2 comments File cmd/stacks/stacks.go Line 856,

11:12 AM

Alan Donovan (Gerrit), … Ingo Oeser (Gerrit)13

11:10 AM

[tools] gopls/internal/analysis/modernize: pass to use go1.26 new(x)

Attention needed from Alan Donovan, Ingo Oeser and Madeline Kalil Alan Donovan uploaded new patchset

unread,

[tools] gopls/internal/analysis/modernize: pass to use go1.26 new(x)

Attention needed from Alan Donovan, Ingo Oeser and Madeline Kalil Alan Donovan uploaded new patchset

11:10 AM

Michael Knyszek (Gerrit), … Carlos Amedee (Gerrit)3

11:06 AM

[go/release-branch.go1.25] [release-branch.go1.25] internal/poll: don't call Seek for overlapped Windows handles

Carlos Amedee submitted the change Change information Commit message: [release-branch.go1.25]

unread,

[go/release-branch.go1.25] [release-branch.go1.25] internal/poll: don't call Seek for overlapped Windows handles

Carlos Amedee submitted the change Change information Commit message: [release-branch.go1.25]

11:06 AM

shuang cui (Gerrit), Alan Donovan (Gerrit)20

11:04 AM

[tools] go/analysis/passes/modernize: directly remove user-defined min/max functions

Attention needed from shuang cui Alan Donovan added 17 comments Patchset-level comments File-level

unread,

[tools] go/analysis/passes/modernize: directly remove user-defined min/max functions

Attention needed from shuang cui Alan Donovan added 17 comments Patchset-level comments File-level

11:04 AM

Peter Weinberger (Gerrit)

10:57 AM

[tools] gopls/unimported: WIP, DO NOT REVIEW

Attention needed from Peter Weinberger Peter Weinberger uploaded new patchset Peter Weinberger

unread,

[tools] gopls/unimported: WIP, DO NOT REVIEW

Attention needed from Peter Weinberger Peter Weinberger uploaded new patchset Peter Weinberger

10:57 AM

Paul Murphy (Gerrit), … Quim Muntal (Gerrit)5

10:43 AM

[go] runtime: cleanup comments from asm_ppc64x.s improvements

Attention needed from Keith Randall and Paul Murphy Quim Muntal voted Code-Review+2 Code-Review +2

unread,

[go] runtime: cleanup comments from asm_ppc64x.s improvements

Attention needed from Keith Randall and Paul Murphy Quim Muntal voted Code-Review+2 Code-Review +2

10:43 AM

Quim Muntal (Gerrit)2

10:30 AM

[go] runtime/cgo: deduplicate pthreads-related functions

Attention needed from Ian Lance Taylor, Keith Randall and Quim Muntal Quim Muntal removed a vote from

unread,

[go] runtime/cgo: deduplicate pthreads-related functions

Attention needed from Ian Lance Taylor, Keith Randall and Quim Muntal Quim Muntal removed a vote from

10:30 AM

Quim Muntal (Gerrit), Paul Murphy (Gerrit)3

10:28 AM

[go] runtime: fix aix/ppc64 library initialization

Attention needed from Keith Randall and Quim Muntal Paul Murphy voted Code-Review+2 Code-Review +2

unread,

[go] runtime: fix aix/ppc64 library initialization

Attention needed from Keith Randall and Quim Muntal Paul Murphy voted Code-Review+2 Code-Review +2

10:28 AM

Search

Clear search

Close search

Google apps

Main menu