Groups

golang-codereviews

Contact owners and managers

1–30 of 106724

0 selected

Sean Liao (Gerrit), … Michael Knyszek (Gerrit)8

3:37 PM

[go] go/doc: exclude examples with results

Sean Liao submitted the change Change information Commit message: go/doc: exclude examples with

unread,

[go] go/doc: exclude examples with results

Sean Liao submitted the change Change information Commit message: go/doc: exclude examples with

3:37 PM

Hongxiang Jiang (Gerrit), … Gopher Robot (Gerrit)11

3:29 PM

[vscode-go] extension/src/language: extend range support to type def

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

unread,

[vscode-go] extension/src/language: extend range support to type def

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

3:29 PM

Gopher Robot (Gerrit), Dmitri Shuralyov (Gerrit)2

3:18 PM

[tools] internal/stdlib: update stdlib index for Go 1.26 Release Candidate 1

Attention needed from David Chase and Michael Knyszek Dmitri Shuralyov added 2 comments Patchset-

unread,

[tools] internal/stdlib: update stdlib index for Go 1.26 Release Candidate 1

Attention needed from David Chase and Michael Knyszek Dmitri Shuralyov added 2 comments Patchset-

3:18 PM

Ethan Lee (Gerrit), Hongxiang Jiang (Gerrit)9

3:12 PM

[tools] gopls/internal/server: modify checkGoModDeps condition

Attention needed from Ethan Lee Hongxiang Jiang voted Code-Review+2 Code-Review +2 Open in Gerrit

unread,

[tools] gopls/internal/server: modify checkGoModDeps condition

Attention needed from Ethan Lee Hongxiang Jiang voted Code-Review+2 Code-Review +2 Open in Gerrit

3:12 PM

Madeline Kalil (Gerrit), Alan Donovan (Gerrit)18

3:11 PM

[tools] gopls/internal/golang: fix incorrect missing method code action

Attention needed from Madeline Kalil Alan Donovan added 4 comments Patchset-level comments File-level

unread,

[tools] gopls/internal/golang: fix incorrect missing method code action

Attention needed from Madeline Kalil Alan Donovan added 4 comments Patchset-level comments File-level

3:11 PM

Gopher Robot (Gerrit), … David Chase (Gerrit)6

3:01 PM

[dl] dl: add go1.26rc1

Gopher Robot submitted the change Change information Commit message: dl: add go1.26rc1 Change-Id:

unread,

[dl] dl: add go1.26rc1

Gopher Robot submitted the change Change information Commit message: dl: add go1.26rc1 Change-Id:

3:01 PM

Gopher Robot (Gerrit), … David Chase (Gerrit)6

3:01 PM

[go/release-branch.go1.26] [release-branch.go1.26] go1.26rc1

Gopher Robot submitted the change Change information Commit message: [release-branch.go1.26] go1.

unread,

[go/release-branch.go1.26] [release-branch.go1.26] go1.26rc1

Gopher Robot submitted the change Change information Commit message: [release-branch.go1.26] go1.

3:01 PM

Madeline Kalil (Gerrit), … Hongxiang Jiang (Gerrit)15

2:58 PM

[tools] gopls/internal/golang: implement type definition for builtin types

Madeline Kalil submitted the change Change information Commit message: gopls/internal/golang:

unread,

[tools] gopls/internal/golang: implement type definition for builtin types

Madeline Kalil submitted the change Change information Commit message: gopls/internal/golang:

2:58 PM

Nicholas Husin (Gerrit), … Neal Patel (Gerrit)4

2:39 PM

[vulndb] data/reports: add 2 reports

Nicholas Husin submitted the change Change information Commit message: data/reports: add 2 reports -

unread,

[vulndb] data/reports: add 2 reports

Nicholas Husin submitted the change Change information Commit message: data/reports: add 2 reports -

2:39 PM

Roland Shoemaker (Gerrit), … Michael Knyszek (Gerrit)34

2:23 PM

[go] crypto/tls: reject trailing messages after client/server hello

Roland Shoemaker submitted the change with unreviewed changes Unreviewed changes 4 is the latest

unread,

[go] crypto/tls: reject trailing messages after client/server hello

Roland Shoemaker submitted the change with unreviewed changes Unreviewed changes 4 is the latest

2:23 PM

Hongxiang Jiang (Gerrit), … Madeline Kalil (Gerrit)12

2:18 PM

[tools] gopls/internal/test/marker: add optional error to typedef marker

Hongxiang Jiang submitted the change Change information Commit message: gopls/internal/test/marker:

unread,

[tools] gopls/internal/test/marker: add optional error to typedef marker

Hongxiang Jiang submitted the change Change information Commit message: gopls/internal/test/marker:

2:18 PM

Hongxiang Jiang (Gerrit), … Madeline Kalil (Gerrit)22

2:18 PM

[tools] gopls/internal/server: support type def with selected range

Hongxiang Jiang submitted the change Change information Commit message: gopls/internal/server:

unread,

[tools] gopls/internal/server: support type def with selected range

Hongxiang Jiang submitted the change Change information Commit message: gopls/internal/server:

2:18 PM

Michael Matloob (Gerrit), … Filippo Valsorda (Gerrit)11

1:58 PM

[go] cmd/go: add tlskyber godebug back with no effect

Michael Matloob abandoned this change Related details Attention set is empty Submit Requirements:

unread,

[go] cmd/go: add tlskyber godebug back with no effect

Michael Matloob abandoned this change Related details Attention set is empty Submit Requirements:

1:58 PM

Nhan Nguyen (Gerrit), Keith Randall (Gerrit)3

1:46 PM

[go] cmd/compile: implement reverse bounds check elimination

Attention needed from Martin Möhrmann and Nhan Nguyen Nhan Nguyen uploaded new patchset Nhan Nguyen

unread,

[go] cmd/compile: implement reverse bounds check elimination

Attention needed from Martin Möhrmann and Nhan Nguyen Nhan Nguyen uploaded new patchset Nhan Nguyen

1:46 PM

Pontus Leitzler (Gerrit), … Alan Donovan (Gerrit)7

1:42 PM

[tools] gopls/internal/cache: avoid unnecessary mod tidy invalidation

Alan Donovan submitted the change Change information Commit message: gopls/internal/cache: avoid

unread,

[tools] gopls/internal/cache: avoid unnecessary mod tidy invalidation

Alan Donovan submitted the change Change information Commit message: gopls/internal/cache: avoid

1:42 PM

Peter Weinberger (Gerrit), … Alan Donovan (Gerrit)24

1:39 PM

[tools] gopls: remove a use of panic for flow control

Alan Donovan abandoned this change Related details Attention set is empty Submit Requirements: Code-

unread,

[tools] gopls: remove a use of panic for flow control

Alan Donovan abandoned this change Related details Attention set is empty Submit Requirements: Code-

1:39 PM

Alan Donovan (Gerrit), … Damien Neil (Gerrit)15

1:34 PM

[go] os/exec: second call to Cmd.Start is always an error

Attention needed from Damien Neil, Kirill Kolyshkin and Ефим Верзаков Alan Donovan added 3 comments

unread,

[go] os/exec: second call to Cmd.Start is always an error

Attention needed from Damien Neil, Kirill Kolyshkin and Ефим Верзаков Alan Donovan added 3 comments

1:34 PM

Ethan Lee (Gerrit)4

1:26 PM

[pkgsite] internal/frontend: instantiate api implementation

Ethan Lee uploaded new patchset Ethan Lee uploaded patch set #4 to this change. Open in Gerrit

unread,

[pkgsite] internal/frontend: instantiate api implementation

Ethan Lee uploaded new patchset Ethan Lee uploaded patch set #4 to this change. Open in Gerrit

1:26 PM

Ethan Lee (Gerrit)

1:04 PM

[pkgsite] internal/frontend: define API using proto

Ethan Lee has uploaded the change for review Commit message internal/frontend: define API using proto

unread,

[pkgsite] internal/frontend: define API using proto

Ethan Lee has uploaded the change for review Commit message internal/frontend: define API using proto

1:04 PM

David Chase (Gerrit), Keith Randall (Gerrit)5

1:00 PM

[go] cmd/compile: (amd64) optimize float32(round64(float64(x)))

Attention needed from David Chase, Keith Randall, Martin Möhrmann and Russ Cox Keith Randall added 1

unread,

[go] cmd/compile: (amd64) optimize float32(round64(float64(x)))

Attention needed from David Chase, Keith Randall, Martin Möhrmann and Russ Cox Keith Randall added 1

1:00 PM

David Chase (Gerrit), Keith Randall (Gerrit)4

12:55 PM

[go] cmd/compile: (wasm) optimize float32(round64(float64(x)))

Attention needed from David Chase and Martin Möhrmann Keith Randall voted Code-Review+1 Code-Review +

unread,

[go] cmd/compile: (wasm) optimize float32(round64(float64(x)))

Attention needed from David Chase and Martin Möhrmann Keith Randall voted Code-Review+1 Code-Review +

12:55 PM

Ethan Lee (Gerrit)

12:46 PM

[pkgsite] internal: define API handler for MajorVersions

Ethan Lee has uploaded the change for review Commit message internal: define API handler for

unread,

[pkgsite] internal: define API handler for MajorVersions

Ethan Lee has uploaded the change for review Commit message internal: define API handler for

12:46 PM

Alan Donovan (Gerrit)

12:42 PM

[tools] go/analysis/passes/scannererr: report failure to check bufio.Scanner.Err

Alan Donovan has uploaded the change for review Commit message go/analysis/passes/scannererr: report

unread,

[tools] go/analysis/passes/scannererr: report failure to check bufio.Scanner.Err

Alan Donovan has uploaded the change for review Commit message go/analysis/passes/scannererr: report

12:42 PM

Sean Liao (Gerrit), … Damien Neil (Gerrit)7

12:18 PM

[website] _content/doc/go1.26: add note for http.Client cookie Host change

Sean Liao submitted the change Change information Commit message: _content/doc/go1.26: add note for

unread,

[website] _content/doc/go1.26: add note for http.Client cookie Host change

Sean Liao submitted the change Change information Commit message: _content/doc/go1.26: add note for

12:18 PM

Daniel Morsing (Gerrit), … t hepudds (Gerrit)8

12:10 PM

[go] runtime: pass actual allocation size to special free

Attention needed from Daniel Morsing and t hepudds t hepudds added 1 comment Patchset-level comments

unread,

[go] runtime: pass actual allocation size to special free

Attention needed from Daniel Morsing and t hepudds t hepudds added 1 comment Patchset-level comments

12:10 PM

Cherry Mui (Gerrit), David Chase (Gerrit)3

12:06 PM

[go] cmd/compile: use unsigned constant when folding loads for SIMD ops with constants

David Chase submitted the change Change information Commit message: cmd/compile: use unsigned

unread,

[go] cmd/compile: use unsigned constant when folding loads for SIMD ops with constants

David Chase submitted the change Change information Commit message: cmd/compile: use unsigned

12:06 PM

Mike Kruskal (Gerrit), … Michael Stapelberg (Gerrit)7

11:59 AM

[protobuf] compiler/protogen: introduce and expose feature resoluton to protogen

Attention needed from Mike Kruskal Mike Kruskal uploaded new patchset Mike Kruskal uploaded patch set

unread,

[protobuf] compiler/protogen: introduce and expose feature resoluton to protogen

Attention needed from Mike Kruskal Mike Kruskal uploaded new patchset Mike Kruskal uploaded patch set

11:59 AM

Josh Bleecher Snyder (Gerrit), Michael Knyszek (Gerrit)3

11:45 AM

[term] x/term: handle delete key

Attention needed from Josh Bleecher Snyder Michael Knyszek voted Auto-Submit +1 Code-Review +2 Commit

unread,

[term] x/term: handle delete key

Attention needed from Josh Bleecher Snyder Michael Knyszek voted Auto-Submit +1 Code-Review +2 Commit

11:45 AM

Dmitri Shuralyov (Gerrit), … Gopher Robot (Gerrit)5

11:32 AM

[build/luci-config] main.star: reenable linux/mips64le builders for golang.org/x repos

Gopher Robot submitted the change Change information Commit message: main.star: reenable linux/

unread,

[build/luci-config] main.star: reenable linux/mips64le builders for golang.org/x repos

Gopher Robot submitted the change Change information Commit message: main.star: reenable linux/

11:32 AM

Dmitri Shuralyov (Gerrit), Michael Knyszek (Gerrit)3

11:28 AM

[build/luci-config] main.star: remove known issue for linux/mips64le builders

Attention needed from Dmitri Shuralyov Michael Knyszek voted Code-Review+2 Code-Review +2 Open in

unread,

[build/luci-config] main.star: remove known issue for linux/mips64le builders

Attention needed from Dmitri Shuralyov Michael Knyszek voted Code-Review+2 Code-Review +2 Open in

11:28 AM

Search

Clear search

Close search

Google apps

Main menu