[zeek/spicy] 6486b4: Use standard-compliant type for `std::string_view`...

0 views
Skip to first unread message

Benjamin Bannier

unread,
Jul 13, 2026, 1:42:43 PM (13 days ago) Jul 13
to spicy-...@zeek.org
Branch: refs/heads/topic/bbannier/atoi_n-cleanup
Home: https://github.com/zeek/spicy
Commit: 6486b46f02b6e8b01d96ba855dd4c605b64b91bf
https://github.com/zeek/spicy/commit/6486b46f02b6e8b01d96ba855dd4c605b64b91bf
Author: Benjamin Bannier <benjamin...@corelight.com>
Date: 2026-07-13 (Mon, 13 Jul 2026)

Changed paths:
M hilti/runtime/include/util.h

Log Message:
-----------
Use standard-compliant type for `std::string_view` iterator type

We previously assumed that `std::string_view` used `const char*` as
underlying iterator type, but this is not in the standard and in fact
msvc deviates. Use a generic iterator type instead.

This fixes a regression introduced in
7c0a1f12cd672dacd28573f974c59eb30b035f69.

fixup! Change `hilti::rt::atoi_n` to take a `string_view`



To unsubscribe from these emails, change your notification settings at https://github.com/zeek/spicy/settings/notifications

Benjamin Bannier

unread,
Jul 13, 2026, 3:45:55 PM (13 days ago) Jul 13
to spicy-...@zeek.org
Branch: refs/heads/main
Home: https://github.com/zeek/spicy
Commit: 6486b46f02b6e8b01d96ba855dd4c605b64b91bf
https://github.com/zeek/spicy/commit/6486b46f02b6e8b01d96ba855dd4c605b64b91bf
Author: Benjamin Bannier <benjamin...@corelight.com>
Date: 2026-07-13 (Mon, 13 Jul 2026)

Changed paths:
M hilti/runtime/include/util.h

Log Message:
-----------
Use standard-compliant type for `std::string_view` iterator type

We previously assumed that `std::string_view` used `const char*` as
underlying iterator type, but this is not in the standard and in fact
msvc deviates. Use a generic iterator type instead.

This fixes a regression introduced in
7c0a1f12cd672dacd28573f974c59eb30b035f69.

fixup! Change `hilti::rt::atoi_n` to take a `string_view`


Commit: 7c5e0337f5c4f0bc9341ea22d2a096b2e42dfdad
https://github.com/zeek/spicy/commit/7c5e0337f5c4f0bc9341ea22d2a096b2e42dfdad
Author: Benjamin Bannier <benjamin...@corelight.com>
Date: 2026-07-13 (Mon, 13 Jul 2026)

Changed paths:
M CHANGES
M VERSION
M hilti/runtime/include/util.h

Log Message:
-----------
Merge branch 'topic/bbannier/atoi_n-cleanup'


Compare: https://github.com/zeek/spicy/compare/07adbfc14813...7c5e0337f5c4
Reply all
Reply to author
Forward
0 new messages