[zeek/spicy] 73598e: Fix msvc warnings about unused parameters

0 views
Skip to first unread message

Benjamin Bannier

unread,
Jun 3, 2026, 6:19:39 AM (3 days ago) Jun 3
to spicy-...@zeek.org
Branch: refs/heads/topic/bbannier/msvc-warnings
Home: https://github.com/zeek/spicy
Commit: 73598eda67c5827837cd37481824b4db9eee6499
https://github.com/zeek/spicy/commit/73598eda67c5827837cd37481824b4db9eee6499
Author: Benjamin Bannier <benjamin...@corelight.com>
Date: 2026-06-03 (Wed, 03 Jun 2026)

Changed paths:
M .clang-tidy
M hilti/runtime/include/result.h
M hilti/runtime/include/types/any.h
M hilti/runtime/include/types/map.h
M hilti/runtime/include/types/null.h
M hilti/runtime/include/types/set.h
M hilti/runtime/src/benchmarks/fiber.cc
M hilti/runtime/src/fiber.cc
M hilti/runtime/src/safe-math.cc
M hilti/runtime/src/tests/fiber.cc
M hilti/runtime/src/tests/util.cc
M hilti/runtime/src/type-info.cc
M hilti/toolchain/include/ast/builder/builder.h
M hilti/toolchain/include/ast/declarations/export.h
M hilti/toolchain/include/ast/node.h
M hilti/toolchain/include/ast/operator.h
M hilti/toolchain/include/ast/type.h
M hilti/toolchain/include/ast/types/auto.h
M hilti/toolchain/include/ast/types/bitfield.h
M hilti/toolchain/include/ast/types/enum.h
M hilti/toolchain/include/ast/types/exception.h
M hilti/toolchain/include/ast/types/function.h
M hilti/toolchain/include/ast/types/integer.h
M hilti/toolchain/include/ast/types/list.h
M hilti/toolchain/include/ast/types/map.h
M hilti/toolchain/include/ast/types/member.h
M hilti/toolchain/include/ast/types/operand-list.h
M hilti/toolchain/include/ast/types/optional.h
M hilti/toolchain/include/ast/types/reference.h
M hilti/toolchain/include/ast/types/result.h
M hilti/toolchain/include/ast/types/set.h
M hilti/toolchain/include/ast/types/struct.h
M hilti/toolchain/include/ast/types/tuple.h
M hilti/toolchain/include/ast/types/type.h
M hilti/toolchain/include/ast/types/union.h
M hilti/toolchain/include/ast/types/vector.h
M hilti/toolchain/include/ast/visitor.h
M hilti/toolchain/include/base/id-base.h
M hilti/toolchain/include/compiler/detail/cxx/unit.h
M hilti/toolchain/include/compiler/detail/optimizer/pass.h
M hilti/toolchain/include/compiler/driver.h
M hilti/toolchain/src/ast/expressions/name.cc
M hilti/toolchain/src/ast/node.cc
M hilti/toolchain/src/ast/operator.cc
M hilti/toolchain/src/ast/operators/bitfield.cc
M hilti/toolchain/src/ast/operators/enum.cc
M hilti/toolchain/src/ast/operators/exception.cc
M hilti/toolchain/src/ast/operators/generic.cc
M hilti/toolchain/src/ast/operators/list.cc
M hilti/toolchain/src/ast/operators/map.cc
M hilti/toolchain/src/ast/operators/optional.cc
M hilti/toolchain/src/ast/operators/real.cc
M hilti/toolchain/src/ast/operators/reference.cc
M hilti/toolchain/src/ast/operators/result.cc
M hilti/toolchain/src/ast/operators/set.cc
M hilti/toolchain/src/ast/operators/signed-integer.cc
M hilti/toolchain/src/ast/operators/struct.cc
M hilti/toolchain/src/ast/operators/tuple.cc
M hilti/toolchain/src/ast/operators/union.cc
M hilti/toolchain/src/ast/operators/unsigned-integer.cc
M hilti/toolchain/src/ast/operators/vector.cc
M hilti/toolchain/src/ast/type.cc
M hilti/toolchain/src/compiler/cfg.cc
M hilti/toolchain/src/compiler/codegen/codegen.cc
M hilti/toolchain/src/compiler/codegen/coercions.cc
M hilti/toolchain/src/compiler/codegen/ctors.cc
M hilti/toolchain/src/compiler/codegen/expressions.cc
M hilti/toolchain/src/compiler/codegen/operators.cc
M hilti/toolchain/src/compiler/codegen/statements.cc
M hilti/toolchain/src/compiler/codegen/types.cc
M hilti/toolchain/src/compiler/codegen/unpack.cc
M hilti/toolchain/src/compiler/coercer.cc
M hilti/toolchain/src/compiler/constant-folder.cc
M hilti/toolchain/src/compiler/cxx/unit.cc
M hilti/toolchain/src/compiler/optimizer/passes/remove-unused-fields.cc
M hilti/toolchain/src/compiler/plugin.cc
M hilti/toolchain/src/compiler/printer.cc
M hilti/toolchain/src/compiler/resolver.cc
M hilti/toolchain/src/compiler/type-unifier.cc
M hilti/toolchain/src/compiler/unit.cc
M hilti/toolchain/tests/visitor.cc
M spicy/runtime/include/filter.h
M spicy/runtime/include/parsed-unit.h
M spicy/runtime/include/unit-context.h
M spicy/runtime/src/driver.cc
M spicy/toolchain/bin/spicy-driver.cc
M spicy/toolchain/include/ast/types/unit-items/property.h
M spicy/toolchain/include/ast/types/unit-items/unresolved-field.h
M spicy/toolchain/include/ast/types/unit.h
M spicy/toolchain/src/ast/operators/unit.cc
M spicy/toolchain/src/ast/types/unit-items/field.cc
M spicy/toolchain/src/compiler/codegen/grammar-builder.cc
M spicy/toolchain/src/compiler/codegen/parser-builder.cc
M spicy/toolchain/src/compiler/codegen/parsers/types.cc
M spicy/toolchain/src/compiler/driver.cc
M spicy/toolchain/src/compiler/plugin.cc
M spicy/toolchain/src/compiler/printer.cc
M spicy/toolchain/src/compiler/resolver.cc

Log Message:
-----------
Fix msvc warnings about unused parameters

Instead of fixing all instances where msvc warns about this, address
this globally by addressing everything clang-tidy's
`misc-unused-parameters` lint reports. That lint support automatic
updates with a fixit, so almost all changes here were done
automatically; the only manual tweaks were updating uses of the
constructor of `ProductionFactory` where clang-tidy correctly dropped a
parameter, but did not update all users, and a removal of a now unused
value around use of the resolver's `fieldType` method.



To unsubscribe from these emails, change your notification settings at https://github.com/zeek/spicy/settings/notifications
Reply all
Reply to author
Forward
0 new messages