[zeek/spicy] 1278f7: Address review feedback.

0 views
Skip to first unread message

Robin Sommer

unread,
Feb 19, 2026, 5:01:06 AMFeb 19
to spicy-...@zeek.org
Branch: refs/heads/topic/robin/remove-unused-fields
Home: https://github.com/zeek/spicy
Commit: 1278f72968131173cf6d13b241c78bb8f1e52620
https://github.com/zeek/spicy/commit/1278f72968131173cf6d13b241c78bb8f1e52620
Author: Robin Sommer <ro...@corelight.com>
Date: 2026-02-19 (Thu, 19 Feb 2026)

Changed paths:
M hilti/runtime/include/types/bitfield.h
M hilti/toolchain/include/ast/builder/builder.h
M hilti/toolchain/include/ast/builder/node-factory.h
M hilti/toolchain/include/ast/ctors/tuple.h
M hilti/toolchain/include/ast/declaration.h
M hilti/toolchain/include/ast/expressions/grouping.h
M hilti/toolchain/include/ast/node.h
M hilti/toolchain/include/compiler/detail/cfg.h
M hilti/toolchain/src/compiler/cfg.cc
M hilti/toolchain/src/compiler/optimizer/pass.cc
M hilti/toolchain/src/compiler/optimizer/passes/remove-unused-fields.cc
M spicy/toolchain/bin/spicy-dump/printer-json.cc
M spicy/toolchain/src/compiler/codegen/unit-builder.cc

Log Message:
-----------
Address review feedback.


Commit: d5889a145f383496aaa9973fc3bc461c96e5405b
https://github.com/zeek/spicy/commit/d5889a145f383496aaa9973fc3bc461c96e5405b
Author: Robin Sommer <ro...@corelight.com>
Date: 2026-02-19 (Thu, 19 Feb 2026)

Changed paths:
M hilti/toolchain/src/compiler/optimizer/passes/remove-unused-fields.cc
M tests/Baseline/hilti.optimization.unused-struct-fields/output

Log Message:
-----------
Fix bug with side-effect-having expressions in field optimizer pass.


Compare: https://github.com/zeek/spicy/compare/351c04e2a6de...d5889a145f38

To unsubscribe from these emails, change your notification settings at https://github.com/zeek/spicy/settings/notifications
Reply all
Reply to author
Forward
0 new messages