[zeek/spicy] d973af: Include coercions in detection of expressions with...

[Benjamin Bannier]

Branch: refs/heads/release/1.16
Home: https://github.com/zeek/spicy
Commit: d973af28c938a10972074f9cbcc8cdf337009b10
https://github.com/zeek/spicy/commit/d973af28c938a10972074f9cbcc8cdf337009b10
Author: Benjamin Bannier <benjamin...@corelight.com>
Date: 2026-06-17 (Wed, 17 Jun 2026)

Changed paths:
M hilti/toolchain/src/compiler/cfg.cc

Log Message:
-----------
Include coercions in detection of expressions with side effects

We previously would always consider expressions with coercions as having
side effects which in at least #2404 lead to us generating code which
caused a most vexing parse. Since coercions do not have side effects
themself, extend our detection to include them by querying the behavior
of the coerced expression. This should fix the majority of new failures
introduced by recent rewrites which removed the LHS of assignments; we
will do more structural fixes in follow-up patches.

Closes #2404.

(cherry picked from commit d9ecb209f2593b038c10ea6d8d05e4a96873d2e9)



To unsubscribe from these emails, change your notification settings at https://github.com/zeek/spicy/settings/notifications