[zeek/spicy] ee2bde: Add `--use-clang-tidy` flag to `configure`.

0 views
Skip to first unread message

Robin Sommer

unread,
Sep 2, 2025, 5:41:45 AM (7 days ago) Sep 2
to spicy-...@zeek.org
Branch: refs/heads/topic/robin/gh-2107-tidy-toolchain
Home: https://github.com/zeek/spicy
Commit: ee2bde19601ee332d867515e6a274f9609730ab8
https://github.com/zeek/spicy/commit/ee2bde19601ee332d867515e6a274f9609730ab8
Author: Robin Sommer <ro...@corelight.com>
Date: 2025-09-02 (Tue, 02 Sep 2025)

Changed paths:
M CMakeLists.txt
M configure

Log Message:
-----------
Add `--use-clang-tidy` flag to `configure`.


Commit: e1156a22bbfd70bbe4eba374045864f39260734b
https://github.com/zeek/spicy/commit/e1156a22bbfd70bbe4eba374045864f39260734b
Author: Robin Sommer <ro...@corelight.com>
Date: 2025-09-02 (Tue, 02 Sep 2025)

Changed paths:
M .clang-tidy

Log Message:
-----------
Enable clang-tidy's naming check.

Not sure why this was excluded: we want it for the toolchain, and it
doesn't seem to hurt for the rest.


Commit: aa303b1ba84750ed53e62d803f52f9efe7520f9c
https://github.com/zeek/spicy/commit/aa303b1ba84750ed53e62d803f52f9efe7520f9c
Author: Robin Sommer <ro...@corelight.com>
Date: 2025-09-02 (Tue, 02 Sep 2025)

Changed paths:
M .clang-tidy
M .clang-tidy.toolchain
M hilti/runtime/include/extension-points.h
M hilti/runtime/include/result.h
M hilti/runtime/include/safe-int.h
M hilti/runtime/include/types/bytes.h
M hilti/toolchain/include/ast/builder/node-factory.h
M hilti/toolchain/include/ast/node.h
M hilti/toolchain/include/ast/types/operand-list.h
M hilti/toolchain/include/base/code-formatter.h
M hilti/toolchain/include/base/graph.h
M hilti/toolchain/include/base/util.h
M hilti/toolchain/include/compiler/detail/cfg.h
M hilti/toolchain/include/compiler/jit.h
M hilti/toolchain/src/ast/ast-context.cc
M hilti/toolchain/src/ast/node.cc
M hilti/toolchain/src/ast/operator.cc
M hilti/toolchain/src/ast/operators/bitfield.cc
M hilti/toolchain/src/ast/operators/struct.cc
M hilti/toolchain/src/base/util.cc
M hilti/toolchain/src/compiler/cfg.cc
M hilti/toolchain/src/compiler/codegen/statements.cc
M hilti/toolchain/src/compiler/coercer.cc
M hilti/toolchain/src/compiler/cxx/elements.cc
M hilti/toolchain/src/compiler/cxx/unit.cc
M hilti/toolchain/src/compiler/jit.cc
M hilti/toolchain/src/compiler/optimizer.cc
M hilti/toolchain/src/compiler/validator.cc
M hilti/toolchain/src/config.cc.in
M hilti/toolchain/tests/util.cc
M spicy/toolchain/include/ast/types/unit-items/block.h
M spicy/toolchain/src/compiler/codegen/parser-builder.cc
M spicy/toolchain/src/compiler/codegen/productions/look-ahead.cc
M spicy/toolchain/src/compiler/codegen/unit-builder.cc
M spicy/toolchain/src/compiler/validator.cc
M spicy/toolchain/src/config.cc.in
M spicy/toolchain/tests/grammar.cc

Log Message:
-----------
Enforce naming conventions across toolchain using clang-tidy.

This comes with one style clarification: for static, file-local
functions we had an inconsistent mix of prefixing their names with an
underscores vs not. The original intent was to have that prefix, but I
don't see a way to enforce it through clang-tidy, and it's hard to
find all those instances not having the prefix otherwise. So switching
over to not using an underscore prefix.


Compare: https://github.com/zeek/spicy/compare/78cc8fb31a5c...aa303b1ba847

To unsubscribe from these emails, change your notification settings at https://github.com/zeek/spicy/settings/notifications
Reply all
Reply to author
Forward
0 new messages