[zeek/spicy] 305229: Remove capture group in `spicy.types.unit.synchron...

0 views
Skip to first unread message

Benjamin Bannier

unread,
Jul 23, 2026, 6:12:26 PM (3 days ago) Jul 23
to spicy-...@zeek.org
Branch: refs/heads/topic/bbannier/issue/2438
Home: https://github.com/zeek/spicy
Commit: 3052291919e3e9efd8222501b9f4d28fe208ffd4
https://github.com/zeek/spicy/commit/3052291919e3e9efd8222501b9f4d28fe208ffd4
Author: Benjamin Bannier <benjamin...@corelight.com>
Date: 2026-07-24 (Fri, 24 Jul 2026)

Changed paths:
M tests/Baseline/spicy.types.unit.synchronize-on-gap/gap_between_matches.log
M tests/spicy/types/unit/synchronize-on-gap.spicy

Log Message:
-----------
Remove capture group in `spicy.types.unit.synchronize-on-gap` test

The test was using a capture group when all it cared about was an
alternation.


Commit: 936093e16d8e5baccf1d578315291ed77007d8d8
https://github.com/zeek/spicy/commit/936093e16d8e5baccf1d578315291ed77007d8d8
Author: Benjamin Bannier <benjamin...@corelight.com>
Date: 2026-07-24 (Fri, 24 Jul 2026)

Changed paths:
M spicy/toolchain/src/compiler/codegen/parsers/literals.cc
A tests/Baseline/spicy.types.unit.switch-lahead-regexp-captures/output
A tests/spicy/types/unit/switch-lahead-regexp-captures.spicy

Log Message:
-----------
Fix parsing of regexps with capture groups in lookahead

The lookahead fast path consumed the look-ahead token and skipped the
regex loop, so capture groups were never populated. For regexp fields
that have captures, we now skip the fast path and let the regex loop run
instead so captures are filled normally.

Fixes #2438.


Compare: https://github.com/zeek/spicy/compare/e726e96adff8...936093e16d8e

To unsubscribe from these emails, change your notification settings at https://github.com/zeek/spicy/settings/notifications
Reply all
Reply to author
Forward
0 new messages