[zeek/spicy] b1fa64: Fix regression causing removal of used fields

0 views
Skip to first unread message

Benjamin Bannier

unread,
Jun 30, 2026, 6:00:02 AM (4 days ago) Jun 30
to spicy-...@zeek.org
Branch: refs/heads/topic/bbannier/fix-removal-of-used-field
Home: https://github.com/zeek/spicy
Commit: b1fa64037c70df2b0b05cf36a836d244947ce311
https://github.com/zeek/spicy/commit/b1fa64037c70df2b0b05cf36a836d244947ce311
Author: Benjamin Bannier <benjamin...@corelight.com>
Date: 2026-06-30 (Tue, 30 Jun 2026)

Changed paths:
M hilti/toolchain/src/compiler/optimizer/passes/remove-unused-fields.cc

Log Message:
-----------
Fix regression causing removal of used fields

In 09c092a9733 from #2336 we changed how a number of optimizer passes
reference functions. A cleanup there caused a regression in the
`RemoveUnusedFields` pass so that we now remove fields even though they
are used. This leads to compilation failures, e.g., in Zeek's builtin
PostgreSQL parser.

Since that pass works on fields instead of general functions this patch
simply reverts the cleanup in that pass.



To unsubscribe from these emails, change your notification settings at https://github.com/zeek/spicy/settings/notifications

Benjamin Bannier

unread,
Jun 30, 2026, 12:20:33 PM (4 days ago) Jun 30
to spicy-...@zeek.org
Branch: refs/heads/main
Home: https://github.com/zeek/spicy
Commit: b1fa64037c70df2b0b05cf36a836d244947ce311
https://github.com/zeek/spicy/commit/b1fa64037c70df2b0b05cf36a836d244947ce311
Author: Benjamin Bannier <benjamin...@corelight.com>
Date: 2026-06-30 (Tue, 30 Jun 2026)

Changed paths:
M hilti/toolchain/src/compiler/optimizer/passes/remove-unused-fields.cc

Log Message:
-----------
Fix regression causing removal of used fields

In 09c092a9733 from #2336 we changed how a number of optimizer passes
reference functions. A cleanup there caused a regression in the
`RemoveUnusedFields` pass so that we now remove fields even though they
are used. This leads to compilation failures, e.g., in Zeek's builtin
PostgreSQL parser.

Since that pass works on fields instead of general functions this patch
simply reverts the cleanup in that pass.


Commit: 22533c4c0f604fcced893436c853bbbd80b6be28
https://github.com/zeek/spicy/commit/22533c4c0f604fcced893436c853bbbd80b6be28
Author: Benjamin Bannier <benjamin...@corelight.com>
Date: 2026-06-30 (Tue, 30 Jun 2026)

Changed paths:
M CHANGES
M VERSION
M hilti/toolchain/src/compiler/optimizer/passes/remove-unused-fields.cc

Log Message:
-----------
Merge branch 'topic/bbannier/fix-removal-of-used-field'


Compare: https://github.com/zeek/spicy/compare/d99aa5248bc1...22533c4c0f60
Reply all
Reply to author
Forward
0 new messages