Issue 538 in webp: CMake Error at cmake/cpu.cmake:80 (if)

[wlzq… via monorail]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 538 by wlzq...@gmail.com: CMake Error at cmake/cpu.cmake:80 (if)
https://bugs.chromium.org/p/webp/issues/detail?id=538

What steps will reproduce the problem?
1. use cmake 3.5.
2. execute ..\cmake-3.5.1-win32-x86\bin\cmake.exe -G Ninja ..\libwebp-1.2.1\

What is the expected output? What do you see instead?

expect:
CMake should generate the build file without problem.

got:
CMake Error at CMakeLists.txt:3 (if):
if given arguments:

"EMSCRIPTEN" "AND" "0" "GREATER_EQUAL" "2"

Unknown arguments specified


What version of the product are you using? On what operating system?
libwebp 1.2.1, cmake 3.5.1, Windows 10

Please provide any additional information below.

It seems that GREATER_EQUAL was added in CMake 3.7.

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

[wlzq… via monorail]

Comment #1 on issue 538 by wlzq...@gmail.com: CMake Error at cmake/cpu.cmake:80 (if)
https://bugs.chromium.org/p/webp/issues/detail?id=538#c1

Sorry, the cmake output is:

CMake Error at cmake/cpu.cmake:80 (if):

if given arguments:

"EMSCRIPTEN" "AND" "0" "GREATER_EQUAL" "2"

Unknown arguments specified

Call Stack (most recent call first):
cmake/deps.cmake:148 (include)
CMakeLists.txt:75 (include)

[jz… via monorail]

Updates:
Status: Accepted

Comment #2 on issue 538 by jz...@google.com: CMake Error at cmake/cpu.cmake:80 (if)
https://bugs.chromium.org/p/webp/issues/detail?id=538#c2

Thanks for the report. I'm somewhat inclined to increase the minimum version requirement. Do you need to rely on 3.5.1 for any particular reason?

[wlzq… via monorail]

Comment #3 on issue 538 by wlzq...@gmail.com: CMake Error at cmake/cpu.cmake:80 (if)
https://bugs.chromium.org/p/webp/issues/detail?id=538#c3

No, I used to use Ubuntu 16.04 LTS, which provides CMake 3.5.1 only. This is why I found this issue. I have upgraded to 18.04 LTS recently.

[jz… via monorail]

Updates:
Owner: jz...@google.com
Status: Started

Comment #4 on issue 538 by jz...@google.com: CMake Error at cmake/cpu.cmake:80 (if)
https://bugs.chromium.org/p/webp/issues/detail?id=538#c4

Thanks for the background. 16.04 is at the end of standard support, but not end of life. Still with newer LTS versions available and no build coverage for this platform I think it may be simpler to move the cmake check forward.

[Git Watcher via monorail]

Comment #5 on issue 538 by Git Watcher: CMake Error at cmake/cpu.cmake:80 (if)
https://bugs.chromium.org/p/webp/issues/detail?id=538#c5

The following revision refers to this bug:
https://chromium.googlesource.com/webm/libwebp/+/3875c7de07099a1c6584b9dc9647db618d469deb

commit 3875c7de07099a1c6584b9dc9647db618d469deb
Author: James Zern <jz...@google.com>
Date: Tue Aug 31 20:21:46 2021

CMakeLists.txt: set minimum version to 3.7

cmake/cpu.cmake (at least) requires 3.7 due to its use of GREATER_EQUAL:
https://cmake.org/cmake/help/latest/release/3.7.html

Bug: webp:538
Change-Id: I63511226a593218e1f4d3b1a7c4c998de3ba2ae1

[modify] https://crrev.com/3875c7de07099a1c6584b9dc9647db618d469deb/CMakeLists.txt

[jz… via monorail]

Updates:
Labels: v1.2.2
Status: Fixed

Comment #6 on issue 538 by jz...@google.com: CMake Error at cmake/cpu.cmake:80 (if)
https://bugs.chromium.org/p/webp/issues/detail?id=538#c6

(No comment was entered for this change.)