Issue 14 in webp2: CMAKE_CXX_STANDARD 11 -> 14

[matej… via monorail]

Status: Accepted
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 14 by matej...@gmail.com: CMAKE_CXX_STANDARD 11 -> 14
https://bugs.chromium.org/p/webp2/issues/detail?id=14

What steps will reproduce the problem?
1. build

What is the expected output?
build successfully

What do you see instead?
/usr/include/gtest/internal/gtest-port.h:270:2: error: #error C++ versions less than C++14 are not supported.
270 | #error C++ versions less than C++14 are not supported.


Please use labels and text to provide additional information.
change this line
https://chromium.googlesource.com/codecs/libwebp2/+/refs/heads/main/CMakeLists.txt#23

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

[ygu… via monorail]

Comment #1 on issue 14 by ygu...@google.com: CMAKE_CXX_STANDARD 11 -> 14
https://bugs.chromium.org/p/webp2/issues/detail?id=14#c1

Thank you for the report.
This is due to the dependency GoogleTest not supporting C++11 any more.
One can use an older release such as 1.12.1 to target C++11:
https://github.com/google/googletest/releases/tag/release-1.12.1
Or one can disable tests altogether with
cmake -DWP2_BUILD_TESTS=OFF

That said, we may consider migrating the whole libwebp2 repository to C++14 when we have the time.

[ingri… via monorail]

Comment #2 on issue 14 by ingri...@gmail.com: CMAKE_CXX_STANDARD 11 -> 14
https://bugs.chromium.org/p/webp2/issues/detail?id=14#c2

(No comment was entered for this change.)

Attachments:
Uploads from Ingrida Kalokova (1).csv 10.1 KB

[Git Watcher via monorail]

Comment #3 on issue 14 by Git Watcher: CMAKE_CXX_STANDARD 11 -> 14
https://bugs.chromium.org/p/webp2/issues/detail?id=14#c3

The following revision refers to this bug:
https://chromium.googlesource.com/codecs/libwebp2/+/92822802cd1ce2f8028cd12ae3caed5826c96982

commit 92822802cd1ce2f8028cd12ae3caed5826c96982
Author: Yannis Guyon <ygu...@google.com>
Date: Fri Apr 21 08:41:23 2023

Migrate libwebp2 from C++11 to C++14

GoogleTest requires C++14 starting at version 1.13.
See https://bugs.chromium.org/p/webp2/issues/detail?id=14

BUG=webp2:14

Change-Id: Ie9a93c51c119eb8b59449314ab410545facee852
Reviewed-on: https://chromium-review.googlesource.com/c/codecs/libwebp2/+/4454320
Tested-by: WebM Builds <bui...@webmproject.org>
Reviewed-by: Pascal Massimino <sk...@google.com>

[modify] https://crrev.com/92822802cd1ce2f8028cd12ae3caed5826c96982/doc/container/CMakeLists.txt
[modify] https://crrev.com/92822802cd1ce2f8028cd12ae3caed5826c96982/Makefile
[modify] https://crrev.com/92822802cd1ce2f8028cd12ae3caed5826c96982/presubmit/build_and_test.sh
[modify] https://crrev.com/92822802cd1ce2f8028cd12ae3caed5826c96982/CMakeLists.txt

[ygu… via monorail]

Updates:
Status: Fixed

Comment #4 on issue 14 by ygu...@google.com: CMAKE_CXX_STANDARD 11 -> 14
https://bugs.chromium.org/p/webp2/issues/detail?id=14#c4

(No comment was entered for this change.)