Issue 590 in webp: libwebp 1.3.0

[jz… via monorail]

Status: Accepted
Owner: jz...@google.com
Labels: Maintainability Type-Task Priority-Medium

New issue 590 by jz...@google.com: libwebp 1.3.0
https://bugs.chromium.org/p/webp/issues/detail?id=590

This will be the first release that adds libsharpyuv with libwebp taking a dependency on the new lib.

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

[Git Watcher via monorail]

Updates:
Labels: merge-merged-1.3.0

Comment #1 on issue 590 by Git Watcher: libwebp 1.3.0
https://bugs.chromium.org/p/webp/issues/detail?id=590#c1

The following revision refers to this bug:
https://chromium.googlesource.com/webm/libwebp/+/0ba772442e1f7a2b6592138a001652a67e7f9e6a

commit 0ba772442e1f7a2b6592138a001652a67e7f9e6a
Author: James Zern <jz...@google.com>
Date: Fri Dec 16 23:48:05 2022

update NEWS

Bug: webp:590
Change-Id: I877bda2d177bd371cd2a43974200c66cf5fa8a10

[modify] https://crrev.com/0ba772442e1f7a2b6592138a001652a67e7f9e6a/NEWS

[Git Watcher via monorail]

Comment #2 on issue 590 by Git Watcher: libwebp 1.3.0
https://bugs.chromium.org/p/webp/issues/detail?id=590#c2

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libwebp/+/e763eb1ea3ca2bdcf2d6fe01a08a301b6c0030f0

commit e763eb1ea3ca2bdcf2d6fe01a08a301b6c0030f0
Author: James Zern <jz...@google.com>
Date: Fri Dec 16 23:26:41 2022

bump version to 1.3.0

libwebp{,decoder} - 1.3.0
libwebp libtool - 8.6.1
libwebpdecoder libtool - 4.6.1

mux - 1.3.0
libtool - 3.11.0

demux - 1.3.0
libtool - 2.12.0

sharpyuv - 0.2.0 (unchanged, first release)
libtool - 0.0.0 (ditto)

Bug: webp:590
Change-Id: Ibf3ed56af87667c30650d8dd60eb0ff3bdcb6749

[modify] https://crrev.com/e763eb1ea3ca2bdcf2d6fe01a08a301b6c0030f0/src/demux/Makefile.am
[modify] https://crrev.com/e763eb1ea3ca2bdcf2d6fe01a08a301b6c0030f0/configure.ac
[modify] https://crrev.com/e763eb1ea3ca2bdcf2d6fe01a08a301b6c0030f0/extras/extras.c
[modify] https://crrev.com/e763eb1ea3ca2bdcf2d6fe01a08a301b6c0030f0/src/mux/Makefile.am
[modify] https://crrev.com/e763eb1ea3ca2bdcf2d6fe01a08a301b6c0030f0/src/dec/vp8i_dec.h
[modify] https://crrev.com/e763eb1ea3ca2bdcf2d6fe01a08a301b6c0030f0/src/mux/libwebpmux.rc
[modify] https://crrev.com/e763eb1ea3ca2bdcf2d6fe01a08a301b6c0030f0/src/libwebp.rc
[modify] https://crrev.com/e763eb1ea3ca2bdcf2d6fe01a08a301b6c0030f0/src/mux/muxi.h
[modify] https://crrev.com/e763eb1ea3ca2bdcf2d6fe01a08a301b6c0030f0/README.md
[modify] https://crrev.com/e763eb1ea3ca2bdcf2d6fe01a08a301b6c0030f0/src/demux/demux.c
[modify] https://crrev.com/e763eb1ea3ca2bdcf2d6fe01a08a301b6c0030f0/src/Makefile.am
[modify] https://crrev.com/e763eb1ea3ca2bdcf2d6fe01a08a301b6c0030f0/src/enc/vp8i_enc.h
[modify] https://crrev.com/e763eb1ea3ca2bdcf2d6fe01a08a301b6c0030f0/src/libwebpdecoder.rc
[modify] https://crrev.com/e763eb1ea3ca2bdcf2d6fe01a08a301b6c0030f0/src/demux/libwebpdemux.rc

[Git Watcher via monorail]

Comment #3 on issue 590 by Git Watcher: libwebp 1.3.0
https://bugs.chromium.org/p/webp/issues/detail?id=590#c3

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libwebp/+/2a8686fcab773920173eeff73a30faa6555fc0a5

commit 2a8686fcab773920173eeff73a30faa6555fc0a5
Author: James Zern <jz...@google.com>
Date: Fri Dec 16 23:05:27 2022

update AUTHORS

Bug: webp:590
Change-Id: I5f18987cd56f5efd47fe901b097669346c698446

[modify] https://crrev.com/2a8686fcab773920173eeff73a30faa6555fc0a5/AUTHORS

[Git Watcher via monorail]

Comment #4 on issue 590 by Git Watcher: libwebp 1.3.0
https://bugs.chromium.org/p/webp/issues/detail?id=590#c4

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libwebp/+/bdf33d03b0b2a6c707583e33d0bd7a98495f4928

commit bdf33d03b0b2a6c707583e33d0bd7a98495f4928
Author: James Zern <jz...@google.com>
Date: Fri Jan 13 01:58:11 2023

Merge tag 'v1.3.0'

libwebp-1.3.0

- 12/16/2022: version 1.3.0
This is a binary compatible release.
* add libsharpyuv, which exposes -sharp_yuv/config.use_sharp_yuv
functionality to other libraries; libwebp now depends on this library
* major updates to the container and lossless bitstream docs (#448, #546,
#551)
* miscellaneous warning, bug & build fixes (#576, #583, #584)

* tag 'v1.3.0':
update ChangeLog
update NEWS
bump version to 1.3.0

update AUTHORS

Bug: webp:590

Bug: b/262806895
Change-Id: I4bc5cfb0708fab3569dc567d22bfdbcb5ff2a1ad

[kmi… via monorail]

Comment #5 on issue 590 by kmi...@gmail.com: libwebp 1.3.0
https://bugs.chromium.org/p/webp/issues/detail?id=590#c5

src/libwebp.pc.in should more formally list libsharpyuv as "Requires.private" rather than "Requires"?

For dynamic linking the dependency is transitive (already linked to libwebp which does not expose any libsharpyuv symbols), and "Requires.private" handles the static linking case just the same as "Libs.private".

[Git Watcher via monorail]

Comment #6 on issue 590 by Git Watcher: libwebp 1.3.0
https://bugs.chromium.org/p/webp/issues/detail?id=590#c6

The following revision refers to this bug:

https://skia.googlesource.com/skia/+/143da5a0b35daef3199b562d122b2db6ef9eedae

commit 143da5a0b35daef3199b562d122b2db6ef9eedae
Author: James Zern <jz...@google.com>
Date: Fri Jan 13 02:32:55 2023

update libwebp to 1.3.0

https://chromium.googlesource.com/webm/libwebp/+log/v1.2.3..v1.3.0

- 12/16/2022: version 1.3.0
This is a binary compatible release.
* add libsharpyuv, which exposes -sharp_yuv/config.use_sharp_yuv
functionality to other libraries; libwebp now depends on this library
* major updates to the container and lossless bitstream docs (#448, #546,
#551)
* miscellaneous warning, bug & build fixes (#576, #583, #584)

Bug: b:262806895
Bug: webp:590
Change-Id: I819050d1e7a0e52f76f6705ebb5d5421669b95a5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/625732
Reviewed-by: Leon Scroggins <scr...@google.com>
Commit-Queue: Leon Scroggins <scr...@google.com>

[modify] https://crrev.com/143da5a0b35daef3199b562d122b2db6ef9eedae/bazel/external/libwebp/BUILD.bazel
[modify] https://crrev.com/143da5a0b35daef3199b562d122b2db6ef9eedae/bazel/deps.bzl
[modify] https://crrev.com/143da5a0b35daef3199b562d122b2db6ef9eedae/DEPS
[modify] https://crrev.com/143da5a0b35daef3199b562d122b2db6ef9eedae/third_party/libwebp/BUILD.gn

[Git Watcher via monorail]

Comment #7 on issue 590 by Git Watcher: libwebp 1.3.0
https://bugs.chromium.org/p/webp/issues/detail?id=590#c7

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/699b05f8e8c0da3464d65a14a19ec9c61c628ccc

commit 699b05f8e8c0da3464d65a14a19ec9c61c628ccc
Author: James Zern <jz...@chromium.org>
Date: Wed Jan 18 00:53:58 2023

Roll src/third_party/libwebp/src/ 7366f7f39..603e8d7ad (113 commits)

https://chromium.googlesource.com/webm/libwebp.git/+log/7366f7f394af..603e8d7adb0c

$ git log 7366f7f39..603e8d7ad --date=short --no-merges --format='%ad %ae %s'
2022-12-19 jzern update ChangeLog
2022-12-16 jzern update NEWS
2022-12-16 jzern bump version to 1.3.0
2022-12-16 jzern update AUTHORS
2022-12-15 jzern */Android.mk: add a check for NDK_ROOT
2022-12-15 jzern doc/api.md,webp_js/README.md: Webp -> WebP
2022-12-15 jzern extras: WebpToSDL -> WebPToSDL
2022-12-15 jzern xcframeworkbuild.sh: bump MACOSX_CATALYST_MIN_VERSION
2022-12-14 jzern CMake: align .pc variables with autoconf
2022-11-22 jzern webp-lossless-bitstream-spec,cosmetics: reflow paragraphs
(...)
2022-08-01 jzern webp-container-spec.txt: update 'key words' text
2022-07-29 jzern utils.h,WEBP_ALIGN: make bitmask unsigned
2022-07-30 jzern add WebPInt32ToMem
2022-07-28 jzern add WebPMemToInt32
2022-07-27 maryla Build libsharpyuv as a full installable library.
2022-07-25 jzern CMake: set rpath for shared objects
2022-07-25 vrabaud Fix the lossless specs a bit more.
2022-07-22 jzern CMake: fix dylib versioning
2022-07-21 jzern CMakeLists.txt: correct libwebpmux name in WebPConfig.cmake
2022-07-21 jzern Revert "cmake: fix webpmux lib name for cmake linking"

Created with:
roll-dep src/third_party/libwebp/src

Bug: 1366372
Bug: 1403132
Bug: b/262806895
Bug: webp:590
Change-Id: I05b35d5d10278c612c5ae7a3bed08cbc900e3b3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4122988
Commit-Queue: James Zern <jz...@google.com>
Reviewed-by: Leon Scroggins <scr...@google.com>
Cr-Commit-Position: refs/heads/main@{#1093653}

[modify] https://crrev.com/699b05f8e8c0da3464d65a14a19ec9c61c628ccc/third_party/libwebp/README.chromium
[modify] https://crrev.com/699b05f8e8c0da3464d65a14a19ec9c61c628ccc/DEPS
[modify] https://crrev.com/699b05f8e8c0da3464d65a14a19ec9c61c628ccc/third_party/libwebp/BUILD.gn

[jz… via monorail]

Comment #8 on issue 590 by jz...@google.com: libwebp 1.3.0
https://bugs.chromium.org/p/webp/issues/detail?id=590#c8

> src/libwebp.pc.in should more formally list libsharpyuv as "Requires.private"
> rather than "Requires"?
>
> For dynamic linking the dependency is transitive (already linked to libwebp
> which does not expose any libsharpyuv symbols), and "Requires.private"
> handles the static linking case just the same as "Libs.private".

Thanks. Yes, I think you're correct.

[jz… via monorail]

Updates:
Status: Done

Comment #9 on issue 590 by jz...@google.com: libwebp 1.3.0
https://bugs.chromium.org/p/webp/issues/detail?id=590#c9

(No comment was entered for this change.)

[jz… via monorail]

Comment #10 on issue 590 by jz...@google.com: libwebp 1.3.0
https://bugs.chromium.org/p/webp/issues/detail?id=590#c10

Comment #5 is addressed in:
https://chromium-review.googlesource.com/c/webm/libwebp/+/4174742