Issue 11 in webp2: Shared library

[rcar… via monorail]

Status: Accepted
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 11 by rcar...@gmail.com: Shared library
https://bugs.chromium.org/p/webp2/issues/detail?id=11

What steps will reproduce the problem?
1. diff --git a/CMakeLists.txt b/CMakeLists.txt
index e70ae31..d8e2bc4 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -38,6 +38,7 @@ if(NOT EMSCRIPTEN)
# Users can still explicitly opt-in to make a SIMD-enabled build.
set(WP2_ENABLE_SIMD_DEFAULT ON)
endif()
+option(BUILD_SHARED_LIBS "Build shared instead of static libraries." OFF)
option(WP2_ENABLE_SIMD "Enable any SIMD optimization."
${WP2_ENABLE_SIMD_DEFAULT})
set(WP2_ENABLE_CONTEXT_SWITCH
@@ -77,6 +78,10 @@ set(WP2_DEP_LIBRARIES)
set(WP2_DEP_INCLUDE_DIRS)
set(WP2_DEFINITIONS)

+if(BUILD_SHARED_LIBS)
+ set(CMAKE_POSITION_INDEPENDENT_CODE ON)
+endif()
+
if(NOT CMAKE_BUILD_TYPE)
set(CMAKE_BUILD_TYPE
"Release"
2.
3.

What is the expected output?


What do you see instead?


Please use labels and text to provide additional information.

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

[vrab… via monorail]

Comment #1 on issue 11 by vra...@google.com: Shared library
https://bugs.chromium.org/p/webp2/issues/detail?id=11#c1

No need for setting an option. I am proposing https://chromium-review.googlesource.com/c/codecs/libwebp2/+/3738288

[Git Watcher via monorail]

Comment #2 on issue 11 by Git Watcher: Shared library
https://bugs.chromium.org/p/webp2/issues/detail?id=11#c2

The following revision refers to this bug:
https://chromium.googlesource.com/codecs/libwebp2/+/7df349959d0c5b6d57dac3869e3b464b93739f45

commit 7df349959d0c5b6d57dac3869e3b464b93739f45
Author: Vincent Rabaud <vra...@google.com>
Date: Mon Jul 04 10:54:12 2022

Enable PIC for shared libs.

BUG=webp2:11
Change-Id: I338dc08738c7f3b8af35e09418a9d39d3c2ea1b0
Reviewed-on: https://chromium-review.googlesource.com/c/codecs/libwebp2/+/3738288
Tested-by: WebM Builds <bui...@webmproject.org>
Reviewed-by: James Zern <jz...@google.com>

[modify] https://crrev.com/7df349959d0c5b6d57dac3869e3b464b93739f45/CMakeLists.txt

[vrab… via monorail]

Updates:
Status: Fixed

Comment #3 on issue 11 by vra...@google.com: Shared library
https://bugs.chromium.org/p/webp2/issues/detail?id=11#c3

(No comment was entered for this change.)