Issue 575 in webp: CMake: Breaking change of libwebpmux imported target name in 1.2.3

[ant.c… via monorail]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 575 by ant.c...@gmail.com: CMake: Breaking change of libwebpmux imported target name in 1.2.3
https://bugs.chromium.org/p/webp/issues/detail?id=575

Before 1.2.3, imported target name of webpmux library in CMake config file was WebP::libwebpmux.
A commit (https://chromium.googlesource.com/webm/libwebp/+/13b8281609113c4904877e637d4e8a775d8150bc) included in 1.2.3 changed this name to WebP::webpmux, which could break downstream projects relying on this target name.

While WebP::libwebpmux was not super consistent with other imported target names (no lib prefix for other targets), it's not a very good idea to change this name in a patch release.

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

[ant.c… via monorail]

Comment #1 on issue 575 by ant.c...@gmail.com: CMake: Breaking change of libwebpmux imported target name in 1.2.3
https://bugs.chromium.org/p/webp/issues/detail?id=575#c1

I think also that this change was made for the wrong reason, I have to say I don't understand the message in https://chromium.googlesource.com/webm/libwebp/+/13b8281609113c4904877e637d4e8a775d8150bc, it looks more like a misusage of CMake config file in libgd (or a patch of openwrt in libgd package) leading to their issue in generated libgd pkg-config file.

[jz… via monorail]

Updates:
Owner: vra...@google.com
Status: Accepted

Comment #2 on issue 575 by jz...@google.com: CMake: Breaking change of libwebpmux imported target name in 1.2.3
https://bugs.chromium.org/p/webp/issues/detail?id=575#c2

Thanks for the report. You're right, changing target names isn't good for compatibility. I lost track of this change as we tend to treat autoconf/configure as the canonical build system.

[jz… via monorail]

Comment #3 on issue 575 by jz...@google.com: CMake: Breaking change of libwebpmux imported target name in 1.2.3
https://bugs.chromium.org/p/webp/issues/detail?id=575#c3

An option here will be to revert this change in the 1.2.3 branch and make a quick 1.2.4 release based on that.

[Git Watcher via monorail]

Comment #5 on issue 575 by Git Watcher: CMake: Breaking change of libwebpmux imported target name in 1.2.3
https://bugs.chromium.org/p/webp/issues/detail?id=575#c5

The following revision refers to this bug:
https://chromium.googlesource.com/webm/libwebp/+/c2e3fd30c41528a1113e455964d6d1287335157b

commit c2e3fd30c41528a1113e455964d6d1287335157b
Author: James Zern <jz...@google.com>
Date: Fri Jul 22 00:57:23 2022

Revert "cmake: fix webpmux lib name for cmake linking"

This reverts commit 13b8281609113c4904877e637d4e8a775d8150bc.

This breaks target name compatibility with earlier releases.

Conflicts:
CMakeLists.txt

Bug: webp:575
Change-Id: I3d4895b8a8d14b3f4595ec19646ec4a1001c7748

[modify] https://crrev.com/c2e3fd30c41528a1113e455964d6d1287335157b/CMakeLists.txt

[Git Watcher via monorail]

Updates:
Labels: merge-merged-1.2.3

Comment #4 on issue 575 by Git Watcher: CMake: Breaking change of libwebpmux imported target name in 1.2.3
https://bugs.chromium.org/p/webp/issues/detail?id=575#c4

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libwebp/+/bfad7ab589a997a69ba568a7c5d9696474f917fc

commit bfad7ab589a997a69ba568a7c5d9696474f917fc
Author: James Zern <jz...@google.com>
Date: Fri Jul 22 01:27:50 2022

CMakeLists.txt: correct libwebpmux name in WebPConfig.cmake

this fixes link errors when using ${WEBP_LIBRARIES} from
WebPConfig.cmake:
/usr/bin/ld: cannot find -llibwebpmux: No such file or directory
/usr/bin/ld: note to link with /tmp/install/lib/libwebpmux.a use
-l:libwebpmux.a or rename it to liblibwebpmux.a

previously mentioned in https://github.com/openwrt/packages/pull/16784

Bug: webp:575
Change-Id: I38b45cb102ef1086ed992178cd736f45acf10d35

[modify] https://crrev.com/bfad7ab589a997a69ba568a7c5d9696474f917fc/CMakeLists.txt

[jz… via monorail]

Updates:
Status: Fixed

Comment #7 on issue 575 by jz...@google.com: CMake: Breaking change of libwebpmux imported target name in 1.2.3
https://bugs.chromium.org/p/webp/issues/detail?id=575#c7

(No comment was entered for this change.)