Issue 1544 in webm: Enable CONFIG_VP9_HIGHBITDEPTH on arm

[emir… via monorail]

Status: Unconfirmed
Owner: ----

New issue 1544 by emir...@chromium.org: Enable CONFIG_VP9_HIGHBITDEPTH on arm
https://bugs.chromium.org/p/webm/issues/detail?id=1544

This feature, necessary for VP9 Profile 2 encode, is enabled on desktop but not on arm by default. Can we look at the possiblity of enabling it on arm as well?
https://cs.chromium.org/chromium/src/third_party/libvpx/generate_gni.sh?l=344

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

[ji… via monorail]

Updates:
Cc: johannko...@google.com mar...@google.com jz...@google.com
Components: libvpx
Labels: Type-Enhancement OS-Android Pri-2
Owner: ji...@google.com
Status: Assigned

Comment #1 on issue 1544 by ji...@google.com: Enable CONFIG_VP9_HIGHBITDEPTH on arm
https://bugs.chromium.org/p/webm/issues/detail?id=1544#c1

(No comment was entered for this change.)

[johannko… via monorail]

Comment #2 on issue 1544 by johannko...@google.com: Enable CONFIG_VP9_HIGHBITDEPTH on arm
https://bugs.chromium.org/p/webm/issues/detail?id=1544#c2

There was previously concerns about vp9 encoder speed in that configuration. If encode speed looks reasonable, I have no objection to this change (and it should be as simple as adding $HIGHBD to $all_platforms).

[ji… via monorail]

Comment #3 on issue 1544 by ji...@google.com: Enable CONFIG_VP9_HIGHBITDEPTH on arm
https://bugs.chromium.org/p/webm/issues/detail?id=1544#c3

I'll run some tests to evaluate the HBD vp9 encoder speed on ARM and update with results.

[ji… via monorail]

Comment #4 on issue 1544 by ji...@google.com: Enable CONFIG_VP9_HIGHBITDEPTH on arm
https://bugs.chromium.org/p/webm/issues/detail?id=1544#c4

v1.7.0-597-gde5a4fbb1

I ran some tests on Pixel XL and here is the result (average across 10 runs on each clip, without performance mode):

This is how much HBD is slower than LBD:

VGA 1 thread: 2.9%
VGA 2 threads: 1.1%
HD 1 thread: 3.7%
HD 2 threads: 3.4%

[ji… via monorail]

Comment #5 on issue 1544 by ji...@google.com: Enable CONFIG_VP9_HIGHBITDEPTH on arm
https://bugs.chromium.org/p/webm/issues/detail?id=1544#c5

v1.7.0-597-gde5a4fbb1

I use speed 8 for testing and it's bitexact for HBD vs LBD.

On Samsung Galaxy S8+:

VGA 1 thread: 6.5%
VGA 2 threads: 9.6%
HD 1 thread: 8.3%
HD 2 threads: 10.6%

It seems like we'd better not enable vp9 high bitdepth on ARM for now.

[ji… via monorail]

Comment #7 on issue 1544 by ji...@google.com: Enable CONFIG_VP9_HIGHBITDEPTH on arm
https://bugs.chromium.org/p/webm/issues/detail?id=1544#c7

@emircan, do you have more comments on this one?

[emir… via monorail]

Comment #8 on issue 1544 by emir...@chromium.org: Enable CONFIG_VP9_HIGHBITDEPTH on arm
https://bugs.chromium.org/p/webm/issues/detail?id=1544#c8

We can skip VP9.2 support in those platforms then. Is the below check enough to fidn out if it is enabled or not?

static bool vpx_supports_high_bit_depth =
(vpx_codec_get_caps(vpx_codec_vp9_cx()) & VPX_CODEC_CAP_HIGHBITDEPTH) !=
0 &&
(vpx_codec_get_caps(vpx_codec_vp9_dx()) & VPX_CODEC_CAP_HIGHBITDEPTH) !=
0;

[ji… via monorail]

Comment #9 on issue 1544 by ji...@google.com: Enable CONFIG_VP9_HIGHBITDEPTH on arm
https://bugs.chromium.org/p/webm/issues/detail?id=1544#c9

Those check should be enough to see if libvpx is configured with CONFIG_VP9_HIGHBITDEPTH.

[ji… via monorail]

Comment #10 on issue 1544 by ji...@google.com: Enable CONFIG_VP9_HIGHBITDEPTH on arm
https://bugs.chromium.org/p/webm/issues/detail?id=1544#c10

I have tried those flags and it worked for me.

Maybe good to have @jzern to take another look to see if I missed anything.

[jz… via monorail]

Comment #11 on issue 1544 by jz...@google.com: Enable CONFIG_VP9_HIGHBITDEPTH on arm
https://bugs.chromium.org/p/webm/issues/detail?id=1544#c11

Checking the capability should be enough.

[ji… via monorail]

Updates:
Status: WontFix

Comment #12 on issue 1544 by ji...@google.com: Enable CONFIG_VP9_HIGHBITDEPTH on arm
https://bugs.chromium.org/p/webm/issues/detail?id=1544#c12

I'll close this for now.

emircan@, feel free to reopen it if you have more issues.

[m… via monorail]

Comment #13 on issue 1544 by m...@niekvandermaas.nl: Enable CONFIG_VP9_HIGHBITDEPTH on arm
https://bugs.chromium.org/p/webm/issues/detail?id=1544#c13

I noticed CONFIG_VP9_HIGHBITDEPTH is also disabled on arm64 - can you consider enabling this on arm64?

[jz… via monorail]

Comment #14 on issue 1544 by jz...@google.com: Enable CONFIG_VP9_HIGHBITDEPTH on arm
https://bugs.chromium.org/p/webm/issues/detail?id=1544#c14

This is a very old bug, if you have a feature request I'd suggest opening a new one. Chromium has highbd configurations now [1] so I don't believe there's an issue.

[1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/libvpx/generate_gni.sh;l=374;drc=756600e3f4a7985f6d794b40eea1790fb7787e53