Issue 1767 in webm: integer sanitizer warnings in VP9 ResizeTest

24 views
Skip to first unread message

jz… via monorail

unread,
Jun 1, 2022, 12:57:35 AM6/1/22
to webm-d...@webmproject.org
Status: Available
Owner: jz...@google.com
Labels: Type-Bug Pri-2

New issue 1767 by jz...@google.com: integer sanitizer warnings in VP9 ResizeTest
https://bugs.chromium.org/p/webm/issues/detail?id=1767

v1.11.0-225-g8f56e1c07

Currently only realtime is tested with VP9 [1], unlike VP8 which uses ONE_PASS_TEST_MODES. Matching that instantiation will show some integer sanitizer warnings [2], full log attached.

$ source tools/set_analyzer_env.sh integer
$ LDFLAGS="-fsanitize=integer --rtlib=compiler-rt -lgcc_s" ../configure --target=x86-linux-gcc --enable-ccache --enable-vp9-temporal-denoising --disable-dependency-tracking --enable-debug --disable-install-docs --disable-optimizations


[1] https://chromium.googlesource.com/webm/libvpx/+/8f56e1c074712ffa937dc48a14d4b01e378a170f/test/resize_test.cc#799
[2]
../vp9/encoder/vp9_segmentation.c:42:36: runtime error: implicit conversion from type 'int' of value -9 (32-bit, signed) to type 'unsigned int' changed the value to 4294967287 (32-bit, unsigned)
../vpx_dsp/x86/sum_squares_sse2.c:36:52: runtime error: implicit conversion from type 'unsigned int' of value 4294967295 (32-bit, unsigned) to type 'int' changed the value to -1 (32-bit, signed)
../vpx_dsp/x86/sum_squares_sse2.c:36:67: runtime error: implicit conversion from type 'unsigned int' of value 4294967295 (32-bit, unsigned) to type 'int' changed the value to -1 (32-bit, signed)
../vp9/encoder/x86/vp9_diamond_search_sad_avx.c:81:45: runtime error: implicit conversion from type 'uint32_t' (aka 'unsigned int') of value 4290576316 (32-bit, unsigned) to type 'int' changed the value to -4390980 (32-bit, signed)
../vp9/encoder/vp9_rdopt.c:3472:31: runtime error: implicit conversion from type 'int' of value -1024 (32-bit, signed) to type 'uint16_t' (aka 'unsigned short') changed the value to 64512 (16-bit, unsigned)

Attachments:
log.txt.gz 2.3 KB

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Git Watcher via monorail

unread,
Jun 1, 2022, 2:17:09 PM6/1/22
to webm-d...@webmproject.org

Comment #2 on issue 1767 by Git Watcher: integer sanitizer warnings in VP9 ResizeTest
https://bugs.chromium.org/p/webm/issues/detail?id=1767#c2

The following revision refers to this bug:
https://chromium.googlesource.com/webm/libvpx/+/9d279c88c3e8873c114298d69e919bfef45a1dab

commit 9d279c88c3e8873c114298d69e919bfef45a1dab
Author: James Zern <jz...@google.com>
Date: Sat May 28 22:25:49 2022

resize_test: add TODO for ResizeTest instantiation for VP9

this should match VP8 and use ONE_PASS_TEST_MODES, but currently the
code will produce integer sanitizer warnings and may segfault under
certain conditions

Bug: webm:1767,webm:1768
Change-Id: I6482ff1862f19716fde3d57522591bc61d76a84f

[modify] https://crrev.com/9d279c88c3e8873c114298d69e919bfef45a1dab/test/resize_test.cc

jz… via monorail

unread,
Jun 1, 2022, 9:50:43 PM6/1/22
to webm-d...@webmproject.org
Updates:
Owner: jz...@google.com
Status: Assigned

Comment #3 on issue 1767 by jz...@google.com: integer sanitizer warnings in VP9 ResizeTest
https://bugs.chromium.org/p/webm/issues/detail?id=1767#c3

(No comment was entered for this change.)

Git Watcher via monorail

unread,
Jun 13, 2022, 9:25:05 PM6/13/22
to webm-d...@webmproject.org
Updates:
Status: Fixed

Comment #4 on issue 1767 by Git Watcher: integer sanitizer warnings in VP9 ResizeTest
https://bugs.chromium.org/p/webm/issues/detail?id=1767#c4


The following revision refers to this bug:
https://chromium.googlesource.com/webm/libvpx/+/3dc6aa01bacc9818d4ccc0ee0f1b691ae0ec0315

commit 3dc6aa01bacc9818d4ccc0ee0f1b691ae0ec0315
Author: James Zern <jz...@google.com>
Date: Thu Jun 02 01:55:10 2022

vp9,encoder: fix some integer sanitizer warnings

the issues fixed in this change are related to implicit conversions
between int / unsigned int:

vp9/encoder/vp9_segmentation.c:42:36: runtime error: implicit conversion
from type 'int' of value -9 (32-bit, signed) to type 'unsigned int'
changed the value to 4294967287 (32-bit, unsigned)
vpx_dsp/x86/sum_squares_sse2.c:36:52: runtime error: implicit conversion
from type 'unsigned int' of value 4294967295 (32-bit, unsigned) to type
'int' changed the value to -1 (32-bit, signed)
vpx_dsp/x86/sum_squares_sse2.c:36:67: runtime error: implicit conversion
from type 'unsigned int' of value 4294967295 (32-bit, unsigned) to type
'int' changed the value to -1 (32-bit, signed)
vp9/encoder/x86/vp9_diamond_search_sad_avx.c:81:45: runtime error:
implicit conversion from type 'uint32_t' (aka 'unsigned int') of value
4290576316 (32-bit, unsigned) to type 'int' changed the value to
-4390980 (32-bit, signed)
vp9/encoder/vp9_rdopt.c:3472:31: runtime error: implicit conversion from
type 'int' of value -1024 (32-bit, signed) to type 'uint16_t' (aka
'unsigned short') changed the value to 64512 (16-bit, unsigned)

Reply all
Reply to author
Forward
0 new messages