Issue 358 in webp: HAVE_CPU_FEATURES_H redefinition for Android CMake build

[g… via monorail]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 358 by gf...@google.com: HAVE_CPU_FEATURES_H redefinition for Android CMake build
https://bugs.chromium.org/p/webp/issues/detail?id=358

What steps will reproduce the problem?
1.clone g...@github.com:googlesamples/android-ndk.git
2.cd webp
3.gradlew assembleDebug

In terminal, I saw:
In file included from /Users/gfan/tmp/android-ndk/webp/libwebp/src/enc/picture_csp_enc.c:18:
In file included from /Users/gfan/tmp/android-ndk/webp/libwebp/src/enc/./vp8i_enc.h:19:
In file included from /Users/gfan/tmp/android-ndk/webp/libwebp/src/enc/../dsp/dsp.h:18:
/Users/gfan/tmp/android-ndk/webp/view/.externalNativeBuild/cmake/arm7Debug/libwebp/build/include/webp/../webp/config.h:17:9: warning: 'HAVE_CPU_FEATURES_H' macro redefined [-Wmacro-redefined]
#define HAVE_CPU_FEATURES_H
^
<command line>:2:9: note: previous definition is here
#define HAVE_CPU_FEATURES_H 1
^
1 warning generated.

This might be related to recent CMake clean-up checkin.

What is the expected output? What do you see instead?
Should not see the duplicate definition for HAVE_CPU_FEATURES_H for Android

What version of the product are you using? On what operating system?


Please provide any additional information below.



--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

[pascal.m… via monorail]

Updates:
Owner: vincent....@gmail.com
Status: Accepted

Comment #1 on issue 358 by pascal.m...@gmail.com: HAVE_CPU_FEATURES_H redefinition for Android CMake build
https://bugs.chromium.org/p/webp/issues/detail?id=358#c1

thanks for the detailed report.

[jz… via monorail]

Updates:
Labels: v0.6.1

Comment #2 on issue 358 by jz...@google.com: HAVE_CPU_FEATURES_H redefinition for Android CMake build
https://bugs.chromium.org/p/webp/issues/detail?id=358#c2

any update on this one?

[vincent.… via monorail]

Updates:
Status: Fixed

Comment #3 on issue 358 by vincent....@gmail.com: HAVE_CPU_FEATURES_H redefinition for Android CMake build
https://bugs.chromium.org/p/webp/issues/detail?id=358#c3

Fixed with https://chromium-review.googlesource.com/c/webm/libwebp/+/681377