Issue 352 in webp: add portable intrinsics / wasm support for lossy decoding

[jz… via monorail]

Status: Started
Owner: slava...@google.com
CC: pascal.m...@gmail.com, gde...@google.com, bradn...@google.com
Labels: Type-Enhancement Priority-Medium

New issue 352 by jz...@google.com: add portable intrinsics / wasm support for lossy decoding
https://bugs.chromium.org/p/webp/issues/detail?id=352

The goal is to develop a portable intrinsics implementation of lossy decoding only in the portable-intrinsics branch. This can then be migrated to wasm intrinsics as they become available.

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

[bugdro… via monorail]

Updates:
Labels: merge-merged-portable-intrinsics

Comment #2 on issue 352 by bugd...@chromium.org: add portable intrinsics / wasm support for lossy decoding
https://bugs.chromium.org/p/webp/issues/detail?id=352#c2

The following revision refers to this bug:
https://chromium.googlesource.com/webm/libwebp/+/a37a7b00d5416a25ed33b2a3e83c85b4aeda43cc

commit a37a7b00d5416a25ed33b2a3e83c85b4aeda43cc
Author: Scott LaVarnway <slava...@google.com>
Date: Thu Jun 29 21:48:14 2017

wasm: Add DC16*, VE16, and HE16 functions

BUG=webp:352

Change-Id: Ia003257d00c2c2ea16a6e6344671237e78c0eac6

[modify] https://crrev.com/a37a7b00d5416a25ed33b2a3e83c85b4aeda43cc/src/dsp/dec_wasm.c

[jz… via monorail]

Updates:
Cc: bbu...@google.com

Comment #3 on issue 352 by jz...@google.com: add portable intrinsics / wasm support for lossy decoding
https://bugs.chromium.org/p/webp/issues/detail?id=352#c3

(No comment was entered for this change.)

[bugdro… via monorail]

Comment #4 on issue 352 by bugd...@chromium.org: add portable intrinsics / wasm support for lossy decoding
https://bugs.chromium.org/p/webp/issues/detail?id=352#c4

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libwebp/+/440945ca57092372f7eca7fa7d725bacd7d706b6

commit 440945ca57092372f7eca7fa7d725bacd7d706b6
Author: Scott LaVarnway <slava...@google.com>
Date: Fri Jun 30 02:14:12 2017

wasm: Add DC8uv*, VE8uv, and HE8uv functions

BUG=webp:352

Change-Id: Ia0b2b0d5007c12fff201ac94673312420da42a53

[modify] https://crrev.com/440945ca57092372f7eca7fa7d725bacd7d706b6/src/dsp/dec_wasm.c

[bugdro… via monorail]

Comment #5 on issue 352 by bugd...@chromium.org: add portable intrinsics / wasm support for lossy decoding
https://bugs.chromium.org/p/webp/issues/detail?id=352#c5

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libwebp/+/b4cefba73159118cf247ea89868133dd75b44a6c

commit b4cefba73159118cf247ea89868133dd75b44a6c
Author: Scott LaVarnway <slava...@google.com>
Date: Fri Jun 30 18:08:43 2017

wasm: Add VE4 and RD4

BUG=webp:352

Change-Id: I24286685d7c002ec55534a98bcb88ecd82562f79

[modify] https://crrev.com/b4cefba73159118cf247ea89868133dd75b44a6c/src/dsp/dec_wasm.c

[bugdro… via monorail]

Comment #6 on issue 352 by bugd...@chromium.org: add portable intrinsics / wasm support for lossy decoding
https://bugs.chromium.org/p/webp/issues/detail?id=352#c6

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libwebp/+/3a5528713b32aa6de33a57113fe32ba09901c892

commit 3a5528713b32aa6de33a57113fe32ba09901c892
Author: Scott LaVarnway <slava...@google.com>
Date: Mon Jul 03 12:36:24 2017

wasm: Add VR4, LD4, and VL4

BUG=webp:352

Change-Id: I28ec852da8aef65b7f3c372c08be5c6bf68256be

[modify] https://crrev.com/3a5528713b32aa6de33a57113fe32ba09901c892/src/dsp/dec_wasm.c

[bugdro… via monorail]

Comment #7 on issue 352 by bugd...@chromium.org: add portable intrinsics / wasm support for lossy decoding
https://bugs.chromium.org/p/webp/issues/detail?id=352#c7

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libwebp/+/ad4ca27449aef99f70bba320cb38e6fd91370467

commit ad4ca27449aef99f70bba320cb38e6fd91370467
Author: Scott LaVarnway <slava...@google.com>
Date: Wed Jul 05 19:16:05 2017

wasm: Add Transform

BUG=webp:352

Change-Id: Ib119b4121c6fd1a5165088dd132b4ab2aca627a5

[modify] https://crrev.com/ad4ca27449aef99f70bba320cb38e6fd91370467/src/dsp/dec_wasm.c

[bugdro… via monorail]

Comment #8 on issue 352 by bugd...@chromium.org: add portable intrinsics / wasm support for lossy decoding
https://bugs.chromium.org/p/webp/issues/detail?id=352#c8

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libwebp/+/e6e3ec335c17190b14b5727f93f21b7be0313643

commit e6e3ec335c17190b14b5727f93f21b7be0313643
Author: Scott LaVarnway <slava...@google.com>
Date: Wed Jul 05 22:56:01 2017

wasm: Add Truemotion

BUG=webp:352

Change-Id: Ie65e155ac2d8253a5706ee85e830ec220a12ab4b

[modify] https://crrev.com/e6e3ec335c17190b14b5727f93f21b7be0313643/src/dsp/dec_wasm.c

[bugdro… via monorail]

Comment #9 on issue 352 by bugd...@chromium.org: add portable intrinsics / wasm support for lossy decoding
https://bugs.chromium.org/p/webp/issues/detail?id=352#c9

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libwebp/+/bafa90ccd8c3e5b40cf3e8e3745abcf5dc93d423

commit bafa90ccd8c3e5b40cf3e8e3745abcf5dc93d423
Author: Scott LaVarnway <slava...@google.com>
Date: Thu Jul 06 18:21:53 2017

wasm: Add VFilter16

BUG=webp:352

Change-Id: I97f38aee5de063957c1512f6bd429c0e84c02087

[modify] https://crrev.com/bafa90ccd8c3e5b40cf3e8e3745abcf5dc93d423/src/dsp/dec_wasm.c

[bugdro… via monorail]

Comment #10 on issue 352 by bugd...@chromium.org: add portable intrinsics / wasm support for lossy decoding
https://bugs.chromium.org/p/webp/issues/detail?id=352#c10

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libwebp/+/fe6184d70664cf710c35b6e71fe3df1695bca24a

commit fe6184d70664cf710c35b6e71fe3df1695bca24a
Author: Scott LaVarnway <slava...@google.com>
Date: Fri Jul 07 17:52:48 2017

wasm: Add HFilter16

BUG=webp:352

Change-Id: I8f1124b36bb5769790b0e7b193acb775e8f463b1

[modify] https://crrev.com/fe6184d70664cf710c35b6e71fe3df1695bca24a/src/dsp/dec_wasm.c

[bugdro… via monorail]

Comment #11 on issue 352 by bugd...@chromium.org: add portable intrinsics / wasm support for lossy decoding
https://bugs.chromium.org/p/webp/issues/detail?id=352#c11

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libwebp/+/9eceff25c07d86275539f0745fd157c7369854da

commit 9eceff25c07d86275539f0745fd157c7369854da
Author: Scott LaVarnway <slava...@google.com>
Date: Mon Jul 10 13:31:00 2017

wasm: Add VFilter16i and HFilter16i

BUG=webp:352

Change-Id: If2cf5737d7aeab9e2d7205adfd334e3041a83c9f

[modify] https://crrev.com/9eceff25c07d86275539f0745fd157c7369854da/src/dsp/dec_wasm.c

[bugdro… via monorail]

Comment #12 on issue 352 by bugd...@chromium.org: add portable intrinsics / wasm support for lossy decoding
https://bugs.chromium.org/p/webp/issues/detail?id=352#c12

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libwebp/+/cd01fc3944a14dbc65b81113213a16cba3a4b134

commit cd01fc3944a14dbc65b81113213a16cba3a4b134
Author: Scott LaVarnway <slava...@google.com>
Date: Mon Jul 10 18:54:39 2017

wasm: Add VFilter8 and HFilter8

BUG=webp:352

Change-Id: Ic43eb5edd7e2508d2975c8f4f72cdba60c4b70f7

[modify] https://crrev.com/cd01fc3944a14dbc65b81113213a16cba3a4b134/src/dsp/dec_wasm.c

[bugdro… via monorail]

Comment #13 on issue 352 by bugd...@chromium.org: add portable intrinsics / wasm support for lossy decoding
https://bugs.chromium.org/p/webp/issues/detail?id=352#c13

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libwebp/+/d2adc08095f7d5f2c3bf13b07ca51a421a2b7167

commit d2adc08095f7d5f2c3bf13b07ca51a421a2b7167
Author: James Zern <jz...@google.com>
Date: Mon Jul 10 22:15:00 2017

add README.wasm

describes how to build dwebp using portable intrinsics

BUG=webp:352

Change-Id: Ibd39dd156d6b64b52f9ade871b969a070bc9ab61

[add] https://crrev.com/d2adc08095f7d5f2c3bf13b07ca51a421a2b7167/README.wasm

[bugdro… via monorail]

Comment #14 on issue 352 by bugd...@chromium.org: add portable intrinsics / wasm support for lossy decoding
https://bugs.chromium.org/p/webp/issues/detail?id=352#c14

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libwebp/+/9a1a3aa8276e6f16552aeb685884cd8628d350ee

commit 9a1a3aa8276e6f16552aeb685884cd8628d350ee
Author: Scott LaVarnway <slava...@google.com>
Date: Mon Jul 10 18:46:53 2017

wasm: Generic add,sub saturate

BUG=webp:352

Change-Id: I2640df736ea852ca5adcb5048550e26475c777ef

[modify] https://crrev.com/9a1a3aa8276e6f16552aeb685884cd8628d350ee/src/dsp/dec_wasm.c

[bugdro… via monorail]

Comment #15 on issue 352 by bugd...@chromium.org: add portable intrinsics / wasm support for lossy decoding
https://bugs.chromium.org/p/webp/issues/detail?id=352#c15

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libwebp/+/d6f90a3d8308c3f5a3d7587a1c339ada3d67377c

commit d6f90a3d8308c3f5a3d7587a1c339ada3d67377c
Author: Scott LaVarnway <slava...@google.com>
Date: Mon Jul 10 20:19:58 2017

wasm: Add VFilter8i and HFilter8i

BUG=webp:352

Change-Id: I76bac76d55ba2ac62bac479ee60291acacfc491c

[modify] https://crrev.com/d6f90a3d8308c3f5a3d7587a1c339ada3d67377c/src/dsp/dec_wasm.c

[bugdro… via monorail]

Comment #16 on issue 352 by bugd...@chromium.org: add portable intrinsics / wasm support for lossy decoding
https://bugs.chromium.org/p/webp/issues/detail?id=352#c16

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libwebp/+/c396e6701b34a3870ad92d1e16c15e5424cc2b72

commit c396e6701b34a3870ad92d1e16c15e5424cc2b72
Author: Scott LaVarnway <slava...@google.com>
Date: Tue Jul 11 15:48:49 2017

wasm: cleanup _pack_sw_2_sb(), SignedShift8b()


BUG=webp:352

Change-Id: I35a36e1841f71f286fa7e032866a878b52ba56ba

[modify] https://crrev.com/c396e6701b34a3870ad92d1e16c15e5424cc2b72/src/dsp/dec_wasm.c

[bugdro… via monorail]

Comment #17 on issue 352 by bugd...@chromium.org: add portable intrinsics / wasm support for lossy decoding
https://bugs.chromium.org/p/webp/issues/detail?id=352#c17

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libwebp/+/e83df9d208795558e02f44f6713e9e88923a7f4e

commit e83df9d208795558e02f44f6713e9e88923a7f4e
Author: Scott LaVarnway <slava...@google.com>
Date: Tue Jul 11 20:18:15 2017

wasm: replace #if with #ifdef

BUG=webp:352

Change-Id: Ib173e8cdb9077b385141c0e3a2f7ceb1a183b89e

[modify] https://crrev.com/e83df9d208795558e02f44f6713e9e88923a7f4e/src/dsp/dec_wasm.c

[bugdro… via monorail]

Comment #18 on issue 352 by bugd...@chromium.org: add portable intrinsics / wasm support for lossy decoding
https://bugs.chromium.org/p/webp/issues/detail?id=352#c18

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libwebp/+/3387fb6fa634a916f7c410c1f500748648f4292e

commit 3387fb6fa634a916f7c410c1f500748648f4292e
Author: Scott LaVarnway <slava...@google.com>
Date: Tue Jul 11 20:06:24 2017

wasm: Replace 5 __builtin_shufflevector()

with _unpack*()

BUG=webp:352

Change-Id: Iea17286260afe7d242c91b02d888c5af59ab0cb7

[modify] https://crrev.com/3387fb6fa634a916f7c410c1f500748648f4292e/src/dsp/dec_wasm.c

[bugdro… via monorail]

Comment #19 on issue 352 by bugd...@chromium.org: add portable intrinsics / wasm support for lossy decoding
https://bugs.chromium.org/p/webp/issues/detail?id=352#c19

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libwebp/+/415b98ffad0029405ecd6024854ea590a945f36b

commit 415b98ffad0029405ecd6024854ea590a945f36b
Author: Scott LaVarnway <slava...@google.com>
Date: Fri Jul 14 22:11:57 2017

wasm: Enable neon add,sub with sat builtins

For performance testing

BUG=webp:352

Change-Id: I3fab48ee610437ac07dd603208972edf17c6f50b

[modify] https://crrev.com/415b98ffad0029405ecd6024854ea590a945f36b/src/dsp/dec_wasm.c

[bugdro… via monorail]

Comment #20 on issue 352 by bugd...@chromium.org: add portable intrinsics / wasm support for lossy decoding
https://bugs.chromium.org/p/webp/issues/detail?id=352#c20

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libwebp/+/0b8ecc8cfaba22e89edd9e15ef9775cc7408af7c

commit 0b8ecc8cfaba22e89edd9e15ef9775cc7408af7c
Author: Scott LaVarnway <slava...@google.com>
Date: Tue Jul 18 20:34:21 2017

wasm: Rename _pack_sw_2_sb to _pack_epi16_to_epi8

BUG=webp:352

Change-Id: I67beb9297d3a37f3691779e0ad6f557f06195219

[modify] https://crrev.com/0b8ecc8cfaba22e89edd9e15ef9775cc7408af7c/src/dsp/dec_wasm.c

[bugdro… via monorail]

Comment #21 on issue 352 by bugd...@chromium.org: add portable intrinsics / wasm support for lossy decoding
https://bugs.chromium.org/p/webp/issues/detail?id=352#c21

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libwebp/+/9d1e151bf5f178363f802f05580509fc277ab143

commit 9d1e151bf5f178363f802f05580509fc277ab143
Author: Scott LaVarnway <slava...@google.com>
Date: Thu Jul 27 22:03:52 2017

wasm: replace _mulhi_int16x8() with x86 builtin

BUG=webp:352

Change-Id: Ie51a8bb68211d7778610a818bba02e7455e47e23

[modify] https://crrev.com/9d1e151bf5f178363f802f05580509fc277ab143/src/dsp/dec_wasm.c

[bugdro… via monorail]

Comment #22 on issue 352 by bugd...@chromium.org: add portable intrinsics / wasm support for lossy decoding
https://bugs.chromium.org/p/webp/issues/detail?id=352#c22

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libwebp/+/6fcc3a720d3c15ecfe524cf6a28b93d4af1b1f0c

commit 6fcc3a720d3c15ecfe524cf6a28b93d4af1b1f0c
Author: Scott LaVarnway <slava...@google.com>
Date: Fri Jul 28 16:04:30 2017

wasm: Add simple loopfilter

BUG=webp:352

Change-Id: If51454b8f54fb14ced91fa703e86e057457f454f

[modify] https://crrev.com/6fcc3a720d3c15ecfe524cf6a28b93d4af1b1f0c/src/dsp/dec_wasm.c

[bugdro… via monorail]

Comment #23 on issue 352 by bugd...@chromium.org: add portable intrinsics / wasm support for lossy decoding
https://bugs.chromium.org/p/webp/issues/detail?id=352#c23

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libwebp/+/8ed24a564c408d6ec81fb8ac4b36994922b519bf

commit 8ed24a564c408d6ec81fb8ac4b36994922b519bf
Author: Scott LaVarnway <slava...@google.com>
Date: Wed Aug 23 19:10:37 2017

wasm: replace _mulhi_int16x8() with neon builtin

BUG=webp:352

Change-Id: I5c21ee4c631fb7eccff36c7d3cd47a72badf1a89

[modify] https://crrev.com/8ed24a564c408d6ec81fb8ac4b36994922b519bf/src/dsp/dec_wasm.c

[jz… via monorail]

Updates:
Status: Fixed

Comment #24 on issue 352 by jz...@google.com: add portable intrinsics / wasm support for lossy decoding
https://bugs.chromium.org/p/webp/issues/detail?id=352#c24

This is done as far as the intent of the bug goes. The lossy decoder has simple and complex loopfilter support along with optional platform specific implementations of mulhi for experimentation purposes.