Issue 339 in webp: Investigate removal / refinement of WORK_AROUND_GCC

17 views
Skip to first unread message

jz… via monorail

unread,
Mar 23, 2017, 3:01:11 AM3/23/17
to webp-d...@webmproject.org
Status: Accepted
Owner: jz...@google.com
Labels: Type-Defect Priority-Medium v0.6.1

New issue 339 by jz...@google.com: Investigate removal / refinement of WORK_AROUND_GCC
https://bugs.chromium.org/p/webp/issues/detail?id=339

v0.6.0-65-gd0b7404e

These were put in place for build or performance issues with older versions of gcc. In the latter case these may be overly greedy version wise and not strictly necessary for e.g., NEON where common toolchains (NDK's gcc, clang) have moved forward quickly.

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

johannko… via monorail

unread,
Mar 23, 2017, 11:38:46 AM3/23/17
to webp-d...@webmproject.org

Comment #1 on issue 339 by johannko...@google.com: Investigate removal / refinement of WORK_AROUND_GCC
https://bugs.chromium.org/p/webp/issues/detail?id=339#c1

Arm uses "VPX_INCOMPATIBLE_GCC" for gcc 4.6 and earlier. I'm in favor of removing the workaround and ignoring reports about broken 4.6 builds (or adding a configure-time check and failing there)

jz… via monorail

unread,
Mar 23, 2017, 4:19:18 PM3/23/17
to webp-d...@webmproject.org

Comment #2 on issue 339 by jz...@google.com: Investigate removal / refinement of WORK_AROUND_GCC
https://bugs.chromium.org/p/webp/issues/detail?id=339#c2

This is a webp bug, if you'd like to add a similar request for libvpx please do.

bugdro… via monorail

unread,
Sep 20, 2017, 2:04:29 AM9/20/17
to webp-d...@webmproject.org

Comment #3 on issue 339 by bugd...@chromium.org: Investigate removal / refinement of WORK_AROUND_GCC
https://bugs.chromium.org/p/webp/issues/detail?id=339#c3

The following revision refers to this bug:
https://chromium.googlesource.com/webm/libwebp/+/01c426f1e7bd83e6a6f86d77f08103d1dca1f2af

commit 01c426f1e7bd83e6a6f86d77f08103d1dca1f2af
Author: James Zern <jz...@google.com&gt;
Date: Wed Sep 20 03:59:43 2017

define WEBP_USE_INTRINSICS w/gcc-4.9+

32-bit builds are neutral to slightly faster using ndk r15c on a
N5/S6/CM1

BUG=webp:339

Change-Id: I94b9442e0ceaf2f5edb2b4026bc8b99cd77c918b

[modify] https://crrev.com/01c426f1e7bd83e6a6f86d77f08103d1dca1f2af/src/dsp/neon.h

bugdro… via monorail

unread,
Sep 20, 2017, 2:05:33 AM9/20/17
to webp-d...@webmproject.org

Comment #4 on issue 339 by bugd...@chromium.org: Investigate removal / refinement of WORK_AROUND_GCC
https://bugs.chromium.org/p/webp/issues/detail?id=339#c4


The following revision refers to this bug:
https://chromium.googlesource.com/webm/libwebp/+/f78da3dea6b2e02974a647122e96777667875d21

commit f78da3dea6b2e02974a647122e96777667875d21
Author: James Zern <jz...@google.com&gt;
Date: Wed Sep 20 03:59:49 2017

add LOCAL_CLANG_PREREQ and avoid WORK_AROUND_GCC w/3.8+

this results in a 15-20% speedup for lossy decoding on a N5/S6/CM1

BUG=webp:339

Change-Id: Icdeb84c3e0b8908147ac276b4d8f76c3d565b735

[modify] https://crrev.com/f78da3dea6b2e02974a647122e96777667875d21/src/dsp/dsp.h
[modify] https://crrev.com/f78da3dea6b2e02974a647122e96777667875d21/src/dsp/neon.h

jz… via monorail

unread,
Oct 20, 2017, 4:05:22 AM10/20/17
to webp-d...@webmproject.org
Updates:
Status: Fixed

Comment #5 on issue 339 by jz...@google.com: Investigate removal / refinement of WORK_AROUND_GCC
https://bugs.chromium.org/p/webp/issues/detail?id=339#c5

I think leaving the legacy code is all right now that we're hitting the intrinsics with modern compilers.

bugdro… via monorail

unread,
Oct 28, 2017, 3:52:18 PM10/28/17
to webp-d...@webmproject.org
Updates:
Labels: merge-merged-portable-intrinsics

Comment #6 on issue 339 by bugd...@chromium.org: Investigate removal / refinement of WORK_AROUND_GCC
https://bugs.chromium.org/p/webp/issues/detail?id=339#c6


The following revision refers to this bug:
https://chromium.googlesource.com/webm/libwebp/+/a26996116f9e43b0da717d5ff67a09e85526b2c6

commit a26996116f9e43b0da717d5ff67a09e85526b2c6
Author: James Zern <jz...@google.com&gt;
Date: Sat Oct 28 18:49:18 2017

define WEBP_USE_INTRINSICS w/gcc-4.9+

32-bit builds are neutral to slightly faster using ndk r15c on a
N5/S6/CM1

BUG=webp:339

Change-Id: I94b9442e0ceaf2f5edb2b4026bc8b99cd77c918b
(cherry picked from commit 01c426f1e7bd83e6a6f86d77f08103d1dca1f2af)

[modify] https://crrev.com/a26996116f9e43b0da717d5ff67a09e85526b2c6/src/dsp/neon.h

bugdro… via monorail

unread,
Oct 28, 2017, 3:52:19 PM10/28/17
to webp-d...@webmproject.org

Comment #7 on issue 339 by bugd...@chromium.org: Investigate removal / refinement of WORK_AROUND_GCC
https://bugs.chromium.org/p/webp/issues/detail?id=339#c7


The following revision refers to this bug:

Author: James Zern <jz...@google.com&gt;
Date: Sat Oct 28 18:49:18 2017

add LOCAL_CLANG_PREREQ and avoid WORK_AROUND_GCC w/3.8+

this results in a 15-20% speedup for lossy decoding on a N5/S6/CM1

BUG=webp:339

Change-Id: Icdeb84c3e0b8908147ac276b4d8f76c3d565b735
(cherry picked from commit f78da3dea6b2e02974a647122e96777667875d21)

[modify] https://crrev.com/08af9670256d08173e80a1464474649ebe0a989e/src/dsp/dsp.h
[modify] https://crrev.com/08af9670256d08173e80a1464474649ebe0a989e/src/dsp/neon.h
Reply all
Reply to author
Forward
0 new messages