Issue 380 in webp: vwebp & spec frame duration 0 inconsistency

10 views
Skip to first unread message

jz… via monorail

unread,
Apr 20, 2018, 3:46:01 PM4/20/18
to webp-d...@webmproject.org
Status: Accepted
Owner: jz...@google.com
Labels: Type-Defect Priority-Medium v0.6.2

New issue 380 by jz...@google.com: vwebp & spec frame duration 0 inconsistency
https://bugs.chromium.org/p/webp/issues/detail?id=380

v0.6.1-69-gd77bf512

Related to the changes made in gif2webp:
https://bugs.chromium.org/p/webp/issues/detail?id=379

As mentioned on the mailing list:
https://groups.google.com/a/webmproject.org/forum/#!topic/webp-discuss/SP56Jvxeh9M

Frame Duration: 24 bits (uint24)
The time to wait before displaying the next frame, in 1 millisecond units. In particular, frame duration of 0 is useful when one wants to update multiple areas of the canvas at once during the animation.

This should be updated that the interpretation is implementation defined.

vwebp does nothing special for 0 duration frames, playing back as fast as possible.

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

bugdro… via monorail

unread,
Apr 20, 2018, 7:38:34 PM4/20/18
to webp-d...@webmproject.org

Comment #1 on issue 380 by bugd...@chromium.org: vwebp & spec frame duration 0 inconsistency
https://bugs.chromium.org/p/webp/issues/detail?id=380#c1

The following revision refers to this bug:
https://chromium.googlesource.com/webm/libwebp/+/fd3d5756cb7c63ba78c73297f755f072751d4aed

commit fd3d5756cb7c63ba78c73297f755f072751d4aed
Author: Vincent Rabaud <vra...@google.com>
Date: Fri Apr 20 19:53:10 2018

vwebp: Copy Chrome's behavior w/frame duration == 0

BUG=webp:380

Change-Id: Ia0b108d7da755ff91cf6c84581412e47a3a6e5d9

[modify] https://crrev.com/fd3d5756cb7c63ba78c73297f755f072751d4aed/examples/vwebp.c

bugdro… via monorail

unread,
Apr 20, 2018, 7:38:34 PM4/20/18
to webp-d...@webmproject.org

Comment #2 on issue 380 by bugd...@chromium.org: vwebp & spec frame duration 0 inconsistency
https://bugs.chromium.org/p/webp/issues/detail?id=380#c2


The following revision refers to this bug:
https://chromium.googlesource.com/webm/libwebp/+/71c39a06c83b7bfbee136fd40ac710bdda3a237c

commit 71c39a06c83b7bfbee136fd40ac710bdda3a237c
Author: James Zern <jz...@google.com>
Date: Fri Apr 20 22:23:12 2018

webp-container-spec: correct frame duration=0 note

the interpretation of a 0 duration depends on the implementation;
merging of multiple frames isn't guaranteed, some may enforce a minimum
duration.

BUG=webp:380

Change-Id: Idf592049d2092e4cc5cfb2e4c59ddbc91bd52f9c

[modify] https://crrev.com/71c39a06c83b7bfbee136fd40ac710bdda3a237c/doc/webp-container-spec.txt

bugdro… via monorail

unread,
Apr 20, 2018, 11:03:28 PM4/20/18
to webp-d...@webmproject.org
Updates:
Labels: merge-merged-1.0.0

Comment #3 on issue 380 by bugd...@chromium.org: vwebp & spec frame duration 0 inconsistency
https://bugs.chromium.org/p/webp/issues/detail?id=380#c3


The following revision refers to this bug:
https://chromium.googlesource.com/webm/libwebp/+/e6b2164e3a3677f38c903cea57ecce879b05f133

commit e6b2164e3a3677f38c903cea57ecce879b05f133
Author: Vincent Rabaud <vra...@google.com>
Date: Sat Apr 21 02:59:15 2018


vwebp: Copy Chrome's behavior w/frame duration == 0

BUG=webp:380

Change-Id: Ia0b108d7da755ff91cf6c84581412e47a3a6e5d9
(cherry picked from commit fd3d5756cb7c63ba78c73297f755f072751d4aed)

[modify] https://crrev.com/e6b2164e3a3677f38c903cea57ecce879b05f133/examples/vwebp.c

bugdro… via monorail

unread,
Apr 20, 2018, 11:03:29 PM4/20/18
to webp-d...@webmproject.org

Comment #4 on issue 380 by bugd...@chromium.org: vwebp & spec frame duration 0 inconsistency
https://bugs.chromium.org/p/webp/issues/detail?id=380#c4


The following revision refers to this bug:
https://chromium.googlesource.com/webm/libwebp/+/8d510751dadc6a470768e2874842a466b1e80d60

commit 8d510751dadc6a470768e2874842a466b1e80d60
Author: James Zern <jz...@google.com>
Date: Sat Apr 21 02:59:21 2018


webp-container-spec: correct frame duration=0 note

the interpretation of a 0 duration depends on the implementation;
merging of multiple frames isn't guaranteed, some may enforce a minimum
duration.

BUG=webp:380

Change-Id: Idf592049d2092e4cc5cfb2e4c59ddbc91bd52f9c
(cherry picked from commit 71c39a06c83b7bfbee136fd40ac710bdda3a237c)

[modify] https://crrev.com/8d510751dadc6a470768e2874842a466b1e80d60/doc/webp-container-spec.txt

jz… via monorail

unread,
Apr 20, 2018, 11:06:10 PM4/20/18
to webp-d...@webmproject.org
Updates:
Status: Fixed

Comment #5 on issue 380 by jz...@google.com: vwebp & spec frame duration 0 inconsistency
https://bugs.chromium.org/p/webp/issues/detail?id=380#c5

(No comment was entered for this change.)
Reply all
Reply to author
Forward
0 new messages