Issue 323 in webp: Version info missing in Windows .dll files

[skuldw… via monorail]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 323 by skuldw...@gmail.com: Version info missing in Windows .dll files
https://bugs.chromium.org/p/webp/issues/detail?id=323

It's always good practice to add version info to DLLs (and exes) where possible.
The executable files do have displayed version info and is less of an issue.

To "fix" the dll building to include version info the following can be done:

See attached example Makefile.vc which has one line added and one line edited.
Original is:
$(LIBWEBPDECODER) $(LIBWEBP) $(LIBWEBPMUX) $(LIBWEBPDEMUX):
$(LNKDLL) /out:$(DIRBIN)\$(@B:_dll=.dll) /implib:$@ $(LFLAGS) $**
-xcopy $(DIROBJ)\*.pdb $(DIRLIB) /y

Fixed is:
$(LIBWEBPDECODER) $(LIBWEBP) $(LIBWEBPMUX) $(LIBWEBPDEMUX):
rc /nologo version.rc
$(LNKDLL) /out:$(DIRBIN)\$(@B:_dll=.dll) /implib:$@ $(LFLAGS) $** version.res
-xcopy $(DIROBJ)\*.pdb $(DIRLIB) /y


In addition the following two files need to to be added to the source archive (see attached files):
version.h and version.rc

Ideally both libwebpdecoder.dll and libwebp.dll should have their own version info (the currently example here gives libwebpdecoder.dll the same info as libwebp.dll so the name in the version info for both are "libwebp")

This is just a quick proof of concept to show how easily the version info can be added without messing with the rest of the source or change the build process.

Attachments:
Makefile.vc 14.2 KB
version.h 991 bytes
version.rc 867 bytes

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

[bugdro… via monorail]

Comment #1 on issue 323 by bugd...@chromium.org: Version info missing in Windows .dll files
https://bugs.chromium.org/p/webp/issues/detail?id=323#c1

The following revision refers to this bug:
https://chromium.googlesource.com/webm/libwebp/+/43d3f01a2ffeefa5e5cc7fb2ac4497be2473c54d

commit 43d3f01a2ffeefa5e5cc7fb2ac4497be2473c54d
Author: James Zern <jz...@google.com>
Date: Fri Jan 20 08:07:48 2017

add .rc files for windows dll versioning

BUG=webp:323

Change-Id: Id415a32b63618d39af2e599cec0d40f64c35bbce

[modify] https://crrev.com/43d3f01a2ffeefa5e5cc7fb2ac4497be2473c54d/Makefile.vc
[add] https://crrev.com/43d3f01a2ffeefa5e5cc7fb2ac4497be2473c54d/src/demux/libwebpdemux.rc
[add] https://crrev.com/43d3f01a2ffeefa5e5cc7fb2ac4497be2473c54d/src/libwebpdecoder.rc
[add] https://crrev.com/43d3f01a2ffeefa5e5cc7fb2ac4497be2473c54d/src/mux/libwebpmux.rc
[add] https://crrev.com/43d3f01a2ffeefa5e5cc7fb2ac4497be2473c54d/src/libwebp.rc

[jz… via monorail]

Updates:
Status: Fixed

Comment #2 on issue 323 by jz...@google.com: Version info missing in Windows .dll files
https://bugs.chromium.org/p/webp/issues/detail?id=323#c2

Thanks for the report. This will be included in the 0.6.0 release which should be coming soon.

[bugdro… via monorail]

Comment #3 on issue 323 by bugd...@chromium.org: Version info missing in Windows .dll files
https://bugs.chromium.org/p/webp/issues/detail?id=323#c3

The following revision refers to this bug:

https://chromium.googlesource.com/webm/libwebp/+/84cef16f47509314e0e3d1d687af725f20f7031d

commit 84cef16f47509314e0e3d1d687af725f20f7031d
Author: James Zern <jz...@google.com>
Date: Sat Jan 21 01:03:51 2017

Makefile.vc: fix CFG=debug-dynamic build

strip '_debug' from the library basename to form the resource target.
since:
919f9e2f Merge "add .rc files for windows dll versioning"

BUG=webp:323

Change-Id: I97cfa48afa846211385720034a40aa452c68134c

[modify] https://crrev.com/84cef16f47509314e0e3d1d687af725f20f7031d/Makefile.vc