WebHare 5.7 release

[Arnold Hendriks]

We've finished 5.7 (Well, we did last week). Please see https://www.webhare.dev/reference-next/release-notes/5.7/

If anything is unclear or missing, post it here!

[Wouter Hendriks]

Got a crash that seems to have to do with 5.7 changes.

This XML:

            <imgedit name="previewimage"
                     width="1pr"
                     height="1pr"
                     onchange="onphotoedit"
                     publisher="false"
                     title=""
                     upload="false" />

And this code

^previewimage->value := WrapBlob(imagedata, selection.filename);

Triggers:

Exception EXCEPTION: Invalid output format '' in resize method.
At wh::internal/graphics.whlib(631,11)

Trace:
wh::internal/graphics.whlib(631,11) VALIDATERESIZEMETHOD
wh::internal/graphics.whlib(684,13) EXPLAINIMAGEPROCESSING
wh::graphics/filters.whlib(290,26) __MYGFXRESIZEIMAGEBLOBWITHMETHOD
wh::graphics/filters.whlib(244,21) GFXRESIZEWRAPPEDIMAGEWITHMETHOD
wh::graphics/filters.whlib(223,10) GFXRESIZEIMAGEBLOBWITHMETHOD
mod::tollium/lib/components/imgedit.whlib(587,45) TOLLIUMIMGEDIT#SETVALUE
mod::wvuaw/tolliumapps/sellingprocess.whlib(2293,20) PHOTOS#ONROWSSELECT
mod::tollium/lib/componentbase.whlib(1591,17) TOLLIUMCOMPONENTBASE#TOLLIUMDISPATCHEVENT
mod::tollium/lib/internal/screenmanager.whlib(454,24) SCREENMANAGER#DOEVENTS
mod::tollium/lib/internal/controllerbase.whlib(2144,37) TOLLIUMCONTROLLERBASE#TOLLIUM_PARSEPENDINGEVENTS
mod::tollium/lib/internal/controllerbase.whlib(3270,18) TOLLIUMCONTROLLERBASE#CONTROLLERLOOP
mod::tollium/lib/internal/controllerbase.whlib(3227,11) TOLLIUMCONTROLLERBASE#RUNMODALSCREEN
mod::tollium/lib/screenbase.whlib(895,32) TOLLIUMSCREENBASE#RUNMODAL
mod::wvuaw/tolliumapps/sellingprocess.whlib(1984,10) UPDATESELLINGPROCESS#DOMANAGEPHOTOS
mod::wvuaw/tolliumapps/sellingprocess.whlib(366,45) UPDATESELLINGPROCESS#INIT
mod::tollium/lib/screenbase.whlib(1013,15) TOLLIUMSCREENBASE#TOLLIUMINITIALIZESCREEN
mod::tollium/lib/internal/controllerbase.whlib(2001,17) TOLLIUMCONTROLLERBASE#PVT_LOADSCREEN
mod::tollium/lib/screenbase.whlib(623,47) TOLLIUMSCREENBASE#LOADSCREEN
mod::wvuaw/tolliumapps/main.whlib(3009,25) EDITSELLINGPROCESS#INIT
mod::tollium/lib/screenbase.whlib(1013,15) TOLLIUMSCREENBASE#TOLLIUMINITIALIZESCREEN
mod::tollium/lib/internal/controllerbase.whlib(2001,17) TOLLIUMCONTROLLERBASE#PVT_LOADSCREEN
mod::tollium/lib/internal/controllerbase.whlib(2087,18) TOLLIUMCONTROLLERBASE#LOADSCREEN
mod::tollium/lib/internal/controllerbase.whlib(2237,32) TOLLIUMCONTROLLERBASE#__DOINTEGRATEDAPPLAUNCH
mod::tollium/lib/internal/controllerbase.whlib(2221,15) TOLLIUMCONTROLLERBASE#LAUNCHTHEAPPLICATION
mod::tollium/lib/internal/controllerbase.whlib(2157,15) TOLLIUMCONTROLLERBASE#LAUNCHAPPLICATION
mod::tollium/lib/todd/internal/controller.whlib(475,28) TOLLIUMWEBCONTROLLER#LAUNCHAPPLICATION
mod::tollium/scripts/internal/applicationhost.whscr(150,16) :INITFUNCTION

[Arnold Hendriks]

What is the value of this->imgsize just before the crash? Because your code doesn't seem to be setting imgsize, but as far as I can tell the code in the crash shouldn't be reachable then

[Arnold Hendriks]

and make sure you are completely uptodate and have commit 98985b8e7568ce097656a4fba09097bf5c5c85d5

[Wouter Hendriks]

^previewimage->imgsize? It's:

APP:+RECORD
application.tsx:951 APP: +BGCOLOR: ''
application.tsx:951 APP: +FIXORIENTATION: TRUE
application.tsx:951 APP: +FORMAT: ''
application.tsx:951 APP: +METHOD: 'none'
application.tsx:951 APP: +NOFORCE: FALSE
application.tsx:951 APP: +SETHEIGHT: 0
application.tsx:951 APP: +SETWIDTH: 0
application.tsx:951 APP: +ALLOWEDACTIONS: ['all']
application.tsx:951 

Yep, I have that commit.

Weird thing is that it only crashes on certain blobs. I've attached 2:

- crashes on PvBBp4vfCXKF0Wj5DnaJo1DT7ticRvHCWAmJ3SHXbpGo2ubcwx-3ae57602-ecbb-453e-950a-b3a962dfbba0.jpeg

- works fine on Ad86aEfiQmpr6jcVqEFVhKNB5se8I7XmKzdizUJzYandoXvCJH-img-0202.jpeg

Found it. It's because of the rotation in the first, a DumpValue of WrapBlob of the first:

APP:+RECORD
application.tsx:951 APP: +DATA: BLOB (1020351 bytes)
application.tsx:951 APP: +DOMINANTCOLOR: ''
application.tsx:951 APP: +EXTENSION: '.jpg'
application.tsx:951 APP: +FILENAME: 'noname.jpg'
application.tsx:951 APP: +HASH: ''
application.tsx:951 APP: +HEIGHT: 2160
application.tsx:951 APP: +MIMETYPE: 'image/jpeg'
application.tsx:951 APP: +MIRRORED: FALSE
application.tsx:951 APP: +ROTATION: 270
application.tsx:951 APP: +SOURCE_FSOBJECT: 0
application.tsx:951 APP: +WIDTH: 3840
application.tsx:951 APP: +__BLOBSOURCE: ''
application.tsx:951 APP: +REFPOINT: DEFAULT RECORD

If I change the one that was working (which has rotation:0), add rotation, and then try it, it also crashes.

[Arnold Hendriks]

Hmm, the images don't crash the generic imgedit component at https://my.webhare.dev/testoutput/webhare_testsuite.testsite/testsuiteportal/?app=webhare_testsuite:anycomponent(imgedit,%7B%22width%22%3A%22250px%22%2C%22height%22%3A%22250px%22%7D)&

Can you reproduce it there or supply a selfcontainefdtestcase, or modifications to the above (or to https://my.webhare.dev/.system/jstests/?site=webhare_testsuite.testsite&skip=&autotests=&reportid=&startat=&mask=tollium.components.testimgedit) that trigger it ?

[Wouter Hendriks]

Here's a minimal test case module:

https://static.webwerf.nl/whmodule-imagecrash-2025-05-7.tar.gz

Open with:

http://my.webhare.dev/?app=imagecrash

Press "nocrash" for nocrash and "crash" for a crash.

One thing I'm doing differently than the tests is download the image from an URL, WrapBlob the blob and pass that to the image field.

[Arnold Hendriks]

Ah - the problem is specifically with *static* <imgedit> and rotated input. That's why I couldn't reproduce it 

https://gitlab.webhare.com/webhare-opensource/platform/-/merge_requests/2171 should fix it, give it a shot

[Wouter Hendriks]

Yes, that works, great!

[Arnold Hendriks]

FYI this feature is in master and scheduled as 5.7 backport in https://gitlab.webhare.com/webhare-opensource/platform/-/merge_requests/2177