Work auto-closes?

[Wouter Hendriks]

Got this code:

    console.log('ensureTag1 ISWORKOPEN', whdb.isWorkOpen());
    // get the tag ID from wvuaw.tags
    const tag = await whdb.db<WvuawDB>()
      .selectFrom("wvuaw.tags")
      .where("tag", "=", _tag)
      .select(["id"])
      .executeTakeFirst() as { id: number } | undefined;
    console.log('ensureTag2 ISWORKOPEN', whdb.isWorkOpen());

Output:

ensureTag1 ISWORKOPEN true
ensureTag2 ISWORKOPEN false

Somehow, the work is closed after the select? What could cause this?

[Arnold Hendriks]

Something running between the start and completion of the select that closes the work or the context. 

There's n way to even guess without context - who/what is actually managing the transaction.

 

[Wouter Hendriks]

Yeah, forgot an 'await' somewhere.

Tip: if you want your editor to warn you about forgetting awaits (which I forget pretty often :-)), use this rule:

https://typescript-eslint.io/rules/no-misused-promises/

Make sure to follow the https://typescript-eslint.io/getting-started/typed-linting/ instructions as well.

[Arnold Hendriks]

On Saturday, October 12, 2024 at 2:18:02 PM UTC+2 Wouter Hendriks wrote:

Yeah, forgot an 'await' somewhere.

Tip: if you want your editor to warn you about forgetting awaits (which I forget pretty often :-)), use this rule:

https://typescript-eslint.io/rules/no-misused-promises/

Make sure to follow the https://typescript-eslint.io/getting-started/typed-linting/ instructions as well.

Enabling this has been on our wishlist for quite a while, but to enable it in wh validate required a bit of work as you need to integrate eslint and tsc a lot deeper ('parser services'). 

And the list of issues to fix once we enable this was no fun. Hats off to Rob for his horrible week :)

[Arnold Hendriks]

8:02 PM UTC+2 Wouter Hendriks wrote:

Yeah, forgot an 'await' somewhere.

Tip: if you want your editor to warn you about forgetting awaits (which I forget pretty often :-)), use this rule:

https://typescript-eslint.io/rules/no-misused-promises/

Make sure to follow the https://typescript-eslint.io/getting-started/typed-linting/ instructions as well.

Enabling this has been on our wishlist for quite a while, but to enable it in wh validate required a bit of work as you need to integrate eslint and tsc a lot deeper ('parser services'). 

And we've had this for a few weeks now! Still only warnings and we might have to start recommending some specific coding patterns to help reduce the list