Adding Ops to WASM backend

[Pablo Escriva]

Hello tfjs community,

I am new to TensorFlow.js and would like to add the "Fill" Op to the WASM backend to use the face-api library.

I have not found any documentation on how to add new Ops, could you please give me some advices on how to achieve this?

I have tried adding 'Fill' to tfjs-backend-wasm and building the .wasm files, but when I use them with Face-Api it still shows Fill NotYetImplemented. Do I need to change anything from tfjs-core?

Thanks!

Pablo

[Jason Mayes]

Hi Pablo! Thanks for reaching out. I shall let Na from our team let you know more details on this one as she may be releasing some docs around this very soon and she is an expert in this area.

--
You received this message because you are subscribed to the Google Groups "TensorFlow.js Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tfjs+uns...@tensorflow.org.
To view this discussion on the web visit https://groups.google.com/a/tensorflow.org/d/msgid/tfjs/736a27f3-86ed-47a0-9613-d5276768fdbfn%40tensorflow.org.

--

•  Jason Mayes   •  Senior Developer Advocate, TensorFlow.js   •  Google   •   Follow my discoveries or contribute your own

This email may be confidential and privileged. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person.

[Na Li]

Hi Pablok,

Thank you for the question. We just added a doc on how to contribute ops to TF.js repository: https://github.com/tensorflow/tfjs/blob/master/CONTRIBUTING_MISSING_OP.md

Feel free to reach out if you have any questions. Looking forward to your PR!

Best,

Na Li

On Sat, Oct 3, 2020 at 11:01 AM Pablo Escriva <pabloescri...@gmail.com> wrote:

[Pablo Escriva]

Hello Na,

Thank you for adding the new doc, very useful!

I went through the instructions to add the "Fill" OP to backend-wasm:

• First of all, the "Fill" operation already shows as supported in https://github.com/tensorflow/tfjs/blob/master/tfjs-converter/docs/supported_ops.md.
• Nevertheless, I continued the steps of your guide and realized that the Fill Op is already implemented in both tfjs-core and tfjs-backend-wasm.
  

However when I switch from webgl to wasm I get the "NotYetImplemented" error, so clearly I am missing something here. Could you please help me figure out what needs to be done to be able to use Fill in wasm?

Thanks in advance,

Pablo

[Na Li]

Hi Pablo,

Can you file a bug report here: https://github.com/tensorflow/tfjs/issues 

Also if you can attach any code that can help us reproduce the error will be great.

Na