MLIR on Windows?

[Vinod Grover]

Given that Tensorflow is available on Windows, I was wondering if there are any near term plans to port MIR to Windows?

 

Best

Vinod

 

---

This email message is for the sole use of the intended recipient(s) and may contain confidential information.  Any unauthorized review, use, disclosure or distribution is prohibited.  If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message.

---

[Mehdi AMINI]

Hi Vinod,

Yes we will have to align the supported platform for MLIR to what TensorFlow and LLVM are supporting. I don't have a precise timeline at this point, but I expect it to be done in the coming months.

Best,

-- 

Mehdi

--
You received this message because you are subscribed to the Google Groups "MLIR" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mlir+uns...@tensorflow.org.
To view this discussion on the web visit https://groups.google.com/a/tensorflow.org/d/msgid/mlir/MWHPR12MB1694052579FAC93259C6A332C52C0%40MWHPR12MB1694.namprd12.prod.outlook.com.

[loic...@sonarsource.com]

Hello,

Do you have any idea on how this support on windows would work? More specifically, do you intend to have it built by compilers other than clang (i.e. MsVC?)

Do you think there are any serious reasons that would make a windows version difficult to have? Or is this probably just a matter of testing and small adjustments? I'm asking because if it's the second, I might try to spend some time doing it...

--- 

Loïc Joly

[Jacques Pienaar]

Hey Loïc,

I believe it to be in the 2nd category. At least for clang, but for MSVC not sure as I haven't used it in more than a decade. It would be great if you could look at it and report back problems and we can work together on addressing them.

Thanks,

Jacques

--

You received this message because you are subscribed to the Google Groups "MLIR" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mlir+uns...@tensorflow.org.

To view this discussion on the web visit https://groups.google.com/a/tensorflow.org/d/msgid/mlir/d874cf45-be6e-4ad3-a9b3-9c8e63c183ec%40tensorflow.org.

[Chris Lattner]

We aspire to be buildable by whatever compilers are currently supported by the LLVM project.  I’m pretty sure that includes MSVC, but I don’t think we’ve tested it.

-Chris

To view this discussion on the web visit https://groups.google.com/a/tensorflow.org/d/msgid/mlir/CAM4W%2BYfJxXXpua%3D5P9HDkQhD29xsRP7HJAaoWJAcd60gtktWVA%40mail.gmail.com.

[loic...@sonarsource.com]

Hello,

I just successfully build MLIR with visual studio. I'm now trying to understand why some tests are failing (or why they are working currently :) ). I had to make several changes in the code to achieve that. Some seem legit to me, some are a little bit more hackish... . I read that you are not yet ready to accept community contribution, but if you want to, I can make those changes available to you anyways, just tell me the preferred way.

--- 

Loïc

[Jacques Pienaar]

Hey Loic,

Thats great that you have it working (modulo tests failing* ;-)). Have you signed the Google CLA? (https://cla.developers.google.com/). Post that I think it would be easier to discuss (creating a PR is an option by way of showing the problems that needed to be address).

Thanks,

Jacques

* I know of one test currently failing externally (issue 17) that we have fixed internally but we haven't pushed that out yet, but may later today.

--
You received this message because you are subscribed to the Google Groups "MLIR" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mlir+uns...@tensorflow.org.

To view this discussion on the web visit https://groups.google.com/a/tensorflow.org/d/msgid/mlir/cb55ea3f-ee0f-444e-ae33-a42d4b65a61a%40tensorflow.org.

[loic...@sonarsource.com]

Maybe someone can help me on this one: https://github.com/tensorflow/mlir/blob/master/test/AffineOps/canonicalize.mlir contains: 

// RUN: mlir-opt %s -split-input-file -canonicalize

When I run it, I have the error:

mlir-opt.exe: Unknown command line argument '-canonicalize'.  Try: 'C:\Dev\llvm-project\build\release\bin\mlir-opt.exe -help'

I looked into mlir-opt, and I could not see any option looking like canonicalize

Any idea?

---

Loïc

To unsubscribe from this group and stop receiving emails from it, send an email to ml...@tensorflow.org.

[Alex Zinenko]

Looks like the library containing the canonicalization pass did not get linked into mlir-opt binary.  MLIR passes are attached at link time using static initializers, so you may need to forcibly link pass libraries beacuse there are no symbols used by mlir-opt that belong to those libraries

To unsubscribe from this group and stop receiving emails from it, send an email to mlir+uns...@tensorflow.org.
To view this discussion on the web visit https://groups.google.com/a/tensorflow.org/d/msgid/mlir/75e1274d-a157-4f0c-a43b-c9538ccc7e3c%40tensorflow.org.

--

-- Alex

[Jacques Pienaar]

Yes the whole_archive_link rule in https://github.com/tensorflow/mlir/blob/master/CMakeLists.txt might need to be updated for windows.

-- Jacques

To view this discussion on the web visit https://groups.google.com/a/tensorflow.org/d/msgid/mlir/CAPL655hbzK2bF%3DWOu22Tbh8_btnEkWte0KsdUWun7JnKr1h%3DeA%40mail.gmail.com.

[loic...@sonarsource.com]

Thank you, I updated the whole_archive_link rule, and it now has many more options :)

Next step: -emit=ast generates an AST with windows paths, that is then compared to unix paths, which obviously fails... I'm not sure how to approach this. I've seen some use of {{[/\\]}} in some test cases of LLVM, but it seems overly verbose... Maybe the best would be to canonicalize the path during -emit=ast? Any opinion there?

To view this discussion on the web visit https://groups.google.com/a/tensorflow.org/d/msgid/mlir/75e1274d-a157-4f0c-a43b-c9538ccc7e3c%40tensorflow.org.

--

-- Alex

--
You received this message because you are subscribed to the Google Groups "MLIR" group.

To unsubscribe from this group and stop receiving emails from it, send an email to ml...@tensorflow.org.

To view this discussion on the web visit https://groups.google.com/a/tensorflow.org/d/msgid/mlir/CAPL655hbzK2bF%3DWOu22Tbh8_btnEkWte0KsdUWun7JnKr1h%3DeA%40mail.gmail.com.

[Mehdi AMINI]

Ah, that's the Toy tutorial right?

If you have a way to canonicalize the path to use the Unix syntax it would be nice. Maybe some utilities in LLVM Support can do this?

-- 

Mehdi

To unsubscribe from this group and stop receiving emails from it, send an email to mlir+uns...@tensorflow.org.
To view this discussion on the web visit https://groups.google.com/a/tensorflow.org/d/msgid/mlir/2c5e52b7-5447-4404-966c-101ec22951a1%40tensorflow.org.

[loic...@sonarsource.com]

Yes, that was only needed for the toy tutorial. I did it manually, replacing '\' with '/'. 4 of the 5 toy tests now work correctly. Unfortunately, other tests have issues that are not so easy to find, especially when you don't know what is the expected output...

As it is now, when I run the check-mlir target in release mode, I have 116 successful tests, and 25 failures.

I also have issues with the debug builds, I'm not sure exactly why... It looks like the issue on static object being removed applies also for command line option, while they work in release mode... :(

Anyway, I made a PR with my changes, you can have a look at it: https://github.com/tensorflow/mlir/pull/22 (if you prefer that I create a pull request local to my fork, tell me so, I will change it).

To view this discussion on the web visit https://groups.google.com/a/tensorflow.org/d/msgid/mlir/2c5e52b7-5447-4404-966c-101ec22951a1%40tensorflow.org.

[loic...@sonarsource.com]

Did the colleague who wanted to work on the windows port have time to look at my PR to see if it can help him?

I must put this on hold for now, but may come back to it in one week...

[Lei Zhang]

Hi Loïc, I'll take a look of building MLIR on Windows. Much appreciated for your PR; it definitely helps! :)

Thanks,

Lei

To unsubscribe from this group and stop receiving emails from it, send an email to mlir+uns...@tensorflow.org.
To view this discussion on the web visit https://groups.google.com/a/tensorflow.org/d/msgid/mlir/ad5c0fe5-f4e8-44ed-aa62-f45e4f19f484%40tensorflow.org.

[ming]

Hello,After I build MLIR with visua studio 2019,I can't find bin directory under build directory.can you help me?

[Jacques Pienaar]

Hey,

Via bazel https://docs.bazel.build/versions/master/output_directories.html shows the main directories where output is generated (if you build one cc_binary target bazel reports the full path too). If you are referring to building the part in LLVM via cmake, those tend to end up in tools dir under the build directory (but I haven't build on windows there).

It would help if you said what target your are building and how.

-- Jacques

--
You received this message because you are subscribed to the Google Groups "MLIR" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mlir+uns...@tensorflow.org.

To view this discussion on the web visit https://groups.google.com/a/tensorflow.org/d/msgid/mlir/0eae6250-ec1f-4032-b0a6-d68ee3fe50e2o%40tensorflow.org.