Issue 14163 in skia: 2023 O4 - KR4 - Use standard Skia facilities for remote glyph cache serialization

5 views
Skip to first unread message

h… via monorail

unread,
Mar 6, 2023, 11:09:08 AM3/6/23
to bu...@skia.org
Status: Accepted
Owner: he...@google.com
CC: brian...@google.com
Priority: Medium
Type: Defect

New issue 14163 by he...@google.com: 2023 O4 - KR4 - Use standard Skia facilities for remote glyph cache serialization
https://bugs.chromium.org/p/skia/issues/detail?id=14163

Use the standard Skia serialization API for serializing OOP-R font data.

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

h… via monorail

unread,
Mar 6, 2023, 11:13:44 AM3/6/23
to bu...@skia.org

Comment #1 on issue 14163 by he...@google.com: 2023 O4 - KR4 - Use standard Skia facilities for remote glyph cache serialization
https://bugs.chromium.org/p/skia/issues/detail?id=14163#c1

For the first pass I'm going to keep the API the same:
SK_SPI void writeStrikeData(std::vector<uint8_t>* memory);

The code will just copy the SkWriteBuffer to the vector.

I will put the implementation behind the flag:
SK_SUPPORT_LEGACY_STRIKE_SERIALIZATION

Git Watcher via monorail

unread,
Mar 6, 2023, 12:41:07 PM3/6/23
to bu...@skia.org

Comment #2 on issue 14163 by Git Watcher: 2023 O4 - KR4 - Use standard Skia facilities for remote glyph cache serialization
https://bugs.chromium.org/p/skia/issues/detail?id=14163#c2

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/03a17d0557a766498718f3ee0d6ecb8d6baeb07f

commit 03a17d0557a766498718f3ee0d6ecb8d6baeb07f
Author: Herb Derby <he...@google.com>
Date: Mon Mar 06 17:40:17 2023

Add a flag for legacy strike serialization to SkUserConfig.h

Add the flag SK_SUPPORT_LEGACY_STRIKE_SERIALIZATION to continue using
the std::vector based strike serialization while updating Skia to use
the SkWriteBuffer serialization system.

Bug: skia:14163
Change-Id: Id4f8e3f81c7d4db52ef0d73f62e5fe0eb0a53ed3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4307324
Auto-Submit: Herb Derby <he...@google.com>
Reviewed-by: Brian Osman <brian...@google.com>
Commit-Queue: Brian Osman <brian...@google.com>
Cr-Commit-Position: refs/heads/main@{#1113437}

[modify] https://crrev.com/03a17d0557a766498718f3ee0d6ecb8d6baeb07f/skia/config/SkUserConfig.h

Git Watcher via monorail

unread,
Mar 6, 2023, 12:43:05 PM3/6/23
to bu...@skia.org

Comment #3 on issue 14163 by Git Watcher: 2023 O4 - KR4 - Use standard Skia facilities for remote glyph cache serialization
https://bugs.chromium.org/p/skia/issues/detail?id=14163#c3


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/2999c4be3d0dc11309d0134ff4ff68ffe3c68ff6

commit 2999c4be3d0dc11309d0134ff4ff68ffe3c68ff6
Author: Herb Derby <he...@google.com>
Date: Mon Mar 06 16:32:07 2023

Strike Serialization: Add guard flags to start new work

Make an stump routines for new code guarded by
SK_SUPPORT_LEGACY_STRIKE_SERIALIZATION.

This corresponds to the Chromium CL:
https://chromium-review.git.corp.google.com/c/chromium/src/+/4307324

Bug: skia:14163
Change-Id: Ifff277930996eb601371b51088760ff58f46b447
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/652697
Reviewed-by: Brian Osman <brian...@google.com>
Commit-Queue: Herb Derby <he...@google.com>

[modify] https://crrev.com/2999c4be3d0dc11309d0134ff4ff68ffe3c68ff6/src/core/SkChromeRemoteGlyphCache.cpp

Git Watcher via monorail

unread,
Mar 6, 2023, 2:40:13 PM3/6/23
to bu...@skia.org

Comment #4 on issue 14163 by Git Watcher: 2023 O4 - KR4 - Use standard Skia facilities for remote glyph cache serialization
https://bugs.chromium.org/p/skia/issues/detail?id=14163#c4


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/3e38c84ce48e931637f34438ef423eb0dd9218ca

commit 3e38c84ce48e931637f34438ef423eb0dd9218ca
Author: Herb Derby <he...@google.com>
Date: Mon Mar 06 18:31:07 2023

Remove old Slug Conversion code

Remove old code that is no longer used. It was
bridge code before the remote cache could be used
to convert slugs. That upgrade has happened, and the
old code is no longer needed.

I checked for the flag SK_SUPPORT_LEGACY_SLUG_CONVERT
using Brian's tool, and there were no instances of it.

Bug: skia:14163
Change-Id: Ica207cdf86cabaf3f1b1ae5e32b9d05c98445dde
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/652756
Reviewed-by: Robert Phillips <robertp...@google.com>
Commit-Queue: Herb Derby <he...@google.com>

[modify] https://crrev.com/3e38c84ce48e931637f34438ef423eb0dd9218ca/src/core/SkChromeRemoteGlyphCache.cpp

Git Watcher via monorail

unread,
Mar 7, 2023, 9:14:06 AM3/7/23
to bu...@skia.org

Comment #5 on issue 14163 by Git Watcher: 2023 O4 - KR4 - Use standard Skia facilities for remote glyph cache serialization
https://bugs.chromium.org/p/skia/issues/detail?id=14163#c5


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/372c79bbcd95719888ecb1d7ac64768edcba0940

commit 372c79bbcd95719888ecb1d7ac64768edcba0940
Author: Herb Derby <he...@google.com>
Date: Mon Mar 06 21:44:22 2023

Remove remote_demo

The remote_demo app was a test bed before the Chrome
Remote cache was put into Chrome. I don't think it has
been used in 2 years.

Bug: skia:14163
Change-Id: Id6947e722b77fc09b277b6894c3709ff357da01a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/652419
Commit-Queue: Herb Derby <he...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>

[modify] https://crrev.com/372c79bbcd95719888ecb1d7ac64768edcba0940/BUILD.gn
[delete] https://crrev.com/5ff6641713763d648e06581f3b71a958d6c4a307/tools/remote_demo.cpp

Git Watcher via monorail

unread,
Mar 7, 2023, 12:41:18 PM3/7/23
to bu...@skia.org

Comment #6 on issue 14163 by Git Watcher: 2023 O4 - KR4 - Use standard Skia facilities for remote glyph cache serialization
https://bugs.chromium.org/p/skia/issues/detail?id=14163#c6


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/dc7545310d7e448e221dcf98a00fe7dc068fc66b

commit dc7545310d7e448e221dcf98a00fe7dc068fc66b
Author: Herb Derby <he...@google.com>
Date: Tue Mar 07 16:47:19 2023

Remove unused flag manipulated Slug testing

These testing modes have been moved to DM, and have no more
use.

Bug: skia:14163
Change-Id: I0aea262cd5d06803bcc59c22e4346f83fb4c1bbf
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/653216

Commit-Queue: Herb Derby <he...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>

Git Watcher via monorail

unread,
Mar 7, 2023, 12:46:07 PM3/7/23
to bu...@skia.org

Comment #7 on issue 14163 by Git Watcher: 2023 O4 - KR4 - Use standard Skia facilities for remote glyph cache serialization
https://bugs.chromium.org/p/skia/issues/detail?id=14163#c7


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/36d1215ca0f3e98e17704e2e332792adb5cc3e36

commit 36d1215ca0f3e98e17704e2e332792adb5cc3e36
Author: Herb Derby <he...@google.com>
Date: Tue Mar 07 17:05:08 2023

Move parts of API to testing for remote cache

Some parts of the remote cache API are for testing only.
Label the forTest, and remove their names from linking
with Chromium by removing SK_SPI.

Bug: skia:14163
Change-Id: I6c3707f6f3d2d4a5021c4e022b23d1791c0a09b0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/653217

Commit-Queue: Herb Derby <he...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>

Git Watcher via monorail

unread,
Mar 7, 2023, 4:15:06 PM3/7/23
to bu...@skia.org

Comment #8 on issue 14163 by Git Watcher: 2023 O4 - KR4 - Use standard Skia facilities for remote glyph cache serialization
https://bugs.chromium.org/p/skia/issues/detail?id=14163#c8


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/7b18d6c5c676abcb274a8dc6b2896c8c2f667a63

commit 7b18d6c5c676abcb274a8dc6b2896c8c2f667a63
Author: Herb Derby <he...@google.com>
Date: Tue Mar 07 19:56:06 2023

Experiment with simpler test API

The serializeTypefaceForTest API on SkStrikeServer has a lot
of machinery that is unused by the remote cache system.

Experiment with a simpler API for tracking typefaces through
the tests. Just remember the unique ID for the server typeface
and use that to look up the client typeface ID after
deserializing the strike changes.

Remove the test SkRemoteGlyphCache_TypefaceSerialization because
it exercises a part of the API that should never be used by
clients. Move the important part to
SkRemoteGlyphCache_StrikeSerialization.

Bug: skia:14163
Change-Id: Ic7858156b9d632a8a7ae22f075673f38a7a508ff
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/653279

Commit-Queue: Herb Derby <he...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>

Git Watcher via monorail

unread,
Mar 8, 2023, 11:06:08 AM3/8/23
to bu...@skia.org

Comment #9 on issue 14163 by Git Watcher: 2023 O4 - KR4 - Use standard Skia facilities for remote glyph cache serialization
https://bugs.chromium.org/p/skia/issues/detail?id=14163#c9


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/bc3e02fc68b3c614a4383e87f960b5575d3742b3

commit bc3e02fc68b3c614a4383e87f960b5575d3742b3
Author: Herb Derby <he...@google.com>
Date: Tue Mar 07 22:25:03 2023

Use new Typeface API for Remote Cache testing

Update all the tests to use the new testing methods, and
remove all the old testing APIs.

Bug: skia:14163
Change-Id: Ib195c7121a8ea3978d03561456cbec1db60ec814
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/653281

Reviewed-by: Robert Phillips <robertp...@google.com>
Commit-Queue: Herb Derby <he...@google.com>

Git Watcher via monorail

unread,
Mar 9, 2023, 3:03:04 PM3/9/23
to bu...@skia.org

Comment #10 on issue 14163 by Git Watcher: 2023 O4 - KR4 - Use standard Skia facilities for remote glyph cache serialization
https://bugs.chromium.org/p/skia/issues/detail?id=14163#c10


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/c21fe6f7293d49f6c4d19b582209055b2570a792

commit c21fe6f7293d49f6c4d19b582209055b2570a792
Author: Herb Derby <he...@google.com>
Date: Thu Mar 09 17:26:51 2023

Stream SkFontMetrics

Write code for streaming SkFontMetrics. Add basic tests.

Bug: skia:14163
Change-Id: I81b2caa5d32c6c905e70dbaf1d96d536ccedbbf8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/654536

Commit-Queue: Herb Derby <he...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>

Git Watcher via monorail

unread,
Mar 13, 2023, 10:44:07 AM3/13/23
to bu...@skia.org

Comment #11 on issue 14163 by Git Watcher: 2023 O4 - KR4 - Use standard Skia facilities for remote glyph cache serialization
https://bugs.chromium.org/p/skia/issues/detail?id=14163#c11


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/289a43b0a3fe35fff80edf7c2f169b35cd826c92

commit 289a43b0a3fe35fff80edf7c2f169b35cd826c92
Author: Herb Derby <he...@google.com>
Date: Fri Mar 10 20:07:12 2023

Add SkTypefaceProxy serialization

Introduce SkTypefaceProxyPrototype that represents the
serialized form of SkTypefaceProxy. Add a basic test to
make sure it all works.

Move SkTypefaceProxy ctor implementation to .cpp.

Bug: skia:14163
Change-Id: I715b5042b2f308c9c9ef557caa94ea9fc749f8f9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/654543
Reviewed-by: Ben Wagner <bung...@google.com>
Commit-Queue: Herb Derby <he...@google.com>

[modify] https://crrev.com/289a43b0a3fe35fff80edf7c2f169b35cd826c92/include/core/SkFontStyle.h
[modify] https://crrev.com/289a43b0a3fe35fff80edf7c2f169b35cd826c92/src/core/SkTypeface_remote.cpp
[modify] https://crrev.com/289a43b0a3fe35fff80edf7c2f169b35cd826c92/src/core/SkTypeface_remote.h
[modify] https://crrev.com/289a43b0a3fe35fff80edf7c2f169b35cd826c92/include/core/SkTypeface.h
[modify] https://crrev.com/289a43b0a3fe35fff80edf7c2f169b35cd826c92/toolchain/linux_trampolines/IWYU_mapping.imp
[modify] https://crrev.com/289a43b0a3fe35fff80edf7c2f169b35cd826c92/tests/SkRemoteGlyphCacheTest.cpp

Git Watcher via monorail

unread,
Mar 16, 2023, 5:04:04 PM3/16/23
to bu...@skia.org

Comment #12 on issue 14163 by Git Watcher: 2023 O4 - KR4 - Use standard Skia facilities for remote glyph cache serialization
https://bugs.chromium.org/p/skia/issues/detail?id=14163#c12


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/562cc981238bb8d3ddbb5a97100844d3751476f9

commit 562cc981238bb8d3ddbb5a97100844d3751476f9
Author: Herb Derby <he...@google.com>
Date: Thu Mar 16 19:05:02 2023

Add serialization to SkGlyph

All the glyph serialization was baked into the chrome remote glyph
cache. Pull it out, clean it up, and test it.

Bug: skia:14163
Change-Id: I5d3cdf52d29569e6c83e1535ce259863322dd748
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/657717
Reviewed-by: Robert Phillips <robertp...@google.com>
Commit-Queue: Herb Derby <he...@google.com>

[modify] https://crrev.com/562cc981238bb8d3ddbb5a97100844d3751476f9/tests/SkGlyphTest.cpp
[modify] https://crrev.com/562cc981238bb8d3ddbb5a97100844d3751476f9/src/core/SkGlyph.cpp
[modify] https://crrev.com/562cc981238bb8d3ddbb5a97100844d3751476f9/src/core/SkGlyph.h

Git Watcher via monorail

unread,
Mar 20, 2023, 5:53:05 PM3/20/23
to bu...@skia.org

Comment #13 on issue 14163 by Git Watcher: 2023 O4 - KR4 - Use standard Skia facilities for remote glyph cache serialization
https://bugs.chromium.org/p/skia/issues/detail?id=14163#c13


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/e476fa36680620f033c26d44808dec578b9b7bc1

commit e476fa36680620f033c26d44808dec578b9b7bc1
Author: Herb Derby <he...@google.com>
Date: Mon Mar 20 19:37:17 2023

Update test to check buffer state

Fix the logic detecting an empty picture which breaks the buffer
state. The state of the readBuffer after reading the glyph should
be valid.

Bug: skia:14163

Change-Id: I850eb2fedd3eadde17670eea6a6124cf5f1380f1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/658918

Commit-Queue: Herb Derby <he...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>

Git Watcher via monorail

unread,
Mar 21, 2023, 11:46:09 AM3/21/23
to bu...@skia.org

Comment #14 on issue 14163 by Git Watcher: 2023 O4 - KR4 - Use standard Skia facilities for remote glyph cache serialization
https://bugs.chromium.org/p/skia/issues/detail?id=14163#c14


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/33d292833f8c91475ac9426c41c940763c3a15da

commit 33d292833f8c91475ac9426c41c940763c3a15da
Author: Herb Derby <he...@google.com>
Date: Tue Mar 21 13:04:27 2023

Add test for a glyph's signed top left values

Add test to highlight a bug handling the signed values
of the top left offset. Fix the bug by being careful with
sign extension.

Bug: skia:14163
Change-Id: I80e512fa9466cc54944af312ef53cba8c46ff4ca
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/659297

Reviewed-by: Robert Phillips <robertp...@google.com>
Commit-Queue: Herb Derby <he...@google.com>

Git Watcher via monorail

unread,
Mar 22, 2023, 10:46:06 AM3/22/23
to bu...@skia.org

Comment #15 on issue 14163 by Git Watcher: 2023 O4 - KR4 - Use standard Skia facilities for remote glyph cache serialization
https://bugs.chromium.org/p/skia/issues/detail?id=14163#c15


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/7052575122a68b43b90d95ab423349fd794a2ba0

commit 7052575122a68b43b90d95ab423349fd794a2ba0
Author: Herb Derby <he...@google.com>
Date: Tue Mar 21 14:14:14 2023

Add bulk glyph serialization to strikes

Add methods to serialize and deserialize the three glyph types:
mask(image), path, and drawable.

Bug: skia:14163
Change-Id: I2b8b48e8ffac7d59b5ee3446a5b944552e9ee023
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/659717

Reviewed-by: Robert Phillips <robertp...@google.com>
Commit-Queue: Herb Derby <he...@google.com>

Git Watcher via monorail

unread,
Mar 22, 2023, 11:11:09 AM3/22/23
to bu...@skia.org

Comment #16 on issue 14163 by Git Watcher: 2023 O4 - KR4 - Use standard Skia facilities for remote glyph cache serialization
https://bugs.chromium.org/p/skia/issues/detail?id=14163#c16


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/90f653a7233ead5d7b648b1eb360b725987a85a8

commit 90f653a7233ead5d7b648b1eb360b725987a85a8
Author: Herb Derby <he...@google.com>
Date: Wed Mar 22 14:08:40 2023

Check the buffer state carefully after reads

Make sure to check the state of the SkReadBuffer after every
read during the glyph serialization tests.

Bug: skia:14163
Change-Id: I6f7c61bd4e3e1076179fc40f524bbc21e6b7c873
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/660019

Reviewed-by: Robert Phillips <robertp...@google.com>
Commit-Queue: Herb Derby <he...@google.com>

Git Watcher via monorail

unread,
Mar 22, 2023, 12:05:06 PM3/22/23
to bu...@skia.org

Comment #17 on issue 14163 by Git Watcher: 2023 O4 - KR4 - Use standard Skia facilities for remote glyph cache serialization
https://bugs.chromium.org/p/skia/issues/detail?id=14163#c17


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/ab43a068fc0d416393fa840f033e8f636048dee0

commit ab43a068fc0d416393fa840f033e8f636048dee0
Author: Herb Derby <he...@google.com>
Date: Wed Mar 22 15:04:11 2023

For path, validate flow control variable hasPath

If hasPath is false on invalid data, then the empty path
would be set. This situation should leave the path unset.

Bug: skia:14163
Change-Id: Ib5bbea1f12738adbc26bc51addca8269b15b2339
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/660216

Commit-Queue: Herb Derby <he...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>

Git Watcher via monorail

unread,
Mar 22, 2023, 2:08:10 PM3/22/23
to bu...@skia.org

Comment #18 on issue 14163 by Git Watcher: 2023 O4 - KR4 - Use standard Skia facilities for remote glyph cache serialization
https://bugs.chromium.org/p/skia/issues/detail?id=14163#c18


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/1f9c0ee23ce76b77e79923ac30009f7803d1d4f0

commit 1f9c0ee23ce76b77e79923ac30009f7803d1d4f0
Author: Herb Derby <he...@google.com>
Date: Wed Mar 08 18:06:21 2023

Add Skia buffer based serialization to SkChromeRemoteGlyphCache

Add the top level of the Skia based serialization code. This
is tested by the existing remote glyph cache unit tests.

The two serialization systems, the std::vector and the skia based,
are controlled by the flag:
SK_SUPPORT_LEGACY_STRIKE_SERIALIZATION

This CL keeps the old system as the default, but his will change
soon.

Add a bunch of #if defined to keep the compiler happy.

Bug: skia:14163
Change-Id: I1f2b709b713ed2addba2b7bf025f84a8629275f5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/656238

Commit-Queue: Herb Derby <he...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>

Git Watcher via monorail

unread,
Mar 22, 2023, 2:57:22 PM3/22/23
to bu...@skia.org

Comment #19 on issue 14163 by Git Watcher: 2023 O4 - KR4 - Use standard Skia facilities for remote glyph cache serialization
https://bugs.chromium.org/p/skia/issues/detail?id=14163#c19


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/4f1cae66791c60dc6584f6cecbd58c533965a7ac

commit 4f1cae66791c60dc6584f6cecbd58c533965a7ac
Author: Herb Derby <he...@google.com>
Date: Wed Mar 22 17:03:56 2023

Flip flag to use new remote cache serialization

Bug: skia:14163
Change-Id: Ib00b959b68b3fe215a7398d004f634ba3dc2f7ce
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/660376

Reviewed-by: Robert Phillips <robertp...@google.com>
Commit-Queue: Herb Derby <he...@google.com>

Git Watcher via monorail

unread,
Mar 27, 2023, 12:53:05 PM3/27/23
to bu...@skia.org

Comment #20 on issue 14163 by Git Watcher: 2023 O4 - KR4 - Use standard Skia facilities for remote glyph cache serialization
https://bugs.chromium.org/p/skia/issues/detail?id=14163#c20


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/8192bafd43075d321b096f42e1d0b338f20466a9

commit 8192bafd43075d321b096f42e1d0b338f20466a9
Author: Herb Derby <he...@google.com>
Date: Mon Mar 27 16:52:35 2023

Enable the new streaming code

Remove SK_SUPPORT_LEGACY_STRIKE_SERIALIZATION from Skia's config.

Testing:
Built Chrome, and tried several sites:
Google Search
New York Times
Wikipedia entry for cat in English, Thai, and Chinese
news.cn
espn

There were no serialization errors logged in chrome://gpu

Bug: skia:14163
Change-Id: If89e1d401e12eb8f27d006429ae82e11938d0e4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4374637
Commit-Queue: Herb Derby <he...@google.com>
Reviewed-by: Brian Osman <brian...@google.com>
Cr-Commit-Position: refs/heads/main@{#1122475}

[modify] https://crrev.com/8192bafd43075d321b096f42e1d0b338f20466a9/skia/config/SkUserConfig.h

h… via monorail

unread,
Apr 6, 2023, 11:24:04 AM4/6/23
to bu...@skia.org
Updates:
Status: Fixed

Comment #21 on issue 14163 by he...@google.com: 2023 O4 - KR4 - Use standard Skia facilities for remote glyph cache serialization
https://bugs.chromium.org/p/skia/issues/detail?id=14163#c21

(No comment was entered for this change.)

Git Watcher via monorail

unread,
Jul 24, 2023, 3:29:08 PM7/24/23
to bu...@skia.org

Comment #22 on issue 14163 by Git Watcher: 2023 O4 - KR4 - Use standard Skia facilities for remote glyph cache serialization
https://bugs.chromium.org/p/skia/issues/detail?id=14163#c22


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/6c93070215c8c614194ed3a17138f30288f2a1a3

commit 6c93070215c8c614194ed3a17138f30288f2a1a3
Author: Kevin Lubick <kjlu...@google.com>
Date: Mon Jul 24 15:10:35 2023

Remove code guarded by SK_SUPPORT_LEGACY_STRIKE_SERIALIZATION

This landed in https://crrev.com/c/4374637 and was not reverted in
the months since.

Change-Id: I63e2fa3f657cdc1be3ae54c2c8896c3196e99c30
Bug: skia:14163
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/728698
Reviewed-by: Brian Osman <brian...@google.com>
Commit-Queue: Kevin Lubick <kjlu...@google.com>

[modify] https://crrev.com/6c93070215c8c614194ed3a17138f30288f2a1a3/src/core/SkChromeRemoteGlyphCache.cpp

Git Watcher via monorail

unread,
Jul 25, 2023, 9:57:16 AM7/25/23
to bu...@skia.org

Comment #23 on issue 14163 by Git Watcher: 2023 O4 - KR4 - Use standard Skia facilities for remote glyph cache serialization
https://bugs.chromium.org/p/skia/issues/detail?id=14163#c23


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/f7a829a5bfed04f318fdd2220a89ebd5929f8eb0

commit f7a829a5bfed04f318fdd2220a89ebd5929f8eb0
Author: Kevin Lubick <kjlu...@google.com>
Date: Tue Jul 25 13:56:36 2023

Remove reference to SK_SUPPORT_LEGACY_STRIKE_SERIALIZATION

This was removed in https://skia-review.googlesource.com/c/skia/+/728698

Bug: skia:14163
Change-Id: I6288a89e9a9ce658667ccac95dedd3c8b15343e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4713036
Auto-Submit: Kevin Lubick <kjlu...@chromium.org>
Reviewed-by: Brian Osman <brian...@google.com>
Commit-Queue: Brian Osman <brian...@google.com>
Cr-Commit-Position: refs/heads/main@{#1174811}

[modify] https://crrev.com/f7a829a5bfed04f318fdd2220a89ebd5929f8eb0/skia/config/SkUserConfig.h
Reply all
Reply to author
Forward
0 new messages