Issue 12890 in skia: Include SKQP in android CTS

14 views
Skip to first unread message

nif… via monorail

unread,
Feb 1, 2022, 1:25:36 PM2/1/22
to bu...@skia.org
Status: Accepted
Owner: nif...@google.com
Priority: Medium
Type: Defect

New issue 12890 by nif...@google.com: Include SKQP in android CTS
https://bugs.chromium.org/p/skia/issues/detail?id=12890

Get the APK working correctly
revive the build files that would allow it to be in CTS
Inform CTS team of it's new location.

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Git Watcher via monorail

unread,
Feb 9, 2022, 11:27:05 AM2/9/22
to bu...@skia.org

Comment #1 on issue 12890 by Git Watcher: Include SKQP in android CTS
https://bugs.chromium.org/p/skia/issues/detail?id=12890#c1

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/43c5837e1bb8a36daaeed9d2807f6d51ed175e77

commit 43c5837e1bb8a36daaeed9d2807f6d51ed175e77
Author: Nathaniel Nifong <nif...@google.com>
Date: Tue Feb 01 18:28:48 2022

Do not assert a nonzero number of GMs or unit tests in skqp

Bug: skia:12890
Change-Id: Iba42248fdc673a6f0fd44251841749065dd12483
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/502700
Reviewed-by: Derek Sollenberger <djso...@google.com>
Commit-Queue: Nathaniel Nifong <nif...@google.com>

[modify] https://crrev.com/43c5837e1bb8a36daaeed9d2807f6d51ed175e77/tools/skqp/src/jni_skqp.cpp

Git Watcher via monorail

unread,
Feb 11, 2022, 1:53:53 PM2/11/22
to bu...@skia.org

Comment #2 on issue 12890 by Git Watcher: Include SKQP in android CTS
https://bugs.chromium.org/p/skia/issues/detail?id=12890#c2


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/0d36473ebc04f181ef9b2abf6e0e1d464775d206

commit 0d36473ebc04f181ef9b2abf6e0e1d464775d206
Author: Nathaniel Nifong <nif...@google.com>
Date: Thu Feb 10 20:43:00 2022

Add android build files for skqp cts testing

Bug: skia:12890
Change-Id: I44dde188b7b7daf1c6e5c718b6b2874bbc28510d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/506459

Reviewed-by: Derek Sollenberger <djso...@google.com>
Commit-Queue: Nathaniel Nifong <nif...@google.com>

Git Watcher via monorail

unread,
Feb 11, 2022, 3:49:06 PM2/11/22
to bu...@skia.org

Comment #3 on issue 12890 by Git Watcher: Include SKQP in android CTS
https://bugs.chromium.org/p/skia/issues/detail?id=12890#c3


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/007fd156a0330db394566701e83b6960ab8e77ab

commit 007fd156a0330db394566701e83b6960ab8e77ab
Author: Derek Sollenberger <djso...@google.com>
Date: Fri Feb 11 20:08:47 2022

Fix SkQP errors when built in the Android framework.

Bug: skia:12890
Change-Id: I81ab3c883fc085d02ff6984c799f2e7d840f7a1d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/507916
Auto-Submit: Derek Sollenberger <djso...@google.com>
Reviewed-by: Leon Scroggins <scr...@google.com>
Commit-Queue: Leon Scroggins <scr...@google.com>
Reviewed-by: Nathaniel Nifong <nif...@google.com>
Commit-Queue: Nathaniel Nifong <nif...@google.com>

[modify] https://crrev.com/007fd156a0330db394566701e83b6960ab8e77ab/platform_tools/android/apps/skqp/src/main/java/org/skia/skqp/SkQPActivity.java

nif… via monorail

unread,
Feb 24, 2022, 9:37:45 AM2/24/22
to bu...@skia.org

nif… via monorail

unread,
Mar 9, 2022, 9:34:07 AM3/9/22
to bu...@skia.org

Comment #5 on issue 12890 by nif...@google.com: Include SKQP in android CTS
https://bugs.chromium.org/p/skia/issues/detail?id=12890#c5

it is now in the CTS suite, and running in postsubmit, but not yet in the presubmit of skia

There are some Qualcomm devices that don't pass without workarounds
https://b.corp.google.com/issues/222736702

nif… via monorail

unread,
Mar 10, 2022, 9:27:40 AM3/10/22
to bu...@skia.org
Updates:
Status: Fixed

Comment #6 on issue 12890 by nif...@google.com: Include SKQP in android CTS
https://bugs.chromium.org/p/skia/issues/detail?id=12890#c6

(No comment was entered for this change.)
Reply all
Reply to author
Forward
0 new messages