Issue 14631 in skia: Triaged images reported as untriaged in post submit

[katel… via monorail]

Status: Accepted
Owner: katel...@google.com
Components: Gold
Priority: Medium
Type: Defect

New issue 14631 by katel...@google.com: Triaged images reported as untriaged in post submit
https://bugs.chromium.org/p/skia/issues/detail?id=14631

From flakes reported in https://github.com/flutter/flutter/issues/130911

The following builds (occurring around the same time ~4:30 AM CDT 7/14/23) failed in post submit testing, reporting the images from the PR as untriaged. The images were triaged in presubmit before the change landed.

According to go/flutter-gold, the images were triaged ~2:30 AM CDT 7/14/23

Change in question: https://github.com/flutter/flutter/pull/130414
I thought this might be related to force pushes in the PR, maybe the wrong patchset was triaged? But we use an endpoint to check that images are triaged before a change can land via https://flutter-gold.skia.org/json/v1/changelist_summary/github/[PRNumber]

Example output from Gold in post submit:

03:06 +3587 ~22: /b/s/w/ir/x/w/flutter/packages/flutter/test/material/dialog_theme_test.dart: Material2 - Custom dialog shape matches golden
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following SkiaException was thrown while running async test code:
Skia Gold received an unapproved image in post-submit
testing. Golden file images in flutter/flutter are triaged
in pre-submit during code review for the given PR.

Visit https://flutter-gold.skia.org/ to view and approve
the image(s), or revert the associated change. For more
information, visit the wiki:
https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter

Debug information for Gold --------------------------------
stdout: Given image with hash ff0d6ff642e43b57aaaeaa0254911d33 for test
material.m2_dialog_theme.dialog_with_custom_border
Untriaged or negative image:
https://flutter-gold.skia.org/detail?grouping=name%3Dmaterial.m2_dialog_theme.dialog_with_custom_border%26source_type%3Dflutter&digest=ff0d6ff642e43b57aaaeaa0254911d33


stderr: Test: material.m2_dialog_theme.dialog_with_custom_border FAIL

Attachments:
Screenshot 2023-07-20 at 1.24.17 PM.png 77.0 KB

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

[kjlub… via monorail]

Updates:
Cc: katel...@google.com
Owner: kjlu...@google.com

Comment #1 on issue 14631 by kjlu...@google.com: Triaged images reported as untriaged in post submit
https://bugs.chromium.org/p/skia/issues/detail?id=14631#c1

Taking ownership. I'll check the database logs tomorrow AM