Issue 8272 in skia: Pref regression @a9660ec89bc79f90c6d705baf65336195ea52307 (Update ShouldUseAAA with our better complexity estimation)

[fmal… via monorail]

Status: New
Owner: liyu...@google.com
CC: fmal...@google.com, mtkl...@google.com
Labels: FromSkiaPerf
Priority: Medium
Type: Defect

New issue 8272 by fmal...@google.com: Pref regression @a9660ec89bc79f90c6d705baf65336195ea52307 (Update ShouldUseAAA with our better complexity estimation)
https://bugs.chromium.org/p/skia/issues/detail?id=8272

This bug was found via SkiaPerf.

Visit this URL to see the details of the suspicious cluster:

https://perf.skia.org/t/?begin=1533926304&end=1533926305&subset=all

The suspect commit is:

https://skia.googlesource.com/skia/+/a9660ec89bc79f90c6d705baf65336195ea52307

Looks real, if tiny?

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

[mtkl… via monorail]

Comment #1 on issue 8272 by mtkl...@google.com: Pref regression @a9660ec89bc79f90c6d705baf65336195ea52307 (Update ShouldUseAAA with our better complexity estimation)
https://bugs.chromium.org/p/skia/issues/detail?id=8272#c1

Bug fix, right? WAI?

[fmal… via monorail]

Updates:
Status: WontFix

Comment #2 on issue 8272 by fma...@chromium.org: Pref regression @a9660ec89bc79f90c6d705baf65336195ea52307 (Update ShouldUseAAA with our better complexity estimation)
https://bugs.chromium.org/p/skia/issues/detail?id=8272#c2

SG, just checking that it's not unexpected.

[liyuq… via monorail]

Comment #3 on issue 8272 by liyu...@google.com: Pref regression @a9660ec89bc79f90c6d705baf65336195ea52307 (Update ShouldUseAAA with our better complexity estimation)
https://bugs.chromium.org/p/skia/issues/detail?id=8272#c3

I'll download the SVG/SKPs and test it locally. (Since I changed my
Desktop, I lost those resources and didn't test them when I upload the
change.) Maybe there's something that I can improve.

[liyuq… via monorail]

Updates:
Status: Started

Comment #4 on issue 8272 by liyu...@google.com: Pref regression @a9660ec89bc79f90c6d705baf65336195ea52307 (Update ShouldUseAAA with our better complexity estimation)
https://bugs.chromium.org/p/skia/issues/detail?id=8272#c4

(No comment was entered for this change.)

[bugdro… via monorail]

Comment #5 on issue 8272 by bugd...@chromium.org: Pref regression @a9660ec89bc79f90c6d705baf65336195ea52307 (Update ShouldUseAAA with our better complexity estimation)
https://bugs.chromium.org/p/skia/issues/detail?id=8272#c5

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/04ccd72c1a24a57856f4a973ea43ea84be81c4f9

commit 04ccd72c1a24a57856f4a973ea43ea84be81c4f9
Author: Yuqian Li <liyu...@google.com>
Date: Tue Aug 28 18:41:16 2018

Further improve AA choice

Compared with current master:
1.26% faster in Seal_of_New_Hampshire.svg_1
1.90% faster in native_image_to_raster_surface
2.70% faster in Seal_of_Texas.svg_1
2.76% faster in WestVirginia-StateSeal.svg_1
2.80% faster in chart_aa
3.36% faster in Iowa-StateSeal.svg_1
3.44% faster in Seal_of_Illinois.svg_1
4.37% faster in Seal_of_Maryland_%28reverse%29.svg_1
4.64% faster in Minnesota-StateSeal.svg_1
5.06% faster in Seal_of_Tennessee.svg_1
16.76% faster in clip_strategy_path_100

Compared with the Skia without https://skia-review.googlesource.com/c/skia/+/146220
(no significant slowdowns for any SVGs)
4.69% slower in path_fill_big_rotated_rect_aa_45
2.50% slower in points
1.27% faster in native_image_to_raster_surface
1.39% faster in patch_square_meshlines_0.100000x0.100000
2.09% faster in path_hairline_big_noAA_line
2.62% faster in Seal_of_Maryland_%28reverse%29.svg_1
3.63% faster in rotated_rects_aa_alternating_transparent_and_opaque_darken
3.93% faster in zeroradroundrect
4.60% faster in rotated_rects_aa_same_transparent_darken
4.64% faster in ovals_1
4.73% faster in rotated_rects_aa_changing_opaque_darken
4.74% faster in rotated_rects_aa_changing_transparent_darken
5.01% faster in rotated_rects_aa_same_opaque_darken
5.07% faster in nested_aaclip_AA
6.06% faster in ovals_3
6.25% faster in dash_0_noclip
7.86% faster in rotated_rects_aa_same_transparent_src
7.86% faster in rotated_rects_aa_changing_transparent_src
9.31% faster in rrects_3
9.35% faster in rotated_rects_aa_alternating_transparent_and_opaque_src
10.95% faster in rotated_rects_aa_same_transparent_srcover
10.95% faster in rotated_rects_aa_changing_transparent_srcover
11.46% faster in rotated_rects_aa_alternating_transparent_and_opaque_srcover
11.90% faster in rotated_rects_aa_same_opaque_srcover
11.90% faster in rotated_rects_aa_changing_opaque_srcover
12.09% faster in rotated_rects_aa_same_opaque_src
12.13% faster in rotated_rects_aa_changing_opaque_src
20.89% faster in path_fill_small_triangle

Bug: skia:8272
Change-Id: Ic1434ea71660b0d3a7ddf1f63d098cfe7acfd861
Reviewed-on: https://skia-review.googlesource.com/149337
Auto-Submit: Yuqian Li <liyu...@google.com>
Commit-Queue: Mike Klein <mtk...@google.com>
Reviewed-by: Mike Klein <mtk...@google.com>

[modify] https://crrev.com/04ccd72c1a24a57856f4a973ea43ea84be81c4f9/src/core/SkScan_AntiPath.cpp

[brian… via monorail]

Updates:
Status: Obsolete

Comment #6 on issue 8272 by brian...@google.com: Pref regression @a9660ec89bc79f90c6d705baf65336195ea52307 (Update ShouldUseAAA with our better complexity estimation)
https://bugs.chromium.org/p/skia/issues/detail?id=8272#c6

(No comment was entered for this change.)