Issue 12466 in skia: Graphite sprint

250 views
Skip to first unread message

rober… via monorail

unread,
Sep 21, 2021, 1:26:35 PM9/21/21
to bu...@skia.org
Status: Accepted
Owner: rober...@google.com
CC: michae...@google.com, egda...@google.com, bsalo...@google.com, jvan...@google.com
Area: GPU
Priority: Medium
Type: Defect

New issue 12466 by rober...@google.com: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466

Quickly develop a Graphite prototype

This effort basically continues/preempts skbug.com/11837 (Investigate new architectural possibilities assuming a modern graphics API and hardware)

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Git Watcher via monorail

unread,
Sep 21, 2021, 4:29:10 PM9/21/21
to bu...@skia.org

Comment #1 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c1

The following revision refers to this bug:
https://skia.googlesource.com/skia/+/f15c3ff9d30ef7077c5217f83efd1b1311bbaa25

commit f15c3ff9d30ef7077c5217f83efd1b1311bbaa25
Author: Robert Phillips <robertp...@google.com>
Date: Tue Sep 21 19:34:36 2021

Add SkSurface_Graphite stub

and fix up the #include guards

Bug: skia:12466
Change-Id: I865ebb00827001b2cf0f7d871e872a7be0f36c22
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/451156
Commit-Queue: Robert Phillips <robertp...@google.com>
Reviewed-by: Greg Daniel <egda...@google.com>

[modify] https://crrev.com/f15c3ff9d30ef7077c5217f83efd1b1311bbaa25/gn/graphite.gni
[modify] https://crrev.com/f15c3ff9d30ef7077c5217f83efd1b1311bbaa25/experimental/graphite/src/SkStuff.cpp
[modify] https://crrev.com/f15c3ff9d30ef7077c5217f83efd1b1311bbaa25/experimental/graphite/include/Context.h
[add] https://crrev.com/f15c3ff9d30ef7077c5217f83efd1b1311bbaa25/experimental/graphite/src/Surface_Graphite.h
[add] https://crrev.com/f15c3ff9d30ef7077c5217f83efd1b1311bbaa25/experimental/graphite/src/Surface_Graphite.cpp
[modify] https://crrev.com/f15c3ff9d30ef7077c5217f83efd1b1311bbaa25/experimental/graphite/src/Device.h

Git Watcher via monorail

unread,
Sep 22, 2021, 12:00:09 PM9/22/21
to bu...@skia.org

Comment #2 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c2


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/5a6f1606cc6aaa9620fe2f892cf64055521ed85e

commit 5a6f1606cc6aaa9620fe2f892cf64055521ed85e
Author: Robert Phillips <robertp...@google.com>
Date: Tue Sep 21 20:34:35 2021

Add more stub classes

Bug: skia:12466
Change-Id: Iaa8431bf6fbe20c30b34a90a5a55f6f89723aa30
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/451257
Reviewed-by: Greg Daniel <egda...@google.com>
Commit-Queue: Robert Phillips <robertp...@google.com>

[modify] https://crrev.com/5a6f1606cc6aaa9620fe2f892cf64055521ed85e/gn/graphite.gni
[add] https://crrev.com/5a6f1606cc6aaa9620fe2f892cf64055521ed85e/experimental/graphite/src/Task.h
[add] https://crrev.com/5a6f1606cc6aaa9620fe2f892cf64055521ed85e/experimental/graphite/src/SurfaceDrawContext.cpp
[add] https://crrev.com/5a6f1606cc6aaa9620fe2f892cf64055521ed85e/experimental/graphite/src/SDCTask.h
[add] https://crrev.com/5a6f1606cc6aaa9620fe2f892cf64055521ed85e/experimental/graphite/src/SurfaceDrawContext.h
[modify] https://crrev.com/5a6f1606cc6aaa9620fe2f892cf64055521ed85e/experimental/graphite/src/SkStuff.cpp
[add] https://crrev.com/5a6f1606cc6aaa9620fe2f892cf64055521ed85e/experimental/graphite/src/Task.cpp
[modify] https://crrev.com/5a6f1606cc6aaa9620fe2f892cf64055521ed85e/experimental/graphite/src/Device.cpp
[add] https://crrev.com/5a6f1606cc6aaa9620fe2f892cf64055521ed85e/experimental/graphite/src/SDCTask.cpp
[modify] https://crrev.com/5a6f1606cc6aaa9620fe2f892cf64055521ed85e/experimental/graphite/src/Device.h

rober… via monorail

unread,
Sep 22, 2021, 2:51:17 PM9/22/21
to bu...@skia.org

Comment #3 on issue 12466 by rober...@google.com: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c3

The following 3 Graphite CLs were landed before this issue was created:

https://skia-review.googlesource.com/c/skia/+/450480 (Establish beachhead)
https://skia-review.googlesource.com/c/skia/+/450976 (More beachhead)
https://skia-review.googlesource.com/c/skia/+/451039 (Update sprint to graphite name)

Git Watcher via monorail

unread,
Sep 22, 2021, 3:37:05 PM9/22/21
to bu...@skia.org

Comment #4 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c4


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/01754ecf1264b8e7a818db249775481c468856a4

commit 01754ecf1264b8e7a818db249775481c468856a4
Author: Michael Ludwig <michae...@google.com>
Date: Wed Sep 22 18:44:20 2021

Graphite: Rough out DrawCommandList and BoundsManager

Device will own and manage a BoundsManager, which it will use to decide
the sort and test Z's that it passes to the DrawCommandList in its
draw() implementations.

DrawCommandList might end up being owned by the SDC, with the SDC
exposing a similar drawing API. There will need to be some mechanism to
end a DrawCommandList and start a new one (the list moves into an
SDCTask). This would either happen from an external flush call, or in
the rare case where the representable Z values are exhausted and we
have to insert a depth buffer clear and start a new task that depends
on the prior one.

Bug: skia:12466
Change-Id: I892b631037dc801eb94da2462683c9701afa281b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/451599
Commit-Queue: Michael Ludwig <michae...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>

[modify] https://crrev.com/01754ecf1264b8e7a818db249775481c468856a4/gn/graphite.gni
[add] https://crrev.com/01754ecf1264b8e7a818db249775481c468856a4/experimental/graphite/src/DrawCommandList.h
[add] https://crrev.com/01754ecf1264b8e7a818db249775481c468856a4/experimental/graphite/src/BoundsManager.h

Git Watcher via monorail

unread,
Sep 22, 2021, 5:35:04 PM9/22/21
to bu...@skia.org

Comment #5 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c5


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/d6bf374c3ca5402dc2a7077725e686ed6f1a3283

commit d6bf374c3ca5402dc2a7077725e686ed6f1a3283
Author: Robert Phillips <robertp...@google.com>
Date: Wed Sep 22 20:07:30 2021

Graphite: Improve DM/Graphite connection

This makes "dm --config grgl --src gm skp" generate a lot of green pngs and adds a stub class for Image_Graphite.

Bug: skia:12466
Change-Id: Ia7cf891ad278434f473cf6c9c4673bf8fa085adf
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/451740
Commit-Queue: Robert Phillips <robertp...@google.com>
Reviewed-by: Michael Ludwig <michae...@google.com>

[add] https://crrev.com/d6bf374c3ca5402dc2a7077725e686ed6f1a3283/experimental/graphite/src/Image_Graphite.cpp
[modify] https://crrev.com/d6bf374c3ca5402dc2a7077725e686ed6f1a3283/tools/flags/CommonFlagsConfig.h
[modify] https://crrev.com/d6bf374c3ca5402dc2a7077725e686ed6f1a3283/experimental/graphite/src/Device.cpp
[modify] https://crrev.com/d6bf374c3ca5402dc2a7077725e686ed6f1a3283/experimental/graphite/src/Surface_Graphite.cpp
[add] https://crrev.com/d6bf374c3ca5402dc2a7077725e686ed6f1a3283/experimental/graphite/src/Image_Graphite.h
[modify] https://crrev.com/d6bf374c3ca5402dc2a7077725e686ed6f1a3283/experimental/graphite/src/Device.h
[modify] https://crrev.com/d6bf374c3ca5402dc2a7077725e686ed6f1a3283/gn/graphite.gni
[modify] https://crrev.com/d6bf374c3ca5402dc2a7077725e686ed6f1a3283/tools/flags/CommonFlagsConfig.cpp
[modify] https://crrev.com/d6bf374c3ca5402dc2a7077725e686ed6f1a3283/dm/DMSrcSink.cpp
[modify] https://crrev.com/d6bf374c3ca5402dc2a7077725e686ed6f1a3283/dm/DM.cpp
[modify] https://crrev.com/d6bf374c3ca5402dc2a7077725e686ed6f1a3283/experimental/graphite/src/Surface_Graphite.h
[modify] https://crrev.com/d6bf374c3ca5402dc2a7077725e686ed6f1a3283/dm/DMSrcSink.h

Git Watcher via monorail

unread,
Sep 22, 2021, 6:15:05 PM9/22/21
to bu...@skia.org

Comment #6 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c6


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/605748b95bef200d779abda7c2d115f6a796cf3a

commit 605748b95bef200d779abda7c2d115f6a796cf3a
Author: Robert Phillips <robertp...@google.com>
Date: Wed Sep 22 19:48:20 2021

Graphite: Add compilation bots

Bug: skia:12466
Change-Id: I5cca024b8df9cf2203d5f09109154d02f0490445
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/451417
Reviewed-by: Brian Salomon <bsal...@google.com>
Reviewed-by: Jim Van Verth <jvan...@google.com>
Reviewed-by: Eric Boren <bor...@google.com>
Commit-Queue: Robert Phillips <robertp...@google.com>

[modify] https://crrev.com/605748b95bef200d779abda7c2d115f6a796cf3a/infra/bots/recipe_modules/build/default.py
[add] https://crrev.com/605748b95bef200d779abda7c2d115f6a796cf3a/infra/bots/recipe_modules/build/examples/full.expected/Build-Mac-Clang-arm64-Debug-Graphite.json
[modify] https://crrev.com/605748b95bef200d779abda7c2d115f6a796cf3a/infra/bots/recipe_modules/build/examples/full.py
[modify] https://crrev.com/605748b95bef200d779abda7c2d115f6a796cf3a/infra/bots/jobs.json
[add] https://crrev.com/605748b95bef200d779abda7c2d115f6a796cf3a/infra/bots/recipe_modules/build/examples/full.expected/Build-Mac-Clang-arm64-Release-Graphite.json
[modify] https://crrev.com/605748b95bef200d779abda7c2d115f6a796cf3a/infra/bots/tasks.json
[modify] https://crrev.com/605748b95bef200d779abda7c2d115f6a796cf3a/infra/bots/cfg.json

Git Watcher via monorail

unread,
Sep 22, 2021, 11:48:10 PM9/22/21
to bu...@skia.org

Comment #7 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c7


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/ee79cc34918740c1d26e554a40d1fb42b1ad6cea

commit ee79cc34918740c1d26e554a40d1fb42b1ad6cea
Author: Robert Phillips <robertp...@google.com>
Date: Thu Sep 23 03:46:25 2021

Revert "Graphite: Add compilation bots"

This reverts commit 605748b95bef200d779abda7c2d115f6a796cf3a.

Reason for revert: Red bots

Original change's description:

> Graphite: Add compilation bots
>
> Bug: skia:12466
> Change-Id: I5cca024b8df9cf2203d5f09109154d02f0490445
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/451417
> Reviewed-by: Brian Salomon <bsal...@google.com>
> Reviewed-by: Jim Van Verth <jvan...@google.com>
> Reviewed-by: Eric Boren <bor...@google.com>
> Commit-Queue: Robert Phillips <robertp...@google.com>

Bug: skia:12466
Change-Id: If35cf18de94731e17596a6b064941c2bef20f265
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/451422
Auto-Submit: Robert Phillips <robertp...@google.com>
Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>

[modify] https://crrev.com/ee79cc34918740c1d26e554a40d1fb42b1ad6cea/infra/bots/recipe_modules/build/default.py
[delete] https://crrev.com/605748b95bef200d779abda7c2d115f6a796cf3a/infra/bots/recipe_modules/build/examples/full.expected/Build-Mac-Clang-arm64-Debug-Graphite.json
[modify] https://crrev.com/ee79cc34918740c1d26e554a40d1fb42b1ad6cea/infra/bots/recipe_modules/build/examples/full.py
[modify] https://crrev.com/ee79cc34918740c1d26e554a40d1fb42b1ad6cea/infra/bots/jobs.json
[delete] https://crrev.com/605748b95bef200d779abda7c2d115f6a796cf3a/infra/bots/recipe_modules/build/examples/full.expected/Build-Mac-Clang-arm64-Release-Graphite.json
[modify] https://crrev.com/ee79cc34918740c1d26e554a40d1fb42b1ad6cea/infra/bots/tasks.json
[modify] https://crrev.com/ee79cc34918740c1d26e554a40d1fb42b1ad6cea/infra/bots/cfg.json

Git Watcher via monorail

unread,
Sep 23, 2021, 4:24:05 PM9/23/21
to bu...@skia.org

Comment #8 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c8


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/ae5705e705093ff074d4fbe0ecab21009ca93155

commit ae5705e705093ff074d4fbe0ecab21009ca93155
Author: Robert Phillips <robertp...@google.com>
Date: Thu Sep 23 19:01:29 2021

Reland "Graphite: Add compilation bots"

This reverts commit ee79cc34918740c1d26e554a40d1fb42b1ad6cea.

Reason for revert: It was a swarming failure

Original change's description:

> Revert "Graphite: Add compilation bots"
>
> This reverts commit 605748b95bef200d779abda7c2d115f6a796cf3a.
>
> Reason for revert: Red bots
>
> Original change's description:
> > Graphite: Add compilation bots
> >
> > Bug: skia:12466
> > Change-Id: I5cca024b8df9cf2203d5f09109154d02f0490445
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/451417
> > Reviewed-by: Brian Salomon <bsal...@google.com>
> > Reviewed-by: Jim Van Verth <jvan...@google.com>
> > Reviewed-by: Eric Boren <bor...@google.com>
> > Commit-Queue: Robert Phillips <robertp...@google.com>
>
> Bug: skia:12466
> Change-Id: If35cf18de94731e17596a6b064941c2bef20f265
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/451422
> Auto-Submit: Robert Phillips <robertp...@google.com>
> Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>

Bug: skia:12466
Change-Id: I630971ccbe40648c0df0c0cc61e16c93264eb82d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/452319
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Commit-Queue: Robert Phillips <robertp...@google.com>

[modify] https://crrev.com/ae5705e705093ff074d4fbe0ecab21009ca93155/infra/bots/recipe_modules/build/default.py
[add] https://crrev.com/ae5705e705093ff074d4fbe0ecab21009ca93155/infra/bots/recipe_modules/build/examples/full.expected/Build-Mac-Clang-arm64-Debug-Graphite.json
[modify] https://crrev.com/ae5705e705093ff074d4fbe0ecab21009ca93155/infra/bots/recipe_modules/build/examples/full.py
[modify] https://crrev.com/ae5705e705093ff074d4fbe0ecab21009ca93155/infra/bots/jobs.json
[add] https://crrev.com/ae5705e705093ff074d4fbe0ecab21009ca93155/infra/bots/recipe_modules/build/examples/full.expected/Build-Mac-Clang-arm64-Release-Graphite.json
[modify] https://crrev.com/ae5705e705093ff074d4fbe0ecab21009ca93155/infra/bots/tasks.json
[modify] https://crrev.com/ae5705e705093ff074d4fbe0ecab21009ca93155/infra/bots/cfg.json

Git Watcher via monorail

unread,
Sep 24, 2021, 12:20:13 PM9/24/21
to bu...@skia.org

Comment #9 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c9


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/1e90b88e45ba43e9be71ef05e5039a914ef668ae

commit 1e90b88e45ba43e9be71ef05e5039a914ef668ae
Author: Jim Van Verth <jvan...@google.com>
Date: Fri Sep 24 15:09:08 2021

Graphite: Add stubs for Gpu and Caps

Bug: skia:12466
Change-Id: I1267d3a387e74dc510ee4d00925049a4e7ac9edd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/452557
Reviewed-by: Robert Phillips <robertp...@google.com>
Commit-Queue: Jim Van Verth <jvan...@google.com>

[modify] https://crrev.com/1e90b88e45ba43e9be71ef05e5039a914ef668ae/gn/graphite.gni
[add] https://crrev.com/1e90b88e45ba43e9be71ef05e5039a914ef668ae/experimental/graphite/src/Gpu.h
[add] https://crrev.com/1e90b88e45ba43e9be71ef05e5039a914ef668ae/experimental/graphite/src/Caps.h
[add] https://crrev.com/1e90b88e45ba43e9be71ef05e5039a914ef668ae/experimental/graphite/src/Caps.cpp
[add] https://crrev.com/1e90b88e45ba43e9be71ef05e5039a914ef668ae/experimental/graphite/src/Gpu.cpp

Git Watcher via monorail

unread,
Sep 24, 2021, 4:31:11 PM9/24/21
to bu...@skia.org

Comment #10 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c10


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Fri Sep 24 19:04:45 2021

Graphite: add ResourceProvider and CommandBuffer stubs

Bug: skia:12466
Change-Id: I30b53802d706406faf8045264c09a75ee3bf9126
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/452232

Commit-Queue: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Sep 24, 2021, 5:52:08 PM9/24/21
to bu...@skia.org

Comment #11 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c11


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Fri Sep 24 20:37:51 2021

Graphite: enable Metal by default on build bots

Bug: skia:12466
Change-Id: I8cfbd2b61819cb55b4fa70cfcfe523dbcb903fd8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/452725
Reviewed-by: Robert Phillips <robertp...@google.com>

Commit-Queue: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Sep 24, 2021, 8:52:09 PM9/24/21
to bu...@skia.org

Comment #12 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c12


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Fri Sep 24 20:46:36 2021

Graphite: add MtlGpu.

Bug: skia:12466
Change-Id: I51dc73a213e672578767b41c01c487c942465964
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/452722

Commit-Queue: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Sep 25, 2021, 1:52:10 PM9/25/21
to bu...@skia.org

Comment #13 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c13


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/aeb5d4daed3ab8927c80db3904dc0f8c24169afa

commit aeb5d4daed3ab8927c80db3904dc0f8c24169afa
Author: Michael Ludwig <michae...@google.com>
Date: Sat Sep 25 17:06:50 2021

[graphite] Flesh out Device/SDC a bit more

Renames SDCTask -> RenderPassTask and adds comments describing its
purpose. Has SDC use a DrawList and expose similar drawing functions.
Stubs out all Device methods that will eventually need to be supported,
but groups them into in-scope and out-of-scope sections. Implements the
drawing functions in terms of drawPath() and has drawPath() invoke the
SDC functions (with untested support for path effects, hairline, etc.).

Bug: skia:12466
Change-Id: Id661fc987aeb35f0dfa536c0cb0b6210742cf32c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/452233
Commit-Queue: Michael Ludwig <michae...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>

[modify] https://crrev.com/aeb5d4daed3ab8927c80db3904dc0f8c24169afa/gn/graphite.gni
[add] https://crrev.com/aeb5d4daed3ab8927c80db3904dc0f8c24169afa/experimental/graphite/src/RenderPassTask.cpp
[modify] https://crrev.com/aeb5d4daed3ab8927c80db3904dc0f8c24169afa/experimental/graphite/src/SurfaceDrawContext.cpp
[delete] https://crrev.com/6f06bab632490b82a3cc73be76f8c5ad119ac092/experimental/graphite/src/SDCTask.h
[modify] https://crrev.com/aeb5d4daed3ab8927c80db3904dc0f8c24169afa/experimental/graphite/src/SurfaceDrawContext.h
[add] https://crrev.com/aeb5d4daed3ab8927c80db3904dc0f8c24169afa/experimental/graphite/src/RenderPassTask.h
[modify] https://crrev.com/aeb5d4daed3ab8927c80db3904dc0f8c24169afa/experimental/graphite/src/Device.cpp
[rename] https://crrev.com/aeb5d4daed3ab8927c80db3904dc0f8c24169afa/experimental/graphite/src/DrawList.h
[delete] https://crrev.com/6f06bab632490b82a3cc73be76f8c5ad119ac092/experimental/graphite/src/SDCTask.cpp
[modify] https://crrev.com/aeb5d4daed3ab8927c80db3904dc0f8c24169afa/experimental/graphite/src/Device.h

Git Watcher via monorail

unread,
Sep 28, 2021, 7:29:11 AM9/28/21
to bu...@skia.org

Comment #14 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c14


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Mon Sep 27 19:59:26 2021

Graphite: Add stubs for Pipeline and PipelineDesc

Bug: skia:12466
Change-Id: Ie949a17166b3ab5c529b74a6762c8a6f8ca8052f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/453061
Reviewed-by: Michael Ludwig <michae...@google.com>

Commit-Queue: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Sep 28, 2021, 1:47:08 PM9/28/21
to bu...@skia.org

Comment #15 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c15


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/4a19f2c52eec904357849c44515fc93b70e27195

commit 4a19f2c52eec904357849c44515fc93b70e27195
Author: Michael Ludwig <michae...@google.com>
Date: Mon Sep 27 23:46:11 2021

[graphite] Define DrawPass for SDC

Updates SDC's state to be a current DL and a list of pending passes,
RenderPassTask then takes over the DrawPasses.

Does not rename SDC to DrawContext as discussed in 9/27 meeting.

Bug: skia:12466
Change-Id: I358d15bc93663729438e5b6f7163eee22dc6769f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/453296

Commit-Queue: Michael Ludwig <michae...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>
Reviewed-by: Jim Van Verth <jvan...@google.com>

[modify] https://crrev.com/4a19f2c52eec904357849c44515fc93b70e27195/experimental/graphite/src/RenderPassTask.cpp
[modify] https://crrev.com/4a19f2c52eec904357849c44515fc93b70e27195/experimental/graphite/src/SurfaceDrawContext.cpp
[modify] https://crrev.com/4a19f2c52eec904357849c44515fc93b70e27195/experimental/graphite/src/SurfaceDrawContext.h
[add] https://crrev.com/4a19f2c52eec904357849c44515fc93b70e27195/experimental/graphite/src/DrawPass.cpp
[modify] https://crrev.com/4a19f2c52eec904357849c44515fc93b70e27195/experimental/graphite/src/RenderPassTask.h
[modify] https://crrev.com/4a19f2c52eec904357849c44515fc93b70e27195/experimental/graphite/src/DrawList.h
[add] https://crrev.com/4a19f2c52eec904357849c44515fc93b70e27195/experimental/graphite/src/DrawPass.h

Git Watcher via monorail

unread,
Sep 28, 2021, 1:47:10 PM9/28/21
to bu...@skia.org

Comment #16 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c16


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Tue Sep 28 15:55:21 2021

[graphite] Stub in more Metal classes

Bug: skia:12466
Change-Id: I83ebf7dbea0d67b3c121b011f62e7b729f5e5257
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/453577
Reviewed-by: Greg Daniel <egda...@google.com>
Commit-Queue: Jim Van Verth <jvan...@google.com>

[modify] https://crrev.com/47b6286e6e863817844ec57969d0f7b07d086886/gn/graphite.gni
[add] https://crrev.com/47b6286e6e863817844ec57969d0f7b07d086886/experimental/graphite/src/mtl/MtlCommandBuffer.mm
[add] https://crrev.com/47b6286e6e863817844ec57969d0f7b07d086886/experimental/graphite/src/mtl/MtlPipeline.mm
[add] https://crrev.com/47b6286e6e863817844ec57969d0f7b07d086886/experimental/graphite/src/mtl/MtlCaps.h
[add] https://crrev.com/47b6286e6e863817844ec57969d0f7b07d086886/experimental/graphite/src/mtl/MtlCaps.mm
[add] https://crrev.com/47b6286e6e863817844ec57969d0f7b07d086886/experimental/graphite/src/mtl/MtlResourceProvider.mm
[add] https://crrev.com/47b6286e6e863817844ec57969d0f7b07d086886/experimental/graphite/src/mtl/MtlPipeline.h
[add] https://crrev.com/47b6286e6e863817844ec57969d0f7b07d086886/experimental/graphite/src/mtl/MtlCommandBuffer.h
[modify] https://crrev.com/47b6286e6e863817844ec57969d0f7b07d086886/experimental/graphite/src/Pipeline.h
[add] https://crrev.com/47b6286e6e863817844ec57969d0f7b07d086886/experimental/graphite/src/mtl/MtlResourceProvider.h

Git Watcher via monorail

unread,
Sep 28, 2021, 4:39:07 PM9/28/21
to bu...@skia.org

Comment #17 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c17


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/949aebff35da495e9efc56bbd9dfe7915b247fb1

commit 949aebff35da495e9efc56bbd9dfe7915b247fb1
Author: Michael Ludwig <michae...@google.com>
Date: Tue Sep 28 19:19:34 2021

[graphite] Fix build for DrawPass

Bug: skia:12466
Change-Id: I2ba1f1541c273ba90032c93a92ed3770dc5b0080
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/453756
Commit-Queue: Michael Ludwig <michae...@google.com>

Commit-Queue: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Sep 28, 2021, 5:12:14 PM9/28/21
to bu...@skia.org

Comment #18 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c18


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/e19164d9f48dd75249bdd9db840d3740ee75ecf3

commit e19164d9f48dd75249bdd9db840d3740ee75ecf3
Author: Robert Phillips <robertp...@google.com>
Date: Tue Sep 28 18:01:13 2021

[graphite] Move some basic include/gpu files over to Graphite

This is mainly to make make MtlBackendContext available.

GrTypes has to go to GraphiteTypes due to a name collision with Types.h in in sktext.

Bug: skia:12466
Change-Id: If073d5540c3dbf3fbfb404808d80deab42c40aa6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/453497
Commit-Queue: Robert Phillips <robertp...@google.com>
Reviewed-by: Greg Daniel <egda...@google.com>

Reviewed-by: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Sep 29, 2021, 10:56:04 AM9/29/21
to bu...@skia.org

Comment #19 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c19


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Wed Sep 29 13:56:37 2021

[graphite] Flesh out more of Metal Caps.

Allocates and initializes the caps with GpuFamily and Group info.

Bug: skia:12466
Change-Id: I7abb8b6df2acf2ac70f3fbe56e935f44815776dd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/453796

Commit-Queue: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Sep 29, 2021, 12:32:06 PM9/29/21
to bu...@skia.org

Comment #20 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c20


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/d73cff0e2de008f0210ec2fda669cf6c32362619

commit d73cff0e2de008f0210ec2fda669cf6c32362619
Author: Greg Daniel <egda...@google.com>
Date: Wed Sep 29 15:42:09 2021

[graphite] Add TextureInfo class.

Also adds the Mtl subclass as well

Bug: skia:12466
Change-Id: Ia3a81f33a00374a96765fde3a3442c5e13188ad1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/453719
Commit-Queue: Greg Daniel <egda...@google.com>
Reviewed-by: Jim Van Verth <jvan...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>

[modify] https://crrev.com/d73cff0e2de008f0210ec2fda669cf6c32362619/gn/graphite.gni
[modify] https://crrev.com/d73cff0e2de008f0210ec2fda669cf6c32362619/experimental/graphite/include/mtl/MtlTypes.h
[modify] https://crrev.com/d73cff0e2de008f0210ec2fda669cf6c32362619/experimental/graphite/include/GraphiteTypes.h
[add] https://crrev.com/d73cff0e2de008f0210ec2fda669cf6c32362619/experimental/graphite/src/mtl/MtlTypesPriv.mm
[add] https://crrev.com/d73cff0e2de008f0210ec2fda669cf6c32362619/experimental/graphite/include/TextureInfo.h
[modify] https://crrev.com/d73cff0e2de008f0210ec2fda669cf6c32362619/experimental/graphite/include/mtl/MtlBackendContext.h
[add] https://crrev.com/d73cff0e2de008f0210ec2fda669cf6c32362619/experimental/graphite/include/private/MtlTypesPriv.h

Git Watcher via monorail

unread,
Sep 29, 2021, 2:19:08 PM9/29/21
to bu...@skia.org

Comment #21 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c21


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Wed Sep 29 16:22:51 2021

[graphite] Address nits from https://review.skia.org/453796

Bug: skia:12466
Change-Id: Ibe9f09c3801ca22a9b390b0e7a7623a6b73da162
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/453944
Auto-Submit: Jim Van Verth <jvan...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>

Commit-Queue: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Sep 29, 2021, 2:25:13 PM9/29/21
to bu...@skia.org

Comment #22 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c22


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/6abafd681ee56f6652d0d48b16b3480af7c5739a

commit 6abafd681ee56f6652d0d48b16b3480af7c5739a
Author: Michael Ludwig <michae...@google.com>
Date: Wed Sep 29 17:37:53 2021

[graphite] fix assert in Device ctor

Bug: skia:12466
Change-Id: Ida0113701b7ba2b45b5bddcc76d2729c8658fb14
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/453948
Commit-Queue: Michael Ludwig <michae...@google.com>
Commit-Queue: Robert Phillips <robertp...@google.com>
Auto-Submit: Michael Ludwig <michae...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>

[modify] https://crrev.com/6abafd681ee56f6652d0d48b16b3480af7c5739a/experimental/graphite/src/Device.cpp

Git Watcher via monorail

unread,
Sep 29, 2021, 3:10:13 PM9/29/21
to bu...@skia.org

Comment #23 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c23


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/d034db791d67fc7f8b6fbae75d38b97f328d6acc

commit d034db791d67fc7f8b6fbae75d38b97f328d6acc
Author: Robert Phillips <robertp...@google.com>
Date: Wed Sep 29 18:29:32 2021

[graphite] Add GraphiteTestContext

Bug: skia:12466
Change-Id: I90ebec9ee744de3822bd82d474858015d2490d72
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/453636
Commit-Queue: Robert Phillips <robertp...@google.com>

Reviewed-by: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Sep 29, 2021, 6:13:04 PM9/29/21
to bu...@skia.org

Comment #24 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c24


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Wed Sep 29 20:48:25 2021

[graphite] Add Metal trampoline.

Adds the interface between C++ and Objective-C code so we can create
the Gpu.

Bug: skia:12466
Change-Id: I0c4b5d21ddaa119c21682105dc84d75769f069f6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/453952

Commit-Queue: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Sep 30, 2021, 11:30:10 AM9/30/21
to bu...@skia.org

Comment #25 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c25


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/b2d20e02e7337806cd21a7869976cf9c92d9efda

commit b2d20e02e7337806cd21a7869976cf9c92d9efda
Author: Greg Daniel <egda...@google.com>
Date: Thu Sep 30 14:51:08 2021

[graphite] Add basic Texture files.

Bug: skia:12466
Change-Id: If708d8a4bd00802e60a860215edcb64db179e573
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/454616
Commit-Queue: Greg Daniel <egda...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>

Reviewed-by: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Sep 30, 2021, 2:05:08 PM9/30/21
to bu...@skia.org

Comment #26 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c26


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/091694fe16e1fb6af5802f4afc74f54964a4799d

commit 091694fe16e1fb6af5802f4afc74f54964a4799d
Author: Robert Phillips <robertp...@google.com>
Date: Thu Sep 30 15:41:16 2021

[graphite] Add ContextFactory

Bug: skia:12466
Change-Id: I3299940af72cffde3904cf5f6262955807d6d1bc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/453637

Reviewed-by: Jim Van Verth <jvan...@google.com>
Commit-Queue: Robert Phillips <robertp...@google.com>

[add] https://crrev.com/091694fe16e1fb6af5802f4afc74f54964a4799d/tools/graphite/ContextFactory.cpp
[add] https://crrev.com/091694fe16e1fb6af5802f4afc74f54964a4799d/tools/graphite/ContextFactory.h
[modify] https://crrev.com/091694fe16e1fb6af5802f4afc74f54964a4799d/experimental/graphite/src/Device.cpp
[modify] https://crrev.com/091694fe16e1fb6af5802f4afc74f54964a4799d/experimental/graphite/src/ResourceProvider.h
[modify] https://crrev.com/091694fe16e1fb6af5802f4afc74f54964a4799d/experimental/graphite/src/Surface_Graphite.cpp
[modify] https://crrev.com/091694fe16e1fb6af5802f4afc74f54964a4799d/experimental/graphite/src/Device.h
[modify] https://crrev.com/091694fe16e1fb6af5802f4afc74f54964a4799d/experimental/graphite/src/ResourceProvider.cpp
[modify] https://crrev.com/091694fe16e1fb6af5802f4afc74f54964a4799d/dm/DMSrcSink.cpp
[modify] https://crrev.com/091694fe16e1fb6af5802f4afc74f54964a4799d/experimental/graphite/src/SkStuff.cpp
[modify] https://crrev.com/091694fe16e1fb6af5802f4afc74f54964a4799d/BUILD.gn
[modify] https://crrev.com/091694fe16e1fb6af5802f4afc74f54964a4799d/tools/graphite/GraphiteTestContext.h
[modify] https://crrev.com/091694fe16e1fb6af5802f4afc74f54964a4799d/experimental/graphite/include/SkStuff.h
[modify] https://crrev.com/091694fe16e1fb6af5802f4afc74f54964a4799d/tools/graphite/mtl/MtlTestContext.mm
[modify] https://crrev.com/091694fe16e1fb6af5802f4afc74f54964a4799d/tools/graphite/mtl/GraphiteMtlTestContext.h

Git Watcher via monorail

unread,
Sep 30, 2021, 2:25:09 PM9/30/21
to bu...@skia.org

Comment #27 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c27


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/f69f21e601f99f84354d50c043261054790ba994

commit f69f21e601f99f84354d50c043261054790ba994
Author: Greg Daniel <egda...@google.com>
Date: Thu Sep 30 15:56:44 2021

Add MtlTexture class.

Bug: skia:12466
Change-Id: I6207af8bb34ccab28265ced733e1930f42e2db8b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/454776
Reviewed-by: Robert Phillips <robertp...@google.com>

Reviewed-by: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Sep 30, 2021, 5:39:07 PM9/30/21
to bu...@skia.org

Comment #28 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c28


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Thu Sep 30 20:27:30 2021

[graphite] Add support to Mac Viewer.

Adds a type enum to WindowContext to determine which kind of
GPU context (GrDirectContext or skgpu::Context) we're using.

Bug: skia:12466
Change-Id: I288878740392a43cd9e82c925fbe2c372d140dc5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/454699
Reviewed-by: Brian Osman <brian...@google.com>
Commit-Queue: Jim Van Verth <jvan...@google.com>

[add] https://crrev.com/7bb0ff05cec57ee2252b4c2e7b4a8782b84205b3/tools/sk_app/GraphiteMetalWindowContext.mm
[modify] https://crrev.com/7bb0ff05cec57ee2252b4c2e7b4a8782b84205b3/tools/viewer/Viewer.cpp
[modify] https://crrev.com/7bb0ff05cec57ee2252b4c2e7b4a8782b84205b3/tools/sk_app/Window.h
[modify] https://crrev.com/7bb0ff05cec57ee2252b4c2e7b4a8782b84205b3/tools/sk_app/WindowContext.h
[modify] https://crrev.com/7bb0ff05cec57ee2252b4c2e7b4a8782b84205b3/tools/sk_app/mac/Window_mac.mm
[modify] https://crrev.com/7bb0ff05cec57ee2252b4c2e7b4a8782b84205b3/BUILD.gn
[add] https://crrev.com/7bb0ff05cec57ee2252b4c2e7b4a8782b84205b3/tools/sk_app/GraphiteMetalWindowContext.h
[add] https://crrev.com/7bb0ff05cec57ee2252b4c2e7b4a8782b84205b3/tools/sk_app/mac/GraphiteMetalWindowContext_mac.mm
[modify] https://crrev.com/7bb0ff05cec57ee2252b4c2e7b4a8782b84205b3/tools/sk_app/mac/WindowContextFactory_mac.h
[modify] https://crrev.com/7bb0ff05cec57ee2252b4c2e7b4a8782b84205b3/tools/sk_app/WindowContext.cpp

Git Watcher via monorail

unread,
Oct 1, 2021, 12:35:04 PM10/1/21
to bu...@skia.org

Comment #29 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c29


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/8e29caf4c130fad5c57255723ac3b98f440f11c2

commit 8e29caf4c130fad5c57255723ac3b98f440f11c2
Author: Greg Daniel <egda...@google.com>
Date: Fri Oct 01 14:31:56 2021

[graphite] Add support for UsageFlags on Texture.

Bug: skia:12466
Change-Id: Iee62164899742356abf15ae3bc3dec0e724a365d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/454743

Reviewed-by: Jim Van Verth <jvan...@google.com>
Commit-Queue: Greg Daniel <egda...@google.com>

Git Watcher via monorail

unread,
Oct 4, 2021, 10:05:09 AM10/4/21
to bu...@skia.org

Comment #30 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c30


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Fri Oct 01 20:07:30 2021

[graphite] Add CommandBuffer creation

Bug: skia:12466
Change-Id: I3a22d03e5042a94f2bf6d379b2fff17f0b48edb3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/455217
Reviewed-by: Greg Daniel <egda...@google.com>

Commit-Queue: Jim Van Verth <jvan...@google.com>

[modify] https://crrev.com/1f9be54238d3213a630119bcad51fba0986bb17b/experimental/graphite/src/mtl/MtlCommandBuffer.mm
[modify] https://crrev.com/1f9be54238d3213a630119bcad51fba0986bb17b/experimental/graphite/src/ResourceProvider.cpp
[modify] https://crrev.com/1f9be54238d3213a630119bcad51fba0986bb17b/experimental/graphite/src/ResourceProvider.h
[modify] https://crrev.com/1f9be54238d3213a630119bcad51fba0986bb17b/experimental/graphite/src/mtl/MtlResourceProvider.mm
[modify] https://crrev.com/1f9be54238d3213a630119bcad51fba0986bb17b/experimental/graphite/src/mtl/MtlGpu.h
[modify] https://crrev.com/1f9be54238d3213a630119bcad51fba0986bb17b/experimental/graphite/src/mtl/MtlCommandBuffer.h
[modify] https://crrev.com/1f9be54238d3213a630119bcad51fba0986bb17b/experimental/graphite/src/mtl/MtlResourceProvider.h
[modify] https://crrev.com/1f9be54238d3213a630119bcad51fba0986bb17b/experimental/graphite/src/CommandBuffer.h

Git Watcher via monorail

unread,
Oct 4, 2021, 10:38:07 AM10/4/21
to bu...@skia.org

Comment #31 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c31


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/c2a7ae5ade0e1e818fc5197159627772297ea68e

commit c2a7ae5ade0e1e818fc5197159627772297ea68e
Author: Greg Daniel <egda...@google.com>
Date: Mon Oct 04 13:36:21 2021

[graphite] Add support for Mtl Stencil/Depth Textures.

Bug: skia:12466
Change-Id: I38f3469c53414c36b05f3bdbc266b50783cfa676
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/455496

Reviewed-by: Jim Van Verth <jvan...@google.com>
Commit-Queue: Greg Daniel <egda...@google.com>

Git Watcher via monorail

unread,
Oct 4, 2021, 2:08:19 PM10/4/21
to bu...@skia.org

Comment #32 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c32


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/0dc6445a46eaf762422d1fbc4bab04b02abe3444

commit 0dc6445a46eaf762422d1fbc4bab04b02abe3444
Author: Michael Ludwig <michae...@google.com>
Date: Mon Oct 04 17:28:07 2021

[graphite] Define SortKey as part of DrawPass impl

Every command that's in a DrawList will produce 1-3 SortKeys (depending
on its type of draw and the number of steps involved). For example a
large non-convex path fill requires a stencil draw for the curves, a
stencil draw of its inner triangles, and a covering draw for shading.

Since the SortKeys are only temporary and can be discarded once the
list has finished being converted into the DrawPass itself, they are
defined in the cpp file. However, I could see exposing them if only so
that the conceptual model is more apparent, since this is a key part
of the new approach in graphite.

Related to the details of the SortKey, the DrawList and SDC APIs have
been updated to reflect the differences in stencil-and-fill path
rendering that needs to be ordered based on both its color-depth
intersections and stencil buffer intersections, and convex filled
paths that don't require stenciling at all.

As a little cleanup, these parameters have been named something to
reflect their semantics even though they stay uint16_t's.

Bug: skia:12466
Change-Id: I02d6361f2889c0a6b341623131e4abda00a11145
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/455216
Reviewed-by: Chris Dalton <csmart...@google.com>
Commit-Queue: Michael Ludwig <michae...@google.com>

[modify] https://crrev.com/0dc6445a46eaf762422d1fbc4bab04b02abe3444/experimental/graphite/src/SurfaceDrawContext.cpp
[modify] https://crrev.com/0dc6445a46eaf762422d1fbc4bab04b02abe3444/experimental/graphite/src/DrawPass.cpp
[modify] https://crrev.com/0dc6445a46eaf762422d1fbc4bab04b02abe3444/experimental/graphite/src/SurfaceDrawContext.h
[modify] https://crrev.com/0dc6445a46eaf762422d1fbc4bab04b02abe3444/experimental/graphite/include/GraphiteTypes.h
[modify] https://crrev.com/0dc6445a46eaf762422d1fbc4bab04b02abe3444/experimental/graphite/src/Device.cpp
[modify] https://crrev.com/0dc6445a46eaf762422d1fbc4bab04b02abe3444/experimental/graphite/src/DrawList.h

Git Watcher via monorail

unread,
Oct 4, 2021, 3:07:07 PM10/4/21
to bu...@skia.org

Comment #33 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c33


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Mon Oct 04 15:15:27 2021

[graphite] Fix creation of command buffer for different SDK/OS versions

Bug: skia:12466
Change-Id: I9828c59f0406e457e723f78940b1f42ff343fa2e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/455500
Auto-Submit: Jim Van Verth <jvan...@google.com>
Reviewed-by: Greg Daniel <egda...@google.com>

[modify] https://crrev.com/4008c5a3b0e7b10f92dc5c2e53570d8445df2fd8/experimental/graphite/src/mtl/MtlCommandBuffer.mm

Git Watcher via monorail

unread,
Oct 4, 2021, 3:15:07 PM10/4/21
to bu...@skia.org

Comment #34 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c34


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/e20b3ec822f23df1504428b9cff330e93e7c50d3

commit e20b3ec822f23df1504428b9cff330e93e7c50d3
Author: Greg Daniel <egda...@google.com>
Date: Mon Oct 04 17:24:22 2021

[graphite] Add remaining factories to MtlTexture.

Adds factory for SampledTextures and MSAA textures

Bug: skia:12466
Change-Id: Ia8aa7fa874e8256fe4dea8a16ceb459dbb02547d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/455618
Commit-Queue: Jim Van Verth <jvan...@google.com>
Reviewed-by: Jim Van Verth <jvan...@google.com>

[modify] https://crrev.com/e20b3ec822f23df1504428b9cff330e93e7c50d3/experimental/graphite/src/mtl/MtlTexture.mm
[modify] https://crrev.com/e20b3ec822f23df1504428b9cff330e93e7c50d3/experimental/graphite/src/mtl/MtlTexture.h

Git Watcher via monorail

unread,
Oct 4, 2021, 3:52:04 PM10/4/21
to bu...@skia.org

Comment #35 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c35


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/a525fd141bbde7c226f98c223d4b59d064189220

commit a525fd141bbde7c226f98c223d4b59d064189220
Author: Michael Ludwig <michae...@google.com>
Date: Mon Oct 04 17:36:40 2021

[graphite] SurfaceDrawContext -> DrawContext

Bug: skia:12466
Change-Id: If4a06bc0ab8befab8a155276c316ba9378b90a48
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/455658
Commit-Queue: Michael Ludwig <michae...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>

[modify] https://crrev.com/a525fd141bbde7c226f98c223d4b59d064189220/gn/graphite.gni
[delete] https://crrev.com/e20b3ec822f23df1504428b9cff330e93e7c50d3/experimental/graphite/src/SurfaceDrawContext.cpp
[modify] https://crrev.com/a525fd141bbde7c226f98c223d4b59d064189220/experimental/graphite/src/DrawPass.cpp
[modify] https://crrev.com/a525fd141bbde7c226f98c223d4b59d064189220/experimental/graphite/src/Device.cpp
[rename] https://crrev.com/a525fd141bbde7c226f98c223d4b59d064189220/experimental/graphite/src/DrawContext.h
[add] https://crrev.com/a525fd141bbde7c226f98c223d4b59d064189220/experimental/graphite/src/DrawContext.cpp
[modify] https://crrev.com/a525fd141bbde7c226f98c223d4b59d064189220/experimental/graphite/src/DrawPass.h
[modify] https://crrev.com/a525fd141bbde7c226f98c223d4b59d064189220/experimental/graphite/src/Device.h

Git Watcher via monorail

unread,
Oct 4, 2021, 4:37:06 PM10/4/21
to bu...@skia.org

Comment #36 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c36


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/9602a4fad0ef7072232351ffd1e6ab1b658fe359

commit 9602a4fad0ef7072232351ffd1e6ab1b658fe359
Author: Michael Ludwig <michae...@google.com>
Date: Mon Oct 04 20:35:15 2021

Revert "[graphite] SurfaceDrawContext -> DrawContext"

This reverts commit a525fd141bbde7c226f98c223d4b59d064189220.

Reason for revert: missed updating sdc->dc in one spot

Original change's description:

> [graphite] SurfaceDrawContext -> DrawContext
>
> Bug: skia:12466
> Change-Id: If4a06bc0ab8befab8a155276c316ba9378b90a48
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/455658
> Commit-Queue: Michael Ludwig <michae...@google.com>
> Reviewed-by: Robert Phillips <robertp...@google.com>

Bug: skia:12466
Change-Id: I60e316225d44d7046bc82c80fe42345d8941f99e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/455662
Auto-Submit: Michael Ludwig <michae...@google.com>
Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>

[modify] https://crrev.com/9602a4fad0ef7072232351ffd1e6ab1b658fe359/gn/graphite.gni
[add] https://crrev.com/9602a4fad0ef7072232351ffd1e6ab1b658fe359/experimental/graphite/src/SurfaceDrawContext.cpp
[modify] https://crrev.com/9602a4fad0ef7072232351ffd1e6ab1b658fe359/experimental/graphite/src/DrawPass.cpp
[rename] https://crrev.com/9602a4fad0ef7072232351ffd1e6ab1b658fe359/experimental/graphite/src/SurfaceDrawContext.h
[modify] https://crrev.com/9602a4fad0ef7072232351ffd1e6ab1b658fe359/experimental/graphite/src/Device.cpp
[delete] https://crrev.com/a525fd141bbde7c226f98c223d4b59d064189220/experimental/graphite/src/DrawContext.cpp
[modify] https://crrev.com/9602a4fad0ef7072232351ffd1e6ab1b658fe359/experimental/graphite/src/DrawPass.h
[modify] https://crrev.com/9602a4fad0ef7072232351ffd1e6ab1b658fe359/experimental/graphite/src/Device.h

Git Watcher via monorail

unread,
Oct 4, 2021, 5:44:06 PM10/4/21
to bu...@skia.org

Comment #37 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c37


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/65e848d6b5ba1c97aff22aa7ae7d7906e79e9c30

commit 65e848d6b5ba1c97aff22aa7ae7d7906e79e9c30
Author: Michael Ludwig <michae...@google.com>
Date: Mon Oct 04 20:36:51 2021

Reland "[graphite] SurfaceDrawContext -> DrawContext"

This reverts commit 9602a4fad0ef7072232351ffd1e6ab1b658fe359.

Reason for revert: fixed var ref

Original change's description:

> Revert "[graphite] SurfaceDrawContext -> DrawContext"
>
> This reverts commit a525fd141bbde7c226f98c223d4b59d064189220.
>
> Reason for revert: missed updating sdc->dc in one spot
>
> Original change's description:
> > [graphite] SurfaceDrawContext -> DrawContext
> >
> > Bug: skia:12466
> > Change-Id: If4a06bc0ab8befab8a155276c316ba9378b90a48
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/455658
> > Commit-Queue: Michael Ludwig <michae...@google.com>
> > Reviewed-by: Robert Phillips <robertp...@google.com>
>
> Bug: skia:12466
> Change-Id: I60e316225d44d7046bc82c80fe42345d8941f99e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/455662
> Auto-Submit: Michael Ludwig <michae...@google.com>
> Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>

Bug: skia:12466
Change-Id: I693b1e39fd65fe20cd5bb3f36bcc5f3da011c6b3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/455663

Commit-Queue: Michael Ludwig <michae...@google.com>
Commit-Queue: Robert Phillips <robertp...@google.com>
Auto-Submit: Michael Ludwig <michae...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>

[modify] https://crrev.com/65e848d6b5ba1c97aff22aa7ae7d7906e79e9c30/gn/graphite.gni
[delete] https://crrev.com/df93db9d329600fc92af942f68539c2fe969a9e4/experimental/graphite/src/SurfaceDrawContext.cpp
[modify] https://crrev.com/65e848d6b5ba1c97aff22aa7ae7d7906e79e9c30/experimental/graphite/src/DrawPass.cpp
[modify] https://crrev.com/65e848d6b5ba1c97aff22aa7ae7d7906e79e9c30/experimental/graphite/src/Device.cpp
[rename] https://crrev.com/65e848d6b5ba1c97aff22aa7ae7d7906e79e9c30/experimental/graphite/src/DrawContext.h
[add] https://crrev.com/65e848d6b5ba1c97aff22aa7ae7d7906e79e9c30/experimental/graphite/src/DrawContext.cpp
[modify] https://crrev.com/65e848d6b5ba1c97aff22aa7ae7d7906e79e9c30/experimental/graphite/src/DrawPass.h
[modify] https://crrev.com/65e848d6b5ba1c97aff22aa7ae7d7906e79e9c30/experimental/graphite/src/Device.h

Git Watcher via monorail

unread,
Oct 5, 2021, 10:35:08 AM10/5/21
to bu...@skia.org

Comment #38 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c38


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Mon Oct 04 20:16:57 2021

[graphite] Add pipeline cache to ResourceProvider

Copied from GrMtlResourceProvider, and stripped down to the barest minimum.

Bug: skia:12466
Change-Id: I63cb52ee4bbc4c6ce5a1de16312bd4c69911d32c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/455619

Commit-Queue: Jim Van Verth <jvan...@google.com>
Reviewed-by: Michael Ludwig <michae...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>

[rename] https://crrev.com/efdb1f0a3b161f948e235f827507ce408c6c1d95/experimental/graphite/src/mtl/MtlRenderPipeline.mm
[modify] https://crrev.com/efdb1f0a3b161f948e235f827507ce408c6c1d95/experimental/graphite/src/ResourceProvider.h
[add] https://crrev.com/efdb1f0a3b161f948e235f827507ce408c6c1d95/experimental/graphite/src/RenderPipelineDesc.h
[modify] https://crrev.com/efdb1f0a3b161f948e235f827507ce408c6c1d95/experimental/graphite/src/mtl/MtlResourceProvider.mm
[delete] https://crrev.com/a6d7296948d44f23ed80fed7b2a38a32c7d6bbe4/experimental/graphite/src/Pipeline.h
[modify] https://crrev.com/efdb1f0a3b161f948e235f827507ce408c6c1d95/experimental/graphite/src/mtl/MtlResourceProvider.h
[modify] https://crrev.com/efdb1f0a3b161f948e235f827507ce408c6c1d95/gn/graphite.gni
[rename] https://crrev.com/efdb1f0a3b161f948e235f827507ce408c6c1d95/experimental/graphite/src/RenderPipelineDesc.cpp
[modify] https://crrev.com/efdb1f0a3b161f948e235f827507ce408c6c1d95/experimental/graphite/src/ResourceProvider.cpp
[add] https://crrev.com/efdb1f0a3b161f948e235f827507ce408c6c1d95/experimental/graphite/src/mtl/MtlRenderPipeline.h
[rename] https://crrev.com/efdb1f0a3b161f948e235f827507ce408c6c1d95/experimental/graphite/src/RenderPipeline.cpp
[add] https://crrev.com/efdb1f0a3b161f948e235f827507ce408c6c1d95/experimental/graphite/src/RenderPipeline.h
[delete] https://crrev.com/a6d7296948d44f23ed80fed7b2a38a32c7d6bbe4/experimental/graphite/src/mtl/MtlPipeline.h
[delete] https://crrev.com/a6d7296948d44f23ed80fed7b2a38a32c7d6bbe4/experimental/graphite/src/PipelineDesc.h

Git Watcher via monorail

unread,
Oct 5, 2021, 11:54:04 AM10/5/21
to bu...@skia.org

Comment #39 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c39


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Tue Oct 05 15:09:01 2021

[graphite] Update minimum Metal SDK required

Bug: skia:12466
Change-Id: I97d8743057199abd88948f0804cceb4180ad8b74
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/455997

Commit-Queue: Jim Van Verth <jvan...@google.com>
Commit-Queue: Greg Daniel <egda...@google.com>

Auto-Submit: Jim Van Verth <jvan...@google.com>
Reviewed-by: Greg Daniel <egda...@google.com>

Git Watcher via monorail

unread,
Oct 5, 2021, 3:11:06 PM10/5/21
to bu...@skia.org

Comment #40 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c40


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/237c22adb8a12581ca7e2f135c1d53adc19290e1

commit 237c22adb8a12581ca7e2f135c1d53adc19290e1
Author: Robert Phillips <robertp...@google.com>
Date: Tue Oct 05 16:55:58 2021

[graphite] Add ASAN bot

Bug: skia:12466 skia:12507
Change-Id: I1f632afc5e27dfe076f4409bc999bd57be1c2f1a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/455797
Reviewed-by: Greg Daniel <egda...@google.com>
Commit-Queue: Robert Phillips <robertp...@google.com>

[modify] https://crrev.com/237c22adb8a12581ca7e2f135c1d53adc19290e1/infra/bots/gen_tasks_logic/dm_flags.go
[modify] https://crrev.com/237c22adb8a12581ca7e2f135c1d53adc19290e1/infra/bots/jobs.json
[modify] https://crrev.com/237c22adb8a12581ca7e2f135c1d53adc19290e1/infra/bots/tasks.json

Git Watcher via monorail

unread,
Oct 5, 2021, 5:14:17 PM10/5/21
to bu...@skia.org

Comment #41 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c41


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/d4ca5e11a1570e85ee8bbb1f33977d41552581a3

commit d4ca5e11a1570e85ee8bbb1f33977d41552581a3
Author: Greg Daniel <egda...@google.com>
Date: Tue Oct 05 20:34:37 2021

Add Texture creation to ResourceProvider.

The caller to ResourceProvider should be passing in the TextureInfo
they want. Thus we don't need all the specialized factores on
mtl::Texture.

Also removes UsageFlags from Texture which aren't needed.

Bug: skia:12466
Change-Id: Iad51a7da6efe481382a3f5fbaefc6d2504d1c013
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/456236
Reviewed-by: Jim Van Verth <jvan...@google.com>
Commit-Queue: Greg Daniel <egda...@google.com>

[add] https://crrev.com/d4ca5e11a1570e85ee8bbb1f33977d41552581a3/experimental/graphite/src/mtl/MtlUtils.mm
[modify] https://crrev.com/d4ca5e11a1570e85ee8bbb1f33977d41552581a3/experimental/graphite/src/ResourceProvider.h
[modify] https://crrev.com/d4ca5e11a1570e85ee8bbb1f33977d41552581a3/experimental/graphite/src/mtl/MtlTexture.h
[modify] https://crrev.com/d4ca5e11a1570e85ee8bbb1f33977d41552581a3/experimental/graphite/src/mtl/MtlResourceProvider.mm
[modify] https://crrev.com/d4ca5e11a1570e85ee8bbb1f33977d41552581a3/experimental/graphite/src/mtl/MtlResourceProvider.h
[modify] https://crrev.com/d4ca5e11a1570e85ee8bbb1f33977d41552581a3/experimental/graphite/src/Texture.cpp
[modify] https://crrev.com/d4ca5e11a1570e85ee8bbb1f33977d41552581a3/gn/graphite.gni
[modify] https://crrev.com/d4ca5e11a1570e85ee8bbb1f33977d41552581a3/experimental/graphite/src/ResourceProvider.cpp
[modify] https://crrev.com/d4ca5e11a1570e85ee8bbb1f33977d41552581a3/experimental/graphite/src/Texture.h
[modify] https://crrev.com/d4ca5e11a1570e85ee8bbb1f33977d41552581a3/experimental/graphite/src/mtl/MtlTexture.mm
[modify] https://crrev.com/d4ca5e11a1570e85ee8bbb1f33977d41552581a3/experimental/graphite/include/TextureInfo.h
[add] https://crrev.com/d4ca5e11a1570e85ee8bbb1f33977d41552581a3/experimental/graphite/src/mtl/MtlUtils.h

Git Watcher via monorail

unread,
Oct 6, 2021, 11:12:04 AM10/6/21
to bu...@skia.org

Comment #42 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c42


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/fbc64be806204b99e0023f5f36c3db6bf44b2631

commit fbc64be806204b99e0023f5f36c3db6bf44b2631
Author: Greg Daniel <egda...@google.com>
Date: Wed Oct 06 14:30:33 2021

[graphite] Add Caps getters for default TextureInfos

Bug: skia:12466
Change-Id: I9165e5f49e4b897f4b315662221b944e362b7b41
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/456456

Commit-Queue: Greg Daniel <egda...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>
Reviewed-by: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Oct 6, 2021, 11:20:04 AM10/6/21
to bu...@skia.org

Comment #43 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c43


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/3c27c9fe5ecb82d8e6fa59f31536e443d815bc4d

commit 3c27c9fe5ecb82d8e6fa59f31536e443d815bc4d
Author: Greg Daniel <egda...@google.com>
Date: Wed Oct 06 14:38:33 2021

[graphite] Add Debug Graphite build to CQ.

We've gotten far enough along that I don't want changes in main Skia to
start breaking Graphite.

Bug: skia:12466
Change-Id: I66cf2e889521382ef51a99e0966d239f841da655
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/456462
Reviewed-by: Robert Phillips <robertp...@google.com>
Commit-Queue: Greg Daniel <egda...@google.com>

[modify] https://crrev.com/3c27c9fe5ecb82d8e6fa59f31536e443d815bc4d/infra/bots/jobs.json
[modify] https://crrev.com/3c27c9fe5ecb82d8e6fa59f31536e443d815bc4d/infra/bots/tasks.json

Git Watcher via monorail

unread,
Oct 6, 2021, 12:33:05 PM10/6/21
to bu...@skia.org

Comment #44 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c44


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/47da0ac577aabe4911abfeb93aa3f5c2492043be

commit 47da0ac577aabe4911abfeb93aa3f5c2492043be
Author: Robert Phillips <robertp...@google.com>
Date: Wed Oct 06 14:43:54 2021

[graphite] Add stub classes for Recorder, Recording and TaskGraph

Bug: skia:12466
Change-Id: I730c227a78040ea8747d11437032504527b3ee81
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/456463
Reviewed-by: Michael Ludwig <michae...@google.com>
Commit-Queue: Robert Phillips <robertp...@google.com>

[add] https://crrev.com/47da0ac577aabe4911abfeb93aa3f5c2492043be/experimental/graphite/src/Recorder.h
[modify] https://crrev.com/47da0ac577aabe4911abfeb93aa3f5c2492043be/gn/graphite.gni
[add] https://crrev.com/47da0ac577aabe4911abfeb93aa3f5c2492043be/experimental/graphite/src/TaskGraph.cpp
[add] https://crrev.com/47da0ac577aabe4911abfeb93aa3f5c2492043be/experimental/graphite/src/Recorder.cpp
[add] https://crrev.com/47da0ac577aabe4911abfeb93aa3f5c2492043be/experimental/graphite/src/TaskGraph.h
[add] https://crrev.com/47da0ac577aabe4911abfeb93aa3f5c2492043be/experimental/graphite/src/Recording.cpp
[add] https://crrev.com/47da0ac577aabe4911abfeb93aa3f5c2492043be/experimental/graphite/src/Recording.h

Git Watcher via monorail

unread,
Oct 6, 2021, 3:46:06 PM10/6/21
to bu...@skia.org

Comment #45 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c45


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Wed Oct 06 18:41:11 2021

[graphite] Hook up Pipeline creation.

Adds in test pipeline state object creation and shader compilation
routine.

Bug: skia:12466
Change-Id: Ie8d99078a2cebf1da37576e5a50a798fc79c295b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/456472
Reviewed-by: Greg Daniel <egda...@google.com>
Commit-Queue: Jim Van Verth <jvan...@google.com>

[modify] https://crrev.com/daa3c703b0d8fbd0e935f429c2efc3433a451ddd/experimental/graphite/src/mtl/MtlRenderPipeline.mm
[modify] https://crrev.com/daa3c703b0d8fbd0e935f429c2efc3433a451ddd/experimental/graphite/src/mtl/MtlUtils.mm
[modify] https://crrev.com/daa3c703b0d8fbd0e935f429c2efc3433a451ddd/experimental/graphite/src/ResourceProvider.cpp
[modify] https://crrev.com/daa3c703b0d8fbd0e935f429c2efc3433a451ddd/experimental/graphite/src/mtl/MtlRenderPipeline.h
[modify] https://crrev.com/daa3c703b0d8fbd0e935f429c2efc3433a451ddd/experimental/graphite/src/ResourceProvider.h
[modify] https://crrev.com/daa3c703b0d8fbd0e935f429c2efc3433a451ddd/experimental/graphite/src/mtl/MtlResourceProvider.mm
[modify] https://crrev.com/daa3c703b0d8fbd0e935f429c2efc3433a451ddd/experimental/graphite/src/mtl/MtlUtils.h
[modify] https://crrev.com/daa3c703b0d8fbd0e935f429c2efc3433a451ddd/experimental/graphite/src/mtl/MtlResourceProvider.h

Git Watcher via monorail

unread,
Oct 6, 2021, 3:49:08 PM10/6/21
to bu...@skia.org

Comment #46 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c46


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Wed Oct 06 18:11:00 2021

[graphite] Add ResourceProvider to Gpu

Bug: skia:12466
Change-Id: I1224ad193bb9d866439673161075e29adedc0008
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/456475

Reviewed-by: Greg Daniel <egda...@google.com>
Commit-Queue: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Oct 7, 2021, 9:49:04 AM10/7/21
to bu...@skia.org

Comment #47 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c47


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/2aff315093af757b14d11da789c801f88216ab6f

commit 2aff315093af757b14d11da789c801f88216ab6f
Author: Michael Ludwig <michae...@google.com>
Date: Wed Oct 06 19:30:13 2021

[graphite] Add Shape variant over path, rect, rrect, convex poly

This is basically GrShape except that I removed some of the API that
GrStyledShape used. I also changed the set of types that Shape can
represent to be better match what I imagine our final set will be in
graphite: {empty,point,line,rect,rrect,path,arc}
-> {empty,rect,rrect,path,convex-polygon}

The convex polygon is used to store points and lines as well. I also
imagine that it will subsume the need for migrating GrQuad over.

I'm doing this on its own in preparation for moving the ClipStack over
and consolidating the draw handling in Device/DrawList, all of which
get a lot easier if there is a single type that stores the geometry.

For the first milestone, actual rendering will still likely use
Shape::asPath() for the path renderer, but it's not a lot of extra work
to preserve the logical type at the high level, so may as well do that.

There are a few functions internal to Shape that still need to be
implemented (converting a path to a list of vertices, and doing point
containment), but those can come in a later CL.

Bug: skia:12466
Change-Id: I1040c54e3b8004f3bc1767d72ded60b572b39596
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/456257
Commit-Queue: Michael Ludwig <michae...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>

[modify] https://crrev.com/2aff315093af757b14d11da789c801f88216ab6f/gn/graphite.gni
[rename] https://crrev.com/2aff315093af757b14d11da789c801f88216ab6f/experimental/graphite/src/geom/BoundsManager.h
[add] https://crrev.com/2aff315093af757b14d11da789c801f88216ab6f/experimental/graphite/src/geom/Shape.h
[add] https://crrev.com/2aff315093af757b14d11da789c801f88216ab6f/experimental/graphite/src/geom/Shape.cpp
[modify] https://crrev.com/2aff315093af757b14d11da789c801f88216ab6f/experimental/graphite/src/DrawContext.h
[modify] https://crrev.com/2aff315093af757b14d11da789c801f88216ab6f/experimental/graphite/src/DrawContext.cpp

Git Watcher via monorail

unread,
Oct 7, 2021, 10:57:13 AM10/7/21
to bu...@skia.org

Comment #48 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c48


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/e47c5d16aa2c20d3d077e18d0fcbd609244be325

commit e47c5d16aa2c20d3d077e18d0fcbd609244be325
Author: Greg Daniel <egda...@google.com>
Date: Thu Oct 07 14:17:44 2021

[graphite] Add TextureProxy support.

With this change it should now be safe to start using Proxys and Textures
everywhere. There is no caching the Proxys/Textures will live as long as
someone holds a ref.

Bug: skia:12466
Change-Id: I3c657b65b44b9dca0a77a255d6a4fc89e3862124
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/456916
Commit-Queue: Greg Daniel <egda...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>

[modify] https://crrev.com/e47c5d16aa2c20d3d077e18d0fcbd609244be325/gn/graphite.gni
[add] https://crrev.com/e47c5d16aa2c20d3d077e18d0fcbd609244be325/experimental/graphite/src/TextureProxy.h
[add] https://crrev.com/e47c5d16aa2c20d3d077e18d0fcbd609244be325/experimental/graphite/src/TextureInfo.cpp
[modify] https://crrev.com/e47c5d16aa2c20d3d077e18d0fcbd609244be325/experimental/graphite/include/TextureInfo.h
[modify] https://crrev.com/e47c5d16aa2c20d3d077e18d0fcbd609244be325/experimental/graphite/include/private/MtlTypesPriv.h
[add] https://crrev.com/e47c5d16aa2c20d3d077e18d0fcbd609244be325/experimental/graphite/src/TextureProxy.cpp

Git Watcher via monorail

unread,
Oct 8, 2021, 3:55:05 PM10/8/21
to bu...@skia.org

Comment #49 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c49


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Fri Oct 08 16:47:43 2021

[graphite] Some clean up in CommandBuffer creation

Makes the Make() method consistent with other methods by passing in
Gpu, and adds hooks for command buffer tracking.

Bug: skia:12466
Change-Id: If93c2126b1296dcbf788b5471916051fe90dafdf
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/457319
Reviewed-by: Robert Phillips <robertp...@google.com>
Reviewed-by: Michael Ludwig <michae...@google.com>

Commit-Queue: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Oct 11, 2021, 12:19:05 PM10/11/21
to bu...@skia.org

Comment #50 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c50


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/3062759ffd856dc65cbd4a308b604b21808009bf

commit 3062759ffd856dc65cbd4a308b604b21808009bf
Author: Robert Phillips <robertp...@google.com>
Date: Mon Oct 11 15:28:21 2021

[graphite] Set up unit testing system

Bug: skia:12466
Change-Id: I401a185d818a964327d323b9ebcd0850ec0b1c9b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/457318

Reviewed-by: Jim Van Verth <jvan...@google.com>
Commit-Queue: Robert Phillips <robertp...@google.com>

[modify] https://crrev.com/3062759ffd856dc65cbd4a308b604b21808009bf/dm/DMGpuTestProcs.cpp
[modify] https://crrev.com/3062759ffd856dc65cbd4a308b604b21808009bf/tools/graphite/GraphiteTestContext.cpp
[add] https://crrev.com/3062759ffd856dc65cbd4a308b604b21808009bf/tests/graphite/CapsTest.cpp
[modify] https://crrev.com/3062759ffd856dc65cbd4a308b604b21808009bf/tools/graphite/ContextFactory.cpp
[add] https://crrev.com/3062759ffd856dc65cbd4a308b604b21808009bf/experimental/graphite/src/ContextPriv.h
[modify] https://crrev.com/3062759ffd856dc65cbd4a308b604b21808009bf/tools/graphite/ContextFactory.h
[modify] https://crrev.com/3062759ffd856dc65cbd4a308b604b21808009bf/experimental/graphite/src/geom/Shape.h
[add] https://crrev.com/3062759ffd856dc65cbd4a308b604b21808009bf/tests/graphite/ShapeTest.cpp
[add] https://crrev.com/3062759ffd856dc65cbd4a308b604b21808009bf/experimental/graphite/src/ContextPriv.cpp
[modify] https://crrev.com/3062759ffd856dc65cbd4a308b604b21808009bf/gn/graphite.gni
[modify] https://crrev.com/3062759ffd856dc65cbd4a308b604b21808009bf/gn/tests.gni
[modify] https://crrev.com/3062759ffd856dc65cbd4a308b604b21808009bf/dm/DMSrcSink.cpp
[modify] https://crrev.com/3062759ffd856dc65cbd4a308b604b21808009bf/BUILD.gn
[modify] https://crrev.com/3062759ffd856dc65cbd4a308b604b21808009bf/tools/graphite/GraphiteTestContext.h
[modify] https://crrev.com/3062759ffd856dc65cbd4a308b604b21808009bf/experimental/graphite/include/Context.h
[modify] https://crrev.com/3062759ffd856dc65cbd4a308b604b21808009bf/tests/Test.h
[modify] https://crrev.com/3062759ffd856dc65cbd4a308b604b21808009bf/tools/graphite/mtl/MtlTestContext.mm
[modify] https://crrev.com/3062759ffd856dc65cbd4a308b604b21808009bf/tools/graphite/mtl/GraphiteMtlTestContext.h

Git Watcher via monorail

unread,
Oct 11, 2021, 8:25:05 PM10/11/21
to bu...@skia.org

Comment #52 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c52


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/6aa64b6ecd3de5b8e63d02b13addfd6ddb20d122

commit 6aa64b6ecd3de5b8e63d02b13addfd6ddb20d122
Author: Robert Phillips <robertp...@google.com>
Date: Mon Oct 11 17:27:28 2021

[graphite] Run the tests on the Graphite bots

and add a Release M1 test bot

Bug: skia:12466
Change-Id: Id7c7c2e01764127c5ff92be7f636aadb9022f582
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/457897

Reviewed-by: Jim Van Verth <jvan...@google.com>
Commit-Queue: Robert Phillips <robertp...@google.com>

Git Watcher via monorail

unread,
Oct 12, 2021, 4:05:05 PM10/12/21
to bu...@skia.org

Comment #53 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c53


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Tue Oct 12 19:22:34 2021

[graphite] Add command buffer submission and tracking

Bug: skia:12466
Change-Id: I965417fc1de471af33a31155abf2760d5d1b4f62
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/457317

Commit-Queue: Jim Van Verth <jvan...@google.com>
Reviewed-by: Greg Daniel <egda...@google.com>

[modify] https://crrev.com/dc6a9e3e128e9a16fdc8fc814ad56bd6806b8c53/experimental/graphite/src/ResourceProvider.h
[modify] https://crrev.com/dc6a9e3e128e9a16fdc8fc814ad56bd6806b8c53/experimental/graphite/src/mtl/MtlResourceProvider.mm
[modify] https://crrev.com/dc6a9e3e128e9a16fdc8fc814ad56bd6806b8c53/experimental/graphite/src/mtl/MtlGpu.h
[modify] https://crrev.com/dc6a9e3e128e9a16fdc8fc814ad56bd6806b8c53/experimental/graphite/src/mtl/MtlCommandBuffer.h
[modify] https://crrev.com/dc6a9e3e128e9a16fdc8fc814ad56bd6806b8c53/experimental/graphite/src/mtl/MtlResourceProvider.h
[modify] https://crrev.com/dc6a9e3e128e9a16fdc8fc814ad56bd6806b8c53/gn/graphite.gni
[modify] https://crrev.com/dc6a9e3e128e9a16fdc8fc814ad56bd6806b8c53/experimental/graphite/src/Gpu.h
[modify] https://crrev.com/dc6a9e3e128e9a16fdc8fc814ad56bd6806b8c53/experimental/graphite/src/mtl/MtlCommandBuffer.mm
[modify] https://crrev.com/dc6a9e3e128e9a16fdc8fc814ad56bd6806b8c53/experimental/graphite/src/ResourceProvider.cpp
[modify] https://crrev.com/dc6a9e3e128e9a16fdc8fc814ad56bd6806b8c53/experimental/graphite/src/mtl/MtlGpu.mm
[modify] https://crrev.com/dc6a9e3e128e9a16fdc8fc814ad56bd6806b8c53/experimental/graphite/src/Gpu.cpp
[modify] https://crrev.com/dc6a9e3e128e9a16fdc8fc814ad56bd6806b8c53/experimental/graphite/src/CommandBuffer.h
[add] https://crrev.com/dc6a9e3e128e9a16fdc8fc814ad56bd6806b8c53/experimental/graphite/src/GpuWorkSubmission.h

Git Watcher via monorail

unread,
Oct 12, 2021, 5:10:04 PM10/12/21
to bu...@skia.org

Comment #54 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c54


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/76fbbc89e99a4d9654d0f2d97a9fa43aef2be56b

commit 76fbbc89e99a4d9654d0f2d97a9fa43aef2be56b
Author: Michael Ludwig <michae...@google.com>
Date: Tue Oct 12 20:22:32 2021

[graphite] Device, DrawContext, and DrawList use Shape

Adds a line primitive back to geom::Shape since I just couldn't tolerate
drawPoints mallocing a path for every line. When Shape provides a path
like iterator, it will look equivalent to an SkPath that is a line, so
there won't be any reason to analyze an incoming path for a line, but
if we know we want a line, there's no reason to wrap it in a path.

DrawList and DrawContext now take Shapes for their path rendering funcs,
but are documented to use path rendering. It won't be like GrSDC that
tries to choose the algorithm under the hood from you.

Device has been heavily updated to funnel all the draw calls into a
new drawShape(), so the primitive functions do not malloc skpaths any
longer, even if they still end up using path renderering.

Additionally, instead of making new paints that have updated styles or
removed components, drawShape() takes an SkStrokeRec and ignores what's
on the paint, and has additional flags that tell it to ignore aspects
of the paint. This is used when it recurses, or for cases like drawPaint
where path effects and mask filters should be ignored (and eventually
other things like drawImage will ignore path effects and force a fill
style).

Bug: skia:12466
Change-Id: I4700c895ce3fefe2e437f3b4d329fd381593e037
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/457398
Commit-Queue: Michael Ludwig <michae...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>

[modify] https://crrev.com/76fbbc89e99a4d9654d0f2d97a9fa43aef2be56b/experimental/graphite/src/geom/Shape.h
[modify] https://crrev.com/76fbbc89e99a4d9654d0f2d97a9fa43aef2be56b/experimental/graphite/src/geom/Shape.cpp
[modify] https://crrev.com/76fbbc89e99a4d9654d0f2d97a9fa43aef2be56b/experimental/graphite/src/Device.cpp
[modify] https://crrev.com/76fbbc89e99a4d9654d0f2d97a9fa43aef2be56b/experimental/graphite/src/DrawList.h
[modify] https://crrev.com/76fbbc89e99a4d9654d0f2d97a9fa43aef2be56b/experimental/graphite/src/DrawContext.h
[modify] https://crrev.com/76fbbc89e99a4d9654d0f2d97a9fa43aef2be56b/experimental/graphite/src/DrawContext.cpp
[modify] https://crrev.com/76fbbc89e99a4d9654d0f2d97a9fa43aef2be56b/experimental/graphite/src/Device.h

Git Watcher via monorail

unread,
Oct 13, 2021, 10:07:07 AM10/13/21
to bu...@skia.org

Comment #55 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c55


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/76f61debc6fb925034ab4a8f621e1ab574c784c7

commit 76f61debc6fb925034ab4a8f621e1ab574c784c7
Author: Robert Phillips <robertp...@google.com>
Date: Mon Oct 11 20:28:46 2021

[graphite] Initial shader combination/precompile API

Bug: skia:12466
Change-Id: I49e1ec8308a0cde2b5d43901281d60a6f70be5c4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/457119
Reviewed-by: Brian Osman <brian...@google.com>
Commit-Queue: Robert Phillips <robertp...@google.com>

[modify] https://crrev.com/76f61debc6fb925034ab4a8f621e1ab574c784c7/experimental/graphite/src/Context.cpp
[modify] https://crrev.com/76f61debc6fb925034ab4a8f621e1ab574c784c7/dm/DMSrcSink.cpp
[modify] https://crrev.com/76f61debc6fb925034ab4a8f621e1ab574c784c7/experimental/graphite/include/Context.h

Git Watcher via monorail

unread,
Oct 13, 2021, 11:16:04 AM10/13/21
to bu...@skia.org

Comment #56 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c56


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/297d096cfb51847fe46b8ff8b7a8ce49c800030f

commit 297d096cfb51847fe46b8ff8b7a8ce49c800030f
Author: Robert Phillips <robertp...@google.com>
Date: Wed Oct 13 14:37:36 2021

[graphite] More testing infrastructure

With this CL we can run as:

dm --src gm skp tests --config grmtl -v --nocpu --nogpu

and not get all the non-Graphite unit tests.

Bug: skia:12466
Change-Id: Ib3f04f315fe4b5731a54e4c72979a0c1e00baf24
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/457898
Commit-Queue: Robert Phillips <robertp...@google.com>
Reviewed-by: Michael Ludwig <michae...@google.com>

[modify] https://crrev.com/297d096cfb51847fe46b8ff8b7a8ce49c800030f/tests/skia_test.cpp
[modify] https://crrev.com/297d096cfb51847fe46b8ff8b7a8ce49c800030f/tools/flags/CommonFlagsConfig.h
[modify] https://crrev.com/297d096cfb51847fe46b8ff8b7a8ce49c800030f/tools/graphite/ContextFactory.cpp
[modify] https://crrev.com/297d096cfb51847fe46b8ff8b7a8ce49c800030f/tools/graphite/ContextFactory.h
[modify] https://crrev.com/297d096cfb51847fe46b8ff8b7a8ce49c800030f/experimental/sktext/tests/FontResolvedText.cpp
[modify] https://crrev.com/297d096cfb51847fe46b8ff8b7a8ce49c800030f/tests/graphite/MaskTest.cpp
[modify] https://crrev.com/297d096cfb51847fe46b8ff8b7a8ce49c800030f/tools/fm/fm.cpp
[modify] https://crrev.com/297d096cfb51847fe46b8ff8b7a8ce49c800030f/experimental/sktext/tests/UnicodeText.cpp
[modify] https://crrev.com/297d096cfb51847fe46b8ff8b7a8ce49c800030f/gn/tests.gni
[modify] https://crrev.com/297d096cfb51847fe46b8ff8b7a8ce49c800030f/tools/flags/CommonFlagsConfig.cpp
[modify] https://crrev.com/297d096cfb51847fe46b8ff8b7a8ce49c800030f/experimental/sktext/tests/WrappedText.cpp
[modify] https://crrev.com/297d096cfb51847fe46b8ff8b7a8ce49c800030f/dm/DMSrcSink.cpp
[modify] https://crrev.com/297d096cfb51847fe46b8ff8b7a8ce49c800030f/experimental/sktext/tests/ShapedText.cpp
[modify] https://crrev.com/297d096cfb51847fe46b8ff8b7a8ce49c800030f/modules/skparagraph/tests/SkParagraphTest.cpp
[modify] https://crrev.com/297d096cfb51847fe46b8ff8b7a8ce49c800030f/dm/DM.cpp
[modify] https://crrev.com/297d096cfb51847fe46b8ff8b7a8ce49c800030f/experimental/sktext/tests/SelectableText.cpp
[modify] https://crrev.com/297d096cfb51847fe46b8ff8b7a8ce49c800030f/tests/Test.h
[modify] https://crrev.com/297d096cfb51847fe46b8ff8b7a8ce49c800030f/dm/DMSrcSink.h
[modify] https://crrev.com/297d096cfb51847fe46b8ff8b7a8ce49c800030f/tests/graphite/RectTest.cpp

Git Watcher via monorail

unread,
Oct 13, 2021, 1:24:22 PM10/13/21
to bu...@skia.org

Comment #57 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c57


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/170800c8119b5993937fb85f5bf9affb5acdf859

commit 170800c8119b5993937fb85f5bf9affb5acdf859
Author: Robert Phillips <robertp...@google.com>
Date: Wed Oct 13 16:10:09 2021

[graphite] Disable non-Graphite tests on Graphite bots

Bug: skia:12466
Change-Id: If14ba82501199a703cd04db28dda08bf5153141b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/458978
Reviewed-by: Michael Ludwig <michae...@google.com>
Commit-Queue: Robert Phillips <robertp...@google.com>

[modify] https://crrev.com/170800c8119b5993937fb85f5bf9affb5acdf859/infra/bots/gen_tasks_logic/dm_flags.go
[modify] https://crrev.com/170800c8119b5993937fb85f5bf9affb5acdf859/infra/bots/tasks.json

Git Watcher via monorail

unread,
Oct 13, 2021, 2:29:08 PM10/13/21
to bu...@skia.org

Comment #58 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c58


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/b9924539bbe430d346afee74c2f5aa81ba6abe96

commit b9924539bbe430d346afee74c2f5aa81ba6abe96
Author: Greg Daniel <egda...@google.com>
Date: Wed Oct 13 17:30:16 2021

[graphite] Add Buffer and MtlBuffer classes.

Bug: skia:12466
Change-Id: I3252f36c3f78642c55f127379ceba99b4845822e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/458717
Reviewed-by: Michael Ludwig <michae...@google.com>

Reviewed-by: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Oct 13, 2021, 3:43:04 PM10/13/21
to bu...@skia.org

Comment #59 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c59


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Wed Oct 13 18:49:09 2021

[graphite] Fix commandqueue memory leak

Bug: skia:12466
Change-Id: Icbd4fd6098c8a50164613e630db476bf8ea41517
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/459177
Auto-Submit: Jim Van Verth <jvan...@google.com>
Commit-Queue: Robert Phillips <robertp...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>

[modify] https://crrev.com/9467361423e0691811e66e630ef8064ed70fa4f2/tools/graphite/mtl/MtlTestContext.mm

Git Watcher via monorail

unread,
Oct 15, 2021, 9:52:17 AM10/15/21
to bu...@skia.org

Comment #60 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c60


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/a750dfcce25cc6b72070bef284ab9720d6409cd1

commit a750dfcce25cc6b72070bef284ab9720d6409cd1
Author: Robert Phillips <robertp...@google.com>
Date: Thu Oct 14 20:30:49 2021

[graphite] Rearrange internal Context/Recorder/Recording relationship

Bug: skia:12466
Change-Id: I6b15d099f3853b392f3763cd1100d89ff4e4fd1d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/459122

Reviewed-by: Jim Van Verth <jvan...@google.com>
Reviewed-by: Greg Daniel <egda...@google.com>
Commit-Queue: Robert Phillips <robertp...@google.com>

[modify] https://crrev.com/a750dfcce25cc6b72070bef284ab9720d6409cd1/experimental/graphite/src/Recorder.cpp
[modify] https://crrev.com/a750dfcce25cc6b72070bef284ab9720d6409cd1/experimental/graphite/src/Device.cpp
[modify] https://crrev.com/a750dfcce25cc6b72070bef284ab9720d6409cd1/experimental/graphite/src/Surface_Graphite.cpp
[modify] https://crrev.com/a750dfcce25cc6b72070bef284ab9720d6409cd1/experimental/graphite/src/Device.h
[modify] https://crrev.com/a750dfcce25cc6b72070bef284ab9720d6409cd1/experimental/graphite/src/Recording.h
[modify] https://crrev.com/a750dfcce25cc6b72070bef284ab9720d6409cd1/experimental/graphite/src/Recorder.h
[modify] https://crrev.com/a750dfcce25cc6b72070bef284ab9720d6409cd1/experimental/graphite/src/Gpu.h
[modify] https://crrev.com/a750dfcce25cc6b72070bef284ab9720d6409cd1/experimental/graphite/src/Context.cpp
[modify] https://crrev.com/a750dfcce25cc6b72070bef284ab9720d6409cd1/dm/DMSrcSink.cpp
[modify] https://crrev.com/a750dfcce25cc6b72070bef284ab9720d6409cd1/experimental/graphite/src/Recording.cpp
[modify] https://crrev.com/a750dfcce25cc6b72070bef284ab9720d6409cd1/experimental/graphite/src/SkStuff.cpp
[modify] https://crrev.com/a750dfcce25cc6b72070bef284ab9720d6409cd1/experimental/graphite/include/GraphiteTypes.h
[modify] https://crrev.com/a750dfcce25cc6b72070bef284ab9720d6409cd1/experimental/graphite/include/Context.h
[modify] https://crrev.com/a750dfcce25cc6b72070bef284ab9720d6409cd1/experimental/graphite/include/SkStuff.h

Git Watcher via monorail

unread,
Oct 15, 2021, 12:41:04 PM10/15/21
to bu...@skia.org

Comment #61 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c61


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/6a24fe4825b7dd553f434a29c4b3e6ad58efe161

commit 6a24fe4825b7dd553f434a29c4b3e6ad58efe161
Author: Greg Daniel <egda...@google.com>
Date: Fri Oct 15 14:31:29 2021

[graphite] Add call to ResourceProvider to get Buffer.

Bug: skia:12466
Change-Id: I4c80d5438d95562ef42531b4f66a9eaa6ff75d1f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/459877

Reviewed-by: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Oct 15, 2021, 12:41:05 PM10/15/21
to bu...@skia.org

Comment #62 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c62


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/11c4d14d899ea42764dde97b00e106d0934aca50

commit 11c4d14d899ea42764dde97b00e106d0934aca50
Author: Greg Daniel <egda...@google.com>
Date: Fri Oct 15 14:30:56 2021

[graphite] Add getter for default MSAA TextureInfo.

Bug: skia:12466
Change-Id: I663bc5ce12fc15bb4783ab9cf13cd7ccbfd9f9be
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/459876
Reviewed-by: Robert Phillips <robertp...@google.com>
Commit-Queue: Greg Daniel <egda...@google.com>

[modify] https://crrev.com/11c4d14d899ea42764dde97b00e106d0934aca50/experimental/graphite/src/Caps.h
[modify] https://crrev.com/11c4d14d899ea42764dde97b00e106d0934aca50/experimental/graphite/src/mtl/MtlCaps.h
[modify] https://crrev.com/11c4d14d899ea42764dde97b00e106d0934aca50/experimental/graphite/src/mtl/MtlCaps.mm

Git Watcher via monorail

unread,
Oct 15, 2021, 8:07:13 PM10/15/21
to bu...@skia.org

Comment #63 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c63


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/4021b947f7b0bc28813d664f840b4e368b7e087c

commit 4021b947f7b0bc28813d664f840b4e368b7e087c
Author: Michael Ludwig <michae...@google.com>
Date: Fri Oct 15 17:22:44 2021

[graphite] Add Transform that wraps matrix, inverse, type and scale factors

Transform.h is named Transform_graphite.h to avoid collision with
Transform.h in skottie/src

Bug: skia:12466
Change-Id: I017eee2bffe1a0aad605221e67540f732c2ee6b9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/459719
Commit-Queue: Michael Ludwig <michae...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>

[modify] https://crrev.com/4021b947f7b0bc28813d664f840b4e368b7e087c/gn/graphite.gni
[add] https://crrev.com/4021b947f7b0bc28813d664f840b4e368b7e087c/experimental/graphite/src/geom/Transform.cpp
[modify] https://crrev.com/4021b947f7b0bc28813d664f840b4e368b7e087c/gn/tests.gni
[add] https://crrev.com/4021b947f7b0bc28813d664f840b4e368b7e087c/experimental/graphite/src/geom/Transform_graphite.h
[add] https://crrev.com/4021b947f7b0bc28813d664f840b4e368b7e087c/tests/graphite/TransformTest.cpp
[modify] https://crrev.com/4021b947f7b0bc28813d664f840b4e368b7e087c/experimental/graphite/src/Device.cpp
[modify] https://crrev.com/4021b947f7b0bc28813d664f840b4e368b7e087c/experimental/graphite/src/DrawList.h
[modify] https://crrev.com/4021b947f7b0bc28813d664f840b4e368b7e087c/experimental/graphite/src/DrawContext.h
[modify] https://crrev.com/4021b947f7b0bc28813d664f840b4e368b7e087c/experimental/graphite/src/DrawContext.cpp
[modify] https://crrev.com/4021b947f7b0bc28813d664f840b4e368b7e087c/experimental/graphite/src/Device.h

Git Watcher via monorail

unread,
Oct 18, 2021, 10:07:06 AM10/18/21
to bu...@skia.org

Comment #64 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c64


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Fri Oct 15 21:25:19 2021

[graphite] Add resource tracking to CommandBuffer

Bug: skia:12466
Change-Id: I98acab4bbab2fdc1c359161956c3f0aa29ad7adc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/459884
Reviewed-by: Greg Daniel <egda...@google.com>

Commit-Queue: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Oct 18, 2021, 1:50:10 PM10/18/21
to bu...@skia.org

Comment #65 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c65


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Mon Oct 18 16:15:47 2021

[graphite] Add command buffer test

Adds test of command buffer submission with GPU recording (if enabled).
Also adds programmatic GPU recording support.

Bug: skia:12466
Change-Id: I85aba9f7e5e09f62f2ddc7040d1ff84bb9b4ae09
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/460337
Reviewed-by: Michael Ludwig <michae...@google.com>

Commit-Queue: Jim Van Verth <jvan...@google.com>

[modify] https://crrev.com/0c56bbaffe5f9d854c2212d7ac6ccdd900a18b4c/experimental/graphite/src/ContextPriv.cpp
[modify] https://crrev.com/0c56bbaffe5f9d854c2212d7ac6ccdd900a18b4c/experimental/graphite/src/Gpu.h
[modify] https://crrev.com/0c56bbaffe5f9d854c2212d7ac6ccdd900a18b4c/gn/tests.gni
[modify] https://crrev.com/0c56bbaffe5f9d854c2212d7ac6ccdd900a18b4c/experimental/graphite/src/mtl/MtlGpu.mm
[modify] https://crrev.com/0c56bbaffe5f9d854c2212d7ac6ccdd900a18b4c/tests/graphite/CapsTest.cpp
[modify] https://crrev.com/0c56bbaffe5f9d854c2212d7ac6ccdd900a18b4c/experimental/graphite/src/ContextPriv.h
[modify] https://crrev.com/0c56bbaffe5f9d854c2212d7ac6ccdd900a18b4c/BUILD.gn
[modify] https://crrev.com/0c56bbaffe5f9d854c2212d7ac6ccdd900a18b4c/experimental/graphite/src/mtl/MtlGpu.h
[modify] https://crrev.com/0c56bbaffe5f9d854c2212d7ac6ccdd900a18b4c/experimental/graphite/src/Gpu.cpp
[add] https://crrev.com/0c56bbaffe5f9d854c2212d7ac6ccdd900a18b4c/tests/graphite/CommandBufferTest.cpp

Git Watcher via monorail

unread,
Oct 18, 2021, 6:14:05 PM10/18/21
to bu...@skia.org

Comment #66 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c66


The following revision refers to this bug:

Git Watcher via monorail

unread,
Oct 18, 2021, 7:59:04 PM10/18/21
to bu...@skia.org

Comment #67 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c67


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/1f766792d5e32243581cfd9e8a05ae51c0ee8607

commit 1f766792d5e32243581cfd9e8a05ae51c0ee8607
Author: Robert Phillips <robertp...@google.com>
Date: Mon Oct 18 19:53:19 2021

[graphite] Copy UniformDataManager into Graphite and trim down

This attempts to salvage the reuseable portion of:

https://skia-review.googlesource.com/c/skia/+/440841 (New approach to GrProcessor uniforms)

It also removes the old code's Gr- dependencies.

Bug: skia:12466
Change-Id: I7f7f3a9f9b4f3e282af1caeb02d2b305e6756025
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/460556
Reviewed-by: Greg Daniel <egda...@google.com>
Commit-Queue: Robert Phillips <robertp...@google.com>

[add] https://crrev.com/1f766792d5e32243581cfd9e8a05ae51c0ee8607/experimental/graphite/src/UniformDataManager.cpp
[modify] https://crrev.com/1f766792d5e32243581cfd9e8a05ae51c0ee8607/gn/graphite.gni
[add] https://crrev.com/1f766792d5e32243581cfd9e8a05ae51c0ee8607/experimental/graphite/src/UniformDataManager.h
[modify] https://crrev.com/1f766792d5e32243581cfd9e8a05ae51c0ee8607/experimental/graphite/include/private/GraphiteTypesPriv.h

Git Watcher via monorail

unread,
Oct 19, 2021, 1:35:06 PM10/19/21
to bu...@skia.org

Comment #68 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c68


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Tue Oct 19 16:54:50 2021

[graphite] Add RenderPass setup and test

Bug: skia:12466
Change-Id: Ibbb4894c6a46dd8853909214da85314f9abc3959
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/459880

Commit-Queue: Jim Van Verth <jvan...@google.com>
Reviewed-by: Greg Daniel <egda...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>

[modify] https://crrev.com/f3f2e758203218d54222f184473b1f6d519044f1/gn/graphite.gni
[modify] https://crrev.com/f3f2e758203218d54222f184473b1f6d519044f1/experimental/graphite/src/mtl/MtlCommandBuffer.mm
[add] https://crrev.com/f3f2e758203218d54222f184473b1f6d519044f1/experimental/graphite/src/mtl/MtlRenderCommandEncoder.h
[modify] https://crrev.com/f3f2e758203218d54222f184473b1f6d519044f1/experimental/graphite/include/private/GraphiteTypesPriv.h
[modify] https://crrev.com/f3f2e758203218d54222f184473b1f6d519044f1/experimental/graphite/src/Gpu.cpp
[modify] https://crrev.com/f3f2e758203218d54222f184473b1f6d519044f1/experimental/graphite/src/mtl/MtlCommandBuffer.h
[modify] https://crrev.com/f3f2e758203218d54222f184473b1f6d519044f1/tests/graphite/CommandBufferTest.cpp
[modify] https://crrev.com/f3f2e758203218d54222f184473b1f6d519044f1/experimental/graphite/src/CommandBuffer.h

Git Watcher via monorail

unread,
Oct 19, 2021, 1:37:04 PM10/19/21
to bu...@skia.org

Comment #69 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c69


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Tue Oct 19 16:58:33 2021

[graphite] Remove CapsTest

Bug: skia:12466
Change-Id: Ibb99647cf151fb45901aee340d60914611c2ba75
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/461096
Auto-Submit: Jim Van Verth <jvan...@google.com>
Commit-Queue: Robert Phillips <robertp...@google.com>
Reviewed-by: Robert Phillips <robertp...@google.com>

[modify] https://crrev.com/a2645f2f5f8ebdaf619e7125c12b983c35a5838f/gn/tests.gni
[delete] https://crrev.com/f3f2e758203218d54222f184473b1f6d519044f1/tests/graphite/CapsTest.cpp

Git Watcher via monorail

unread,
Oct 19, 2021, 2:08:05 PM10/19/21
to bu...@skia.org

Comment #70 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c70


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/e1bfa18fc512eaca302bffa2f3d2ad2b6428aecd

commit e1bfa18fc512eaca302bffa2f3d2ad2b6428aecd
Author: Chris Dalton <csmart...@google.com>
Date: Mon Oct 18 23:11:00 2021

[graphite] Rect::isEmptyOrNegative() -> Rect::isEmptyNegativeOrNan()

Bug: skia:12466
Change-Id: I89d41509b8158aabac5250f035115954e8ae7f4b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/460655
Commit-Queue: Chris Dalton <csmart...@google.com>
Reviewed-by: Michael Ludwig <michae...@google.com>

[modify] https://crrev.com/e1bfa18fc512eaca302bffa2f3d2ad2b6428aecd/experimental/graphite/src/geom/Rect.h
[modify] https://crrev.com/e1bfa18fc512eaca302bffa2f3d2ad2b6428aecd/tests/graphite/RectTest.cpp

Git Watcher via monorail

unread,
Oct 19, 2021, 3:46:04 PM10/19/21
to bu...@skia.org

Comment #71 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c71


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/2fceb21cb7ce61ffc6bc2e30df9557d39c089ceb

commit 2fceb21cb7ce61ffc6bc2e30df9557d39c089ceb
Author: Chris Dalton <csmart...@google.com>
Date: Tue Oct 19 19:04:41 2021

[graphite] Add an IntersectionTree class

Implements a BSP tree with NEON/SSE optimizations that tracks
non-overlapping regions. This object can be used batch sets of paths
into non-overlapping draws. Performance on AppleM1 with our existing
benchmarks looks very promising:

desk_motionmarkarcs.skp 1227 paths -> 69 draws 450us
desk_motionmarksuits.skp 1417 paths -> 26 draws 201us
desk_chalkboard.skp 1940 paths -> 11 draws 84us
desk_ynevsvg.skp 859 paths -> 10 draws 31us
desk_micrographygirl.skp 318 paths -> 29 draws 11us

Bug: skia:12466
Change-Id: I847a93ed726dea10cb403cb76e578bd81eb920d2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/460298
Commit-Queue: Chris Dalton <csmart...@google.com>
Reviewed-by: Herb Derby <he...@google.com>

[modify] https://crrev.com/2fceb21cb7ce61ffc6bc2e30df9557d39c089ceb/gn/graphite.gni
[modify] https://crrev.com/2fceb21cb7ce61ffc6bc2e30df9557d39c089ceb/gn/tests.gni
[add] https://crrev.com/2fceb21cb7ce61ffc6bc2e30df9557d39c089ceb/bench/graphite/IntersectionTreeBench.cpp
[add] https://crrev.com/2fceb21cb7ce61ffc6bc2e30df9557d39c089ceb/experimental/graphite/src/geom/IntersectionTree.h
[modify] https://crrev.com/2fceb21cb7ce61ffc6bc2e30df9557d39c089ceb/BUILD.gn
[add] https://crrev.com/2fceb21cb7ce61ffc6bc2e30df9557d39c089ceb/tests/graphite/IntersectionTreeTest.cpp
[modify] https://crrev.com/2fceb21cb7ce61ffc6bc2e30df9557d39c089ceb/gn/bench.gni
[add] https://crrev.com/2fceb21cb7ce61ffc6bc2e30df9557d39c089ceb/experimental/graphite/src/geom/IntersectionTree.cpp

Git Watcher via monorail

unread,
Oct 19, 2021, 7:08:13 PM10/19/21
to bu...@skia.org

Comment #72 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c72


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Tue Oct 19 17:51:16 2021

[graphite] Use std::move when adding RenderPass attachment to CmdBuffer

This step was missing from the previous CL.

Bug: skia:12466
Change-Id: I3da0082efefbabf6008fc8962d706f75f0743ecc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/461176

Auto-Submit: Jim Van Verth <jvan...@google.com>
Reviewed-by: Greg Daniel <egda...@google.com>

Commit-Queue: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Oct 19, 2021, 7:26:04 PM10/19/21
to bu...@skia.org

Comment #73 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c73


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/3793335614a50fbf900d471661a45948b10fbbe6

commit 3793335614a50fbf900d471661a45948b10fbbe6
Author: Michael Ludwig <michae...@google.com>
Date: Tue Oct 19 20:18:02 2021

[graphite] Update Shape to use skgpu::Rect and float2

Switches Shape to store kRect types as skgpu::Rect instead of SkRect,
although it can be constructed or set from an SkRect. It returns a Rect
from rect() and bounds() now.

Also switches out the line to be constructed from float2's, and re-use
the fRect storage to store the first segment vertex in topLeft and
the second vertex in botRight.

Bug: skia:12466
Change-Id: I1032fb6f222b0853305186c0e34091b014ae0cea
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/460577
Reviewed-by: Chris Dalton <csmart...@google.com>
Commit-Queue: Michael Ludwig <michae...@google.com>

[modify] https://crrev.com/3793335614a50fbf900d471661a45948b10fbbe6/experimental/graphite/src/geom/Rect.h
[modify] https://crrev.com/3793335614a50fbf900d471661a45948b10fbbe6/experimental/graphite/src/geom/Shape.h
[modify] https://crrev.com/3793335614a50fbf900d471661a45948b10fbbe6/experimental/graphite/src/geom/Shape.cpp
[modify] https://crrev.com/3793335614a50fbf900d471661a45948b10fbbe6/tests/graphite/RectTest.cpp

Git Watcher via monorail

unread,
Oct 19, 2021, 8:05:49 PM10/19/21
to bu...@skia.org

Comment #74 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c74


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/40b143c1743bbb3327689627b97426724ec56bcc

commit 40b143c1743bbb3327689627b97426724ec56bcc
Author: Michael Ludwig <michae...@google.com>
Date: Tue Oct 19 20:19:48 2021

[graphite] Add mapRect(skgpu::Rect) to Transform

While we won't be transforming shapes, we do need an accurate way to
transform bounding boxes to device space. Right now this just uses
SkM44's mapRect function and converts to/from an SkRect. However,
under the hood SkM44 uses a similar negation trick as skgpu::Rect so
I need to explore if using Rect's internal structure directly will let
us compute the bounding box with fewer operations.

Additionally, SkM44's mapRect clips to a fixed w=epsilon plane, and I
think Transform::mapRect should just do the right thing and handle
w clipping/projection as accurately as possible.

Bug: skia:12466
Change-Id: I08c9df6c40cbcdcd8f622baae222bdf361d59070
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/460578
Commit-Queue: Michael Ludwig <michae...@google.com>
Reviewed-by: Chris Dalton <csmart...@google.com>

[modify] https://crrev.com/40b143c1743bbb3327689627b97426724ec56bcc/experimental/graphite/src/geom/Transform.cpp
[modify] https://crrev.com/40b143c1743bbb3327689627b97426724ec56bcc/experimental/graphite/src/geom/Transform_graphite.h

Git Watcher via monorail

unread,
Oct 20, 2021, 10:13:11 AM10/20/21
to bu...@skia.org

Comment #75 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c75


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/8582724780d82aa89bf3772386b42453a9dd27d9

commit 8582724780d82aa89bf3772386b42453a9dd27d9
Author: Greg Daniel <egda...@google.com>
Date: Wed Oct 20 13:24:34 2021

[graphite] Add copyTextureToBuffer call on CommandBuffer.

Bug: skia:12466
Change-Id: I44bd3899dea817318f83444f023c1c8adcfc2d1e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/459881
Commit-Queue: Greg Daniel <egda...@google.com>
Reviewed-by: Jim Van Verth <jvan...@google.com>

[modify] https://crrev.com/8582724780d82aa89bf3772386b42453a9dd27d9/gn/graphite.gni
[modify] https://crrev.com/8582724780d82aa89bf3772386b42453a9dd27d9/experimental/graphite/src/mtl/MtlCommandBuffer.mm
[add] https://crrev.com/8582724780d82aa89bf3772386b42453a9dd27d9/experimental/graphite/src/mtl/MtlBlitCommandEncoder.h
[modify] https://crrev.com/8582724780d82aa89bf3772386b42453a9dd27d9/experimental/graphite/src/mtl/MtlBuffer.h
[modify] https://crrev.com/8582724780d82aa89bf3772386b42453a9dd27d9/experimental/graphite/src/mtl/MtlCommandBuffer.h
[modify] https://crrev.com/8582724780d82aa89bf3772386b42453a9dd27d9/experimental/graphite/src/CommandBuffer.h

Git Watcher via monorail

unread,
Oct 20, 2021, 10:57:04 AM10/20/21
to bu...@skia.org

Comment #76 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c76


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Wed Oct 20 14:24:57 2021

[graphite] Fix non-Metal compile error

Bug: skia:12466
Change-Id: I2e0421191d05c3e0f457425e0dab49c2afb9c2b9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/461477

Commit-Queue: Jim Van Verth <jvan...@google.com>
Commit-Queue: Chris Dalton <csmart...@google.com>

Auto-Submit: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Oct 20, 2021, 1:16:12 PM10/20/21
to bu...@skia.org

Comment #77 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c77


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/ac29367c91a23a9fd770e8e416fc8cf941550126

commit ac29367c91a23a9fd770e8e416fc8cf941550126
Author: Greg Daniel <egda...@google.com>
Date: Wed Oct 20 16:31:20 2021

[graphite] Fix graphite iOS build.

Bug: skia:12466
Change-Id: Id0419836ca96d99836879d509ca2cd1c9244d76f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/461598
Commit-Queue: Greg Daniel <egda...@google.com>

Commit-Queue: Jim Van Verth <jvan...@google.com>
Auto-Submit: Greg Daniel <egda...@google.com>

Reviewed-by: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Oct 20, 2021, 4:21:10 PM10/20/21
to bu...@skia.org

Comment #78 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c78


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/251e7e6bfda2f684f203285a67f1c19feb017faf

commit 251e7e6bfda2f684f203285a67f1c19feb017faf
Author: Michael Ludwig <michae...@google.com>
Date: Tue Oct 19 23:28:47 2021

[graphite] Wire up BoundsManager for color/depth ordering

Except that applyClipToDraw doesn't actually evaluate any clip shapes,
and the BoundsManager is the slow/naive one, I think all the changes to
Device fully implement the tracking/work needed for color/depth sorting.

Bug: skia:12466
Change-Id: I74f38e56d34d822c2be35f1ebedfb7c00b87f04c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/460616

Reviewed-by: Chris Dalton <csmart...@google.com>
Commit-Queue: Michael Ludwig <michae...@google.com>

Git Watcher via monorail

unread,
Oct 20, 2021, 4:54:05 PM10/20/21
to bu...@skia.org

Comment #79 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c79


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Wed Oct 20 20:09:35 2021

[graphite] Take two at fixing non-Metal build

Bug: skia:12466
Change-Id: I7eb240985ce0c267bbc7be040e0f812407d31435
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/461699

Commit-Queue: Jim Van Verth <jvan...@google.com>
Commit-Queue: Greg Daniel <egda...@google.com>

Auto-Submit: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Oct 21, 2021, 10:55:05 AM10/21/21
to bu...@skia.org

Comment #80 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c80


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Thu Oct 21 14:17:42 2021

[graphite] Implement remainder of RenderCommandEncoder methods

Bug: skia:12466
Change-Id: I7be58aca7eedf18e4157d9473216785eead8c89a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/461700

Commit-Queue: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Oct 21, 2021, 2:51:06 PM10/21/21
to bu...@skia.org

Comment #81 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c81


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/09f48647347ade081701328444845c337db89258

commit 09f48647347ade081701328444845c337db89258
Author: Chris Dalton <csmart...@google.com>
Date: Thu Oct 21 18:10:57 2021

Convert GrVertexWriter to a "stream syntax" API

This helps remove all Ganesh dependencies from GrVertexWriter so it can
be shared with Graphite.

Bug: skia:12466
Change-Id: I1ede1cfc48d501cb1e028bca1e8590e6c92f4e4d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/462316
Commit-Queue: Chris Dalton <csmart...@google.com>
Reviewed-by: Brian Osman <brian...@google.com>

[modify] https://crrev.com/09f48647347ade081701328444845c337db89258/src/gpu/tessellate/PathCurveTessellator.cpp
[modify] https://crrev.com/09f48647347ade081701328444845c337db89258/src/gpu/ops/PathStencilCoverOp.cpp
[modify] https://crrev.com/09f48647347ade081701328444845c337db89258/src/gpu/tessellate/MiddleOutPolygonTriangulator.h
[modify] https://crrev.com/09f48647347ade081701328444845c337db89258/src/gpu/ops/AALinearizingConvexPathRenderer.cpp
[modify] https://crrev.com/09f48647347ade081701328444845c337db89258/tests/DMSAATest.cpp
[modify] https://crrev.com/09f48647347ade081701328444845c337db89258/src/gpu/geometry/GrPathUtils.h
[modify] https://crrev.com/09f48647347ade081701328444845c337db89258/src/gpu/ops/AAConvexPathRenderer.cpp
[modify] https://crrev.com/09f48647347ade081701328444845c337db89258/src/gpu/GrVertexChunkArray.h
[modify] https://crrev.com/09f48647347ade081701328444845c337db89258/src/gpu/ops/DrawVerticesOp.cpp
[modify] https://crrev.com/09f48647347ade081701328444845c337db89258/src/gpu/ops/GrOvalOpFactory.cpp
[modify] https://crrev.com/09f48647347ade081701328444845c337db89258/src/gpu/tessellate/PathWedgeTessellator.cpp
[modify] https://crrev.com/09f48647347ade081701328444845c337db89258/src/gpu/GrColor.h
[modify] https://crrev.com/09f48647347ade081701328444845c337db89258/src/gpu/tessellate/PathXform.h
[modify] https://crrev.com/09f48647347ade081701328444845c337db89258/src/gpu/tessellate/shaders/GrStrokeTessellationShader_InstancedImpl.cpp
[modify] https://crrev.com/09f48647347ade081701328444845c337db89258/src/gpu/tessellate/StrokeHardwareTessellator.cpp
[modify] https://crrev.com/09f48647347ade081701328444845c337db89258/src/gpu/GrVertexWriter.h
[modify] https://crrev.com/09f48647347ade081701328444845c337db89258/src/gpu/ops/QuadPerEdgeAA.cpp
[modify] https://crrev.com/09f48647347ade081701328444845c337db89258/src/gpu/ops/LatticeOp.cpp
[modify] https://crrev.com/09f48647347ade081701328444845c337db89258/src/gpu/ops/AtlasInstancedHelper.cpp
[modify] https://crrev.com/09f48647347ade081701328444845c337db89258/src/gpu/ops/FillRRectOp.cpp
[modify] https://crrev.com/09f48647347ade081701328444845c337db89258/src/gpu/geometry/GrTriangulator.cpp
[modify] https://crrev.com/09f48647347ade081701328444845c337db89258/src/gpu/ops/DrawAtlasPathOp.cpp
[modify] https://crrev.com/09f48647347ade081701328444845c337db89258/src/gpu/tessellate/shaders/GrTessellationShader.h
[modify] https://crrev.com/09f48647347ade081701328444845c337db89258/src/gpu/tessellate/StrokeFixedCountTessellator.cpp
[modify] https://crrev.com/09f48647347ade081701328444845c337db89258/src/gpu/tessellate/shaders/GrPathTessellationShader_MiddleOut.cpp

Git Watcher via monorail

unread,
Oct 21, 2021, 3:35:09 PM10/21/21
to bu...@skia.org

Comment #82 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c82


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Thu Oct 21 14:12:17 2021

[graphite] Add pipeline and draw support

Bug: skia:12466
Change-Id: I5c0c919d4523258a11b4545346093953a4f09c7e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/461597
Reviewed-by: Michael Ludwig <michae...@google.com>

Commit-Queue: Jim Van Verth <jvan...@google.com>

[modify] https://crrev.com/dbd3b1b04c8aab762e59dfae6d7c72f86b0d7419/experimental/graphite/src/mtl/MtlRenderPipeline.mm
[modify] https://crrev.com/dbd3b1b04c8aab762e59dfae6d7c72f86b0d7419/experimental/graphite/src/CommandBuffer.cpp
[modify] https://crrev.com/dbd3b1b04c8aab762e59dfae6d7c72f86b0d7419/experimental/graphite/src/ResourceProvider.h
[modify] https://crrev.com/dbd3b1b04c8aab762e59dfae6d7c72f86b0d7419/experimental/graphite/src/mtl/MtlResourceProvider.mm
[modify] https://crrev.com/dbd3b1b04c8aab762e59dfae6d7c72f86b0d7419/experimental/graphite/src/mtl/MtlCommandBuffer.h
[modify] https://crrev.com/dbd3b1b04c8aab762e59dfae6d7c72f86b0d7419/tests/graphite/CommandBufferTest.cpp
[modify] https://crrev.com/dbd3b1b04c8aab762e59dfae6d7c72f86b0d7419/experimental/graphite/src/mtl/MtlResourceProvider.h
[modify] https://crrev.com/dbd3b1b04c8aab762e59dfae6d7c72f86b0d7419/experimental/graphite/src/mtl/MtlCommandBuffer.mm
[modify] https://crrev.com/dbd3b1b04c8aab762e59dfae6d7c72f86b0d7419/experimental/graphite/src/ResourceProvider.cpp
[modify] https://crrev.com/dbd3b1b04c8aab762e59dfae6d7c72f86b0d7419/experimental/graphite/src/mtl/MtlRenderPipeline.h
[modify] https://crrev.com/dbd3b1b04c8aab762e59dfae6d7c72f86b0d7419/experimental/graphite/src/RenderPipeline.h
[modify] https://crrev.com/dbd3b1b04c8aab762e59dfae6d7c72f86b0d7419/experimental/graphite/include/private/GraphiteTypesPriv.h
[modify] https://crrev.com/dbd3b1b04c8aab762e59dfae6d7c72f86b0d7419/experimental/graphite/src/CommandBuffer.h

Git Watcher via monorail

unread,
Oct 21, 2021, 5:26:05 PM10/21/21
to bu...@skia.org

Comment #83 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c83


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Thu Oct 21 19:49:37 2021

[graphite] Move work and resource tracking to CommandBuffer base class.

Also adds test of texture copyback to CommandBufferTest, and
endEncoding() to BlitCommandEncoder.

Bug: skia:12466
Change-Id: I57e4646aacc1d950cc16b70d7feeced1a04e6867
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/462078
Reviewed-by: Greg Daniel <egda...@google.com>

Commit-Queue: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Oct 25, 2021, 8:18:04 PM10/25/21
to bu...@skia.org

Comment #84 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c84


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/8744f3b84ddcf9fc7b817e2893463ecb74e4c2a1

commit 8744f3b84ddcf9fc7b817e2893463ecb74e4c2a1
Author: Michael Ludwig <michae...@google.com>
Date: Mon Oct 25 18:22:59 2021

[graphite] Remove unused prior task depdency on RenderPassTask

Bug: skia:12466
Change-Id: I794de6af814ab1b3e9517e139582e06382ecf957
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/462881
Commit-Queue: Michael Ludwig <michae...@google.com>
Reviewed-by: Greg Daniel <egda...@google.com>
Reviewed-by: Jim Van Verth <jvan...@google.com>

[modify] https://crrev.com/8744f3b84ddcf9fc7b817e2893463ecb74e4c2a1/experimental/graphite/src/RenderPassTask.cpp
[modify] https://crrev.com/8744f3b84ddcf9fc7b817e2893463ecb74e4c2a1/experimental/graphite/src/RenderPassTask.h
[modify] https://crrev.com/8744f3b84ddcf9fc7b817e2893463ecb74e4c2a1/experimental/graphite/src/DrawContext.h
[modify] https://crrev.com/8744f3b84ddcf9fc7b817e2893463ecb74e4c2a1/experimental/graphite/src/DrawContext.cpp

Git Watcher via monorail

unread,
Oct 25, 2021, 8:58:12 PM10/25/21
to bu...@skia.org

Comment #85 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c85


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/1f27d9ad54ad8bacaffb57084bfef6463f0e7c6e

commit 1f27d9ad54ad8bacaffb57084bfef6463f0e7c6e
Author: Michael Ludwig <michae...@google.com>
Date: Mon Oct 25 20:41:51 2021

[graphite] Stub out Renderer and RenderStep

Bug: skia:12466
Change-Id: I8a31cd8480199a941dfc1d9d1092f8a1dafdb0da
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/462882
Commit-Queue: Michael Ludwig <michae...@google.com>
Reviewed-by: Chris Dalton <csmart...@google.com>

Reviewed-by: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Oct 25, 2021, 9:26:05 PM10/25/21
to bu...@skia.org

Comment #86 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c86


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/a21aacf7c76df6cb1fdb7845370244f6e64e178b

commit a21aacf7c76df6cb1fdb7845370244f6e64e178b
Author: Greg Daniel <egda...@google.com>
Date: Mon Oct 25 20:47:46 2021

[graphite] Allow graphite to compile without ganesh and add shared gn files.

With this you should be able to set skia_enable_gpu=false in your gn
args and still be able to compile and run graphite.

Bug: skia:12466
Change-Id: Ibffc8774a8c46afad3f717dabc54fa831338a807
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/463317
Commit-Queue: Greg Daniel <egda...@google.com>

Reviewed-by: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Oct 26, 2021, 10:08:07 AM10/26/21
to bu...@skia.org

Comment #87 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c87


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Tue Oct 26 13:23:59 2021

[graphite] Reorganize CommandBuffer a little

* Keep RenderPass-related routines together
* Rename setRenderPipeline to bindRenderPipeline
* Pass resources as const& to platform-specific routines, to avoid
copies.

Bug: skia:12466
Change-Id: I4c3ea006263ace4a050b6c86f70163f5fd5e254a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/463336
Reviewed-by: Greg Daniel <egda...@google.com>
Commit-Queue: Jim Van Verth <jvan...@google.com>

[modify] https://crrev.com/649e3c2f980d9e1affcf781cccf61a940113a24f/experimental/graphite/src/mtl/MtlCommandBuffer.mm
[modify] https://crrev.com/649e3c2f980d9e1affcf781cccf61a940113a24f/experimental/graphite/src/mtl/MtlRenderPipeline.h
[modify] https://crrev.com/649e3c2f980d9e1affcf781cccf61a940113a24f/experimental/graphite/src/CommandBuffer.cpp
[modify] https://crrev.com/649e3c2f980d9e1affcf781cccf61a940113a24f/experimental/graphite/src/mtl/MtlCommandBuffer.h
[modify] https://crrev.com/649e3c2f980d9e1affcf781cccf61a940113a24f/tests/graphite/CommandBufferTest.cpp
[modify] https://crrev.com/649e3c2f980d9e1affcf781cccf61a940113a24f/experimental/graphite/src/CommandBuffer.h

Git Watcher via monorail

unread,
Oct 26, 2021, 11:16:26 AM10/26/21
to bu...@skia.org

Comment #88 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c88


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/04bff8ba6e501d991af77dfb47e8436a0f175997

commit 04bff8ba6e501d991af77dfb47e8436a0f175997
Author: Michael Ludwig <michae...@google.com>
Date: Tue Oct 26 00:29:20 2021

[graphite] Consolidate ordering constraints into DrawOrder type

Bug: skia:12466
Change-Id: I734c3a9595948dfb74f8ec72684183fe743bfefb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/462883
Auto-Submit: Michael Ludwig <michae...@google.com>

Commit-Queue: Jim Van Verth <jvan...@google.com>
Reviewed-by: Jim Van Verth <jvan...@google.com>

[modify] https://crrev.com/04bff8ba6e501d991af77dfb47e8436a0f175997/gn/graphite.gni
[modify] https://crrev.com/04bff8ba6e501d991af77dfb47e8436a0f175997/experimental/graphite/src/geom/BoundsManager.h
[modify] https://crrev.com/04bff8ba6e501d991af77dfb47e8436a0f175997/experimental/graphite/src/DrawPass.cpp
[add] https://crrev.com/04bff8ba6e501d991af77dfb47e8436a0f175997/experimental/graphite/src/DrawOrder.h
[modify] https://crrev.com/04bff8ba6e501d991af77dfb47e8436a0f175997/experimental/graphite/include/GraphiteTypes.h
[modify] https://crrev.com/04bff8ba6e501d991af77dfb47e8436a0f175997/experimental/graphite/src/Device.cpp
[modify] https://crrev.com/04bff8ba6e501d991af77dfb47e8436a0f175997/experimental/graphite/src/DrawContext.h
[modify] https://crrev.com/04bff8ba6e501d991af77dfb47e8436a0f175997/experimental/graphite/src/DrawList.h
[modify] https://crrev.com/04bff8ba6e501d991af77dfb47e8436a0f175997/experimental/graphite/src/DrawContext.cpp
[modify] https://crrev.com/04bff8ba6e501d991af77dfb47e8436a0f175997/experimental/graphite/src/Device.h

Git Watcher via monorail

unread,
Oct 26, 2021, 11:19:55 AM10/26/21
to bu...@skia.org

Comment #89 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c89


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/2a372177e83dc025d7e23fdaee822ae02a68b517

commit 2a372177e83dc025d7e23fdaee822ae02a68b517
Author: Michael Ludwig <michae...@google.com>
Date: Tue Oct 26 00:42:43 2021

[graphite] Max draw count in DrawList

Bug: skia:12466
Change-Id: Ic312ce41b5eb0ae0c20e6b76032b984d9a406d89
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/462884

Commit-Queue: Jim Van Verth <jvan...@google.com>

Git Watcher via monorail

unread,
Oct 26, 2021, 11:41:13 AM10/26/21
to bu...@skia.org

Comment #90 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c90


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Tue Oct 26 14:25:57 2021

[graphite] Add uniform buffer support to command buffer

Bug: skia:12466
Change-Id: Ie4c1973427e96d84b77f28edb5a4d6f1d53ef8aa
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/463316

Commit-Queue: Jim Van Verth <jvan...@google.com>
Reviewed-by: Greg Daniel <egda...@google.com>

[modify] https://crrev.com/c545aa5aa665755da351b07230f164a888fbe528/experimental/graphite/src/mtl/MtlCommandBuffer.mm
[modify] https://crrev.com/c545aa5aa665755da351b07230f164a888fbe528/experimental/graphite/src/mtl/MtlRenderPipeline.mm
[modify] https://crrev.com/c545aa5aa665755da351b07230f164a888fbe528/experimental/graphite/src/CommandBuffer.cpp
[modify] https://crrev.com/c545aa5aa665755da351b07230f164a888fbe528/experimental/graphite/src/RenderPipelineDesc.h
[modify] https://crrev.com/c545aa5aa665755da351b07230f164a888fbe528/tests/graphite/CommandBufferTest.cpp
[modify] https://crrev.com/c545aa5aa665755da351b07230f164a888fbe528/experimental/graphite/src/mtl/MtlCommandBuffer.h
[modify] https://crrev.com/c545aa5aa665755da351b07230f164a888fbe528/experimental/graphite/src/CommandBuffer.h

Git Watcher via monorail

unread,
Oct 26, 2021, 12:27:05 PM10/26/21
to bu...@skia.org

Comment #91 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c91


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/ef8907c69f77b0c4e7b7a64434fda72ab7611091

commit ef8907c69f77b0c4e7b7a64434fda72ab7611091
Author: Robert Phillips <robertp...@google.com>
Date: Tue Oct 26 15:39:20 2021

[graphite] Rename UniformDataManager to UniformManager and update

Gerrit didn't do so well on this CL. What's changed in the UniformManager is:

a lot of unused stuff was pared out of the UniformDataManager
the Write methods now return the number of bytes written in the call (incl. padding)
all the "#ifdef SK_DEBUG" stuff is new to validate against the prior way of writing uniforms

Bug: skia:12466
Change-Id: I172a74273c774257f751750aef37f4bd4c4e7e7b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/463458
Reviewed-by: Greg Daniel <egda...@google.com>

Reviewed-by: Jim Van Verth <jvan...@google.com>
Commit-Queue: Robert Phillips <robertp...@google.com>

[delete] https://crrev.com/f6fb3db1dc9edc00173dfd368185d72663994481/experimental/graphite/src/UniformDataManager.cpp
[modify] https://crrev.com/ef8907c69f77b0c4e7b7a64434fda72ab7611091/gn/graphite.gni
[add] https://crrev.com/ef8907c69f77b0c4e7b7a64434fda72ab7611091/experimental/graphite/src/UniformManager.cpp
[delete] https://crrev.com/f6fb3db1dc9edc00173dfd368185d72663994481/experimental/graphite/src/UniformDataManager.h
[add] https://crrev.com/ef8907c69f77b0c4e7b7a64434fda72ab7611091/experimental/graphite/src/Uniform.h
[modify] https://crrev.com/ef8907c69f77b0c4e7b7a64434fda72ab7611091/experimental/graphite/include/private/GraphiteTypesPriv.h
[add] https://crrev.com/ef8907c69f77b0c4e7b7a64434fda72ab7611091/experimental/graphite/src/UniformManager.h

Git Watcher via monorail

unread,
Oct 26, 2021, 12:55:13 PM10/26/21
to bu...@skia.org

Comment #92 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c92


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Tue Oct 26 16:12:50 2021

[graphite] Fix link error in DrawOrder.h

Bug: skia:12466
Change-Id: I1e7812e3600cacc8fe678e924d48c27fb8b88138
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/463716
Commit-Queue: Jim Van Verth <jvan...@google.com>
Commit-Queue: Greg Daniel <egda...@google.com>
Auto-Submit: Jim Van Verth <jvan...@google.com>
Reviewed-by: Greg Daniel <egda...@google.com>

[modify] https://crrev.com/215b48dc23e628ceefc39a84b78206d1a3152daa/experimental/graphite/src/DrawOrder.h

Git Watcher via monorail

unread,
Oct 26, 2021, 8:21:09 PM10/26/21
to bu...@skia.org

Comment #93 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c93


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/c75e0ef2b31d6d2682cd25195564d0b1abeefc91

commit c75e0ef2b31d6d2682cd25195564d0b1abeefc91
Author: Greg Daniel <egda...@google.com>
Date: Tue Oct 26 23:46:47 2021

[graphite] Add IndexWriter and UniformWriter classes.

This also adds a base class BufferWriter which Vertex, Index, and
Uniform Writers inherit from

Bug: skia:12466
Change-Id: Icbac1210fbbd07321f9d88728ddde1e761fe4bb0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/463496
Commit-Queue: Greg Daniel <egda...@google.com>
Reviewed-by: Chris Dalton <csmart...@google.com>

[rename] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/src/gpu/BufferWriter.h
[modify] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/src/gpu/tessellate/MiddleOutPolygonTriangulator.h
[modify] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/src/gpu/GrResourceProvider.cpp
[modify] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/src/gpu/tessellate/PathTessellator.h
[modify] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/src/gpu/ops/AALinearizingConvexPathRenderer.cpp
[modify] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/src/gpu/ops/DashOp.cpp
[modify] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/src/gpu/geometry/GrPathUtils.h
[modify] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/src/gpu/ops/SmallPathRenderer.cpp
[modify] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/src/gpu/ops/AAConvexPathRenderer.cpp
[modify] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/src/gpu/GrVertexChunkArray.h
[modify] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/tools/gpu/TestOps.cpp
[modify] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/src/gpu/ops/QuadPerEdgeAA.h
[modify] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/src/gpu/ops/DrawVerticesOp.cpp
[modify] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/src/gpu/ops/GrOvalOpFactory.cpp
[modify] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/src/gpu/GrColor.h
[modify] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/src/gpu/tessellate/PathXform.h
[modify] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/src/gpu/ops/LatticeOp.cpp
[modify] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/src/gpu/ops/AtlasInstancedHelper.cpp
[modify] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/src/gpu/ops/FillRRectOp.cpp
[modify] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/gn/gpu.gni
[modify] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/src/gpu/geometry/GrTriangulator.cpp
[modify] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/src/gpu/geometry/GrQuad.h
[modify] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/src/gpu/ops/DrawAtlasPathOp.cpp
[modify] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/src/gpu/ops/RegionOp.cpp
[modify] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/src/gpu/tessellate/shaders/GrTessellationShader.h
[modify] https://crrev.com/c75e0ef2b31d6d2682cd25195564d0b1abeefc91/src/gpu/ops/StrokeRectOp.cpp

Git Watcher via monorail

unread,
Oct 27, 2021, 9:58:06 AM10/27/21
to bu...@skia.org

Comment #94 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c94


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Wed Oct 27 13:05:39 2021

[graphite] Track target TextureProxy for DrawContext and DrawPass

Bug: skia:12466
Change-Id: I3f29f403a3ac91e81f54b0ec3bad19df8dd58739
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/462885

Commit-Queue: Jim Van Verth <jvan...@google.com>
Reviewed-by: Michael Ludwig <michae...@google.com>
Reviewed-by: Greg Daniel <egda...@google.com>

[modify] https://crrev.com/f44bc854bf4c915a67cbca3368dd119df04d8a30/experimental/graphite/src/mtl/MtlUtils.mm
[modify] https://crrev.com/f44bc854bf4c915a67cbca3368dd119df04d8a30/experimental/graphite/src/Recorder.cpp
[modify] https://crrev.com/f44bc854bf4c915a67cbca3368dd119df04d8a30/experimental/graphite/src/Caps.h
[modify] https://crrev.com/f44bc854bf4c915a67cbca3368dd119df04d8a30/experimental/graphite/src/ContextPriv.h
[modify] https://crrev.com/f44bc854bf4c915a67cbca3368dd119df04d8a30/experimental/graphite/src/Device.cpp
[modify] https://crrev.com/f44bc854bf4c915a67cbca3368dd119df04d8a30/experimental/graphite/src/mtl/MtlCaps.mm
[modify] https://crrev.com/f44bc854bf4c915a67cbca3368dd119df04d8a30/experimental/graphite/src/Recorder.h
[modify] https://crrev.com/f44bc854bf4c915a67cbca3368dd119df04d8a30/experimental/graphite/src/ContextPriv.cpp
[modify] https://crrev.com/f44bc854bf4c915a67cbca3368dd119df04d8a30/experimental/graphite/src/mtl/MtlCaps.h
[modify] https://crrev.com/f44bc854bf4c915a67cbca3368dd119df04d8a30/experimental/graphite/src/SkStuff.cpp
[modify] https://crrev.com/f44bc854bf4c915a67cbca3368dd119df04d8a30/experimental/graphite/src/DrawPass.cpp
[modify] https://crrev.com/f44bc854bf4c915a67cbca3368dd119df04d8a30/experimental/graphite/src/DrawContext.h
[modify] https://crrev.com/f44bc854bf4c915a67cbca3368dd119df04d8a30/experimental/graphite/src/DrawContext.cpp
[modify] https://crrev.com/f44bc854bf4c915a67cbca3368dd119df04d8a30/experimental/graphite/src/DrawPass.h

Git Watcher via monorail

unread,
Oct 27, 2021, 2:45:06 PM10/27/21
to bu...@skia.org

Comment #95 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c95


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/b421a71f37ddd04fa19efa80a537bd48a87c89cf

commit b421a71f37ddd04fa19efa80a537bd48a87c89cf
Author: Robert Phillips <robertp...@google.com>
Date: Tue Oct 26 18:47:58 2021

[graphite] Expand shader precompilation placeholder

Bug: skia:12466
Change-Id: If633ce39c8f45b1ee3c042b5b72d7e0f95ca5c19
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/459597
Reviewed-by: Jim Van Verth <jvan...@google.com>
Commit-Queue: Robert Phillips <robertp...@google.com>

[modify] https://crrev.com/b421a71f37ddd04fa19efa80a537bd48a87c89cf/gn/graphite.gni
[modify] https://crrev.com/b421a71f37ddd04fa19efa80a537bd48a87c89cf/src/gpu/gradients/GrGradientShader.cpp
[modify] https://crrev.com/b421a71f37ddd04fa19efa80a537bd48a87c89cf/gn/tests.gni
[add] https://crrev.com/b421a71f37ddd04fa19efa80a537bd48a87c89cf/experimental/graphite/src/ContextUtils.cpp
[add] https://crrev.com/b421a71f37ddd04fa19efa80a537bd48a87c89cf/tests/graphite/UniformTest.cpp
[modify] https://crrev.com/b421a71f37ddd04fa19efa80a537bd48a87c89cf/tools/flags/CommonFlagsConfig.cpp
[modify] https://crrev.com/b421a71f37ddd04fa19efa80a537bd48a87c89cf/experimental/graphite/src/Context.cpp
[modify] https://crrev.com/b421a71f37ddd04fa19efa80a537bd48a87c89cf/src/gpu/effects/GrSkSLFP.h
[add] https://crrev.com/b421a71f37ddd04fa19efa80a537bd48a87c89cf/experimental/graphite/src/ContextUtils.h

Git Watcher via monorail

unread,
Oct 27, 2021, 3:57:05 PM10/27/21
to bu...@skia.org

Comment #96 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c96


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/6a02277fa2cf4de7f7c0ebc0e600ad426d458068

commit 6a02277fa2cf4de7f7c0ebc0e600ad426d458068
Author: Greg Daniel <egda...@google.com>
Date: Wed Oct 27 19:15:01 2021

[graphite] Add DrawBufferManager class.

This class will manage and suballocate all buffers used for draws. This
includes vertex, index, and uniform buffers.

Bug: skia:12466
Change-Id: I30f498fe3465e4cc693b974019dcef27efaa8073
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/462097
Commit-Queue: Greg Daniel <egda...@google.com>
Reviewed-by: Michael Ludwig <michae...@google.com>

[modify] https://crrev.com/6a02277fa2cf4de7f7c0ebc0e600ad426d458068/gn/graphite.gni
[add] https://crrev.com/6a02277fa2cf4de7f7c0ebc0e600ad426d458068/experimental/graphite/src/DrawBufferManager.cpp
[modify] https://crrev.com/6a02277fa2cf4de7f7c0ebc0e600ad426d458068/experimental/graphite/include/private/GraphiteTypesPriv.h
[modify] https://crrev.com/6a02277fa2cf4de7f7c0ebc0e600ad426d458068/experimental/graphite/src/CommandBuffer.h
[add] https://crrev.com/6a02277fa2cf4de7f7c0ebc0e600ad426d458068/experimental/graphite/src/DrawBufferManager.h

Git Watcher via monorail

unread,
Oct 28, 2021, 10:51:04 AM10/28/21
to bu...@skia.org

Comment #97 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c97


The following revision refers to this bug:

Author: Jim Van Verth <jvan...@google.com>
Date: Wed Oct 27 19:50:18 2021

[graphite] Add vertex and instance buffer support.

Adds Attributes and supporting types to RenderPipelineDesc so they can
be created for the RenderPipeline.

Bug: skia:12466
Change-Id: I7ed920ea6d44f27f7dace81d35cd967a8dea55de
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/464377
Reviewed-by: Greg Daniel <egda...@google.com>

Commit-Queue: Jim Van Verth <jvan...@google.com>

[modify] https://crrev.com/66485f926843f5fcd3226e12d815e6cb20391e12/experimental/graphite/src/mtl/MtlCommandBuffer.mm
[modify] https://crrev.com/66485f926843f5fcd3226e12d815e6cb20391e12/experimental/graphite/src/mtl/MtlRenderPipeline.h
[modify] https://crrev.com/66485f926843f5fcd3226e12d815e6cb20391e12/experimental/graphite/src/mtl/MtlRenderPipeline.mm
[modify] https://crrev.com/66485f926843f5fcd3226e12d815e6cb20391e12/experimental/graphite/src/CommandBuffer.cpp
[modify] https://crrev.com/66485f926843f5fcd3226e12d815e6cb20391e12/experimental/graphite/include/private/GraphiteTypesPriv.h
[modify] https://crrev.com/66485f926843f5fcd3226e12d815e6cb20391e12/experimental/graphite/src/RenderPipelineDesc.h
[modify] https://crrev.com/66485f926843f5fcd3226e12d815e6cb20391e12/experimental/graphite/src/mtl/MtlCommandBuffer.h
[modify] https://crrev.com/66485f926843f5fcd3226e12d815e6cb20391e12/tests/graphite/CommandBufferTest.cpp
[modify] https://crrev.com/66485f926843f5fcd3226e12d815e6cb20391e12/experimental/graphite/src/CommandBuffer.h

Git Watcher via monorail

unread,
Oct 28, 2021, 12:33:06 PM10/28/21
to bu...@skia.org

Comment #98 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c98


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/88376867529bcfa3001ffede07c9756b671421f4

commit 88376867529bcfa3001ffede07c9756b671421f4
Author: Michael Ludwig <michae...@google.com>
Date: Tue Oct 26 00:55:44 2021

[graphite] Actually record draws in DrawList

Bug: skia:12466
Change-Id: I91e1e90900997ad1e16710b51fa3dcdde6861d38
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/462886
Reviewed-by: Robert Phillips <robertp...@google.com>
Commit-Queue: Robert Phillips <robertp...@google.com>

[modify] https://crrev.com/88376867529bcfa3001ffede07c9756b671421f4/gn/graphite.gni
[modify] https://crrev.com/88376867529bcfa3001ffede07c9756b671421f4/experimental/graphite/src/geom/Transform_graphite.h
[modify] https://crrev.com/88376867529bcfa3001ffede07c9756b671421f4/experimental/graphite/src/DrawPass.cpp
[modify] https://crrev.com/88376867529bcfa3001ffede07c9756b671421f4/experimental/graphite/src/Device.cpp
[modify] https://crrev.com/88376867529bcfa3001ffede07c9756b671421f4/experimental/graphite/src/DrawList.h
[modify] https://crrev.com/88376867529bcfa3001ffede07c9756b671421f4/experimental/graphite/src/DrawContext.h
[modify] https://crrev.com/88376867529bcfa3001ffede07c9756b671421f4/experimental/graphite/src/DrawContext.cpp
[modify] https://crrev.com/88376867529bcfa3001ffede07c9756b671421f4/experimental/graphite/src/DrawPass.h
[modify] https://crrev.com/88376867529bcfa3001ffede07c9756b671421f4/experimental/graphite/src/Device.h
[add] https://crrev.com/88376867529bcfa3001ffede07c9756b671421f4/experimental/graphite/src/DrawList.cpp

Git Watcher via monorail

unread,
Oct 28, 2021, 1:03:10 PM10/28/21
to bu...@skia.org

Comment #99 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c99


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/1fe391f0dc88daec2aaac57eab102648a9013cf6

commit 1fe391f0dc88daec2aaac57eab102648a9013cf6
Author: Robert Phillips <robertp...@google.com>
Date: Thu Oct 28 13:58:10 2021

[graphite] Add caches for uniformdata and programs

Bug: skia:12466
Change-Id: Id61b019b583357bb9474c58a81270b0b860c9c4f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/464120
Reviewed-by: Greg Daniel <egda...@google.com>
Commit-Queue: Robert Phillips <robertp...@google.com>

[modify] https://crrev.com/1fe391f0dc88daec2aaac57eab102648a9013cf6/experimental/graphite/src/ContextUtils.cpp
[modify] https://crrev.com/1fe391f0dc88daec2aaac57eab102648a9013cf6/experimental/graphite/src/Recorder.cpp
[add] https://crrev.com/1fe391f0dc88daec2aaac57eab102648a9013cf6/tests/graphite/UniformCacheTest.cpp
[add] https://crrev.com/1fe391f0dc88daec2aaac57eab102648a9013cf6/experimental/graphite/src/ProgramCache.h
[add] https://crrev.com/1fe391f0dc88daec2aaac57eab102648a9013cf6/experimental/graphite/src/UniformCache.h
[modify] https://crrev.com/1fe391f0dc88daec2aaac57eab102648a9013cf6/experimental/graphite/src/Recorder.h
[modify] https://crrev.com/1fe391f0dc88daec2aaac57eab102648a9013cf6/gn/graphite.gni
[modify] https://crrev.com/1fe391f0dc88daec2aaac57eab102648a9013cf6/gn/tests.gni
[modify] https://crrev.com/1fe391f0dc88daec2aaac57eab102648a9013cf6/tests/graphite/UniformTest.cpp
[add] https://crrev.com/1fe391f0dc88daec2aaac57eab102648a9013cf6/experimental/graphite/src/ProgramCache.cpp
[add] https://crrev.com/1fe391f0dc88daec2aaac57eab102648a9013cf6/experimental/graphite/src/UniformCache.cpp
[add] https://crrev.com/1fe391f0dc88daec2aaac57eab102648a9013cf6/tests/graphite/ProgramCacheTest.cpp
[modify] https://crrev.com/1fe391f0dc88daec2aaac57eab102648a9013cf6/experimental/graphite/src/ContextUtils.h

Git Watcher via monorail

unread,
Oct 28, 2021, 1:59:04 PM10/28/21
to bu...@skia.org

Comment #100 on issue 12466 by Git Watcher: Graphite sprint
https://bugs.chromium.org/p/skia/issues/detail?id=12466#c100


The following revision refers to this bug:
https://skia.googlesource.com/skia/+/391f9419496a83f388ae996c3bbb24fcdbadf439

commit 391f9419496a83f388ae996c3bbb24fcdbadf439
Author: Greg Daniel <egda...@google.com>
Date: Thu Oct 28 16:44:43 2021

[graphite] Add a Graphite no Gpu (i.e. Ganesh) build bot

Make sure graphite compiles standalone and not just if ganesh is also
enabled.

Bug: skia:12466
Change-Id: Ic843881a2a88c8d4b62f3a2ea38a10b6a86a12d4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/464817
Reviewed-by: Robert Phillips <robertp...@google.com>
Reviewed-by: Kevin Lubick <kjlu...@google.com>
Commit-Queue: Greg Daniel <egda...@google.com>

[modify] https://crrev.com/391f9419496a83f388ae996c3bbb24fcdbadf439/infra/bots/recipe_modules/build/default.py
[modify] https://crrev.com/391f9419496a83f388ae996c3bbb24fcdbadf439/infra/bots/recipe_modules/build/examples/full.py
[modify] https://crrev.com/391f9419496a83f388ae996c3bbb24fcdbadf439/infra/bots/jobs.json
[modify] https://crrev.com/391f9419496a83f388ae996c3bbb24fcdbadf439/BUILD.gn
[modify] https://crrev.com/391f9419496a83f388ae996c3bbb24fcdbadf439/infra/bots/tasks.json
[modify] https://crrev.com/391f9419496a83f388ae996c3bbb24fcdbadf439/experimental/minimal_ios_mtl_skia_app/BUILD.gn
[add] https://crrev.com/391f9419496a83f388ae996c3bbb24fcdbadf439/infra/bots/recipe_modules/build/examples/full.expected/Build-Mac-Clang-arm64-Debug-Graphite_NoGpu.json
It is loading more messages.
0 new messages