Issue 5629 in skia: SkTDArray.append efficiency

[r… via monorail]

Status: Accepted
Owner: re...@google.com
CC: mtkl...@google.com, bsalo...@google.com, cary...@google.com, he...@google.com

New issue 5629 by re...@google.com: SkTDArray.append efficiency
https://bugs.chromium.org/p/skia/issues/detail?id=5629

It appears that calls to append don't get inlined. This may be because the impl is pretty complex (lots of helper functions calling each-other).

However, in the common case (it seems), there is room already allocated, and therefore append() should be check, inc, return. Very inline-able (and therefore fast).

Request: can we simplify append() to make it faster?

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

[johns… via monorail]

Updates:
Status: Obsolete

Comment #3 on issue 5629 by johns...@google.com: SkTDArray.append efficiency
https://bugs.chromium.org/p/skia/issues/detail?id=5629#c3

The code has been restructured to use SkTDStorage now