Issue 13296 in skia: Perf: "Commits At Step" uses precise build URL, {commit_url} doesn't
0 views
Skip to first unread message
ccr… via monorail
May 4, 2022, 7:55:16 PM5/4/22
to bu...@skia.org
Status: Untriaged
Owner: jcgre...@google.com
Components: Perf
Priority: Medium
Type: Defect
New issue 13296 by ccr...@google.com: Perf: "Commits At Step" uses precise build URL, {commit_url} doesn't
https://bugs.chromium.org/p/skia/issues/detail?id=13296
In this example alert: https://androidx-perf.skia.org/t/?begin=1651617596&end=1651617597&subset=all
Clicking "commits at step" takes you to: https://android-build.googleplex.com/builds/8535457/branches/aosp-androidx-main/targets/androidx/cls?end=8535452
However the bug produced uses the url with only one build number in it: https://android-build.googleplex.com/builds/jump-to-build/8535457 which may miss commits if a build didn't get results (infra failure, or device availability issue)
Request is for {commit_url} to use the same build URL as "Commits at step"
--
You received this message because:
1. The project was configured to send all issue notifications to this address
You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings
Owner: jcgre...@google.com
Components: Perf
Priority: Medium
Type: Defect
New issue 13296 by ccr...@google.com: Perf: "Commits At Step" uses precise build URL, {commit_url} doesn't
https://bugs.chromium.org/p/skia/issues/detail?id=13296
In this example alert: https://androidx-perf.skia.org/t/?begin=1651617596&end=1651617597&subset=all
Clicking "commits at step" takes you to: https://android-build.googleplex.com/builds/8535457/branches/aosp-androidx-main/targets/androidx/cls?end=8535452
However the bug produced uses the url with only one build number in it: https://android-build.googleplex.com/builds/jump-to-build/8535457 which may miss commits if a build didn't get results (infra failure, or device availability issue)
Request is for {commit_url} to use the same build URL as "Commits at step"
--
You received this message because:
1. The project was configured to send all issue notifications to this address
You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings
jcgre… via monorail
May 5, 2022, 8:08:41 AM5/5/22
to bu...@skia.org
Updates:
Labels: Area-Infrastructure
Status: Accepted
Comment #1 on issue 13296 by jcgre...@google.com: Perf: "Commits At Step" uses precise build URL, {commit_url} doesn't
https://bugs.chromium.org/p/skia/issues/detail?id=13296#c1
(No comment was entered for this change.)
Labels: Area-Infrastructure
Status: Accepted
Comment #1 on issue 13296 by jcgre...@google.com: Perf: "Commits At Step" uses precise build URL, {commit_url} doesn't
https://bugs.chromium.org/p/skia/issues/detail?id=13296#c1
(No comment was entered for this change.)
ccr… via monorail
Jun 5, 2023, 6:42:56 PM6/5/23
to bu...@skia.org
Comment #2 on issue 13296 by ccr...@google.com: Perf: "Commits At Step" uses precise build URL, {commit_url} doesn't
https://bugs.chromium.org/p/skia/issues/detail?id=13296#c2
Friendly ping on this?
The issue also shows up if you click on the jump-to-build entry in the alert, and click "commits"
Would prefer to always build the range URL in both cases.
jcgre… via monorail
Jul 21, 2023, 3:17:45 PM7/21/23
to bu...@skia.org
Comment #3 on issue 13296 by jcgre...@google.com: Perf: "Commits At Step" uses precise build URL, {commit_url} doesn't
https://bugs.chromium.org/p/skia/issues/detail?id=13296#c3
Should be fixed in the formatting for new issues: https://skia-review.googlesource.com/c/buildbot/+/723736
Reply all
Reply to author
Forward
0 new messages