Review request for JH7110 SoC & StarFive VisionFive 2 EDK2 code

[John Chew]

Hi Sunil,

I'm reaching out to request a code review of the EDK2 and EDK2-Platform code for the JH7110 SoC and StarFive VisionFive 2 platform.

We have thoroughly tested this code on the StarFive VisionFive 2 SBC, and it is functioning correctly. The boot flow for our code follows this sequence:

BootROM -> U-Boot SPL -> OpenSBI -> EDK2 -> Linux -> OS

Currently, we rely on U-Boot SPL to initialize DDR and load OpenSBI and EDK2 into DDR from multiple boot sources, including SD Card, eMMC, or QSPI Flash. Furthermore, our EDK2 code is capable of loading Linux from various sources as well, such as SD Card, eMMC, NVME, or USB.

Before proceeding with a merge request, we would greatly appreciate your valuable feedback on our code.

You may access our code using the following links:
edk2: https://github.com/johnchewyy/edkii/tree/vf2_jh7110_devel_upstream
edk2-platform: https://github.com/johnchewyy/edkii-platforms/tree/vf2_jh7110_devel_upstream

Looking forward to hearing from you soon!

Thank you =)

John

[Sunil V L]

Hi John,

This is great!.  From a quick glance at your branch, your changes look
good to me!. I will take closer look at individual patches and provide
feedback before 09/22.

Thank you!

Sunil

[Sunil V L]

Hi John,

I left few minor comments in your branch. Otherwise, the changes LGTM.
Few patches have just oneliner. Please update them with proper commit
messages while sending to the edk2-devel.

Thanks!

Sunil

[YuinYee Chew]

Hi Sunil,

Okay sure! I will look into it and fix it.
Thank you so much for your time =)

Regards,
John

--
You received this message because you are subscribed to a topic in the Google Groups "RISC-V Firmware Exchange" group.
To unsubscribe from this topic, visit https://groups.google.com/a/riscv.org/d/topic/fw-exchange/lXjsRLyCO7s/unsubscribe.
To unsubscribe from this group and all its topics, send an email to fw-exchange...@riscv.org.
To view this discussion on the web visit https://groups.google.com/a/riscv.org/d/msgid/fw-exchange/6901cb93-e117-7391-475a-63f48ab55119%40ventanamicro.com.

[John Chew]

Hi Sunil,

Thanks again for your quick review!

Today I updated my base to "edk2-stable202308" and noticed there is some issue  with the current vf2 edk2 code when CPU MMU is enabled :
https://github.com/tianocore/edk2/commit/f220dcbba86bfc1222180c61bbd31dd6023433db

I've seen your suggestion to Tuan to include a PCD in order to make the CPU MMU optional:
https://groups.google.com/u/1/a/riscv.org/g/fw-exchange/c/_kZAoLLdkNI

In that case, shall I wait for the PCD and include it in my .dsc file before sending the below patch to edk2-devel?
https://github.com/johnchewyy/edkii-platforms/commit/f43abdd02f2f7ae3a0a0a4350e2f94a2f59aa786

[Dhaval Sharma]

+1 on having PCD based MMU support. I am facing a similar issue with UPL right now where I would like to see it disabled until all memmap stuff is figured out and current implementation enables it as soon as it finds HW supports it.

You received this message because you are subscribed to the Google Groups "RISC-V Firmware Exchange" group.
To unsubscribe from this group and stop receiving emails from it, send an email to fw-exchange...@riscv.org.
To view this discussion on the web visit https://groups.google.com/a/riscv.org/d/msgid/fw-exchange/a1f171f2-67a9-4033-90aa-d8c2c0d102b6n%40riscv.org.

--

Thanks!

=D

[Tuan Phan]

If no one volunteer to create a patch to add PCD for MMU enabled/disabled then I will post it.

 

To view this discussion on the web visit https://groups.google.com/a/riscv.org/d/msgid/fw-exchange/CAAxYnhQB%2BXOM0GTOc0fWxNZiOJkBuWB7hfVC--WoYdC%2B4Zz2qQ%40mail.gmail.com.

[Sunil V L]

Hi Tuan,

Please go ahead. I don't think anyone is working on it.

Thanks,

Sunil

On 26/09/23 22:09, Tuan Phan wrote:
>
> If no one volunteer to create a patch to add PCD for MMU
> enabled/disabled then I will post it.
>

> *From: *Dhaval Sharma <dha...@rivosinc.com>
> *Date: *Tuesday, September 26, 2023 at 1:46 AM
> *To: *John Chew <yuinye...@starfivetech.com>
> *Cc: *RISC-V Firmware Exchange <fw-ex...@riscv.org>,

> andrei.w...@intel.com <andrei.w...@intel.com>, yon...@intel.com
> <yon...@intel.com>, sun...@ventanamicro.com <sun...@ventanamicro.com>

> *Subject: *Re: Review request for JH7110 SoC & StarFive VisionFive 2

> <https://groups.google.com/a/riscv.org/d/msgid/fw-exchange/a1f171f2-67a9-4033-90aa-d8c2c0d102b6n%40riscv.org?utm_medium=email&utm_source=footer>.

>
>
> --
>
> Thanks!
>
> =D
>
> --
> You received this message because you are subscribed to the Google
> Groups "RISC-V Firmware Exchange" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to fw-exchange...@riscv.org.
> To view this discussion on the web visit
> https://groups.google.com/a/riscv.org/d/msgid/fw-exchange/CAAxYnhQB%2BXOM0GTOc0fWxNZiOJkBuWB7hfVC--WoYdC%2B4Zz2qQ%40mail.gmail.com

> <https://groups.google.com/a/riscv.org/d/msgid/fw-exchange/CAAxYnhQB%2BXOM0GTOc0fWxNZiOJkBuWB7hfVC--WoYdC%2B4Zz2qQ%40mail.gmail.com?utm_medium=email&utm_source=footer>.
>

[Tuan Phan]

Sent a patch for review.

[John Chew]

Hi Tuan,

Thank you very much =D

John

[John Chew]

Hi Sunil,

I have sent the patches for JH7100 SoC and VF2 to edk2-devel.

Please let me know if there are any issues with the patches.
Looking forward to hearing your feedback =)

Thank you!
John