Re: [bug report 2/8] Implement seed/key preference when decoding
5 views
Skip to first unread message
Viktor Dukhovni
2:23 PM (6 hours ago) 2:23 PM
to openss...@openssl.org
On Fri, Apr 10, 2026 at 08:14:32PM +0300, Dan Carpenter wrote:
> Commit 5b2d996f9145 ("Implement seed/key preference when decoding")
> from Jan 28, 2025 (linux-next), leads to the following Smatch static
> checker warning:
>
> providers/implementations/encode_decode/ml_kem_codecs.c:423 ossl_ml_kem_i2d_pubkey()
> error: we previously assumed 'out' could be null (see line 420)
In fact the internall caller must and never does pass NULL, the check is
redundant. The check can be dropped.
--
Viktor. 🇺🇦 Слава Україні!
> Commit 5b2d996f9145 ("Implement seed/key preference when decoding")
> from Jan 28, 2025 (linux-next), leads to the following Smatch static
> checker warning:
>
> providers/implementations/encode_decode/ml_kem_codecs.c:423 ossl_ml_kem_i2d_pubkey()
> error: we previously assumed 'out' could be null (see line 420)
In fact the internall caller must and never does pass NULL, the check is
redundant. The check can be dropped.
--
Viktor. 🇺🇦 Слава Україні!
Reply all
Reply to author
Forward
0 new messages