Missing header file ts_local.h in install location.

9 views
Skip to first unread message

BENTLEY Thom

unread,
Jun 28, 2024, 10:09:41 AM6/28/24
to openss...@openssl.org

Hi All,

 

I build and installed version 3.0.8 on Windows with Visual Studio using the instructions provided.
I copied the bin, include, and lib directories to a location that would be found by the CMake for the

DCMTK toolkit version 3.6.8.

When I attempt to build the DCMTK toolkit, I see that the ts.h value can’t find the definition of TS_verify_ctx.
That’s because of the missing ts_local.h as far as I can see.

 

Is there something I missed in the build of the libraries and the install package?

Thank.

 

 

 

Thom Bentley | Senior Software Engineer | Medidata, a Dassault Systèmes company

 

This email and any attachments are intended solely for the use of the individual or entity to whom it is addressed and may be confidential and/or privileged.

If you are not one of the named recipients or have received this email in error,

(i) you should not read, disclose, or copy it,

(ii) please notify sender of your receipt by reply email and delete this email and all attachments,

(iii) Dassault Systèmes does not accept or assume any liability or responsibility for any use of or reliance on this email.


Please be informed that your personal data are processed according to our data privacy policy as described on our website. Should you have any questions related to personal data protection, please contact 3DS Data Protection Officer https://www.3ds.com/privacy-policy/contact/


Tomas Mraz

unread,
Jun 28, 2024, 10:15:02 AM6/28/24
to BENTLEY Thom, openss...@openssl.org
TS_VERIFY_CTX is an opaque structure since version 1.1.0. You may not
access its members directly. To set them you need to use the various
TS_VERIFY_CTX_set* functions.

If there are any particular accessors missing, please report that as a
bug to https://github.com/openssl/openssl


Tomas Mraz, OpenSSL


On Fri, 2024-06-28 at 14:09 +0000, BENTLEY Thom via openssl-users
wrote:

--
Tomáš Mráz, OpenSSL

Matt Caswell

unread,
Jun 28, 2024, 10:17:36 AM6/28/24
to BENTLEY Thom, openss...@openssl.org

On 28/06/2024 15:09, BENTLEY Thom via openssl-users wrote:
> Hi All,
>
> I build and installed version 3.0.8 on Windows with Visual Studio using
> the instructions provided.
> I copied the bin, include, and lib directories to a location that would
> be found by the CMake for the
>
> DCMTK toolkit version 3.6.8.
>
> When I attempt to build the DCMTK toolkit, I see that the ts.h value
> can’t find the definition of TS_verify_ctx.
> That’s because of the missing ts_local.h as far as I can see.
>

What exactly is the error you are seeing?

ts_local.h is an internal header file that applications external to
OpenSSL should not need. The TS_VERIFY_CTX type is *opaque* and
applications using it should not need to have the structure definition.

Having a very quick look at the code in https://github.com/DCMTK/dcmtk,
I don't see it referring to any internal contents of TS_VERIFY_CTX. It
just passes it around as a pointer object - which should be fine.

Matt


> Is there something I missed in the build of the libraries and the
> install package?
>
> Thank.
>

> **
>
> **
>
> *Thom Bentley *| Senior Software Engineer |Medidata, a Dassault Systèmes
> company <http://www.mdsol.com/>


>
> This email and any attachments are intended solely for the use of the
> individual or entity to whom it is addressed and may be confidential
> and/or privileged.
>
> If you are not one of the named recipients or have received this email
> in error,
>
> (i) you should not read, disclose, or copy it,
>
> (ii) please notify sender of your receipt by reply email and delete this
> email and all attachments,
>
> (iii) Dassault Systèmes does not accept or assume any liability or
> responsibility for any use of or reliance on this email.
>
>
> Please be informed that your personal data are processed according to
> our data privacy policy as described on our website. Should you have any
> questions related to personal data protection, please contact 3DS Data
> Protection Officer https://www.3ds.com/privacy-policy/contact/

> <https://www.3ds.com/privacy-policy/contact/>
>
>

BENTLEY Thom

unread,
Jun 28, 2024, 11:27:48 AM6/28/24
to Matt Caswell, openss...@openssl.org

Here are the compile errors I’m getting.
dcmdsig:

16:34:48:290 19>C:\repos\mmi-director-dcmtk-3.6.8\dcmtk-3.6.8\dcmsign\libsrc\sitstamp.cc(1342,5): error C2027: use of undefined type 'TS_verify_ctx'

16:34:48:290 19>C:\repos\mmi-director-dcmtk-3.6.8\openssl-3.0.8\include\openssl\ts.h(405,16):

16:34:48:290 19>see declaration of 'TS_verify_ctx'

 

dcmpstat:

16:36:48:689 34>C:\repos\mmi-director-dcmtk-3.6.8\openssl-3.0.8\include\openssl\types.h(104,30): error C2371: 'EVP_MD_CTX': redefinition; different basic types

16:36:48:753 34>(compiling source file '../../../dcmtk-3.6.8/dcmpstat/libsrc/dvsighdl.cc')

16:36:48:753 34>C:\repos\mmi-director-dcmtk-3.6.8\dcmtk-3.6.8\dcmsign\include\dcmtk\dcmsign\simdmac.h(39,30):

16:36:48:753 34>see declaration of 'EVP_MD_CTX'

 

dcmtls:

16:35:16:392 26>C:\repos\mmi-director-dcmtk-3.6.8\dcmtk-3.6.8\dcmtls\libsrc\tlsciphr.cc(238,32): error C2027: use of undefined type 'ssl_ctx_st'

16:35:16:392 26>C:\repos\mmi-director-dcmtk-3.6.8\dcmtk-3.6.8\dcmtls\include\dcmtk\dcmtls\tlslayer.h(37,8):

16:35:16:392 26>see declaration of 'ssl_ctx_st'

 

 

 

Thom Bentley | Senior Software Engineer | Medidata, a Dassault Systèmes company

 

From: Matt Caswell <ma...@openssl.org>
Sent: Friday, June 28, 2024 10:18 AM
To: BENTLEY Thom <Thom.B...@3ds.com>; openss...@openssl.org
Subject: Re: Missing header file ts_local.h in install location.

 

On 28/06/2024 15: 09, BENTLEY Thom via openssl-users wrote: > Hi All, > > I build and installed version 3. 0. 8 on Windows with Visual Studio using > the instructions provided. > I copied the bin, include, and lib directories to 

 
 
On 28/06/2024 15:09, BENTLEY Thom via openssl-users wrote:
> Hi All,
> 
> I build and installed version 3.0.8 on Windows with Visual Studio using 
> the instructions provided.
> I copied the bin, include, and lib directories to a location that would 
> be found by the CMake for the
> 
> DCMTK toolkit version 3.6.8.
> 
> When I attempt to build the DCMTK toolkit, I see that the ts.h value 
> can’t find the definition of TS_verify_ctx.
> That’s because of the missing ts_local.h as far as I can see.
> 
 
What exactly is the error you are seeing?
 
ts_local.h is an internal header file that applications external to 
OpenSSL should not need. The TS_VERIFY_CTX type is *opaque* and 
applications using it should not need to have the structure definition.
 

BENTLEY Thom

unread,
Jun 28, 2024, 11:29:12 AM6/28/24
to Tomas Mraz, openss...@openssl.org

Thanks.  Yes, I saw that they became opaque.
The code I’m building works fine with 1.1.1w but we need to move to 3.0.8 at least.
Here are the errors I see.

dcmdsig:
16:34:48:290 19>C:\repos\mmi-director-dcmtk-3.6.8\dcmtk-3.6.8\dcmsign\libsrc\sitstamp.cc(1342,5): error C2027: use of undefined type 'TS_verify_ctx'
16:34:48:290 19>C:\repos\mmi-director-dcmtk-3.6.8\openssl-3.0.8\include\openssl\ts.h(405,16):
16:34:48:290 19>see declaration of 'TS_verify_ctx'

dcmpstat:
16:36:48:689 34>C:\repos\mmi-director-dcmtk-3.6.8\openssl-3.0.8\include\openssl\types.h(104,30): error C2371: 'EVP_MD_CTX': redefinition; different basic types
16:36:48:753 34>(compiling source file '../../../dcmtk-3.6.8/dcmpstat/libsrc/dvsighdl.cc')
16:36:48:753 34>C:\repos\mmi-director-dcmtk-3.6.8\dcmtk-3.6.8\dcmsign\include\dcmtk\dcmsign\simdmac.h(39,30):
16:36:48:753 34>see declaration of 'EVP_MD_CTX'

dcmtls:
16:35:16:392 26>C:\repos\mmi-director-dcmtk-3.6.8\dcmtk-3.6.8\dcmtls\libsrc\tlsciphr.cc(238,32): error C2027: use of undefined type 'ssl_ctx_st'
16:35:16:392 26>C:\repos\mmi-director-dcmtk-3.6.8\dcmtk-3.6.8\dcmtls\include\dcmtk\dcmtls\tlslayer.h(37,8):
16:35:16:392 26>see declaration of 'ssl_ctx_st'

 

 

 

Thom Bentley | Senior Software Engineer | Medidata, a Dassault Systèmes company

 

From: Tomas Mraz <to...@openssl.org>
Sent: Friday, June 28, 2024 10:15 AM
To: BENTLEY Thom <Thom.B...@3ds.com>; openss...@openssl.org
Subject: Re: Missing header file ts_local.h in install location.

 

TS_VERIFY_CTX is an opaque structure since version 1. 1. 0. You may not access its members directly. To set them you need to use the various TS_VERIFY_CTX_set* functions. If there are any particular accessors missing, please report that as a 

TS_VERIFY_CTX is an opaque structure since version 1.1.0. You may not
access its members directly. To set them you need to use the various
TS_VERIFY_CTX_set* functions.
 
If there are any particular accessors missing, please report that as a

Matt Caswell

unread,
Jun 28, 2024, 11:53:52 AM6/28/24
to BENTLEY Thom, Tomas Mraz, openss...@openssl.org

On 28/06/2024 16:29, BENTLEY Thom via openssl-users wrote:
> Thanks.  Yes, I saw that they became opaque.
> The code I’m building works fine with 1.1.1w but we need to move to
> 3.0.8 at least.
> Here are the errors I see.
>
> dcmdsig:
> 16:34:48:290
> 19>C:\repos\mmi-director-dcmtk-3.6.8\dcmtk-3.6.8\dcmsign\libsrc\sitstamp.cc(1342,5): error C2027: use of undefined type 'TS_verify_ctx'
> 16:34:48:290
> 19>C:\repos\mmi-director-dcmtk-3.6.8\openssl-3.0.8\include\openssl\ts.h(405,16):
> 16:34:48:290 19>see declaration of 'TS_verify_ctx'


It looks to me like DCMTK needs updating to use OpenSSL 3.x

This particular error occurs because line 1342 of sitstamp.cc looks like
this:

TS_VERIFY_CTS_set_certs(ctx, NULL);

Earlier on in that file we see this:

#ifndef HAVE_OPENSSL_PROTOTYPE_TS_VERIFY_CTS_SET_CERTS
#define TS_VERIFY_CTS_set_certs(x,y) ((x)->certs = (y))
#endif

So if HAVE_OPENSSL_PROTOTYPE_TS_VERIFY_CTS_SET_CERTS isn't defined then
it will attempt to look inside the TS_VERIFY_CTX structure - which is
not allowed from 1.1.1 onwards because it is opaque.

My guess is the setting of
HAVE_OPENSSL_PROTOTYPE_TS_VERIFY_CTS_SET_CERTS is going wrong with
OpenSSL 3.X

It seems to get defined by Cmake/dcmtkPrepare.cmake:

CHECK_FUNCTIONWITHHEADER_EXISTS("TS_VERIFY_CTS_set_certs(0,0)"
"openssl/ts.h" HAVE_OPENSSL_PROTOTYPE_TS_VERIFY_CTS_SET_CERTS)

Indeed that function header does *not* exist in 3.x because it is
instead a macro:

# ifndef OPENSSL_NO_DEPRECATED_3_0
# define TS_VERIFY_CTS_set_certs(ctx, cert)
TS_VERIFY_CTX_set_certs(ctx,cert)
# endif

In 1.1.1 this was a full C function so the cmake detection would have
worked correctly there.

Matt

>
> dcmpstat:
> 16:36:48:689
> 34>C:\repos\mmi-director-dcmtk-3.6.8\openssl-3.0.8\include\openssl\types.h(104,30): error C2371: 'EVP_MD_CTX': redefinition; different basic types
> 16:36:48:753 34>(compiling source file
> '../../../dcmtk-3.6.8/dcmpstat/libsrc/dvsighdl.cc')
> 16:36:48:753
> 34>C:\repos\mmi-director-dcmtk-3.6.8\dcmtk-3.6.8\dcmsign\include\dcmtk\dcmsign\simdmac.h(39,30):
> 16:36:48:753 34>see declaration of 'EVP_MD_CTX'
>
> dcmtls:
> 16:35:16:392
> 26>C:\repos\mmi-director-dcmtk-3.6.8\dcmtk-3.6.8\dcmtls\libsrc\tlsciphr.cc(238,32): error C2027: use of undefined type 'ssl_ctx_st'
> 16:35:16:392
> 26>C:\repos\mmi-director-dcmtk-3.6.8\dcmtk-3.6.8\dcmtls\include\dcmtk\dcmtls\tlslayer.h(37,8):
> 16:35:16:392 26>see declaration of 'ssl_ctx_st'
>

> **
>
> **
>
> *Thom Bentley *| Senior Software Engineer |Medidata, a Dassault Systèmes
> company <http://www.mdsol.com/>
>
> *From:*Tomas Mraz <to...@openssl.org>
> *Sent:* Friday, June 28, 2024 10:15 AM
> *To:* BENTLEY Thom <Thom.B...@3ds.com>; openss...@openssl.org
> *Subject:* Re: Missing header file ts_local.h in install location.


>
> TS_VERIFY_CTX is an opaque structure since version 1. 1. 0. You may not
> access its members directly. To set them you need to use the various
> TS_VERIFY_CTX_set* functions. If there are any particular accessors
> missing, please report that as a
>
> TS_VERIFY_CTX is an opaque structure since version 1.1.0. You may not
>
> access its members directly. To set them you need to use the various
>
> TS_VERIFY_CTX_set* functions.
>
> If there are any particular accessors missing, please report that as a
>
> bug to

> https://urldefense.com/v3/__https://github.com/openssl/openssl__;!!FbCVDoc3r24SyHFW!8NySO-tJ589YiMdFNLtEu_6Hc7knvKgfTOXGkAFWjfEMxLaE5oRe3igKb4JOdd9HiiJ8sLVdiV6SYZo$ <https://urldefense.com/v3/__https:/github.com/openssl/openssl__;!!FbCVDoc3r24SyHFW!8NySO-tJ589YiMdFNLtEu_6Hc7knvKgfTOXGkAFWjfEMxLaE5oRe3igKb4JOdd9HiiJ8sLVdiV6SYZo$>[github[.]com]

> <https://www.3ds.com/privacy-policy/contact/>
>
>

BENTLEY Thom

unread,
Jun 28, 2024, 12:15:17 PM6/28/24
to Matt Caswell, Tomas Mraz, openss...@openssl.org

Hi Matt,
Yeah,  that’s what I thought too, but they claim they built it with openssl 3.0.8 in their INSTALL file.
https://github.com/DCMTK/dcmtk/blob/59f75a8b50e50ae1bb1ff12098040c6327500740/INSTALL#L219
I have also posted on their discussion board.

 

Thanks.

 

--

Thom Bentley | Senior Software Engineer |Medidata, a Dassault Systèmes company

 

 

From: Matt Caswell <ma...@openssl.org>
Date: Friday, June 28, 2024 at 11:53 AM
To: BENTLEY Thom <Thom.B...@3ds.com>, Tomas Mraz <to...@openssl.org>, "openss...@openssl.org" <openss...@openssl.org>
Subject: Re: Missing header file ts_local.h in install location.

 

On 28/06/2024 16: 29, BENTLEY Thom via openssl-users wrote: > Thanks. Yes, I saw that they became opaque. > The code I’m building works fine with 1. 1. 1w but we need to move to > 3. 0. 8 at least. > Here are the errors I see. > >

BENTLEY Thom

unread,
Jun 28, 2024, 4:04:24 PM6/28/24
to Matt Caswell, Tomas Mraz, openss...@openssl.org

 

 

 

 

Thom Bentley | Senior Software Engineer | Medidata, a Dassault Systèmes company

 

From: Matt Caswell <ma...@openssl.org>
Sent: Friday, June 28, 2024 11:54 AM
To: BENTLEY Thom <Thom.B...@3ds.com>; Tomas Mraz <to...@openssl.org>; openss...@openssl.org
Subject: Re: Missing header file ts_local.h in install location.

 

On 28/06/2024 16: 29, BENTLEY Thom via openssl-users wrote: > Thanks. Yes, I saw that they became opaque. > The code I’m building works fine with 1. 1. 1w but we need to move to > 3. 0. 8 at least. > Here are the errors I see. > >

Tomas Mraz

unread,
Jul 1, 2024, 4:12:14 AM7/1/24
to BENTLEY Thom, Matt Caswell, openss...@openssl.org
Yes, they should search for TS_VERIFY_CTX_set_certs or
TS_VERIFY_CTX_set_flags (that would work for 1.1.1 as well).

Tomas Mraz, OpenSS

BENTLEY Thom

unread,
Jul 8, 2024, 1:46:00 PM7/8/24
to Tomas Mraz, Matt Caswell, openss...@openssl.org

Is it possible that OPENSSL_NO_DEPRECATED_3_0 is defined and that’s what’s causing the issue with DCMTK configuration?

From ts.h:

# ifndef OPENSSL_NO_DEPRECATED_3_0

#  define TS_VERIFY_CTS_set_certs(ctx, cert) TS_VERIFY_CTX_set_certs(ctx,cert)

# endif

STACK_OF(X509) *TS_VERIFY_CTX_set_certs(TS_VERIFY_CTX *ctx, STACK_OF(X509) *certs);

 

 

 

Thom Bentley | Senior Software Engineer | Medidata, a Dassault Systèmes company

 

From: Tomas Mraz <to...@openssl.org>
Sent: Monday, July 1, 2024 4:12 AM
To: BENTLEY Thom <Thom.B...@3ds.com>; Matt Caswell <ma...@openssl.org>; openss...@openssl.org
Subject: Re: Missing header file ts_local.h in install location.

 

Yes, they should search for TS_VERIFY_CTX_set_certs or TS_VERIFY_CTX_set_flags (that would work for 1. 1. 1 as well). Tomas Mraz, OpenSS On Fri, 2024-06-28 at 20: 04 +0000, BENTLEY Thom wrote: > > > > Does this Bing CoPilot response

Reply all
Reply to author
Forward
0 new messages