[openssl/openssl] 4d3d1c: ml_dsa_kmgmt: check params against len and not poi...

2 views
Skip to first unread message

esyr

unread,
Jan 12, 2026, 4:25:37 PM (2 days ago) Jan 12
to openssl...@openssl.org
Branch: refs/heads/master
Home: https://github.com/openssl/openssl
Commit: 4d3d1c9f014dfdef1b49823e3704bc2845ae73fe
https://github.com/openssl/openssl/commit/4d3d1c9f014dfdef1b49823e3704bc2845ae73fe
Author: Eugene Syromiatnikov <es...@openssl.org>
Date: 2026-01-12 (Mon, 12 Jan 2026)

Changed paths:
M providers/implementations/keymgmt/ml_dsa_kmgmt.c

Log Message:
-----------
ml_dsa_kmgmt: check params against len and not pointers in ml_dsa_key_fromdata

The rest of the function conditions the presence/usage of pk/seed/sk
on the non-zeroness of pk_len/seed_len/sk_len, respectively, so perform
the *_len checks in a similar fashion; that makes it in line
with the similarly written ml_kem_key_fromdata() and stops giving Coverity
ideas that the pointers can be NULL when the respective len variables
are non-zero.

Fixes: 5421423ef95c "Flexible encoders for ML-DSA"
Resolves: https://scan5.scan.coverity.com/#/project-view/65248/10222?selectedIssue=1680314
Signed-off-by: Eugene Syromiatnikov <es...@openssl.org>

Reviewed-by: Viktor Dukhovni <vik...@openssl.org>
Reviewed-by: Tomas Mraz <to...@openssl.org>
Reviewed-by: Paul Dale <paul...@oracle.com>
Reviewed-by: Norbert Pocs <norb...@openssl.org>
Reviewed-by: Neil Horman <nho...@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29596)



To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications
Reply all
Reply to author
Forward
0 new messages