[openssl/openssl] 64e96e: Make find-doc-nits compatible accross git versions

0 views
Skip to first unread message

Neil Horman

unread,
Dec 5, 2025, 10:13:40 AM (yesterday) Dec 5
to openssl...@openssl.org
Branch: refs/heads/master
Home: https://github.com/openssl/openssl
Commit: 64e96ecf3c7edbd82322ddcc21a60be490ba2943
https://github.com/openssl/openssl/commit/64e96ecf3c7edbd82322ddcc21a60be490ba2943
Author: Neil Horman <nho...@openssl.org>
Date: 2025-12-05 (Fri, 05 Dec 2025)

Changed paths:
M util/find-doc-nits

Log Message:
-----------
Make find-doc-nits compatible accross git versions

We recently found that the addition of a git config command in
util/find-doc-nits is broken in some cases, sepecifically because git
around version 2.46 broke command line compatibility, replacing the
--regexp option with the --get-regexp option. So to maintain usage of
this specific command to parse the .gitconfig file, we would need to do
some extra version detection to construct the proper command line.

However, find-doc-nits already has a fallback condition, which does some
pure perl parsing of the gitconfig file, which works perfectly well.

Instead of trying to do version matching to construct the right form of
the git config command line, just remove it all, and rely on the perl
parrse to do this work for us, which works currently in all cases.

Fixes #29197

Reviewed-by: Tomas Mraz <to...@openssl.org>
Reviewed-by: Paul Dale <paul...@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/29304)



To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications
Reply all
Reply to author
Forward
0 new messages