[openssl/openssl] 45f40f: Engine removal: Silence the CI tests about engines

0 views
Skip to first unread message

Neil Horman

unread,
Oct 3, 2025, 2:23:37 PM10/3/25
to openssl...@openssl.org
Branch: refs/heads/feature/engineremoval
Home: https://github.com/openssl/openssl
Commit: 45f40f9c11ef5b86996bed3b6d3dc72ec1166400
https://github.com/openssl/openssl/commit/45f40f9c11ef5b86996bed3b6d3dc72ec1166400
Author: Norbert Pocs <norb...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M Configurations/10-main.conf
M Configure

Log Message:
-----------
Engine removal: Silence the CI tests about engines

As we can't do every change in one big PR (and we also don't want),
therefore there always will be failing tests until everything is
resolved/cleaned up. This way we silence the CI about engine tests and
later we can reenable them to see what else needs to be fixed.

Resolves: https://github.com/openssl/project/issues/1371

Signed-off-by: Norbert Pocs <norb...@openssl.org>

Reviewed-by: Saša Nedvědický <sas...@openssl.org>
Reviewed-by: Richard Levitte <lev...@openssl.org>
Reviewed-by: Neil Horman <nho...@openssl.org>
Reviewed-by: Matt Caswell <ma...@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28440)


Commit: 4ed8ebefff9efbfdf1cdefed30f1b0fba9d63b82
https://github.com/openssl/openssl/commit/4ed8ebefff9efbfdf1cdefed30f1b0fba9d63b82
Author: Norbert Pocs <norb...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M test/build.info
R test/enginetest.c
R test/recipes/30-test_engine.t

Log Message:
-----------
Remove engine test

Signed-off-by: Norbert Pocs <norb...@openssl.org>

Reviewed-by: Saša Nedvědický <sas...@openssl.org>
Reviewed-by: Richard Levitte <lev...@openssl.org>
Reviewed-by: Neil Horman <nho...@openssl.org>
Reviewed-by: Matt Caswell <ma...@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28440)


Commit: 9ef2f0fb3ed70953360f641a249080fae017e248
https://github.com/openssl/openssl/commit/9ef2f0fb3ed70953360f641a249080fae017e248
Author: Norbert Pocs <norb...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M test/README-external.md
R test/recipes/95-test_external_gost_engine.t
R test/recipes/95-test_external_gost_engine_data/gost_engine.sh

Log Message:
-----------
Remove GOST external tests

Signed-off-by: Norbert Pocs <norb...@openssl.org>

Reviewed-by: Saša Nedvědický <sas...@openssl.org>
Reviewed-by: Richard Levitte <lev...@openssl.org>
Reviewed-by: Neil Horman <nho...@openssl.org>
Reviewed-by: Matt Caswell <ma...@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28440)


Commit: 56bafa435650bf783647d665915b5625daad9da2
https://github.com/openssl/openssl/commit/56bafa435650bf783647d665915b5625daad9da2
Author: Milan Broz <gmaz...@gmail.com>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M apps/build.info
R apps/engine.c
M doc/build.info
M doc/man1/build.info
M doc/man1/openssl-cmds.pod.in
R doc/man1/openssl-engine.pod.in
M doc/man1/openssl.pod
M doc/man7/openssl-env.pod

Log Message:
-----------
Remove openssl engine command

This patch removes apps/engine.c and associated man pages.

Resolves: https://github.com/openssl/project/issues/1370

Signed-off-by: Milan Broz <gmaz...@gmail.com>

Reviewed-by: Dmitry Belyavskiy <bel...@gmail.com>
Reviewed-by: Paul Dale <ppz...@gmail.com>
Reviewed-by: Matt Caswell <ma...@openssl.org>
Reviewed-by: Richard Levitte <lev...@openssl.org>
Reviewed-by: Tomas Mraz <to...@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28481)


Commit: 9381545912d7b7b855378900b25d911b58b12e6b
https://github.com/openssl/openssl/commit/9381545912d7b7b855378900b25d911b58b12e6b
Author: Norbert Pocs <norb...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M providers/common/include/prov/provider_util.h
M providers/common/provider_util.c
M providers/implementations/asymciphers/sm2_enc.c.in
M providers/implementations/kdfs/hkdf.c.in
M providers/implementations/kdfs/hmacdrbg_kdf.c.in
M providers/implementations/kdfs/kbkdf.c.in
M providers/implementations/kdfs/krb5kdf.c.in
M providers/implementations/kdfs/pbkdf1.c.in
M providers/implementations/kdfs/pbkdf2.c.in
M providers/implementations/kdfs/pkcs12kdf.c.in
M providers/implementations/kdfs/pvkkdf.c.in
M providers/implementations/kdfs/sshkdf.c.in
M providers/implementations/kdfs/sskdf.c.in
M providers/implementations/kdfs/tls1_prf.c.in
M providers/implementations/kdfs/x942kdf.c.in
M providers/implementations/keymgmt/mac_legacy_kmgmt.c.in
M providers/implementations/macs/cmac_prov.c.in
M providers/implementations/macs/gmac_prov.c.in
M providers/implementations/macs/hmac_prov.c.in
M providers/implementations/macs/kmac_prov.c.in
M providers/implementations/rands/drbg_hash.c.in
M providers/implementations/rands/drbg_hmac.c.in
M providers/implementations/signature/mac_legacy_sig.c

Log Message:
-----------
providers/: Remove ENGINEs

Signed-off-by: Norbert Pocs <norb...@openssl.org>

Reviewed-by: Matt Caswell <ma...@openssl.org>
Reviewed-by: Saša Nedvědický <sas...@openssl.org>
Reviewed-by: Neil Horman <nho...@openssl.org>
Reviewed-by: Dmitry Belyavskiy <bel...@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/28384)


Commit: 27a1747a0de1b078b3982daffaf921461fe31e79
https://github.com/openssl/openssl/commit/27a1747a0de1b078b3982daffaf921461fe31e79
Author: Norbert Pocs <norb...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M apps/ca.c
M apps/cmp.c
M apps/cms.c
M apps/crl.c
M apps/dgst.c
M apps/dhparam.c
M apps/dsa.c
M apps/dsaparam.c
M apps/ec.c
M apps/ecparam.c
M apps/enc.c
M apps/gendsa.c
M apps/genpkey.c
M apps/genrsa.c
M apps/include/apps.h
R apps/include/engine_loader.h
M apps/include/opt.h
M apps/info.c
M apps/lib/apps.c
M apps/lib/build.info
R apps/lib/engine.c
R apps/lib/engine_loader.c
M apps/lib/s_cb.c
M apps/list.c
M apps/ocsp.c
M apps/openssl-vms.cnf
M apps/openssl.c
M apps/openssl.cnf
M apps/pkcs12.c
M apps/pkcs7.c
M apps/pkcs8.c
M apps/pkey.c
M apps/pkeyparam.c
M apps/pkeyutl.c
M apps/rand.c
M apps/req.c
M apps/rsa.c
M apps/rsautl.c
M apps/s_client.c
M apps/s_server.c
M apps/smime.c
M apps/speed.c
M apps/spkac.c
M apps/srp.c
M apps/storeutl.c
M apps/ts.c
M apps/verify.c
M apps/version.c
M apps/x509.c
M test/build.info

Log Message:
-----------
apps/: Remove engines

Signed-off-by: Norbert Pocs <norb...@openssl.org>

Reviewed-by: Matt Caswell <ma...@openssl.org>
Reviewed-by: Saša Nedvědický <sas...@openssl.org>
Reviewed-by: Neil Horman <nho...@openssl.org>
Reviewed-by: Dmitry Belyavskiy <bel...@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/28384)


Commit: 2905316b2cef2a448a5419aa1a1efbf8a866b284
https://github.com/openssl/openssl/commit/2905316b2cef2a448a5419aa1a1efbf8a866b284
Author: Norbert Pocs <norb...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M apps/ca.c
M apps/cmp.c
M apps/cms.c
M apps/dgst.c
M apps/include/fmt.h
M apps/include/opt.h
M apps/lib/opt.c
M apps/pkey.c
M apps/pkeyutl.c
M apps/req.c
M apps/rsautl.c
M apps/s_client.c
M apps/s_server.c
M apps/smime.c
M apps/spkac.c
M apps/x509.c
M doc/man1/openssl-cmp.pod.in

Log Message:
-----------
apps/: Remove "-keyform engine"

Resolves: https://github.com/openssl/project/issues/1354

Signed-off-by: Norbert Pocs <norb...@openssl.org>

Reviewed-by: Matt Caswell <ma...@openssl.org>
Reviewed-by: Saša Nedvědický <sas...@openssl.org>
Reviewed-by: Neil Horman <nho...@openssl.org>
Reviewed-by: Dmitry Belyavskiy <bel...@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/28384)


Commit: 1b366f265a814b8a1a49369b34a33ff81baf56b5
https://github.com/openssl/openssl/commit/1b366f265a814b8a1a49369b34a33ff81baf56b5
Author: Norbert Pocs <norb...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M doc/man1/openssl-ca.pod.in
M doc/man1/openssl-cmp.pod.in
M doc/man1/openssl-cms.pod.in
M doc/man1/openssl-dgst.pod.in
M doc/man1/openssl-dhparam.pod.in
M doc/man1/openssl-dsa.pod.in
M doc/man1/openssl-dsaparam.pod.in
M doc/man1/openssl-ec.pod.in
M doc/man1/openssl-ecparam.pod.in
M doc/man1/openssl-enc.pod.in
M doc/man1/openssl-format-options.pod
M doc/man1/openssl-gendsa.pod.in
M doc/man1/openssl-genpkey.pod.in
M doc/man1/openssl-genrsa.pod.in
M doc/man1/openssl-info.pod.in
M doc/man1/openssl-list.pod.in
M doc/man1/openssl-pkcs12.pod.in
M doc/man1/openssl-pkcs7.pod.in
M doc/man1/openssl-pkcs8.pod.in
M doc/man1/openssl-pkey.pod.in
M doc/man1/openssl-pkeyparam.pod.in
M doc/man1/openssl-pkeyutl.pod.in
M doc/man1/openssl-rand.pod.in
M doc/man1/openssl-req.pod.in
M doc/man1/openssl-rsa.pod.in
M doc/man1/openssl-rsautl.pod.in
M doc/man1/openssl-s_client.pod.in
M doc/man1/openssl-s_server.pod.in
M doc/man1/openssl-smime.pod.in
M doc/man1/openssl-speed.pod.in
M doc/man1/openssl-spkac.pod.in
M doc/man1/openssl-srp.pod.in
M doc/man1/openssl-storeutl.pod.in
M doc/man1/openssl-ts.pod.in
M doc/man1/openssl-verify.pod.in
M doc/man1/openssl-version.pod.in
M doc/man1/openssl-x509.pod.in

Log Message:
-----------
apps/: Update docs

Signed-off-by: Norbert Pocs <norb...@openssl.org>

Reviewed-by: Matt Caswell <ma...@openssl.org>
Reviewed-by: Saša Nedvědický <sas...@openssl.org>
Reviewed-by: Neil Horman <nho...@openssl.org>
Reviewed-by: Dmitry Belyavskiy <bel...@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/28384)


Commit: e814527ad74c21a6117c97474b65a78940f8a4f5
https://github.com/openssl/openssl/commit/e814527ad74c21a6117c97474b65a78940f8a4f5
Author: Norbert Pocs <norb...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
R test/afalgtest.c
M test/build.info
M test/danetest.c
M test/ectest.c

Log Message:
-----------
test/: Remove ENGINEs

Signed-off-by: Norbert Pocs <norb...@openssl.org>

Reviewed-by: Matt Caswell <ma...@openssl.org>
Reviewed-by: Saša Nedvědický <sas...@openssl.org>
Reviewed-by: Neil Horman <nho...@openssl.org>
Reviewed-by: Dmitry Belyavskiy <bel...@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/28384)


Commit: b5f7207a9ba8fec62da4fe8700262e3ded453a28
https://github.com/openssl/openssl/commit/b5f7207a9ba8fec62da4fe8700262e3ded453a28
Author: Norbert Pocs <norb...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M crypto/err/err_all.c
M crypto/err/err_all_legacy.c
M crypto/ts/ts_conf.c
M include/openssl/cryptoerr_legacy.h
M include/openssl/evp.h
M include/openssl/rand.h
M include/openssl/ssl.h.in
M include/openssl/ts.h

Log Message:
-----------
include/: Remove ENGINEs

Signed-off-by: Norbert Pocs <norb...@openssl.org>

Reviewed-by: Matt Caswell <ma...@openssl.org>
Reviewed-by: Saša Nedvědický <sas...@openssl.org>
Reviewed-by: Neil Horman <nho...@openssl.org>
Reviewed-by: Dmitry Belyavskiy <bel...@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/28384)


Commit: 04503a3b5b8c62190741e2aefae35b34f10e1225
https://github.com/openssl/openssl/commit/04503a3b5b8c62190741e2aefae35b34f10e1225
Author: Norbert Pocs <norb...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M ssl/ssl_ciph.c
M ssl/ssl_lib.c
M ssl/ssl_local.h
M ssl/statem/statem_clnt.c
M ssl/tls_depr.c

Log Message:
-----------
ssl/: Remove ENGINEs

Signed-off-by: Norbert Pocs <norb...@openssl.org>

Reviewed-by: Matt Caswell <ma...@openssl.org>
Reviewed-by: Saša Nedvědický <sas...@openssl.org>
Reviewed-by: Neil Horman <nho...@openssl.org>
Reviewed-by: Dmitry Belyavskiy <bel...@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/28384)


Commit: 30f21bbb759dfd59a61b6ecdfab4fdef6b950c02
https://github.com/openssl/openssl/commit/30f21bbb759dfd59a61b6ecdfab4fdef6b950c02
Author: Norbert Pocs <norb...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M crypto/asn1/a_digest.c
M crypto/asn1/ameth_lib.c
M crypto/asn1/d2i_pr.c
M crypto/conf/conf_mall.c
M crypto/conf/conf_mod.c
M crypto/dh/dh_lib.c
M crypto/dsa/dsa_lib.c
M crypto/ec/ec_key.c
M crypto/ec/ec_kmeth.c
M crypto/evp/digest.c
M crypto/evp/evp_enc.c
M crypto/evp/evp_pkey_type.c
M crypto/evp/p_lib.c
M crypto/evp/pmeth_lib.c
M crypto/hmac/hmac_s390x.c
M crypto/init.c
M crypto/pem/pem_lib.c
M crypto/rand/rand_lib.c
M crypto/rsa/rsa_lib.c
M crypto/x509/x_pubkey.c

Log Message:
-----------
crypto/: Remove OPENSSL_NO_ENGINE guarded code

Signed-off-by: Norbert Pocs <norb...@openssl.org>

Reviewed-by: Matt Caswell <ma...@openssl.org>
Reviewed-by: Saša Nedvědický <sas...@openssl.org>
Reviewed-by: Neil Horman <nho...@openssl.org>
Reviewed-by: Dmitry Belyavskiy <bel...@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/28384)


Commit: c3d5ff32ba2e470679cde3c74185736abdeb2c39
https://github.com/openssl/openssl/commit/c3d5ff32ba2e470679cde3c74185736abdeb2c39
Author: Norbert Pocs <norb...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M engines/e_loader_attic.c

Log Message:
-----------
engine/e_loader_attic: Remove OPENSSL_NO_ENGINE parts

Signed-off-by: Norbert Pocs <norb...@openssl.org>

Reviewed-by: Matt Caswell <ma...@openssl.org>
Reviewed-by: Saša Nedvědický <sas...@openssl.org>
Reviewed-by: Neil Horman <nho...@openssl.org>
Reviewed-by: Dmitry Belyavskiy <bel...@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/28384)


Commit: c97c1ffb7cfd430c53c3f2bb654551409b4e7d2e
https://github.com/openssl/openssl/commit/c97c1ffb7cfd430c53c3f2bb654551409b4e7d2e
Author: Norbert Pocs <norb...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M doc/man3/EVP_PKEY_set1_RSA.pod
M include/openssl/sslerr_legacy.h
M util/libcrypto.num
M util/libssl.num

Log Message:
-----------
Update symbols after OPENSSL_NO_ENGINE clearup

Signed-off-by: Norbert Pocs <norb...@openssl.org>

Reviewed-by: Matt Caswell <ma...@openssl.org>
Reviewed-by: Saša Nedvědický <sas...@openssl.org>
Reviewed-by: Neil Horman <nho...@openssl.org>
Reviewed-by: Dmitry Belyavskiy <bel...@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/28384)


Commit: 799b172c9f1e3b0064d7f7345054826a45914a0e
https://github.com/openssl/openssl/commit/799b172c9f1e3b0064d7f7345054826a45914a0e
Author: Norbert Pocs <norb...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M Configure
M engines/e_afalg.c
M engines/e_capi.c
M engines/e_dasync.c
M engines/e_devcrypto.c
M engines/e_ossltest.c
M engines/e_padlock.c
M test/evp_extra_test.c
M test/helpers/ssltestlib.c
M test/sslapitest.c
M test/sslbuffertest.c

Log Message:
-----------
Remove OPENSSL_NO_DYNAMIC_ENGINE

Most of the ifdefs were removed, but we want to rewrite the dasync
engine to a provider. Therefore that code was not removed; instead a new
temporary macro was added named TODO_REWRITE_ME_DASYNC_PROVIDER.

Resolves: https://github.com/openssl/project/issues/1363

Signed-off-by: Norbert Pocs <norb...@openssl.org>

Reviewed-by: Matt Caswell <ma...@openssl.org>
Reviewed-by: Saša Nedvědický <sas...@openssl.org>
Reviewed-by: Neil Horman <nho...@openssl.org>
Reviewed-by: Dmitry Belyavskiy <bel...@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/28384)


Commit: 707cec48883b4c77b8f3042d6d80bbcb4d6052c6
https://github.com/openssl/openssl/commit/707cec48883b4c77b8f3042d6d80bbcb4d6052c6
Author: Norbert Pocs <norb...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M Configure

Log Message:
-----------
Remove OPENSSL_NO_STATIC_ENGINE macro

Resolves: https://github.com/openssl/project/issues/1364

Signed-off-by: Norbert Pocs <norb...@openssl.org>

Reviewed-by: Matt Caswell <ma...@openssl.org>
Reviewed-by: Saša Nedvědický <sas...@openssl.org>
Reviewed-by: Neil Horman <nho...@openssl.org>
Reviewed-by: Dmitry Belyavskiy <bel...@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/28384)


Commit: 8884e538036041cd99ac2be598a0c4486bb8d0ee
https://github.com/openssl/openssl/commit/8884e538036041cd99ac2be598a0c4486bb8d0ee
Author: Milan Broz <gmaz...@gmail.com>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M providers/common/include/prov/provider_util.h

Log Message:
-----------
Remove engine from PROV_CIPHER and PROV_DIGEST structs.

Resolves: https://github.com/openssl/project/issues/1352
Resolves: https://github.com/openssl/project/issues/1353

Signed-off-by: Milan Broz <gmaz...@gmail.com>

Reviewed-by: Matt Caswell <ma...@openssl.org>
Reviewed-by: Saša Nedvědický <sas...@openssl.org>
Reviewed-by: Neil Horman <nho...@openssl.org>
Reviewed-by: Dmitry Belyavskiy <bel...@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/28384)


Commit: ea6505ab02c60c65b1df170477a97bf8c1f9c660
https://github.com/openssl/openssl/commit/ea6505ab02c60c65b1df170477a97bf8c1f9c660
Author: Milan Broz <gmaz...@gmail.com>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M crypto/dh/dh_backend.c
M crypto/dh/dh_lib.c
M crypto/dh/dh_local.h
M crypto/dsa/dsa_backend.c
M crypto/dsa/dsa_lib.c
M crypto/dsa/dsa_local.h
M crypto/ec/ec_backend.c
M crypto/ec/ec_key.c
M crypto/ec/ec_local.h
M crypto/evp/evp_enc.c
M crypto/evp/evp_local.h
M crypto/evp/p_lib.c
M crypto/evp/pmeth_lib.c
M crypto/rsa/rsa_backend.c
M crypto/rsa/rsa_lib.c
M crypto/rsa/rsa_local.h
M crypto/store/store_local.h
M crypto/store/store_register.c
M include/crypto/evp.h

Log Message:
-----------
Remove private ENGINE references from local structs.

Resolves: https://github.com/openssl/project/issues/1368

Signed-off-by: Milan Broz <gmaz...@gmail.com>

Reviewed-by: Matt Caswell <ma...@openssl.org>
Reviewed-by: Saša Nedvědický <sas...@openssl.org>
Reviewed-by: Neil Horman <nho...@openssl.org>
Reviewed-by: Dmitry Belyavskiy <bel...@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/28384)


Commit: ae7d5d837ca19519a583f13b0ca9057a14210ff4
https://github.com/openssl/openssl/commit/ae7d5d837ca19519a583f13b0ca9057a14210ff4
Author: Norbert Pocs <norb...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M Configure

Log Message:
-----------
Configure: deprecate-disable engine related options

Signed-off-by: Norbert Pocs <norb...@openssl.org>

Reviewed-by: Matt Caswell <ma...@openssl.org>
Reviewed-by: Saša Nedvědický <sas...@openssl.org>
Reviewed-by: Neil Horman <nho...@openssl.org>
Reviewed-by: Dmitry Belyavskiy <bel...@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/28384)


Commit: 07bb368fcc0127b358f1306c48a3a09bce29d2cc
https://github.com/openssl/openssl/commit/07bb368fcc0127b358f1306c48a3a09bce29d2cc
Author: Neil Horman <nho...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M crypto/engine/eng_init.c
M crypto/engine/eng_lib.c
M crypto/engine/eng_list.c
M crypto/engine/eng_local.h
M crypto/engine/eng_table.c
M crypto/engine/tb_asnmth.c
M crypto/trace.c
M include/openssl/trace.h
M test/trace_api_test.c

Log Message:
-----------
Remove ENGINE_TABLE and ENGINE_REF_COUNT trace categories

With ENGINES going away we need to remove these trace catagories

Reviewed-by: Tomas Mraz <to...@openssl.org>
Reviewed-by: Matt Caswell <ma...@openssl.org>
Reviewed-by: Paul Dale <ppz...@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/28556)


Commit: daea26626d01c207b628a8b10bd07c189788ba61
https://github.com/openssl/openssl/commit/daea26626d01c207b628a8b10bd07c189788ba61
Author: Neil Horman <nho...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M doc/man3/OSSL_trace_set_channel.pod
M doc/man7/openssl-env.pod

Log Message:
-----------
Remove ENGINE_TABLE and ENGINE_REF_COUNT trace documentation

As the subject indicates, with these trace categories gone, we shouldn't
reference them in the docs anymore.

Reviewed-by: Tomas Mraz <to...@openssl.org>
Reviewed-by: Matt Caswell <ma...@openssl.org>
Reviewed-by: Paul Dale <ppz...@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/28556)


Commit: 452756f7b24595a7765a0d578ed40d08ba8aec55
https://github.com/openssl/openssl/commit/452756f7b24595a7765a0d578ed40d08ba8aec55
Author: Norbert Pocs <norb...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M crypto/evp/p_lib.c

Log Message:
-----------
p_lib.c: Remove engine from pkey_set_type

Resolves: https://github.com/openssl/project/issues/1437

Signed-off-by: Norbert Pocs <norb...@openssl.org>

Reviewed-by: Neil Horman <nho...@openssl.org>
Reviewed-by: Matt Caswell <ma...@openssl.org>
Reviewed-by: Paul Dale <ppz...@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/28560)


Commit: cb6967f3691ba2e2affe53ae5b054de70ad02750
https://github.com/openssl/openssl/commit/cb6967f3691ba2e2affe53ae5b054de70ad02750
Author: Milan Broz <gmaz...@gmail.com>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
R README-ENGINES.md
M README.md

Log Message:
-----------
Remove README-ENGINES.md

Resolves: https://github.com/openssl/project/issues/1616

Signed-off-by: Milan Broz <gmaz...@gmail.com>

Reviewed-by: Neil Horman <nho...@openssl.org>
Reviewed-by: Tomas Mraz <to...@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28618)


Commit: 3eecd693de3fe85c8b6676207bcf4656b1553225
https://github.com/openssl/openssl/commit/3eecd693de3fe85c8b6676207bcf4656b1553225
Author: Norbert Pocs <norb...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M crypto/dsa/dsa_lib.c

Log Message:
-----------
crypto/dsa: Remove ENGINE usage

Resolves: https://github.com/openssl/project/issues/1614

Signed-off-by: Norbert Pocs <norb...@openssl.org>

Reviewed-by: Richard Levitte <lev...@openssl.org>
Reviewed-by: Paul Dale <ppz...@gmail.com>
Reviewed-by: Neil Horman <nho...@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28566)


Commit: a91f4ac10e3fd6e1300cc66d3a7b546b04356524
https://github.com/openssl/openssl/commit/a91f4ac10e3fd6e1300cc66d3a7b546b04356524
Author: Norbert Pocs <norb...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M crypto/ec/ec_backend.c
M crypto/ec/ec_key.c
M crypto/ec/ec_kmeth.c
M crypto/ec/ec_local.h

Log Message:
-----------
crypto/ec: Remove ENGINE usage

Resolves: https://github.com/openssl/project/issues/1615

Signed-off-by: Norbert Pocs <norb...@openssl.org>

Reviewed-by: Paul Dale <ppz...@gmail.com>
Reviewed-by: Matt Caswell <ma...@openssl.org>
Reviewed-by: Tomas Mraz <to...@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28570)


Commit: 84af0ab9483a423fd251e9f1ba48c7e54c9e1f0e
https://github.com/openssl/openssl/commit/84af0ab9483a423fd251e9f1ba48c7e54c9e1f0e
Author: Milan Broz <gmaz...@gmail.com>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M .github/workflows/windows.yml
M .github/workflows/windows_comp.yml
M Configurations/descrip.mms.tmpl
M Configurations/unix-Makefile.tmpl
M Configurations/windows-makefile.tmpl
M NOTES-WINDOWS.md
M build.info
M crypto/cversion.c
M crypto/defaults.c
M crypto/engine/eng_list.c
M crypto/info.c
M doc/man3/OpenSSL_version.pod
M exporters/build.info
M exporters/cmake/OpenSSLConfig.cmake.in
M exporters/pkg-config/libcrypto.pc.in
M include/internal/common.h
M test/recipes/02-test_windows_registry.t
M util/mkinstallvars.pl

Log Message:
-----------
Remove ENGINESDIR variable and engines installation from Makefiles.

For compatibility reasons, OPENSSL_ENGINES_DIR and OPENSSL_INFO_ENGINES_DIR
are still supported but return values like with engines disabled.

The OPENSSL_ENGINES environment variable will be removed with engine
removal later.

Resolves: https://github.com/openssl/project/issues/1425

Signed-off-by: Milan Broz <gmaz...@gmail.com>

Reviewed-by: Tomas Mraz <to...@openssl.org>
Reviewed-by: Saša Nedvědický <sas...@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28702)


Commit: 1a99203cb942c856302cfbcd374c382dff9397c8
https://github.com/openssl/openssl/commit/1a99203cb942c856302cfbcd374c382dff9397c8
Author: Neil Horman <nho...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M test/evp_extra_test.c

Log Message:
-----------
remove engine references from evp_extra_test

The evp_extra_test code makes use of the dasync engine to ensure that we
can do evp operations (signatures and ciphers) with an engine.

The dasync engine is used for this purpose, but it does not exercize any
specific pipeline functionality.

Given that engines are getting removed, the engine tests here I think
can just be removed.

Reviewed-by: Richard Levitte <lev...@openssl.org>
Reviewed-by: Tomas Mraz <to...@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28525)


Commit: c7acc30b6ff375b0dcaa6a66e125df4407672d7e
https://github.com/openssl/openssl/commit/c7acc30b6ff375b0dcaa6a66e125df4407672d7e
Author: Neil Horman <nho...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M test/helpers/ssltestlib.c
M test/helpers/ssltestlib.h
M test/sslapitest.c
M test/sslbuffertest.c

Log Message:
-----------
Remove dasync engine from sslapitest and sslbuffertest

With the impending engine removal, we don't have a need to test engine
functionality in these tests anymore, so remove the test cases that make
use of the dasync engine here.

Reviewed-by: Richard Levitte <lev...@openssl.org>
Reviewed-by: Tomas Mraz <to...@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28525)


Commit: f83a38fc66849c0621ba7be3f9147fc8ea30d590
https://github.com/openssl/openssl/commit/f83a38fc66849c0621ba7be3f9147fc8ea30d590
Author: Neil Horman <nho...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M test/ssl_handshake_rtt_test.c

Log Message:
-----------
remove engine.h include from ssl_handshake_rtt_test.c

It seems like it wasn't ever needed before, so with the removal of
engines, just get rid of it.

Reviewed-by: Richard Levitte <lev...@openssl.org>
Reviewed-by: Tomas Mraz <to...@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28525)


Commit: 1763a120b27331df83f36212b741b88edae41ef6
https://github.com/openssl/openssl/commit/1763a120b27331df83f36212b741b88edae41ef6
Author: Neil Horman <nho...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
R test/recipes/30-test_afalg.t

Log Message:
-----------
remove afalg tests

We have a specific test suite that exercizes the afalg engine, that is
becoming useless with engine removal.

I had considered that we should perhaps convert this into a provider,
but having looked at the engine itself, it only offers implementations
for AES-128, AES-192 and AES-256. Given that the default provider
offers these algorithms with hardware acceleration via the aesni
instruction set (or comparable instructions on non-x86 arches), it seems
like the only advantage the afalg engine offers is acceleration of these
ciphers on platforms that have off-cpu accelerators and no cpu based
acceleration support.

given that:
a) Most cpus have instruction based acceleration
b) We don't test with any platforms that use external accelerators

It seems like alot of investment to get no real advantage, so just
remove the test, allowing us to delete the engine entirely in another
PR.

Reviewed-by: Richard Levitte <lev...@openssl.org>
Reviewed-by: Tomas Mraz <to...@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28525)


Commit: 2e130ff71bcb84b86594359d52756fd408021623
https://github.com/openssl/openssl/commit/2e130ff71bcb84b86594359d52756fd408021623
Author: Neil Horman <nho...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M test/sysdefaulttest.c

Log Message:
-----------
Don't enable engines on sysdefault tests

With engine removal, we expect that init flag to disappear, so stop
using it here.

Reviewed-by: Richard Levitte <lev...@openssl.org>
Reviewed-by: Tomas Mraz <to...@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28525)


Commit: 2a42bf1db188dcb61eee9f2c122725365052d57d
https://github.com/openssl/openssl/commit/2a42bf1db188dcb61eee9f2c122725365052d57d
Author: Neil Horman <nho...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M test/recipes/05-test_rand.t

Log Message:
-----------
remove dasync engine test from test_rand

We're removing the engine, so we don't need to test this anymore.

NOTE: This also removes the engine skip check from the test, and this
breaks testing until such time as PR #28461 is merged (which replaces
the remaining engine test with a provider).

Reviewed-by: Richard Levitte <lev...@openssl.org>
Reviewed-by: Tomas Mraz <to...@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28525)


Commit: f70450fecd08fdf0e524fda3d276b0021d583682
https://github.com/openssl/openssl/commit/f70450fecd08fdf0e524fda3d276b0021d583682
Author: Neil Horman <nho...@openssl.org>
Date: 2025-10-03 (Fri, 03 Oct 2025)

Changed paths:
M test/README-dev.md
M test/helpers/ssltestlib.c
M test/run_tests.pl
M test/sslbuffertest.c

Log Message:
-----------
Additonal removals of engine references in tests/*

Spotted by @andrewkdinh, some extra notes about/useages of engines that
are now vestigial.

Reviewed-by: Richard Levitte <lev...@openssl.org>
Reviewed-by: Tomas Mraz <to...@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28525)


Compare: https://github.com/openssl/openssl/compare/8132702244d8...f70450fecd08

To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications
Reply all
Reply to author
Forward
0 new messages