[openssl/installer] 3ed676: Cover HybridCRT installer flavor in CI and tests

0 views
Skip to first unread message

Dmitry Misharov

unread,
Jul 17, 2026, 7:44:32 AM (3 days ago) Jul 17
to openssl...@openssl.org
Branch: refs/heads/main
Home: https://github.com/openssl/installer
Commit: 3ed6760e27c507f678c6d6cc4f49f4208486ca0f
https://github.com/openssl/installer/commit/3ed6760e27c507f678c6d6cc4f49f4208486ca0f
Author: Dmitry Misharov <dmi...@openssl.org>
Date: 2026-07-17 (Fri, 17 Jul 2026)

Changed paths:
M .github/workflows/test-installer.yml
M pyproject.toml
M tests/conftest.py
M tests/test_gui.py
M tests/test_signed.py
M tests/test_silent_install.py

Log Message:
-----------
Cover HybridCRT installer flavor in CI and tests

Build both CRT flavors (VC-WIN64A and VC-WIN64A-HYBRIDCRT) on separate
runners, each packaging its matching installers; the validated 3.1.2 FIPS
module stays VC-WIN64A on both legs (never HybridCRT) per its Security Policy.

Make the pytest suite flavor-aware (derived from the installer filename),
isolate each installer in an empty dir before installing, add a pefile
import-table check that hybrid binaries carry no dynamic VC++ runtime, and
introspect the MSI to assert the hybrid FIPS "validated" disable from 63b0a77.
test_signed / test_gui now follow the flavor's supported FIPS type.

Co-Authored-By: Claude Opus 4.8 (1M context) <nor...@anthropic.com>

Reviewed-By: Norbert Pocs <norb...@openssl.org>


Commit: e990146e94d2ea593817abdaf7fc379cc619ad45
https://github.com/openssl/installer/commit/e990146e94d2ea593817abdaf7fc379cc619ad45
Author: Dmitry Misharov <dmi...@openssl.org>
Date: 2026-07-17 (Fri, 17 Jul 2026)

Changed paths:
M pyproject.toml
M tests/conftest.py
A tests/msi_query.ps1
M tests/test_gui.py
M tests/test_signed.py
M tests/test_silent_install.py

Log Message:
-----------
fix tests

Reviewed-By: Norbert Pocs <norb...@openssl.org>


Commit: ce2762441ce7a0f2ee413a70676158e96c687cee
https://github.com/openssl/installer/commit/ce2762441ce7a0f2ee413a70676158e96c687cee
Author: Dmitry Misharov <dmi...@openssl.org>
Date: 2026-07-17 (Fri, 17 Jul 2026)

Changed paths:
M .github/workflows/test-installer.yml

Log Message:
-----------
test both hybrid and VS installers

Reviewed-By: Norbert Pocs <norb...@openssl.org>


Commit: df6a7f12d804af4299aa2fa0c3618aaeebf729b2
https://github.com/openssl/installer/commit/df6a7f12d804af4299aa2fa0c3618aaeebf729b2
Author: Dmitry Misharov <dmi...@openssl.org>
Date: 2026-07-17 (Fri, 17 Jul 2026)

Changed paths:
M .github/workflows/test-installer.yml
M tests/conftest.py

Log Message:
-----------
rename hybrid installer artifacts/globs to hybridCRT

Reviewed-By: Norbert Pocs <norb...@openssl.org>


Commit: d13748e76ad65e512d87c4122538401ace1dd2e3
https://github.com/openssl/installer/commit/d13748e76ad65e512d87c4122538401ace1dd2e3
Author: Dmitry Misharov <dmi...@openssl.org>
Date: 2026-07-17 (Fri, 17 Jul 2026)

Changed paths:
M .github/workflows/test-installer.yml

Log Message:
-----------
CI: drop redundant installer isolation, keep it only in conftest

The pytest `installer` fixture already copies the single installer under test
into an otherwise-empty temp dir before installing. The workflow step was doing
the same copy, so it's redundant — reduce the CI step to just selecting the
artifact and passing its real path; the fixture does the isolation.

Co-Authored-By: Claude Opus 4.8 (1M context) <nor...@anthropic.com>

Reviewed-By: Norbert Pocs <norb...@openssl.org>


Commit: d02ce3695c767e4c8f891588130fbb0f61766071
https://github.com/openssl/installer/commit/d02ce3695c767e4c8f891588130fbb0f61766071
Author: Dmitry Misharov <dmi...@openssl.org>
Date: 2026-07-17 (Fri, 17 Jul 2026)

Changed paths:
M .github/workflows/test-installer.yml

Log Message:
-----------
parallelize builds

Reviewed-By: Norbert Pocs <norb...@openssl.org>


Commit: 5e017ca48f98d5a938f15e687de233f4d3ac7476
https://github.com/openssl/installer/commit/5e017ca48f98d5a938f15e687de233f4d3ac7476
Author: Dmitry Misharov <dmi...@openssl.org>
Date: 2026-07-17 (Fri, 17 Jul 2026)

Changed paths:
M tests/conftest.py
M tests/test_silent_install.py

Log Message:
-----------
add smoke test for openssl.exe

Reviewed-By: Norbert Pocs <norb...@openssl.org>


Compare: https://github.com/openssl/installer/compare/c834bc859dc2...5e017ca48f98

To unsubscribe from these emails, change your notification settings at https://github.com/openssl/installer/settings/notifications
Reply all
Reply to author
Forward
0 new messages