Calculation Sprint Tickets for the upcoming CleanUp Sprint

[Jinna, Kiran Reddy]

 

Hello All,

 

In regards to the upcoming CleanUp Sprint that is scheduled from June 4th-17th, unresolved tickets from the previous sprints (Order Entry, HTML Form Entry, Logic and Rest WS) will be worked on.

 

Calculation module was part of the Logic Sprint from March 12th-25th. I was told that before the Logic Sprint, there was a whole lot of discussion about the design of the calculation module. I kindly request the members of the community who were part of that design discussions to create relevant tickets pertaining to that module, so that those tickets can be resolved in the upcoming CleanUp sprint.

 

Thanks for your time.

 

Kiran Reddy

Business Analyst

Informatics IT, Merck Research Laboratories

San Francisco, CA

kiran...@merck.com

 

 

Notice:  This e-mail message, together with any attachments, contains
information of Merck & Co., Inc. (One Merck Drive, Whitehouse Station,
New Jersey, USA 08889), and/or its affiliates Direct contact information
for affiliates is available at
http://www.merck.com/contact/contacts.html) that may be confidential,
proprietary copyrighted and/or legally privileged. It is intended solely
for the use of the individual or entity named on this message. If you are
not the intended recipient, and have received this message in error,
please notify us immediately by reply e-mail and then delete it from
your system.

[Ben Wolfe]

So the logic/calculation sprint wiki page + dashboard were:
https://wiki.openmrs.org/display/RES/2012-03-12+Development+Sprint
https://tickets.openmrs.org/secure/Dashboard.jspa?selectPageId=11553

Wyclif / Mike:

There is only one ticket in post-commit review state (integrating logic with calc).  Is there anything left preventing us from just releasing Calc 1.0 ?  I see no download links on its wiki page:
https://wiki.openmrs.org/display/docs/Calculation+Module

Ben

-- OpenMRS Developers: http://go.openmrs.org/dev
Post: d...@openmrs.org
Unsubscribe: dev+uns...@openmrs.org

[Darius Jazayeri]

The situation is that we had a design discussion after the first Calculation module sprint (notes at http://notes.openmrs.org/Design-Forum-2012-04-04) but we didn't create tickets from those notes.

My recollection is that the key decisions were:

• Get rid of the "evaluator" pattern, and just let Calculation have an evaluate method.
• We need to cache token registrations. The first pass at this can just use a HashMap.
• Get rid of EmptyResult
• "Don't need a separate package for registration"

Wyclif, Mike, Burke, etc, does this seem right?

-Darius

[Wyclif Luyima]

The ticket for integrating calculations in logic is not a blocker in any way to releasing Calculation 1.0 since that ticket belongs to the logic module.

I recall it was suggested that we rework Calculations so that they evaluate themselves and get rid of Evaluators.

Basically, what needs to be done is described in form of comments on this ticket https://tickets.openmrs.org/browse/CALC-31

Wyclif

[Michael Seaton]

Yes, this is my recollection as well.

Mike