[TRUNK-3974] i am not sure

[Arek Pień]

Hi, I want to resolve TRUNK-3974 [0] ticket and i need to be sure in my thinking way. I have to fix copy constructor of ConceptNumeric class to be able make deep copy. In comments is attached link to "proper implementation" [1] and i looked up on it and i start wondering if i have to make deep copy only related collections(like it take place in ConceptNumericBuilder [1]) or collections and objects in collections too?? Sorry for that stupid question but i wanna be sure.

cheers

[0] https://tickets.openmrs.org/browse/TRUNK-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

[1] https://github.com/openmrs/openmrs-module-metadatasharing/commit/b3b41a2ff77893b38547215eb35899f7fba329ea

[Rafal Korytkowski]

Arek, I should have called it a converter constructor and not a copy
constructor.

The general rule is that types implementing OpenmrsMetadata (e.g.
ConceptClass, ConceptDatatype) are reusable and you must not create
deep copies of them. If you consider ConceptName, ConceptAnswer,
ConceptSet, ConceptDescription, ConceptMap they only belong to one
specific concept so you just need to change the parent object for
them.

ConceptNumericBuilder does not make deep copies of contained objects.
It only copies collections, because they may be backed by Hibernate.
If you just reference such collections from a different object, it
will break them.

-Rafał

> --
> OpenMRS Developers: http://go.openmrs.org/dev
> Post: d...@openmrs.org
> Unsubscribe: dev+uns...@openmrs.org
> Manage your OpenMRS subscriptions at https://id.openmrs.org/
>
>

[Arek Pień]

Thanks for reply. After your explanation it's pretty clear.

[Robert]

Hello,

I believe I have refactored all of the code to <openmrs:message />
instead of hard code. I have a few questions 1st being is what is the
easiest way to get to the crash report so I can test. 2 looking at the
messages.properties there doesn't seem to be a coherent naming
convention, is there a preferred format?

Thanks have a good day,

Robert

[Lluis Martinez]

Put a debug stop on any class (controller, service, dao), debug and
set any variable that cannot be null to null => NullPointerException

[Robert]

Changing the dao just causes an internal server error page to load not
the the crash report page.

[Lluis Martinez]

Is there any difference between them? Perhaps the improvement means
just this, to show as much info about the crash as possible. Not only
the java stack, but also JVM/Database/OS version, request parameters,
available memory etc.

[Robert]

How I take it is that all the information is there and displayed
correctly but hard coded into the page. (Which it is) I have fixed that
by using the <openmrs:message> tag. Now all I need to do is test to make
sure the page is correct but I can't seem to figure out how to get to
the uncaught exception page.

[Darius Jazayeri]

Robert,

You should be able to create a new controller or edit an existing one, and have it just throw new RuntimeException("testing").

-Darius