module_messages.properties emr.* references not working

[Craig A.]

Hi Everyone,

I see a lot of references to emr.* module_messages.properties, but they aren't loading in my version of the reference application. For example, just initiated a pull request to change emr.user.username to coreapps.user.username in the htmlformentryui module. Where are these emr.* module messages defined?

I want to make sure I'm not missing something.

Sincerely,

Craig

[Mark Goodrich]

Craig,

They were defined in an old EMR module built as part of the Mirebalais deploy that was meant to become a core part of the reference app, but ended up getting phased out in favorite of moving it's contents into EMR-API + other modules.

https://github.com/PIH/openmrs-module-emr

So, generally, any emr.* message properties should be replaced, but we haven't done the best job of doing it.

We did copy some of the emr.* message properties into the uicommons module, so you will find some of them there.  However, we should still try to phase these out.

Take care,
Mark

--
OpenMRS Developers: http://om.rs/dev
Post: d...@openmrs.org | Unsubscribe: dev+uns...@openmrs.org
Manage your OpenMRS subscriptions: http://om.rs/id
 
Visit OpenMRS Talk at http://om.rs/talk for chat and discussions!
To unsubscribe from this group and stop receiving emails from it, send an email to dev+uns...@openmrs.org.

[Craig A.]

Thanks Mark,

I'll make sure to make the changes when I find them and submit pull requests.

Sincerely,

Craig