htmlformentryui UHM-1596 Login Visit permissions don't seem to load

0 views
Skip to first unread message

Craig A.

unread,
Mar 8, 2015, 11:13:22 PM3/8/15
to d...@openmrs.org

Hi Everyone,

This is another weird one. This commit to the htmlformentyui module displays the login box and allows the user to login if their session has timed out. Once the htmlform is submitted, the redirect works as intended, but the activeVisit seems to be dropping on the redirect. 

Steps:
1) Enter the vitals form
2) In another window, logout of the application
3) Return to the vitals form
4) Fill the vitals form and click save
5) Enter the username and password in the popup and click submit
6) The redirect back to the clinicianfacing dashboard works, but there is no active visit. The user has to log out and log in again to access the active visit.

Sincerely,
Craig

Darius Jazayeri

unread,
Mar 9, 2015, 12:23:34 PM3/9/15
to dev
Good catch.

I guess the problem is that when you provide login details via the HFEui popup, you end up without a proper session location. And thus there's no "active visit at your session location".

The quickest fix is probably to ensure that the popup is asking for your session location in the same way as the regular login screen does.

@Mark, FYI.

-Darius

--
OpenMRS Developers: http://om.rs/dev
Post: d...@openmrs.org | Unsubscribe: dev+uns...@openmrs.org
Manage your OpenMRS subscriptions: http://om.rs/id
 
Visit OpenMRS Talk at http://om.rs/talk for chat and discussions!

Craig A.

unread,
Mar 9, 2015, 10:47:58 PM3/9/15
to d...@openmrs.org
Hi,

I just confirmed that the location is not set on the redirect as Darius stated. When I set the location and refreshed the page, the active visit returned. Once logging in we have the visit information. Is it possible to get the visit location from the encounter and push that location in the redirect? (This goes just a step beyond my understanding)

Sincerely,
Craig

Mark Goodrich

unread,
Mar 10, 2015, 11:52:23 AM3/10/15
to d...@openmrs.org
It's not the visit location that we want, but the session location, ie the location the user first selected when logging in.  You'll see some of the potential solutions we proposed in the comments on the ticket here:

https://tickets.pih-emr.org/browse/UHM-1596

As this ticket is in the PIH JIRA, there should probably be a related reference app ticket in the OpenMRS JIRA as well.


Mark
To unsubscribe from this group and stop receiving emails from it, send an email to dev+uns...@openmrs.org.

Reply all
Reply to author
Forward
0 new messages