Merge CLI command doesn't call on reset

1 view
Skip to first unread message

Gabriel Roldan

unread,
Aug 15, 2013, 12:22:21 PM8/15/13
to geo...@opengeo.org, Victor Olaya
Hey, writing to the list cause github is hang out right now and I can't create a bug report.

It came to my attention that the Merge CLI command (at commit ba3b4ec0) in the case of --abort being indicated, calls RefParse and then attempts to call on  ResetOp but it actually never does.
It creates the command as follows but never calls it:

 geogit.command(ResetOp.class).setMode(ResetMode.HARD)
                    .setCommit(Suppliers.ofInstance(ref.get().getObjectId()));

I'm pretty sure it should be calling the .call() method right after, but instead it just prints "Merge aborted successfully" without having executed the reset.

/reminder to self, create issue.
--
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.

Gabriel Roldan

unread,
Aug 15, 2013, 12:25:06 PM8/15/13
to geo...@opengeo.org, Victor Olaya

On Thu, Aug 15, 2013 at 1:22 PM, Gabriel Roldan <gro...@opengeo.org> wrote:
It came to my attention that the Merge CLI command (at commit ba3b4ec0) in the case of --abort being indicated, calls RefParse and then attempts to call on  ResetOp but it actually never does.
It creates the command as follows but never calls it:

 geogit.command(ResetOp.class).setMode(ResetMode.HARD)
                    .setCommit(Suppliers.ofInstance(ref.get().getObjectId()));

I'm pretty sure it should be calling the .call() method right after, but instead it just prints "Merge aborted successfully" without having executed the reset.

of course the moment I hit send github started to work again, despite being down for at least the last half hour. In any case, issue filed: https://github.com/opengeo/GeoGit/issues/398
Reply all
Reply to author
Forward
0 new messages