[oci-dev] [image-spec VOTE] 82e8329 as v1.1.0-rc4 (closes Fri June 30 2023 - 17:00 PM UTC)

59 views
Skip to first unread message

Sajay Antony

unread,
Jun 23, 2023, 1:57:42 PM6/23/23
to dev

Hello everyone,

 

 

The vote needs to be reset since the proposed tag needs to change from from v1.1.0-rc.4 to v1.1.0-rc4 due to similar earlier issue  https://github.com/opencontainers/image-spec/releases/tag/v1.1.0-rc3

 

Please respond LGTM or REJECT (with reasoning).

 

--sajay

 

Vincent Batts

unread,
Jun 23, 2023, 4:15:58 PM6/23/23
to Sajay Antony, dev
LGTM

(tho I think that change is somewhat minor thing maybe not _requiring_ a
re-kick of the vote)

On 23/06/23 17:57 +0000, 'Sajay Antony' via dev wrote:
>Hello everyone,
>
>
> * https://github.com/opencontainers/image-spec/pull/1080
>
>The vote needs to be reset since the proposed tag needs to change from from v1.1.0-rc.4 to v1.1.0-rc4 due to similar earlier issue https://github.com/opencontainers/image-spec/releases/tag/v1.1.0-rc3
>
>Please respond LGTM or REJECT (with reasoning).
>
>--sajay
>
>--
>To unsubscribe from this group and stop receiving emails from it, send an email to dev+uns...@opencontainers.org.
signature.asc

Stephen Day

unread,
Jun 23, 2023, 11:16:39 PM6/23/23
to Sajay Antony, Vincent Batts, dev
Lgtm

Jon Johnson

unread,
Jun 23, 2023, 11:17:27 PM6/23/23
to Stephen Day, Sajay Antony, Vincent Batts, dev
LGTM

Tianon Gravi

unread,
Jun 27, 2023, 7:46:19 PM6/27/23
to Sajay Antony, dev
I agree that we didn't need to reset the vote just for a minor fix to
the tagging (like we did for rc3), but for the avoidance of doubt:

(still) LGTM (https://github.com/opencontainers/image-spec/compare/v1.1.0-rc.3...82e8329f7eb6df5c62924f2792d285ba276ae876)

(I also think it wouldn't hurt to tag it both ways again, just like we
did for rc3, but I don't think it matters all that much.)

♥,
- Tianon
4096R / B42F 6819 007F 00F8 8E36 4FD4 036A 9C25 BF35 7DD4

Sajay Antony

unread,
Jun 29, 2023, 1:41:22 AM6/29/23
to Tianon Gravi, dev

Might need a LGTM on email as per current process is my understanding. 

Maybe we should accept email or PR approval 😁

Just for the record self LGTM from me and maybe person creating the PR can be assumed to approve it. 
From: Tianon Gravi <admw...@gmail.com>
Sent: Tuesday, June 27, 2023 4:46:06 PM
To: Sajay Antony <saj...@microsoft.com>
Cc: dev <d...@opencontainers.org>
Subject: Re: [oci-dev] [image-spec VOTE] 82e8329 as v1.1.0-rc4 (closes Fri June 30 2023 - 17:00 PM UTC)
 
I agree that we didn't need to reset the vote just for a minor fix to
the tagging (like we did for rc3), but for the avoidance of doubt:



(I also think it wouldn't hurt to tag it both ways again, just like we
did for rc3, but I don't think it matters all that much.)

♥,
- Tianon
  4096R / B42F 6819 007F 00F8 8E36  4FD4 036A 9C25 BF35 7DD4

On Fri, 23 Jun 2023 at 10:57, 'Sajay Antony' via dev
<d...@opencontainers.org> wrote:
>
> Hello everyone,
>
>
>
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopencontainers%2Fimage-spec%2Fpull%2F1080&data=05%7C01%7Csajaya%40microsoft.com%7Cccfce98e1e784458aed208db7768b416%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638235063818343396%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=WyTthVS3mV%2BfQxZU78iqsL%2BazCAYkltG%2FO%2FjDKIcCoA%3D&reserved=0
>
>
>
> The vote needs to be reset since the proposed tag needs to change from from v1.1.0-rc.4 to v1.1.0-rc4 due to similar earlier issue  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopencontainers%2Fimage-spec%2Freleases%2Ftag%2Fv1.1.0-rc3&data=05%7C01%7Csajaya%40microsoft.com%7Cccfce98e1e784458aed208db7768b416%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638235063818343396%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2BhhEvPsPYCNQO6VDFGn77apQgVve2yjcWhUMXw%2BKzpY%3D&reserved=0

Vincent Batts

unread,
Jun 29, 2023, 9:53:58 AM6/29/23
to Sajay Antony, Tianon Gravi, dev
it seems to be a mismatch these days 🤷

Brandon Mitchell

unread,
Jun 29, 2023, 4:40:27 PM6/29/23
to d...@opencontainers.org
I'm adding my LGTM with the understanding that this is only an RC. My concern that would prevent approving a GA is that we have a lot of untested changes and we need implementations to prove out the feasibility and show interoperability.

I also opened up a lot of PRs today, but none of those should prevent us from getting this RC out.

Sajay Antony

unread,
Jun 30, 2023, 1:31:04 PM6/30/23
to Vincent Batts, Tianon Gravi, dev
Thank you all vote is closed - 



From: Vincent Batts <vba...@hashbangbash.com>
Sent: Thursday, June 29, 2023 6:53 AM
To: Sajay Antony <saj...@microsoft.com>; Tianon Gravi <admw...@gmail.com>

Vincent Batts

unread,
Jun 30, 2023, 1:42:49 PM6/30/23
to Sajay Antony, Tianon Gravi, dev
🎉
Reply all
Reply to author
Forward
0 new messages